121448 2013-09-16 12:29:23 -0700 Fix creation of embedded JS and CSS files on cmake based ports. 2013-09-16 14:45:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hugo.lima hugo.lima commit-queue gyuyoung.kim joepeck rakuco oldest_to_newest 929869 0 hugo.lima 2013-09-16 12:29:23 -0700 After r155790 JavaScript and CSS files aren't embedded correctly due to a fail on js/css minimization process. CMake expands the macros to: /usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py "<WEBKITDIR/Source/WebCore/xml/XMLViewer.css" > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css instead of: /usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py < WEBKITDIR/Source/WebCore/xml/XMLViewer.css > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css 929874 1 211821 hugo.lima 2013-09-16 12:40:51 -0700 Created attachment 211821 Patch 929878 2 211821 joepeck 2013-09-16 12:45:41 -0700 Comment on attachment 211821 Patch r=me, thanks! 929933 3 211821 commit-queue 2013-09-16 14:45:10 -0700 Comment on attachment 211821 Patch Clearing flags on attachment: 211821 Committed r155903: <http://trac.webkit.org/changeset/155903> 929934 4 commit-queue 2013-09-16 14:45:12 -0700 All reviewed patches have been landed. Closing bug. 211821 2013-09-16 12:40:51 -0700 2013-09-16 14:45:10 -0700 Patch bug-121448-20130916164240.patch text/plain 4768 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ExZTMxYzc2MmRlZTll MDExZWUzNDU4MDFkOTBmNzQyZGI2OTQzMS4uN2ZkYWU3Y2M5YmZmMTNjZDZiMWYzNDk3Mzg4YmM4 ZTQ3NjY5NWRlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA5LTE2ICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEZpeCBj cmVhdGlvbiBvZiBlbWJlZGRlZCBKUyBhbmQgQ1NTIGZpbGVzIG9uIGNtYWtlIGJhc2VkIHBvcnRz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNDQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCBh IGJ1aWxkIGZpeCwgbGF5b3V0IHRlc3RzIGFscmVhZHkgdGVzdCB0aGlzIGlzc3VlLgorCisgICAg ICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTMtMDktMDkgIEh1Z28gUGFyZW50ZSBMaW1hICA8 aHVnby5saW1hQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgQWRkaW5nIE5peCBmaWxlcyBpbiBT b3VyY2UvUGxhdGZvcm0gdG8gdHJ1bmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtl TGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggYmQyMDFlYmFj MmUxNzJhZWFjY2NiOGM1ZDU1NGIyMzA5NTg1Y2ViNi4uODUxODk4Y2I2YjgyNzE3ZmRiOGViMTMz ZGQzY2EyY2UyZWNlODkxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTMwMjQsNyArMzAyNCw3 IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfV0VC Q09SRV9ESVJ9L0luamVjdGVkU2NyaXB0U291cmNlLmggJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S RV9ESVJ9L0luamVjdGVkU2NyaXB0U291cmNlLm1pbi5qcwogICAgIE1BSU5fREVQRU5ERU5DWSBp bnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKICAgICBERVBFTkRTICR7V0VCQ09SRV9E SVJ9L2luc3BlY3Rvci94eGQucGwgJHtXRUJDT1JFX0RJUn0vaW5zcGVjdG9yL1NjcmlwdHMvanNt aW4ucHkKLSAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7V0VCQ09SRV9ESVJ9L2lu c3BlY3Rvci9TY3JpcHRzL2pzbWluLnB5IDwke1dFQkNPUkVfRElSfS9pbnNwZWN0b3IvSW5qZWN0 ZWRTY3JpcHRTb3VyY2UuanMgPiAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vSW5qZWN0 ZWRTY3JpcHRTb3VyY2UubWluLmpzCisgICAgQ09NTUFORCAke1BZVEhPTl9FWEVDVVRBQkxFfSAk e1dFQkNPUkVfRElSfS9pbnNwZWN0b3IvU2NyaXB0cy9qc21pbi5weSA8ICR7V0VCQ09SRV9ESVJ9 L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcyA+ICR7REVSSVZFRF9TT1VSQ0VTX1dF QkNPUkVfRElSfS9JbmplY3RlZFNjcmlwdFNvdXJjZS5taW4uanMKICAgICBDT01NQU5EICR7UEVS TF9FWEVDVVRBQkxFfSAke1dFQkNPUkVfRElSfS9pbnNwZWN0b3IveHhkLnBsIEluamVjdGVkU2Ny aXB0U291cmNlX2pzICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9JbmplY3RlZFNjcmlw dFNvdXJjZS5taW4uanMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0luamVjdGVkU2Ny aXB0U291cmNlLmgKICAgICBWRVJCQVRJTSkKIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUyAk e0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vSW5qZWN0ZWRTY3JpcHRTb3VyY2UuaCkKQEAg LTMwMzUsNyArMzAzNSw3IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtERVJJ VkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0luamVjdGVkU2NyaXB0Q2FudmFzTW9kdWxlU291cmNl LmggJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0luamVjdGVkU2NyaXB0Q2FudmFzTW9k dWxlU291cmNlLm1pbi5qcwogICAgIE1BSU5fREVQRU5ERU5DWSBpbnNwZWN0b3IvSW5qZWN0ZWRT Y3JpcHRDYW52YXNNb2R1bGVTb3VyY2UuanMKICAgICBERVBFTkRTICR7V0VCQ09SRV9ESVJ9L2lu c3BlY3Rvci94eGQucGwgJHtXRUJDT1JFX0RJUn0vaW5zcGVjdG9yL1NjcmlwdHMvanNtaW4ucHkK LSAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7V0VCQ09SRV9ESVJ9L2luc3BlY3Rv ci9TY3JpcHRzL2pzbWluLnB5IDwke1dFQkNPUkVfRElSfS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRDYW52YXNNb2R1bGVTb3VyY2UuanMgPiAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0v SW5qZWN0ZWRTY3JpcHRDYW52YXNNb2R1bGVTb3VyY2UubWluLmpzCisgICAgQ09NTUFORCAke1BZ VEhPTl9FWEVDVVRBQkxFfSAke1dFQkNPUkVfRElSfS9pbnNwZWN0b3IvU2NyaXB0cy9qc21pbi5w eSA8ICR7V0VCQ09SRV9ESVJ9L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdENhbnZhc01vZHVsZVNv dXJjZS5qcyA+ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9JbmplY3RlZFNjcmlwdENh bnZhc01vZHVsZVNvdXJjZS5taW4uanMKICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAk e1dFQkNPUkVfRElSfS9pbnNwZWN0b3IveHhkLnBsIEluamVjdGVkU2NyaXB0Q2FudmFzTW9kdWxl U291cmNlX2pzICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9JbmplY3RlZFNjcmlwdENh bnZhc01vZHVsZVNvdXJjZS5taW4uanMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0lu amVjdGVkU2NyaXB0Q2FudmFzTW9kdWxlU291cmNlLmgKICAgICBWRVJCQVRJTSkKIGxpc3QoQVBQ RU5EIFdlYkNvcmVfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vSW5qZWN0 ZWRTY3JpcHRDYW52YXNNb2R1bGVTb3VyY2UuaCkKQEAgLTMwNTAsNyArMzA1MCw3IEBAIGFkZF9j dXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9 L1hNTFZpZXdlckNTUy5oICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9YTUxWaWV3ZXIu bWluLmNzcwogICAgIE1BSU5fREVQRU5ERU5DWSB4bWwvWE1MVmlld2VyLmNzcwogICAgIERFUEVO RFMgJHtXRUJDT1JFX0RJUn0vaW5zcGVjdG9yL3h4ZC5wbCAke1dFQkNPUkVfRElSfS9pbnNwZWN0 b3IvU2NyaXB0cy9jc3NtaW4ucHkKLSAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7 V0VCQ09SRV9ESVJ9L2luc3BlY3Rvci9TY3JpcHRzL2Nzc21pbi5weSA8JHtXRUJDT1JFX0RJUn0v eG1sL1hNTFZpZXdlci5jc3MgPiAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vWE1MVmll d2VyLm1pbi5jc3MKKyAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7V0VCQ09SRV9E SVJ9L2luc3BlY3Rvci9TY3JpcHRzL2Nzc21pbi5weSA8ICR7V0VCQ09SRV9ESVJ9L3htbC9YTUxW aWV3ZXIuY3NzID4gJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1hNTFZpZXdlci5taW4u Y3NzCiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJDT1JFX0RJUn0vaW5zcGVj dG9yL3h4ZC5wbCBYTUxWaWV3ZXJfY3NzICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9Y TUxWaWV3ZXIubWluLmNzcyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vWE1MVmlld2Vy Q1NTLmgKICAgICBWRVJCQVRJTSkKIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUyAke0RFUklW RURfU09VUkNFU19XRUJDT1JFX0RJUn0vWE1MVmlld2VyQ1NTLmgpCkBAIC0zMDYxLDcgKzMwNjEs NyBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgT1VUUFVUICR7REVSSVZFRF9TT1VSQ0VTX1dF QkNPUkVfRElSfS9YTUxWaWV3ZXJKUy5oICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9Y TUxWaWV3ZXIubWluLmpzCiAgICAgTUFJTl9ERVBFTkRFTkNZIHhtbC9YTUxWaWV3ZXIuanMKICAg ICBERVBFTkRTICR7V0VCQ09SRV9ESVJ9L2luc3BlY3Rvci94eGQucGwgJHtXRUJDT1JFX0RJUn0v aW5zcGVjdG9yL1NjcmlwdHMvanNtaW4ucHkKLSAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFC TEV9ICR7V0VCQ09SRV9ESVJ9L2luc3BlY3Rvci9TY3JpcHRzL2Nzc21pbi5weSA8JHtXRUJDT1JF X0RJUn0veG1sL1hNTFZpZXdlci5qcyA+ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9Y TUxWaWV3ZXIubWluLmpzCisgICAgQ09NTUFORCAke1BZVEhPTl9FWEVDVVRBQkxFfSAke1dFQkNP UkVfRElSfS9pbnNwZWN0b3IvU2NyaXB0cy9qc21pbi5weSA8ICR7V0VCQ09SRV9ESVJ9L3htbC9Y TUxWaWV3ZXIuanMgPiAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vWE1MVmlld2VyLm1p bi5qcwogICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9ICR7V0VCQ09SRV9ESVJ9L2luc3Bl Y3Rvci94eGQucGwgWE1MVmlld2VyX2pzICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9Y TUxWaWV3ZXIubWluLmpzICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9YTUxWaWV3ZXJK Uy5oCiAgICAgVkVSQkFUSU0pCiBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMgJHtERVJJVkVE X1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1hNTFZpZXdlckpTLmgpCg==