121441 2013-09-16 10:36:11 -0700 Change a couple of COMPILE_ASSERTs to static_assert 2013-09-16 10:49:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 929799 0 andersca 2013-09-16 10:36:11 -0700 Change a couple of COMPILE_ASSERTs to static_assert 929800 1 211809 andersca 2013-09-16 10:36:54 -0700 Created attachment 211809 Patch 929802 2 commit-queue 2013-09-16 10:38:37 -0700 Attachment 211809 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/BloomFilter.h', u'Source/WTF/wtf/PackedIntVector.h', u'Source/WTF/wtf/StdLibExtras.h', u'Source/WTF/wtf/StringHasher.h', u'Source/WTF/wtf/Vector.h', u'Source/WTF/wtf/text/AtomicString.cpp', u'Source/WTF/wtf/unicode/Unicode.h']" exit_code: 1 Source/WTF/wtf/StdLibExtras.h:133: bitwise_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 929803 3 211809 kling 2013-09-16 10:38:55 -0700 Comment on attachment 211809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211809&action=review > Source/WTF/wtf/StdLibExtras.h:135 > + static_assert(sizeof(FromType) == sizeof(ToType), "bitwise_cast size of FromType and toType must be equal!"); toType -> ToType 929807 4 andersca 2013-09-16 10:49:33 -0700 Committed r155883: <http://trac.webkit.org/changeset/155883> 211809 2013-09-16 10:36:54 -0700 2013-09-16 10:38:54 -0700 Patch bug-121441-20130916103653.patch text/plain 6474 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI3YTlhMWFlMGQ0ZGZkOGMzYTQyMjc0 ZWY2ZGE1OTE1YTE0ZjI1MDYuLmFhNTU5ZjM0MjdmMjAxYzQzNWEwNDY5MTJiZjU0N2M5YjMwYzY0 MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMDktMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgYSBjb3VwbGUgb2YgQ09NUElMRV9B U1NFUlRzIHRvIHN0YXRpY19hc3NlcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMTQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL0Jsb29tRmlsdGVyLmg6CisgICAgICAgICogd3RmL1BhY2tl ZEludFZlY3Rvci5oOgorICAgICAgICAoV1RGOjpQYWNrZWRJbnRWZWN0b3I6OlBhY2tlZEludFZl Y3Rvcik6CisgICAgICAgICogd3RmL1N0ZExpYkV4dHJhcy5oOgorICAgICAgICAoV1RGOjpiaXR3 aXNlX2Nhc3QpOgorICAgICAgICAoV1RGOjpzYWZlQ2FzdCk6CisgICAgICAgIChXVEY6OnJvdW5k VXBUb011bHRpcGxlT2YpOgorICAgICAgICAqIHd0Zi9TdHJpbmdIYXNoZXIuaDoKKyAgICAgICAg KFdURjo6U3RyaW5nSGFzaGVyOjpoYXNoTWVtb3J5KToKKyAgICAgICAgKiB3dGYvVmVjdG9yLmg6 CisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKiB3dGYvdW5p Y29kZS9Vbmljb2RlLmg6CisKIDIwMTMtMDktMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KIAogICAgICAgICBQaWNrIHRoZSBjb3JyZWN0IG92ZXJsb2FkIHdoZW4gYSBj b25zdCByZWZlcmVuY2UgaXMgcGFzc2VkIHRvIGFwcGVuZFNsb3dDYXNlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvQmxvb21GaWx0ZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0Jsb29tRmlsdGVy LmgKaW5kZXggNDc2MjhmZGNlYzdkOTdkNGQ1MDIxMWIzZTRjZWYwMzkwMDgwNDYwMi4uZTE0Y2Iy ODBlMzU1OGUwMzA0NTE3MjhlYjM2ZTVhNDhjNDk2YjdiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvQmxvb21GaWx0ZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9CbG9vbUZpbHRlci5oCkBA IC0zNyw3ICszNyw3IEBAIHRlbXBsYXRlIDx1bnNpZ25lZCBrZXlCaXRzPgogY2xhc3MgQmxvb21G aWx0ZXIgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIENPTVBJ TEVfQVNTRVJUKGtleUJpdHMgPD0gMTYsIGJsb29tX2ZpbHRlcl9rZXlfc2l6ZSk7CisgICAgc3Rh dGljX2Fzc2VydChrZXlCaXRzIDw9IDE2LCAiQmxvb21GaWx0ZXIga2V5IHNpemUgbXVzdCBiZSBs ZXNzIHRoYW4gb3IgZXF1YWwgdG8gMTYhIik7CiAKICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IHRh YmxlU2l6ZSA9IDEgPDwga2V5Qml0czsKICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQga2V5TWFz ayA9ICgxIDw8IGtleUJpdHMpIC0gMTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BhY2tl ZEludFZlY3Rvci5oIGIvU291cmNlL1dURi93dGYvUGFja2VkSW50VmVjdG9yLmgKaW5kZXggYTI0 NWYzYTM4NDBhNjAyMmY0OTE1ODA2MDdiNjY0ZTRiMjY5NjczMi4uYTA2ZDU4Njc5NGExMWM2Mjg4 Zjk2NDI3MTQ5NzY0ZGQ2NzY3YzRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFja2Vk SW50VmVjdG9yLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFja2VkSW50VmVjdG9yLmgKQEAgLTQw LDEwICs0MCwxMSBAQCBuYW1lc3BhY2UgV1RGIHsKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHVuc2ln bmVkIGJpdENvdW50PgogY2xhc3MgUGFja2VkSW50VmVjdG9yIHsKIHB1YmxpYzoKKyAgICBzdGF0 aWNfYXNzZXJ0KGJpdENvdW50LCAiYml0Q291bnQgbXVzdCBub3QgYmUgemVybyEiKTsKKyAgICBz dGF0aWNfYXNzZXJ0KGJpdENvdW50IDwgc2l6ZW9mKHZvaWQqKSAqIDgsICJiaXRDb3VudCBtdXN0 IG5vdCBleGNlZWQgdGhlIGFkZHJlc3Mgc3BhY2UgbGltaXQhIik7CisKICAgICBQYWNrZWRJbnRW ZWN0b3IoKQogICAgIHsKLSAgICAgICAgQ09NUElMRV9BU1NFUlQoYml0Q291bnQsIGJpdENvdW50 X3NoYWxsX25vdF9iZV96ZXJvKTsKLSAgICAgICAgQ09NUElMRV9BU1NFUlQoYml0Q291bnQgPCBz aXplb2Yodm9pZCopICogOCwgYml0Q291bnRfc2hhbGxfbm90X2V4Y2VlZF9hZGRyZXNzX3NwYWNl X2xpbWl0KTsKICAgICB9CiAgICAgCiAgICAgUGFja2VkSW50VmVjdG9yKGNvbnN0IFBhY2tlZElu dFZlY3RvciYgb3RoZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMu aCBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCmluZGV4IGEzYzZmNGZiOGEzMGJjMTQ5 OWRmNDNjMWY2NGE1Yjc0MTY5NDNhMGIuLjkwNjA3NTBiZmYzYTljODUyYTMyMzQ0YTVjYWFmYzQy YjQwOGVhM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCkBAIC0xMjksMjMgKzEyOSwyMyBAQCBpbmxp bmUgYm9vbCBpczhCeXRlQWxpZ25lZCh2b2lkKiBwKQogLyoKICAqIEMrKydzIGlkZWEgb2YgYSBy ZWludGVycHJldF9jYXN0IGxhY2tzIHN1ZmZpY2llbnQgY29qb25lcy4KICAqLwotdGVtcGxhdGU8 dHlwZW5hbWUgVE8sIHR5cGVuYW1lIEZST00+Ci1pbmxpbmUgVE8gYml0d2lzZV9jYXN0KEZST00g ZnJvbSkKK3RlbXBsYXRlPHR5cGVuYW1lIFRvVHlwZSwgdHlwZW5hbWUgRnJvbVR5cGU+Citpbmxp bmUgVG9UeXBlIGJpdHdpc2VfY2FzdChGcm9tVHlwZSBmcm9tKQogewotICAgIENPTVBJTEVfQVNT RVJUKHNpemVvZihUTykgPT0gc2l6ZW9mKEZST00pLCBXVEZfYml0d2lzZV9jYXN0X3NpemVvZl9j YXN0ZWRfdHlwZXNfaXNfZXF1YWwpOworICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKEZyb21UeXBl KSA9PSBzaXplb2YoVG9UeXBlKSwgImJpdHdpc2VfY2FzdCBzaXplIG9mIEZyb21UeXBlIGFuZCB0 b1R5cGUgbXVzdCBiZSBlcXVhbCEiKTsKICAgICB1bmlvbiB7Ci0gICAgICAgIEZST00gZnJvbTsK LSAgICAgICAgVE8gdG87CisgICAgICAgIEZyb21UeXBlIGZyb207CisgICAgICAgIFRvVHlwZSB0 bzsKICAgICB9IHU7CiAgICAgdS5mcm9tID0gZnJvbTsKICAgICByZXR1cm4gdS50bzsKIH0KIAot dGVtcGxhdGU8dHlwZW5hbWUgVG8sIHR5cGVuYW1lIEZyb20+Ci1pbmxpbmUgVG8gc2FmZUNhc3Qo RnJvbSB2YWx1ZSkKK3RlbXBsYXRlPHR5cGVuYW1lIFRvVHlwZSwgdHlwZW5hbWUgRnJvbVR5cGU+ CitpbmxpbmUgVG9UeXBlIHNhZmVDYXN0KEZyb21UeXBlIHZhbHVlKQogewotICAgIEFTU0VSVChp c0luQm91bmRzPFRvPih2YWx1ZSkpOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDxUbz4odmFsdWUp OworICAgIEFTU0VSVChpc0luQm91bmRzPFRvVHlwZT4odmFsdWUpKTsKKyAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8VG9UeXBlPih2YWx1ZSk7CiB9CiAKIC8vIFJldHVybnMgYSBjb3VudCBvZiB0aGUg bnVtYmVyIG9mIGJpdHMgc2V0IGluICdiaXRzJy4KQEAgLTE3MSw5ICsxNzEsMTAgQEAgaW5saW5l IHNpemVfdCByb3VuZFVwVG9NdWx0aXBsZU9mKHNpemVfdCBkaXZpc29yLCBzaXplX3QgeCkKICAg ICBzaXplX3QgcmVtYWluZGVyTWFzayA9IGRpdmlzb3IgLSAxOwogICAgIHJldHVybiAoeCArIHJl bWFpbmRlck1hc2spICYgfnJlbWFpbmRlck1hc2s7CiB9CisKIHRlbXBsYXRlPHNpemVfdCBkaXZp c29yPiBpbmxpbmUgc2l6ZV90IHJvdW5kVXBUb011bHRpcGxlT2Yoc2l6ZV90IHgpCiB7Ci0gICAg Q09NUElMRV9BU1NFUlQoZGl2aXNvciAmJiAhKGRpdmlzb3IgJiAoZGl2aXNvciAtIDEpKSwgZGl2 aXNvcl9pc19hX3Bvd2VyX29mX3R3byk7CisgICAgc3RhdGljX2Fzc2VydChkaXZpc29yICYmICEo ZGl2aXNvciAmIChkaXZpc29yIC0gMSkpLCAiZGl2aXNvciBtdXN0IGJlIGEgcG93ZXIgb2YgdHdv ISIpOwogICAgIHJldHVybiByb3VuZFVwVG9NdWx0aXBsZU9mKGRpdmlzb3IsIHgpOwogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdHJpbmdIYXNoZXIuaCBiL1NvdXJjZS9XVEYvd3Rm L1N0cmluZ0hhc2hlci5oCmluZGV4IGQ5NTgyYWE5NDExNmE1Y2UyYjE2NDQ0YTJmM2JkODYzNjli ODA1ZmYuLjY0MzFmNWI4YTYzMTU4ZDYwNTFjYzk4NmM5ZDU2NGYyNzI2YWUwMDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL1N0cmluZ0hhc2hlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0 cmluZ0hhc2hlci5oCkBAIC0yNDgsNyArMjQ4LDcgQEAgcHVibGljOgogCiAgICAgdGVtcGxhdGU8 c2l6ZV90IGxlbmd0aD4gc3RhdGljIHVuc2lnbmVkIGhhc2hNZW1vcnkoY29uc3Qgdm9pZCogZGF0 YSkKICAgICB7Ci0gICAgICAgIENPTVBJTEVfQVNTRVJUKCEobGVuZ3RoICUgMiksIGxlbmd0aF9t dXN0X2JlX2FfbXVsdGlwbGVfb2ZfdHdvKTsKKyAgICAgICAgc3RhdGljX2Fzc2VydCghKGxlbmd0 aCAlIDIpLCAibGVuZ3RoIG11c3QgYmUgYSBtdWx0aXBsZSBvZiB0d28hIik7CiAgICAgICAgIHJl dHVybiBoYXNoTWVtb3J5KGRhdGEsIGxlbmd0aCk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9WZWN0b3IuaCBiL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCmluZGV4IDg5YzJh NWNjMTRmMzFlZWI1NDM5ZjI4YjJkYThiYzQxM2JiNmNiM2UuLjdjNDUxMDViZmMwYjEyMTQwYzc2 NGEwMjNiYWEyYTZkNjQ2NzU5ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCkBAIC0xNzQsNyArMTc0LDcgQEAgc3RydWN0 IFZlY3RvckZpbGxlcjx0cnVlLCBUPgogewogICAgIHN0YXRpYyB2b2lkIHVuaW5pdGlhbGl6ZWRG aWxsKFQqIGRzdCwgVCogZHN0RW5kLCBjb25zdCBUJiB2YWwpIAogICAgIHsKLSAgICAgICAgQ09N UElMRV9BU1NFUlQoc2l6ZW9mKFQpID09IHNpemVvZihjaGFyKSwgU2l6ZV9vZl90eXBlX3Nob3Vs ZF9iZV9lcXVhbF90b19vbmUpOworICAgICAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihUKSA9PSAx LCAiU2l6ZSBvZiB0eXBlIFQgc2hvdWxkIGJlIGVxdWFsIHRvIG9uZSEiKTsKICNpZiBDT01QSUxF UihHQ0MpICYmIGRlZmluZWQoX0ZPUlRJRllfU09VUkNFKQogICAgICAgICBpZiAoIV9fYnVpbHRp bl9jb25zdGFudF9wKGRzdEVuZCAtIGRzdCkgfHwgKCEoZHN0RW5kIC0gZHN0KSkpCiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcCBiL1NvdXJj ZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAppbmRleCA4MTAzMDgxYjAxYjM3NzVhOGZi NDg0ODM2ZDEwYTg1ZDg4MzViMTMwLi41MTU5YjRjYTdlM2VkZDI3ODBkYjZiYjhkMDJlNWI1OWRj OGRkN2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAK KysrIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCkBAIC00MCw3ICs0MCw3 IEBAIG5hbWVzcGFjZSBXVEYgewogCiB1c2luZyBuYW1lc3BhY2UgVW5pY29kZTsKIAotQ09NUElM RV9BU1NFUlQoc2l6ZW9mKEF0b21pY1N0cmluZykgPT0gc2l6ZW9mKFN0cmluZyksIGF0b21pY19z dHJpbmdfYW5kX3N0cmluZ19tdXN0X2JlX3NhbWVfc2l6ZSk7CitzdGF0aWNfYXNzZXJ0KHNpemVv ZihBdG9taWNTdHJpbmcpID09IHNpemVvZihTdHJpbmcpLCAiQXRvbWljU3RyaW5nIGFuZCBTdHJp bmcgbXVzdCBiZSBzYW1lIHNpemUhIik7CiAKICNpZiBVU0UoV0VCX1RIUkVBRCkKIGNsYXNzIEF0 b21pY1N0cmluZ1RhYmxlTG9ja2VyIDogcHVibGljIFNwaW5Mb2NrSG9sZGVyIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL3VuaWNvZGUvVW5pY29kZS5oIGIvU291cmNlL1dURi93dGYvdW5p Y29kZS9Vbmljb2RlLmgKaW5kZXggYzc2NDE4NDMwMzdmZDJkOGYxNTcwYzg3OGQ1YjViNDAzMTUx ZmJkZi4uYmYzOGUyZThiZDc5ZTBlNDI1ZjI4OTAyZWJhZjUwMzFmNzVjZmE3NCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvdW5pY29kZS9Vbmljb2RlLmgKKysrIGIvU291cmNlL1dURi93dGYv dW5pY29kZS9Vbmljb2RlLmgKQEAgLTM2LDYgKzM2LDYgQEAgdHlwZWRlZiB1bnNpZ25lZCBjaGFy IExDaGFyOwogI2Vycm9yICJVbmtub3duIFVuaWNvZGUgaW1wbGVtZW50YXRpb24iCiAjZW5kaWYK IAotQ09NUElMRV9BU1NFUlQoc2l6ZW9mKFVDaGFyKSA9PSAyLCBVQ2hhcklzVHdvQnl0ZXMpOwor c3RhdGljX2Fzc2VydChzaXplb2YoVUNoYXIpID09IDIsICJVQ2hhciBtdXN0IGJlIHR3byBieXRl cyEiKTsKIAogI2VuZGlmIC8vIFdURl9VTklDT0RFX0gK