121436 2013-09-16 08:51:49 -0700 Buildfix in WebResourceBuffer.h to make GCC 4.6 happy 2013-09-17 08:03:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110141 1 ossy ossy beidson kbalazs ossy skyul oldest_to_newest 929732 0 ossy 2013-09-16 08:51:49 -0700 WebResourceBuffer.h is only used by NetworkProcess now and the following build failure was revealed by https://bugs.webkit.org/show_bug.cgi?id=110141: /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp:34:1: error: prototype for ‘WebKit::WebResourceBuffer::WebResourceBuffer(WTF::PassRefPtr<WebKit::ShareableResource>)’ does not match any in class ‘WebKit::WebResourceBuffer’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:36:7: error: candidates are: WebKit::WebResourceBuffer::WebResourceBuffer(const WebKit::WebResourceBuffer&) /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:47:5: error: WebKit::WebResourceBuffer::WebResourceBuffer(WTF::PassRefPtr<ShareableResource>) /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp: In member function ‘virtual const char* WebKit::WebResourceBuffer::data() const’: /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp:46:52: error: invalid use of incomplete type ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:32:7: error: forward declaration of ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp: In member function ‘virtual unsigned int WebKit::WebResourceBuffer::size() const’: /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp:51:22: error: invalid use of incomplete type ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:32:7: error: forward declaration of ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp: In member function ‘virtual bool WebKit::WebResourceBuffer::isEmpty() const’: /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp:56:38: error: invalid use of incomplete type ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:32:7: error: forward declaration of ‘struct ShareableResource’ In file included from /home/ossy/WebKitNix/Source/WTF/wtf/RefPtr.h:29:0, from /home/ossy/WebKitNix/Source/WTF/wtf/VectorTraits.h:26, from /home/ossy/WebKitNix/Source/WTF/wtf/Vector.h:31, from /home/ossy/WebKitNix/Source/WebCore/platform/SharedBuffer.h:33, from /home/ossy/WebKitNix/Source/WebCore/loader/ResourceBuffer.h:29, from /home/ossy/WebKitNix/WebKitBuild/Release/DerivedSources/WebKit2/include/WebCore/ResourceBuffer.h:1, from /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:30, from /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.cpp:27: /home/ossy/WebKitNix/Source/WTF/wtf/PassRefPtr.h: In function ‘void WTF::derefIfNotNull(T*) [with T = ShareableResource]’: /home/ossy/WebKitNix/Source/WTF/wtf/PassRefPtr.h:67:39: instantiated from ‘WTF::PassRefPtr<T>::~PassRefPtr() [with T = ShareableResource]’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:38:137: instantiated from here /home/ossy/WebKitNix/Source/WTF/wtf/PassRefPtr.h:52:13: error: invalid use of incomplete type ‘struct ShareableResource’ /home/ossy/WebKitNix/Source/WebKit2/Shared/WebResourceBuffer.h:32:7: error: forward declaration of ‘struct ShareableResource’ related comments: ------------------ -https://bugs.webkit.org/show_bug.cgi?id=110141#c8 Kwang Yul Seo: "Changed forward declaration of ShareableResource to actual include because GCC requires a definition of the type for passing it in a PassOwnPtr." - https://bugs.webkit.org/show_bug.cgi?id=110141#c11 Brady Eidson: " The ChangeLog indicates this undesirable change is because of GCC requirements. Why does GCC have this deficiency? Was the deficiency in GCC fixed in a later version? There's been a vocal and public push to move the compiler dependencies in the project forward, and WebKit2 has traditionally been the flagship of this effort. Is it truly unavoidable to have to make this type of change?" - https://bugs.webkit.org/show_bug.cgi?id=110141#c12 Kwang Yul Seo: "This change was in the original patch written by Balazs Kelemen. I double-checked and found that this is not needed at least in GCC 4.7. I will revert the change because we already limit the supported compilers to GCC >= 4.7 and Clang >= 3.0 (Bug 109932). Balazs, do you remember the version of GCC you had this problem?" - https://bugs.webkit.org/show_bug.cgi?id=110141#c21 by me - https://bugs.webkit.org/show_bug.cgi?id=110141#c22 by kbalazs - https://bugs.webkit.org/show_bug.cgi?id=110141#c23 by me 929735 1 211795 ossy 2013-09-16 08:56:12 -0700 Created attachment 211795 Patch I don't think if we should drop GCC 4.6 (default GCC on the latest Ubuntu LTS - 12.04) support at all if we can fix it with this simple patch. 929828 2 211795 darin 2013-09-16 11:27:26 -0700 Comment on attachment 211795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211795&action=review > Source/WebKit2/ChangeLog:12 > + * Shared/WebResourceBuffer.h: Changed forward declaration of ShareableResource to > + actual include because GCC requires a definition of the type for passing it in a PassOwnPtr. That explanation doesn’t make sense. This header doesn’t have any PassOwnPtr. 929830 3 211795 darin 2013-09-16 11:28:18 -0700 Comment on attachment 211795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211795&action=review > Source/WebKit2/Shared/WebResourceBuffer.h:29 > +#include "ShareableResource.h" Does adding this include to the WebResourceBuffer.cpp file fix the compilation of that file? I don’t think this is needed in the header. 929853 4 211795 ossy 2013-09-16 12:12:09 -0700 Comment on attachment 211795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211795&action=review >> Source/WebKit2/ChangeLog:12 >> + actual include because GCC requires a definition of the type for passing it in a PassOwnPtr. > > That explanation doesn’t make sense. This header doesn’t have any PassOwnPtr. Good point, it seems it was a typo, not PassOwnPtr, but PassRefPtr. >> Source/WebKit2/Shared/WebResourceBuffer.h:29 >> +#include "ShareableResource.h" > > Does adding this include to the WebResourceBuffer.cpp file fix the compilation of that file? I don’t think this is needed in the header. Thanks the idea, maybe it is enough, I'll check it tomorrow. 930219 5 ossy 2013-09-17 08:03:11 -0700 I checked it again and it seems we don't need this workaround anymore after http://trac.webkit.org/changeset/155232/trunk/Source/WTF/wtf/PassRefPtr.h The problem was the hack removed by r155232 used inline instead of always inline. But now it works fine. 211795 2013-09-16 08:56:12 -0700 2013-09-16 12:12:33 -0700 Patch bug-121436-20130916175610.patch text/plain 1600 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzhmMjI5M2E5Y2VjNmRm ZDE2NTE3NmVhMDY1ZTZiOTZiY2IwZTU1OC4uMjYyODdjMGQ4NWZkYjA2M2MxMTMwYjE0ZWQzZjlj YmMwNTk2MzhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTE2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQnVpbGRmaXggaW4g V2ViUmVzb3VyY2VCdWZmZXIuaCB0byBtYWtlIEdDQyA0LjYgaGFwcHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQzNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGJ5IEJhbGF6 cyBLZWxlbWVuIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisgICAgICAgIGFuZCBLd2FuZyBZdWwgU2Vv IDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICAqIFNoYXJlZC9XZWJSZXNvdXJjZUJ1 ZmZlci5oOiBDaGFuZ2VkIGZvcndhcmQgZGVjbGFyYXRpb24gb2YgU2hhcmVhYmxlUmVzb3VyY2Ug dG8KKyAgICAgICAgYWN0dWFsIGluY2x1ZGUgYmVjYXVzZSBHQ0MgcmVxdWlyZXMgYSBkZWZpbml0 aW9uIG9mIHRoZSB0eXBlIGZvciBwYXNzaW5nIGl0IGluIGEgUGFzc093blB0ci4KKwogMjAxMy0w OS0xNiAgRXVubWkgTGVlICA8ZXVubWkxNS5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VG TF1bV0syXSBJbXBsZW1lbnQgcGFuIGFuZCBmbGljayBnZXN0dXJlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvU2hhcmVkL1dlYlJlc291cmNlQnVmZmVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUmVzb3VyY2VCdWZmZXIuaAppbmRleCBiNDdmMzE4MTU4MzI5YTg1NTA0ZTIyODFk YmIzZjU2NjdiZjM0ZjdhLi5kNjI0YzA4ZGZhZTY4MTZiZTIxNzAyZmJmY2FmMDgyZGRhYmU1Y2Jh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUmVzb3VyY2VCdWZmZXIuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUmVzb3VyY2VCdWZmZXIuaApAQCAtMjYsMTIg KzI2LDExIEBACiAjaWZuZGVmIFdlYlJlc291cmNlQnVmZmVyX2gKICNkZWZpbmUgV2ViUmVzb3Vy Y2VCdWZmZXJfaAogCisjaW5jbHVkZSAiU2hhcmVhYmxlUmVzb3VyY2UuaCIKICNpbmNsdWRlIDxX ZWJDb3JlL1Jlc291cmNlQnVmZmVyLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1jbGFzcyBT aGFyZWFibGVSZXNvdXJjZTsKLQogY2xhc3MgV2ViUmVzb3VyY2VCdWZmZXIgOiBwdWJsaWMgV2Vi Q29yZTo6UmVzb3VyY2VCdWZmZXIgewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFdl YlJlc291cmNlQnVmZmVyPiBjcmVhdGUoUGFzc1JlZlB0cjxTaGFyZWFibGVSZXNvdXJjZT4gcmVz b3VyY2UpIHsgcmV0dXJuIGFkb3B0UmVmKG5ldyBXZWJSZXNvdXJjZUJ1ZmZlcihyZXNvdXJjZSkp OyB9Cg==