121433 2013-09-16 08:21:30 -0700 [GTK][EFL] Add ResourceError::internalError() after r138387 2013-09-17 02:46:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110141 1 ossy ossy beidson cdumez commit-queue gyuyoung.kim kbalazs ossy philn rakuco skyul xan.lopez oldest_to_newest 929706 0 ossy 2013-09-16 08:21:30 -0700 http://trac.webkit.org/changeset/138387 added the new ResourceError::internalError(), but for Mac only. We need it for GTK and EFL too. 929714 1 211788 ossy 2013-09-16 08:27:35 -0700 Created attachment 211788 Patch I fixed the GTK implementation as Kwang Yul Seo noticed in https://bugs.webkit.org/show_bug.cgi?id=110141#c13 930100 2 211873 ossy 2013-09-17 01:34:12 -0700 Created attachment 211873 Patch glib/gi18n-lib.h added to fix the GTK build. 930107 3 211873 cdumez 2013-09-17 02:14:22 -0700 Comment on attachment 211873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75 > +WebCore::ResourceError internalError(const WebCore::KURL& url) Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ? > Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:78 > +WebCore::ResourceError internalError(const WebCore::KURL& url) Ditto. 930109 4 211873 ossy 2013-09-17 02:23:05 -0700 Comment on attachment 211873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review >> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75 >> +WebCore::ResourceError internalError(const WebCore::KURL& url) > > Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ? internalError() is called from only ENABLE(NETWORK_PROCESS) blocks, but it builds now with !ENABLE(NETWORK_PROCESS). I don't think if we should add guards not to have unreachable code. It is the job of the linker to get rid these unused functions. 930113 5 211873 cdumez 2013-09-17 02:26:58 -0700 Comment on attachment 211873 Patch I don't really mind either way so r+. There is no guard in WebErrors.h anyway. 930117 6 211873 ossy 2013-09-17 02:46:40 -0700 Comment on attachment 211873 Patch Clearing flags on attachment: 211873 Committed r155942: <http://trac.webkit.org/changeset/155942> 930118 7 ossy 2013-09-17 02:46:46 -0700 All reviewed patches have been landed. Closing bug. 211788 2013-09-16 08:27:35 -0700 2013-09-16 11:57:21 -0700 Patch bug-121433-20130916172733.patch text/plain 2960 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzhmMjI5M2E5Y2VjNmRm ZDE2NTE3NmVhMDY1ZTZiOTZiY2IwZTU1OC4uMzgyNjEyYTZhMzNiMzg0MzY5NjlkNWZjMWFhYmFl NTM2ZjlkYTY4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTE2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS11bRUZMXSBB ZGQgUmVzb3VyY2VFcnJvcjo6aW50ZXJuYWxFcnJvcigpIGFmdGVyIHIxMzgzODcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQzMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGJ5 IEJhbGF6cyBLZWxlbWVuIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisgICAgICAgIGFuZCBLd2FuZyBZ dWwgU2VvIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmludGVy bmFsRXJyb3IpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkVy cm9yc0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmludGVybmFsRXJyb3IpOgorCiAyMDEzLTA5 LTE2ICBFdW5taSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XVtXSzJdIEltcGxlbWVudCBwYW4gYW5kIGZsaWNrIGdlc3R1cmUuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3Jz RWZsLmNwcAppbmRleCA5ZDhkZmRhMGRhYjc0OTIwNDM5MzUyZGFkOTU5NTUzYmRjZGFlYWU1Li4z NDVkOWMwNWRlM2ZjZDNjN2U3YjAxYTkwNTI4NDk5NzRhYWJkYTU2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVy cm9yc0VmbC5jcHAKQEAgLTI2LDEwICsyNiwxMiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2lu Y2x1ZGUgIldlYkVycm9ycy5oIgogCisjaW5jbHVkZSAiV2ViRXJyb3IuaCIKICNpbmNsdWRlIDxX ZWJDb3JlL0Vycm9yc0VmbC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VFcnJvci5oPgog I2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9S ZXNvdXJjZVJlc3BvbnNlLmg+CisjaW5jbHVkZSA8V2ViS2l0Mi9XS0Vycm9yLmg+CiAKIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC03MCw0ICs3Miw5IEBAIFJlc291cmNlRXJyb3IgcGx1 Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkK ICAgICByZXR1cm4gV2ViQ29yZTo6cGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihyZXNwb25zZSk7 CiB9CiAKK1dlYkNvcmU6OlJlc291cmNlRXJyb3IgaW50ZXJuYWxFcnJvcihjb25zdCBXZWJDb3Jl OjpLVVJMJiB1cmwpCit7CisgICAgcmV0dXJuIFJlc291cmNlRXJyb3IoV2ViRXJyb3I6OndlYktp dEVycm9yRG9tYWluKCksIGtXS0Vycm9ySW50ZXJuYWwsIHVybC5zdHJpbmcoKSwgQVNDSUlMaXRl cmFsKCJJbnRlcm5hbCBlcnJvciIpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2d0ay9XZWJF cnJvcnNHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9n dGsvV2ViRXJyb3JzR3RrLmNwcAppbmRleCA4Mzc1ZDA2N2FlYjEyZDg5MmFlZmE2OGU2NmVhNjMz Yzk4ODI2M2NjLi4zZTkxZTI1NmU4M2VmNmY4MzllNmI3YWVhNzUwNTY2Y2ZmZjdmMGRmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2d0ay9XZWJF cnJvcnNHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvZ3RrL1dlYkVycm9yc0d0ay5jcHAKQEAgLTI4LDEwICsyOCwxMiBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIldlYkVycm9ycy5oIgogCisjaW5jbHVkZSAiV2ViRXJyb3IuaCIK ICNpbmNsdWRlIDxXZWJDb3JlL0Vycm9yc0d0ay5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3Vy Y2VFcnJvci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNlLmg+CisjaW5jbHVkZSA8V2ViS2l0Mi9XS0Vycm9y Lmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC03Miw0ICs3NCw5IEBAIFJlc291 cmNlRXJyb3IgcGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNl JiByZXNwb25zZSkKICAgICByZXR1cm4gV2ViQ29yZTo6cGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJv cihyZXNwb25zZSk7CiB9CiAKK1dlYkNvcmU6OlJlc291cmNlRXJyb3IgaW50ZXJuYWxFcnJvcihj b25zdCBXZWJDb3JlOjpLVVJMJiB1cmwpCit7CisgICAgcmV0dXJuIFJlc291cmNlRXJyb3IoV2Vi RXJyb3I6OndlYktpdEVycm9yRG9tYWluKCksIGtXS0Vycm9ySW50ZXJuYWwsIHVybC5zdHJpbmco KSwgXygiSW50ZXJuYWwgZXJyb3IiKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 211873 2013-09-17 01:34:12 -0700 2013-09-17 02:46:40 -0700 Patch bug-121433-20130917103435.patch text/plain 3062 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzM0OTA4OGRkOWZlMTM5 NThkZWYxNDg4MzhlOGZkMjE0MGY0YTU4Mi4uNDg1MzI2ZjRkOTA3MTNhZjU1YzRiYzQwMDIxYjk4 MzdjODFiMDMzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA5LTE3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW0dUS11bRUZMXSBB ZGQgUmVzb3VyY2VFcnJvcjo6aW50ZXJuYWxFcnJvcigpIGFmdGVyIHIxMzgzODcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQzMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGJ5 IEJhbGF6cyBLZWxlbWVuIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisgICAgICAgIGFuZCBLd2FuZyBZ dWwgU2VvIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmludGVy bmFsRXJyb3IpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkVy cm9yc0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmludGVybmFsRXJyb3IpOgorCisyMDEzLTA5 LTE3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKICAgICAgICAgW0dU S11bRUZMXSBBZGQgTmV0d29ya1Byb2Nlc3Mgc3VwcG9ydCBmb3IgUHJvY2Vzc0xhdW5jaGVyCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE0MzQKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwv V2ViRXJyb3JzRWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvZWZsL1dlYkVycm9yc0VmbC5jcHAKaW5kZXggOWQ4ZGZkYTBkYWI3NDkyMDQzOTM1MmRhZDk1 OTU1M2JkY2RhZWFlNS4uMzQ1ZDljMDVkZTNmY2QzYzdlN2IwMWE5MDUyODQ5OTc0YWFiZGE1NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwv V2ViRXJyb3JzRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3BwCkBAIC0yNiwxMCArMjYsMTIgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJFcnJvcnMuaCIKIAorI2luY2x1ZGUgIldlYkVycm9y LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9FcnJvcnNFZmwuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jl c291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVxdWVzdC5oPgogI2lu Y2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXNwb25zZS5oPgorI2luY2x1ZGUgPFdlYktpdDIvV0tF cnJvci5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtNzAsNCArNzIsOSBAQCBS ZXNvdXJjZUVycm9yIHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXNw b25zZSYgcmVzcG9uc2UpCiAgICAgcmV0dXJuIFdlYkNvcmU6OnBsdWdpbldpbGxIYW5kbGVMb2Fk RXJyb3IocmVzcG9uc2UpOwogfQogCitXZWJDb3JlOjpSZXNvdXJjZUVycm9yIGludGVybmFsRXJy b3IoY29uc3QgV2ViQ29yZTo6S1VSTCYgdXJsKQoreworICAgIHJldHVybiBSZXNvdXJjZUVycm9y KFdlYkVycm9yOjp3ZWJLaXRFcnJvckRvbWFpbigpLCBrV0tFcnJvckludGVybmFsLCB1cmwuc3Ry aW5nKCksIEFTQ0lJTGl0ZXJhbCgiSW50ZXJuYWwgZXJyb3IiKSk7Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9ndGsvV2ViRXJyb3JzR3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkVycm9yc0d0ay5jcHAKaW5kZXggODM3NWQwNjdhZWIxMmQ4 OTJhZWZhNjhlNjZlYTYzM2M5ODgyNjNjYy4uYTgyZTdkZWUwZTk1ODZkOTE4NmYwZWU4MzY2YTY1 NDU4OWFkZmMzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9ndGsvV2ViRXJyb3JzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L2d0ay9XZWJFcnJvcnNHdGsuY3BwCkBAIC0yOCwxMCArMjgsMTMg QEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJFcnJvcnMuaCIKIAorI2luY2x1 ZGUgIldlYkVycm9yLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9FcnJvcnNHdGsuaD4KICNpbmNsdWRl IDxXZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVx dWVzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXNwb25zZS5oPgorI2luY2x1ZGUg PFdlYktpdDIvV0tFcnJvci5oPgorI2luY2x1ZGUgPGdsaWIvZ2kxOG4tbGliLmg+CiAKIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC03Miw0ICs3NSw5IEBAIFJlc291cmNlRXJyb3IgcGx1 Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkK ICAgICByZXR1cm4gV2ViQ29yZTo6cGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihyZXNwb25zZSk7 CiB9CiAKK1dlYkNvcmU6OlJlc291cmNlRXJyb3IgaW50ZXJuYWxFcnJvcihjb25zdCBXZWJDb3Jl OjpLVVJMJiB1cmwpCit7CisgICAgcmV0dXJuIFJlc291cmNlRXJyb3IoV2ViRXJyb3I6OndlYktp dEVycm9yRG9tYWluKCksIGtXS0Vycm9ySW50ZXJuYWwsIHVybC5zdHJpbmcoKSwgXygiSW50ZXJu YWwgZXJyb3IiKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=