121420 2013-09-16 03:41:16 -0700 [Win] Compile errors in WebCore derived sources. 2022-03-01 02:56:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned andersca bfulgham buildbot commit-queue darin eflews.bot esprehn+autocc gtk-ews gyuyoung.kim kangil.han kling philn rniwa webkit-ews xan.lopez oldest_to_newest 929607 0 peavo 2013-09-16 03:41:16 -0700 There's a few compile errors in WebCore, e.g: WebCore\DerivedSources\HTMLNames.cpp(4313): error C2440: 'reinterpret_cast' : cannot convert from 'const WebCore::QualifiedName *' to 'WebCore::QualifiedName *' Conversion loses qualifiers WebCore\DerivedSources\MathMLNames.cpp(721): error C2440: 'initializing' : cannot convert from 'const WebCore::QualifiedName *' to 'void *' Conversion loses qualifiers 929616 1 211756 peavo 2013-09-16 03:50:09 -0700 Created attachment 211756 Patch 929619 2 211756 webkit-ews 2013-09-16 03:58:38 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1865012 929622 3 211756 webkit-ews 2013-09-16 04:00:33 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1884175 929624 4 211756 eflews.bot 2013-09-16 04:03:55 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1919005 929627 5 211756 buildbot 2013-09-16 04:17:14 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1835104 929633 6 211756 eflews.bot 2013-09-16 04:34:33 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1884182 929635 7 211756 buildbot 2013-09-16 04:36:31 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1865015 929636 8 211756 gtk-ews 2013-09-16 04:40:20 -0700 Comment on attachment 211756 Patch Attachment 211756 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1852213 929697 9 211782 peavo 2013-09-16 07:36:43 -0700 Created attachment 211782 Patch 929699 10 211782 cdumez 2013-09-16 07:39:28 -0700 Comment on attachment 211782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review > Source/WebCore/dom/make_names.pl:755 > + print(F " new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n"); We usually avoid C-Style casts in the code. > Source/WebCore/dom/make_names.pl:866 > + print F " { (void*)&$name$shortCamelType, *${name}Impl },\n"; Ditto. 929738 11 211782 bfulgham 2013-09-16 08:58:15 -0700 Comment on attachment 211782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review >> Source/WebCore/dom/make_names.pl:755 >> + print(F " new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n"); > > We usually avoid C-Style casts in the code. When SKIP_STATIC_CONSTRUCTORS_ON_GCC is defined, the types of these globals are non-const. For all other platforms, they are const. This requires a combination of static_cast and const_cast, but it is dependent on the setting of this variable. I think in this case, the old fashioned C-style cast is the most concise way of dealing with this. >> Source/WebCore/dom/make_names.pl:866 >> + print F " { (void*)&$name$shortCamelType, *${name}Impl },\n"; > > Ditto. Idem. 929741 12 bfulgham 2013-09-16 09:02:58 -0700 This build failure was introduced in http://trac.webkit.org/changeset/155801. Darin reverted part of the change back in http://trac.webkit.org/changeset/155834/trunk/Source/WebCore/dom/make_names.pl. This change is in keeping with Darin's adjustment. 929742 13 211782 bfulgham 2013-09-16 09:03:26 -0700 Comment on attachment 211782 Patch r=me 929753 14 bfulgham 2013-09-16 09:17:58 -0700 Committed r155868: <http://trac.webkit.org/changeset/155868> 211756 2013-09-16 03:50:09 -0700 2013-09-16 07:36:34 -0700 Patch bug-121420-20130916125006.patch text/plain 2932 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTg0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA5LTE2ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIENvbXBpbGUg ZXJyb3JzIGluIFdlYkNvcmUgZGVyaXZlZCBzb3VyY2VzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vbWFrZV9uYW1lcy5wbDoKKyAgICAgICAg KHByaW50TmFtZXNDcHBGaWxlKTogQWRkZWQgY29uc3QgbW9kaWZpZXIuCisgICAgICAgIChwcmlu dERlZmluaXRpb25zKTogQWRkZWQgcmVpbnRlcnByZXRfY2FzdCBhbmQgY29uc3RfY2FzdC4KKwog MjAxMy0wOS0xNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAg Q1RURTogUmVuZGVyQ29tYmluZVRleHQgYWx3YXlzIGhhcyBhIFRleHQgbm9kZS4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9tYWtlX25hbWVzLnBsCShyZXZpc2lvbiAxNTU4NDcpCisrKyBTb3VyY2UvV2ViQ29y ZS9kb20vbWFrZV9uYW1lcy5wbAkod29ya2luZyBjb3B5KQpAQCAtNzI1LDcgKzcyNSw3IEBAIHN1 YiBwcmludE5hbWVzQ3BwRmlsZQogICAgICAgICBwcmludCBGICJcblxuY29uc3QgV2ViQ29yZTo6 UXVhbGlmaWVkTmFtZSogY29uc3QgKiBnZXQkcGFyYW1ldGVyc3tuYW1lc3BhY2V9VGFncygpXG4i OwogICAgICAgICBwcmludCBGICJ7XG4gICAgc3RhdGljIGNvbnN0IFdlYkNvcmU6OlF1YWxpZmll ZE5hbWUqIGNvbnN0ICRwYXJhbWV0ZXJze25hbWVzcGFjZX1UYWdzW10gPSB7XG4iOwogICAgICAg ICBmb3IgbXkgJG5hbWUgKHNvcnQga2V5cyAlYWxsVGFncykgewotICAgICAgICAgICAgcHJpbnQg RiAiICAgICAgICByZWludGVycHJldF9jYXN0PFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtu YW1lfVRhZyksXG4iOworICAgICAgICAgICAgcHJpbnQgRiAiICAgICAgICByZWludGVycHJldF9j YXN0PGNvbnN0IFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtuYW1lfVRhZyksXG4iOwogICAg ICAgICB9CiAgICAgICAgIHByaW50IEYgIiAgICB9O1xuIjsKICAgICAgICAgcHJpbnQgRiAiICAg IHJldHVybiAkcGFyYW1ldGVyc3tuYW1lc3BhY2V9VGFncztcbiI7CkBAIC03NDAsNyArNzQwLDcg QEAgc3ViIHByaW50TmFtZXNDcHBGaWxlCiAgICAgICAgIHByaW50IEYgIlxuXG5jb25zdCBXZWJD b3JlOjpRdWFsaWZpZWROYW1lKiBjb25zdCAqIGdldCRwYXJhbWV0ZXJze25hbWVzcGFjZX1BdHRy cygpXG4iOwogICAgICAgICBwcmludCBGICJ7XG4gICAgc3RhdGljIGNvbnN0IFdlYkNvcmU6OlF1 YWxpZmllZE5hbWUqIGNvbnN0ICRwYXJhbWV0ZXJze25hbWVzcGFjZX1BdHRyc1tdID0ge1xuIjsK ICAgICAgICAgZm9yIG15ICRuYW1lIChzb3J0IGtleXMgJWFsbEF0dHJzKSB7Ci0gICAgICAgICAg ICBwcmludCBGICIgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8V2ViQ29yZTo6UXVhbGlmaWVkTmFt ZSo+KCYke25hbWV9QXR0ciksXG4iOworICAgICAgICAgICAgcHJpbnQgRiAiICAgICAgICByZWlu dGVycHJldF9jYXN0PGNvbnN0IFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtuYW1lfUF0dHIp LFxuIjsKICAgICAgICAgfQogICAgICAgICBwcmludCBGICIgICAgfTtcbiI7CiAgICAgICAgIHBy aW50IEYgIiAgICByZXR1cm4gJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJzO1xuIjsKQEAgLTc1 Miw3ICs3NTIsNyBAQCBzdWIgcHJpbnROYW1lc0NwcEZpbGUKICAgICBwcmludChGICIgICAgQXRv bWljU3RyaW5nICR7bG93ZXJOYW1lc3BhY2V9TlMoXCIkcGFyYW1ldGVyc3tuYW1lc3BhY2VVUkl9 XCIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpO1xuXG4iKTsKIAogICAgIHBy aW50KEYgIiAgICAvLyBOYW1lc3BhY2VcbiIpOwotICAgIHByaW50KEYgIiAgICBuZXcgKE5vdE51 bGwsIHN0YXRpY19jYXN0PHZvaWQqPigmJHtsb3dlck5hbWVzcGFjZX1OYW1lc3BhY2VVUkkpKSBB dG9taWNTdHJpbmcoJHtsb3dlck5hbWVzcGFjZX1OUyk7XG4iKTsKKyAgICBwcmludChGICIgICAg bmV3IChOb3ROdWxsLCBzdGF0aWNfY2FzdDx2b2lkKj4oY29uc3RfY2FzdDxXVEY6OkF0b21pY1N0 cmluZyAqPigmJHtsb3dlck5hbWVzcGFjZX1OYW1lc3BhY2VVUkkpKSkgQXRvbWljU3RyaW5nKCR7 bG93ZXJOYW1lc3BhY2V9TlMpO1xuIik7CiAgICAgcHJpbnQoRiAiXG4iKTsKICAgICBwcmludCBG IFN0YXRpY1N0cmluZzo6R2VuZXJhdGVTdHJpbmdBc3NlcnRzKFwlYWxsU3RyaW5ncyk7CiAKQEAg LTg2Myw3ICs4NjMsNyBAQCBwcmludCBGIDw8RU5ECiBFTkQKIDsKICAgICBmb3IgbXkgJG5hbWUg KHNvcnQga2V5cyAlJG5hbWVzUmVmKSB7Ci0gICAgICAgIHByaW50IEYgIiAgICAgICAgeyAmJG5h bWUkc2hvcnRDYW1lbFR5cGUsICoke25hbWV9SW1wbCB9LFxuIjsKKyAgICAgICAgcHJpbnQgRiAi ICAgICAgICB7IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGNvbnN0X2Nhc3Q8V2ViQ29yZTo6UXVh bGlmaWVkTmFtZSo+KCYkbmFtZSRzaG9ydENhbWVsVHlwZSkpLCAqJHtuYW1lfUltcGwgfSxcbiI7 CiAgICAgfQogCiBwcmludCBGIDw8RU5ECg== 211782 2013-09-16 07:36:43 -0700 2022-03-01 02:56:41 -0800 Patch bug-121420-20130916163639.patch text/plain 2834 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTg1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA5LTE2ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIENvbXBpbGUg ZXJyb3JzIGluIFdlYkNvcmUgZGVyaXZlZCBzb3VyY2VzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vbWFrZV9uYW1lcy5wbDoKKyAgICAgICAg KHByaW50TmFtZXNDcHBGaWxlKTogQWRkZWQgY29uc3QgbW9kaWZpZXIuCisgICAgICAgIChwcmlu dERlZmluaXRpb25zKTogVXNlIEMgc3R5bGUgY2FzdC4KKwogMjAxMy0wOS0xNiAgS3J6eXN6dG9m IEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQVRLXSBFeHRlbmRzIGF0 ayB2YWx1ZSBpbnRlcmZhY2UgdG8gcmV0dXJuIHByb3BlciBjaGVja2JveCBzdGF0ZXMKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCShyZXZpc2lvbiAxNTU4NTIpCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vbWFrZV9uYW1lcy5wbAkod29ya2luZyBjb3B5KQpAQCAtNzI1LDcgKzcyNSw3IEBA IHN1YiBwcmludE5hbWVzQ3BwRmlsZQogICAgICAgICBwcmludCBGICJcblxuY29uc3QgV2ViQ29y ZTo6UXVhbGlmaWVkTmFtZSogY29uc3QgKiBnZXQkcGFyYW1ldGVyc3tuYW1lc3BhY2V9VGFncygp XG4iOwogICAgICAgICBwcmludCBGICJ7XG4gICAgc3RhdGljIGNvbnN0IFdlYkNvcmU6OlF1YWxp ZmllZE5hbWUqIGNvbnN0ICRwYXJhbWV0ZXJze25hbWVzcGFjZX1UYWdzW10gPSB7XG4iOwogICAg ICAgICBmb3IgbXkgJG5hbWUgKHNvcnQga2V5cyAlYWxsVGFncykgewotICAgICAgICAgICAgcHJp bnQgRiAiICAgICAgICByZWludGVycHJldF9jYXN0PFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigm JHtuYW1lfVRhZyksXG4iOworICAgICAgICAgICAgcHJpbnQgRiAiICAgICAgICByZWludGVycHJl dF9jYXN0PGNvbnN0IFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtuYW1lfVRhZyksXG4iOwog ICAgICAgICB9CiAgICAgICAgIHByaW50IEYgIiAgICB9O1xuIjsKICAgICAgICAgcHJpbnQgRiAi ICAgIHJldHVybiAkcGFyYW1ldGVyc3tuYW1lc3BhY2V9VGFncztcbiI7CkBAIC03NDAsNyArNzQw LDcgQEAgc3ViIHByaW50TmFtZXNDcHBGaWxlCiAgICAgICAgIHByaW50IEYgIlxuXG5jb25zdCBX ZWJDb3JlOjpRdWFsaWZpZWROYW1lKiBjb25zdCAqIGdldCRwYXJhbWV0ZXJze25hbWVzcGFjZX1B dHRycygpXG4iOwogICAgICAgICBwcmludCBGICJ7XG4gICAgc3RhdGljIGNvbnN0IFdlYkNvcmU6 OlF1YWxpZmllZE5hbWUqIGNvbnN0ICRwYXJhbWV0ZXJze25hbWVzcGFjZX1BdHRyc1tdID0ge1xu IjsKICAgICAgICAgZm9yIG15ICRuYW1lIChzb3J0IGtleXMgJWFsbEF0dHJzKSB7Ci0gICAgICAg ICAgICBwcmludCBGICIgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8V2ViQ29yZTo6UXVhbGlmaWVk TmFtZSo+KCYke25hbWV9QXR0ciksXG4iOworICAgICAgICAgICAgcHJpbnQgRiAiICAgICAgICBy ZWludGVycHJldF9jYXN0PGNvbnN0IFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtuYW1lfUF0 dHIpLFxuIjsKICAgICAgICAgfQogICAgICAgICBwcmludCBGICIgICAgfTtcbiI7CiAgICAgICAg IHByaW50IEYgIiAgICByZXR1cm4gJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJzO1xuIjsKQEAg LTc1Miw3ICs3NTIsNyBAQCBzdWIgcHJpbnROYW1lc0NwcEZpbGUKICAgICBwcmludChGICIgICAg QXRvbWljU3RyaW5nICR7bG93ZXJOYW1lc3BhY2V9TlMoXCIkcGFyYW1ldGVyc3tuYW1lc3BhY2VV Ukl9XCIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpO1xuXG4iKTsKIAogICAg IHByaW50KEYgIiAgICAvLyBOYW1lc3BhY2VcbiIpOwotICAgIHByaW50KEYgIiAgICBuZXcgKE5v dE51bGwsIHN0YXRpY19jYXN0PHZvaWQqPigmJHtsb3dlck5hbWVzcGFjZX1OYW1lc3BhY2VVUkkp KSBBdG9taWNTdHJpbmcoJHtsb3dlck5hbWVzcGFjZX1OUyk7XG4iKTsKKyAgICBwcmludChGICIg ICAgbmV3IChOb3ROdWxsLCAodm9pZCopJiR7bG93ZXJOYW1lc3BhY2V9TmFtZXNwYWNlVVJJKSBB dG9taWNTdHJpbmcoJHtsb3dlck5hbWVzcGFjZX1OUyk7XG4iKTsKICAgICBwcmludChGICJcbiIp OwogICAgIHByaW50IEYgU3RhdGljU3RyaW5nOjpHZW5lcmF0ZVN0cmluZ0Fzc2VydHMoXCVhbGxT dHJpbmdzKTsKIApAQCAtODYzLDcgKzg2Myw3IEBAIHByaW50IEYgPDxFTkQKIEVORAogOwogICAg IGZvciBteSAkbmFtZSAoc29ydCBrZXlzICUkbmFtZXNSZWYpIHsKLSAgICAgICAgcHJpbnQgRiAi ICAgICAgICB7ICYkbmFtZSRzaG9ydENhbWVsVHlwZSwgKiR7bmFtZX1JbXBsIH0sXG4iOworICAg ICAgICBwcmludCBGICIgICAgICAgIHsgKHZvaWQqKSYkbmFtZSRzaG9ydENhbWVsVHlwZSwgKiR7 bmFtZX1JbXBsIH0sXG4iOwogICAgIH0KIAogcHJpbnQgRiA8PEVORAo=