121412 2013-09-16 00:08:16 -0700 [sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT 2013-09-16 02:04:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo ggaren msaboff oliver oldest_to_newest 929565 0 jbriance 2013-09-16 00:08:16 -0700 Handle subp opcode with 3 operands in sh4 LLINT backend. offlineasm: Parsing /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h. offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/sh4.rb:573:in `lowerSH4': subp with 3 operands is not handled yetAt /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:376 (RuntimeError) from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[2]: *** [generated/./LLIntAssembly.h] Error 1 929572 1 jbriance 2013-09-16 00:40:26 -0700 Handle bpbeq opcode in sh4 LLINT backend. offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/ast.rb:829:in `lowerDefault': Unhandled opcode bpbeq at /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377At /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:377 (RuntimeError) from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/sh4.rb:783:in `lowerSH4' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /local/jbriance/WebKit/buildbot-env/webkit-dfg/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[3]: *** [generated/./LLIntAssembly.h] Error 1 929575 2 211744 jbriance 2013-09-16 00:56:55 -0700 Created attachment 211744 Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend. 929577 3 211744 kling 2013-09-16 01:41:43 -0700 Comment on attachment 211744 Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend. rs=me 929578 4 211744 commit-queue 2013-09-16 02:04:34 -0700 Comment on attachment 211744 Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend. Clearing flags on attachment: 211744 Committed r155846: <http://trac.webkit.org/changeset/155846> 929579 5 commit-queue 2013-09-16 02:04:38 -0700 All reviewed patches have been landed. Closing bug. 211744 2013-09-16 00:56:55 -0700 2013-09-16 02:04:34 -0700 Handle subp opcode with 3 operands and bpbeq opcode in sh4 LLINT backend. bug-121412.patch text/plain 2519 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1ODQzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTA5LTE2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEhhbmRsZSBzdWJwIG9wY29kZSB3aXRoIDMgb3BlcmFuZHMgYW5kIGJwYmVx IG9wY29kZSBpbiBMTElOVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMTQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogb2ZmbGluZWFzbS9zaDQucmI6CisKIDIwMTMtMDktMTUgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBtYWtlIGRp c3RjaGVjayBmaXguCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9zaDQu cmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vc2g0LnJi CShyZXZpc2lvbiAxNTU4MzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9z aDQucmIJKHdvcmtpbmcgY29weSkKQEAgLTU3MCwxMSArNTcwLDIwIEBAIGNsYXNzIEluc3RydWN0 aW9uCiAgICAgICAgICAgICAgICAgJGFzbS5wdXRzICJhZGQgI3tzaDRPcGVyYW5kcyhvcGVyYW5k cyl9IgogICAgICAgICAgICAgZW5kCiAgICAgICAgIHdoZW4gInN1YmkiLCAic3VicCIKLSAgICAg ICAgICAgIHJhaXNlICIje29wY29kZX0gd2l0aCAje29wZXJhbmRzLnNpemV9IG9wZXJhbmRzIGlz IG5vdCBoYW5kbGVkIHlldCIgdW5sZXNzIG9wZXJhbmRzLnNpemUgPT0gMgotICAgICAgICAgICAg aWYgb3BlcmFuZHNbMF0uaXNfYT8gSW1tZWRpYXRlCi0gICAgICAgICAgICAgICAgJGFzbS5wdXRz ICJhZGQgI3tzaDRPcGVyYW5kcyhbSW1tZWRpYXRlLm5ldyhjb2RlT3JpZ2luLCAtMSAqIG9wZXJh bmRzWzBdLnZhbHVlKSwgb3BlcmFuZHNbMV1dKX0iCisgICAgICAgICAgICBpZiBvcGVyYW5kcy5z aXplID09IDMKKyAgICAgICAgICAgICAgICBpZiBvcGVyYW5kc1sxXSAhPSBvcGVyYW5kc1syXQor ICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm5lZyAje3NoNE9wZXJhbmRzKFtvcGVyYW5k c1syXSwgb3BlcmFuZHNbMl1dKX0iCisgICAgICAgICAgICAgICAgICAgICRhc20ucHV0cyAiYWRk ICN7c2g0T3BlcmFuZHMoW29wZXJhbmRzWzBdLCBvcGVyYW5kc1syXV0pfSIKKyAgICAgICAgICAg ICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgICRhc20ucHV0cyAibW92ICN7c2g0T3BlcmFu ZHMoW29wZXJhbmRzWzBdLCBvcGVyYW5kc1syXV0pfSIKKyAgICAgICAgICAgICAgICAgICAgJGFz bS5wdXRzICJzdWIgI3tzaDRPcGVyYW5kcyhbb3BlcmFuZHNbMV0sIG9wZXJhbmRzWzJdXSl9Igor ICAgICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICRh c20ucHV0cyAic3ViICN7c2g0T3BlcmFuZHMob3BlcmFuZHMpfSIKKyAgICAgICAgICAgICAgICBp ZiBvcGVyYW5kc1swXS5pc19hPyBJbW1lZGlhdGUKKyAgICAgICAgICAgICAgICAgICAgJGFzbS5w dXRzICJhZGQgI3tzaDRPcGVyYW5kcyhbSW1tZWRpYXRlLm5ldyhjb2RlT3JpZ2luLCAtMSAqIG9w ZXJhbmRzWzBdLnZhbHVlKSwgb3BlcmFuZHNbMV1dKX0iCisgICAgICAgICAgICAgICAgZWxzZQor ICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgInN1YiAje3NoNE9wZXJhbmRzKG9wZXJhbmRz KX0iCisgICAgICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICBlbmQKICAgICAgICAgd2hlbiAi bXVsaSIsICJtdWxwIgogICAgICAgICAgICAgJGFzbS5wdXRzICJtdWwubCAje3NoNE9wZXJhbmRz KG9wZXJhbmRzWzAuLjFdKX0iCkBAIC02ODEsNiArNjkwLDggQEAgY2xhc3MgSW5zdHJ1Y3Rpb24K ICAgICAgICAgICAgIGVtaXRTSDRDb25kQnJhbmNoKCJocyIsIHRydWUsIG9wZXJhbmRzKQogICAg ICAgICB3aGVuICJiaWEiLCAiYnBhIiwgImJiYSIKICAgICAgICAgICAgIGVtaXRTSDRDb25kQnJh bmNoKCJoaSIsIGZhbHNlLCBvcGVyYW5kcykKKyAgICAgICAgd2hlbiAiYmliZXEiLCAiYnBiZXEi CisgICAgICAgICAgICBlbWl0U0g0Q29uZEJyYW5jaCgiaGkiLCB0cnVlLCBvcGVyYW5kcykKICAg ICAgICAgd2hlbiAiYmlhZXEiLCAiYnBhZXEiCiAgICAgICAgICAgICBlbWl0U0g0Q29uZEJyYW5j aCgiaHMiLCBmYWxzZSwgb3BlcmFuZHMpCiAgICAgICAgIHdoZW4gImJpZ3RlcSIsICJicGd0ZXEi LCAiYmJndGVxIgo=