121394 2013-09-15 11:15:15 -0700 CTTE: Node subclasses should take a Document by reference in their constructor (Part 9) 2013-09-15 11:24:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam commit-queue dbarton d-r esprehn+autocc fmalita fred.wang kangil.han mrobinson pdr schenney oldest_to_newest 929461 0 sam 2013-09-15 11:15:15 -0700 CTTE: Node subclasses should take a Document by reference in their constructor (Part 9) 929462 1 211716 sam 2013-09-15 11:16:31 -0700 Created attachment 211716 Patch 929463 2 211716 kling 2013-09-15 11:17:13 -0700 Comment on attachment 211716 Patch whee! 929466 3 sam 2013-09-15 11:24:02 -0700 Committed r155818: <http://trac.webkit.org/changeset/155818> 211716 2013-09-15 11:16:31 -0700 2013-09-15 11:17:13 -0700 Patch bug-121394-20130915111630.patch text/plain 4021 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA5LTE1ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ1RURTogTm9kZSBzdWJjbGFzc2VzIHNo b3VsZCB0YWtlIGEgRG9jdW1lbnQgYnkgcmVmZXJlbmNlIGluIHRoZWlyIGNvbnN0cnVjdG9yIChQ YXJ0IDkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjEzOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgdGhlICdjb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UnIHByb3BlcnR5LiBJ dCBpcyB0aGUgZGVmYXVsdCBub3cuCisKKyAgICAgICAgKiBkb20vbWFrZV9uYW1lcy5wbDoKKyAg ICAgICAgQWx3YXlzIHVzZSBhIERvY3VtZW50IHJlZmVyZW5jZS4KKworICAgICAgICAqIGh0bWwv SFRNTFRhZ05hbWVzLmluOgorICAgICAgICAqIG1hdGhtbC9tYXRodGFncy5pbjoKKyAgICAgICAg KiBzdmcvc3ZndGFncy5pbjoKKyAgICAgICAgUmVtb3ZlIHRoZSAnY29uc3RydWN0b3JUYWtlc0Rv Y3VtZW50UmVmZXJlbmNlJyBwcm9wZXJ0eS4KKwogMjAxMy0wOS0xNSAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuZGVyV2lkZ2V0IGRvZXNuJ3QgbmVlZCB0 byBjYWNoZSBhIEZyYW1lVmlldyBwb2ludGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL21h a2VfbmFtZXMucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMu cGwJKHJldmlzaW9uIDE1NTgxNCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBs CSh3b3JraW5nIGNvcHkpCkBAIC0xODEsNyArMTgxLDYgQEAgc3ViIGRlZmF1bHRUYWdQcm9wZXJ0 eUhhc2gKICAgICByZXR1cm4gKAogICAgICAgICAnY29uc3RydWN0b3JOZWVkc0NyZWF0ZWRCeVBh cnNlcicgPT4gMCwKICAgICAgICAgJ2NvbnN0cnVjdG9yTmVlZHNGb3JtRWxlbWVudCcgPT4gMCwK LSAgICAgICAgJ2NvbnN0cnVjdG9yVGFrZXNEb2N1bWVudFJlZmVyZW5jZScgPT4gJHBhcmFtZXRl cnN7Y29uc3RydWN0b3JUYWtlc0RvY3VtZW50UmVmZXJlbmNlfSwKICAgICAgICAgJ25vQ29uc3Ry dWN0b3InID0+IDAsCiAgICAgICAgICdpbnRlcmZhY2VOYW1lJyA9PiBkZWZhdWx0SW50ZXJmYWNl TmFtZSgkX1swXSksCiAgICAgICAgICMgQnkgZGVmYXVsdCwgdGhlIEpTSW50ZXJmYWNlTmFtZSBp cyB0aGUgc2FtZSBhcyB0aGUgaW50ZXJmYWNlTmFtZS4KQEAgLTIwNiw3ICsyMDUsNiBAQCBzdWIg ZGVmYXVsdFBhcmFtZXRlcnNIYXNoCiAgICAgICAgICdhdHRyc051bGxOYW1lc3BhY2UnID0+IDAs CiAgICAgICAgICdmYWxsYmFja0ludGVyZmFjZU5hbWUnID0+ICcnLAogICAgICAgICAnZmFsbGJh Y2tKU0ludGVyZmFjZU5hbWUnID0+ICcnLAotICAgICAgICAnY29uc3RydWN0b3JUYWtlc0RvY3Vt ZW50UmVmZXJlbmNlJyA9PiAwCiAgICAgKTsKIH0KIApAQCAtNDI2LDggKzQyNCw3IEBAIEVORAog ICAgIH0KIAogICAgICMgQ2FsbCB0aGUgY29uc3RydWN0b3Igd2l0aCB0aGUgcmlnaHQgcGFyYW1l dGVycy4KLSAgICBwcmludCBGICIgICAgcmV0dXJuICR7aW50ZXJmYWNlTmFtZX06OmNyZWF0ZSgk Y29uc3RydWN0b3JUYWdOYW1lIjsKLSAgICBwcmludCBGICgkZW5hYmxlZFRhZ3N7JHRhZ05hbWV9 e2NvbnN0cnVjdG9yVGFrZXNEb2N1bWVudFJlZmVyZW5jZX0gPyAiLCBkb2N1bWVudCIgOiAiLCAm ZG9jdW1lbnQiKTsKKyAgICBwcmludCBGICIgICAgcmV0dXJuICR7aW50ZXJmYWNlTmFtZX06OmNy ZWF0ZSgkY29uc3RydWN0b3JUYWdOYW1lLCBkb2N1bWVudCI7CiAgICAgcHJpbnQgRiAiLCBmb3Jt RWxlbWVudCIgaWYgJGVuYWJsZWRUYWdzeyR0YWdOYW1lfXtjb25zdHJ1Y3Rvck5lZWRzRm9ybUVs ZW1lbnR9OwogICAgIHByaW50IEYgIiwgY3JlYXRlZEJ5UGFyc2VyIiBpZiAkZW5hYmxlZFRhZ3N7 JHRhZ05hbWV9e2NvbnN0cnVjdG9yTmVlZHNDcmVhdGVkQnlQYXJzZXJ9OwogICAgIHByaW50IEYg Iik7XG59XG4iOwpAQCAtMTAwMyw3ICsxMDAwLDcgQEAgRU5ECiAgICAgfQogCiAgICAgcHJpbnQg RiAiICAgfVxuIjsKLSAgICBwcmludCBGICIgICByZXR1cm4gJHBhcmFtZXRlcnN7ZmFsbGJhY2tJ bnRlcmZhY2VOYW1lfTo6Y3JlYXRlKG5hbWUsICIgLiAoJHBhcmFtZXRlcnN7Y29uc3RydWN0b3JU YWtlc0RvY3VtZW50UmVmZXJlbmNlfSA/ICIiIDogIiYiKSAuICJkb2N1bWVudCk7XG4iOworICAg IHByaW50IEYgIiAgIHJldHVybiAkcGFyYW1ldGVyc3tmYWxsYmFja0ludGVyZmFjZU5hbWV9Ojpj cmVhdGUobmFtZSwgZG9jdW1lbnQpO1xuIjsKIAogICAgIHByaW50IEYgPDxFTkQKIH0KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhZ05hbWVzLmluCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFRhZ05hbWVzLmluCShyZXZpc2lvbiAxNTU4MTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUYWdOYW1lcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMiw3ICsy LDYgQEAgbmFtZXNwYWNlPSJIVE1MIgogbmFtZXNwYWNlUHJlZml4PSJ4aHRtbCIKIG5hbWVzcGFj ZVVSST0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIKIGZhbGxiYWNrSW50ZXJmYWNlTmFt ZT0iSFRNTFVua25vd25FbGVtZW50IgotY29uc3RydWN0b3JUYWtlc0RvY3VtZW50UmVmZXJlbmNl CiAKIGEgaW50ZXJmYWNlTmFtZT1IVE1MQW5jaG9yRWxlbWVudCwgZ2VuZXJhdGVUeXBlSGVscGVy cwogYWJiciBpbnRlcmZhY2VOYW1lPUhUTUxFbGVtZW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9t YXRobWwvbWF0aHRhZ3MuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbWF0aG1sL21h dGh0YWdzLmluCShyZXZpc2lvbiAxNTU4MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9tYXRobWwvbWF0 aHRhZ3MuaW4JKHdvcmtpbmcgY29weSkKQEAgLTIsNyArMiw2IEBAIG5hbWVzcGFjZT0iTWF0aE1M IgogbmFtZXNwYWNlVVJJPSJodHRwOi8vd3d3LnczLm9yZy8xOTk4L01hdGgvTWF0aE1MIgogZ3Vh cmRGYWN0b3J5V2l0aD0iRU5BQkxFKE1BVEhNTCkiCiBmYWxsYmFja0ludGVyZmFjZU5hbWU9Ik1h dGhNTEVsZW1lbnQiCi1jb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UKIAogbWF0aAog bWZyYWMgaW50ZXJmYWNlTmFtZT1NYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9zdmcvc3ZndGFncy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9zdmcvc3ZndGFncy5pbgkocmV2aXNpb24gMTU1ODE1KQorKysgU291cmNlL1dlYkNvcmUvc3Zn L3N2Z3RhZ3MuaW4JKHdvcmtpbmcgY29weSkKQEAgLTMsNyArMyw2IEBAIG5hbWVzcGFjZVVSST0i aHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcKIGd1YXJkRmFjdG9yeVdpdGg9IkVOQUJMRShTVkcp IgogZmFsbGJhY2tJbnRlcmZhY2VOYW1lPSJTVkdVbmtub3duRWxlbWVudCIKIGZhbGxiYWNrSlNJ bnRlcmZhY2VOYW1lPSJTVkdFbGVtZW50IgotY29uc3RydWN0b3JUYWtlc0RvY3VtZW50UmVmZXJl bmNlCiAKIGEKICNpZiBFTkFCTEVfU1ZHX0ZPTlRTCg==