121383 2013-09-15 04:35:19 -0700 [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714 2013-09-17 12:26:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 121391 1 cgarcia gustavo commit-queue gustavo mrobinson zan oldest_to_newest 929406 0 cgarcia 2013-09-15 04:35:19 -0700 It started to fail (timeout) after the move to the new web inspector (I think) 929533 1 gustavo 2013-09-15 19:17:14 -0700 The timeout is caused by 121315, but I neglected this test and it needs fixage too, because one of its assumptions is no longer true. Patch incoming. 929534 2 211734 gustavo 2013-09-15 19:19:12 -0700 Created attachment 211734 Patch 929536 3 commit-queue 2013-09-15 19:21:07 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 930346 4 211734 gustavo 2013-09-17 12:26:28 -0700 Comment on attachment 211734 Patch Clearing flags on attachment: 211734 Committed r155985: <http://trac.webkit.org/changeset/155985> 930347 5 gustavo 2013-09-17 12:26:34 -0700 All reviewed patches have been landed. Closing bug. 211734 2013-09-15 19:19:12 -0700 2013-09-17 12:26:28 -0700 Patch bug-121383-20130915231910.patch text/plain 3044 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDI5NDljOTBhNjU5ZjI3 ZDRkNjNkYzZjNzVkYTRkMGZhYTkwYWFiNi4uZDE4OGUzYjZmYTViNmEwMjI0ZTlkNzg4MGVlNDkx NjdlOGUwNjU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA5LTE1ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCisgICAgICAgIFtHVEtdIFRlc3Qg L3dlYmtpdDIvV2ViS2l0V2ViSW5zcGVjdG9yU2VydmVyL3Rlc3Qtb3Blbi1kZWJ1Z2dpbmctc2Vz c2lvbiB0aW1lcyBvdXQgYWZ0ZXIgcjE1NTcxNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0SW5zcGVj dG9yU2VydmVyLmNwcDoKKyAgICAgICAgKG9wZW5SZW1vdGVEZWJ1Z2dpbmdTZXNzaW9uKTogdXNl IHRoZSBwYWdlIGNvbnRlbnRzJyB0byBjaGVjayB0aGUgcmVtb3RlIGRlYnVnZ2luZyBvZiB0aGUg cGFnZQorICAgICAgICBoYXMgYmVlbiBzdWNjZXNzZnVseSBvcGVuZWQsIGFzIHRoZSB0aXRsZSBp cyBubyBsb25nZXIgdGhlIHNhbWUgYWZ0ZXIgdGhlIHN3aXRjaCB0byB0aGUgbmV3CisgICAgICAg IGZyb250ZW5kLgorCisyMDEzLTA5LTE1ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25v bWUub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQgbWFrZSBkaXN0Y2hlY2sgZml4LgogCiAgICAg ICAgICogR05VbWFrZWZpbGUubGlzdC5hbToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RJbnNwZWN0b3JTZXJ2ZXIuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdEluc3BlY3RvclNlcnZlci5jcHAKaW5k ZXggYjA0NjhiZmJmNzc0ODFlZTAzMDcwMTkzNTFlYjhlMzNkZTQ0N2EzMi4uYjlmOTA1MTFhMDNi M2U5MzY4ZTI0ZDc0NTNhMzBlYmMxOTEyYTZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdEluc3BlY3RvclNlcnZlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdEluc3BlY3RvclNlcnZlci5j cHAKQEAgLTIxNSw4ICsyMTUsOCBAQCBzdGF0aWMgdm9pZCB0ZXN0UmVtb3RlRGVidWdnaW5nTWVz c2FnZShJbnNwZWN0b3JTZXJ2ZXJUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogCiBzdGF0aWMg dm9pZCBvcGVuUmVtb3RlRGVidWdnaW5nU2Vzc2lvbihJbnNwZWN0b3JTZXJ2ZXJUZXN0KiB0ZXN0 LCBnY29uc3Rwb2ludGVyKQogewotICAgIC8vIFRvIHRlc3QgdGhlIHdob2xlIHBpcGVsaW5lIHRo aXMgZXhwbG9pdHMgYSBiZWhhdmlvciBvZiB0aGUgaW5zcGVjdG9yIGZyb250LWVuZCB3aGljaCB3 b24ndCBwcm92aWRlIGFueSB0aXRsZSB1bmxlc3MgdGhlCi0gICAgLy8gZGVidWdnaW5nIHNlc3Np b24gd2FzIGVzdGFibGlzaGVkIGNvcnJlY3RseSB0aHJvdWdoIHdlYiBzb2NrZXQuIEl0IHNob3Vs ZCBiZSBzb21ldGhpbmcgbGlrZSAiV2ViIEluc3BlY3RvciAtIDxQYWdlIFVSTD4iLgorICAgIC8v IFRvIHRlc3QgdGhlIHdob2xlIHBpcGVsaW5lIHRoaXMgZXhwbG9pdHMgYSBiZWhhdmlvciBvZiB0 aGUgaW5zcGVjdG9yIGZyb250LWVuZCB3aGljaCB3b24ndCBwcm92aWRlIHRoZSBwYWdlIGFkZHJl c3MgYXMgdGl0bGUgdW5sZXNzIHRoZQorICAgIC8vIGRlYnVnZ2luZyBzZXNzaW9uIHdhcyBlc3Rh Ymxpc2hlZCBjb3JyZWN0bHkgdGhyb3VnaCB3ZWIgc29ja2V0LgogICAgIC8vIEluIG91ciBjYXNl IHBhZ2UgVVJMIHNob3VsZCBiZSBodHRwOi8vMTI3LjAuMC4xOjI5OTkvCiAgICAgLy8gU28gdGhp cyB0ZXN0IGNhc2Ugd2lsbCBmYWlsIGlmOgogICAgIC8vIC0gVGhlIHBhZ2UgbGlzdCBkaWRuJ3Qg cmV0dXJuIGEgdmFsaWQgaW5zcGVjdG9yIFVSTApAQCAtMjM1LDkgKzIzNSwxNCBAQCBzdGF0aWMg dm9pZCBvcGVuUmVtb3RlRGVidWdnaW5nU2Vzc2lvbihJbnNwZWN0b3JTZXJ2ZXJUZXN0KiB0ZXN0 LCBnY29uc3Rwb2ludGVyKQogCiAgICAgU3RyaW5nIHJlc29sdmVkVVJMID0gU3RyaW5nKCJodHRw Oi8vMTI3LjAuMC4xOjI5OTkvIikgKyBTdHJpbmc6OmZyb21VVEY4KFdlYlZpZXdUZXN0OjpqYXZh c2NyaXB0UmVzdWx0VG9DU3RyaW5nKGphdmFzY3JpcHRSZXN1bHQpKTsKICAgICB0ZXN0LT5sb2Fk VVJJKHJlc29sdmVkVVJMLnV0ZjgoKS5kYXRhKCkpOwotICAgIHRlc3QtPndhaXRVbnRpbFRpdGxl Q2hhbmdlZCgpOworICAgIHRlc3QtPndhaXRVbnRpbExvYWRGaW5pc2hlZCgpOworCisgICAgamF2 YXNjcmlwdFJlc3VsdCA9IHRlc3QtPnJ1bkphdmFTY3JpcHRBbmRXYWl0VW50aWxGaW5pc2hlZCgi d2luZG93LmRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdsaScpWzBdLnRpdGxlIiwgJmVy cm9yLm91dFB0cigpKTsKKyAgICBnX2Fzc2VydChqYXZhc2NyaXB0UmVzdWx0KTsKKyAgICBnX2Fz c2VydCghZXJyb3IuZ2V0KCkpOwogCi0gICAgZ19hc3NlcnRfY21wc3RyKHdlYmtpdF93ZWJfdmll d19nZXRfdGl0bGUodGVzdC0+bV93ZWJWaWV3KSwgPT0sICJXZWIgSW5zcGVjdG9yIC0gaHR0cDov LzEyNy4wLjAuMToyOTk5LyIpOworICAgIEdPd25QdHI8Y2hhcj4gdGl0bGUoV2ViVmlld1Rlc3Q6 OmphdmFzY3JpcHRSZXN1bHRUb0NTdHJpbmcoamF2YXNjcmlwdFJlc3VsdCkpOworICAgIGdfYXNz ZXJ0X2NtcHN0cih0aXRsZS5nZXQoKSwgPT0sICJodHRwOi8vMTI3LjAuMC4xOjI5OTkvIik7CiB9 CiAKIHN0YXRpYyB2b2lkIHNlbmRJbmNvbXBsZXRlUmVxdWVzdChJbnNwZWN0b3JTZXJ2ZXJUZXN0 KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQo=