121363 2013-09-14 11:56:26 -0700 [CTTE] Node subclasses should take a Document by reference in their constructor (HTMLBodyElement) 2013-09-14 12:15:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 929265 0 sam 2013-09-14 11:56:26 -0700 Node subclasses should take a Document by reference in their constructor (HTMLBodyElement) 929266 1 211658 sam 2013-09-14 11:59:48 -0700 Created attachment 211658 Patch 929272 2 sam 2013-09-14 12:15:00 -0700 Committed r155777: <http://trac.webkit.org/changeset/155777> 211658 2013-09-14 11:59:48 -0700 2013-09-14 12:13:32 -0700 Patch bug-121363-20130914115947.patch text/plain 7637 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTc3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBACisyMDEzLTA5LTE0ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTm9kZSBzdWJjbGFzc2VzIHNob3VsZCB0 YWtlIGEgRG9jdW1lbnQgYnkgcmVmZXJlbmNlIGluIHRoZWlyIGNvbnN0cnVjdG9yIChIVE1MQm9k eUVsZW1lbnQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjEzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGRvbS9tYWtlX25hbWVzLnBsOgorICAgICAgICAoZGVmYXVsdFRhZ1Byb3BlcnR5SGFzaCk6 CisgICAgICAgIChwcmludENvbnN0cnVjdG9ySW50ZXJpb3IpOgorICAgICAgICBBZGQgYSBuZXcg cHJvcGVydHksICdjb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UnLCB0byBpbmRpY2F0 ZSB0aGF0IHRoZSBjbGFzcworICAgICAgICBoYXMgYmVlbiBjb252ZXJ0ZWQgdG8gdGFrZSBhIERv Y3VtZW50IGJ5IHJlZmVyZW5jZS4gT25jZSBhbGwgY2xhc3NlcyBhcmUgY29udmVydGVkLCB0aGlz CisgICAgICAgIHdpbGwgZ28gYXdheS4KKworICAgICAgICAqIGh0bWwvSFRNTFRhZ05hbWVzLmlu OgorICAgICAgICBBZGQgdGhlICdjb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UnIHBy b3BlcnR5IHRvIHRoZSA8Ym9keT4gdGFnIGFzIGFuIGluaXRpYWwKKyAgICAgICAgc3RlcC4KKwor ICAgICAgICAqIGh0bWwvSFRNTEJvZHlFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxCb2R5RWxlbWVudDo6SFRNTEJvZHlFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxC b2R5RWxlbWVudDo6Y3JlYXRlKToKKyAgICAgICAgKiBodG1sL0hUTUxCb2R5RWxlbWVudC5oOgor ICAgICAgICBNb2RpZnkgdGhlIGNvbnN0cnVjdG9yIGFuZCBjcmVhdGUgZnVuY3Rpb25zIG9mIEhU TUxCb2R5RWxlbWVudCB0byB0YWtlIGEgRG9jdW1lbnQgcmVmZXJlbmNlLgorCisgICAgICAgICog ZWRpdGluZy9tYXJrdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRnJhZ21lbnRGcm9t TWFya3VwKToKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUZyYWdtZW50Rm9yVHJhbnNmb3JtVG9G cmFnbWVudCk6CisgICAgICAgICogaHRtbC9IVE1MVmlld1NvdXJjZURvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZUNvbnRhaW5pbmdU YWJsZSk6CisgICAgICAgIFVwZGF0ZSBjYWxsZXJzIG9mIEhUTUxCb2R5RWxlbWVudDo6Y3JlYXRl KCkgdG8gcGFzcyBhIERvY3VtZW50IHJlZmVyZW5jZS4KKwogMjAxMy0wOS0xNCAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQgZm9yIGFueSBj dXN0b20gYmluZGluZ3MgZm9yIENvbnNvbGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtl X25hbWVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBs CShyZXZpc2lvbiAxNTU3NzEpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAko d29ya2luZyBjb3B5KQpAQCAtMTgxLDYgKzE4MSw3IEBAIHN1YiBkZWZhdWx0VGFnUHJvcGVydHlI YXNoCiAgICAgcmV0dXJuICgKICAgICAgICAgJ2NvbnN0cnVjdG9yTmVlZHNDcmVhdGVkQnlQYXJz ZXInID0+IDAsCiAgICAgICAgICdjb25zdHJ1Y3Rvck5lZWRzRm9ybUVsZW1lbnQnID0+IDAsCisg ICAgICAgICdjb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UnID0+IDAsCiAgICAgICAg ICdub0NvbnN0cnVjdG9yJyA9PiAwLAogICAgICAgICAnaW50ZXJmYWNlTmFtZScgPT4gZGVmYXVs dEludGVyZmFjZU5hbWUoJF9bMF0pLAogICAgICAgICAjIEJ5IGRlZmF1bHQsIHRoZSBKU0ludGVy ZmFjZU5hbWUgaXMgdGhlIHNhbWUgYXMgdGhlIGludGVyZmFjZU5hbWUuCkBAIC00MjQsNyArNDI1 LDggQEAgRU5ECiAgICAgfQogCiAgICAgIyBDYWxsIHRoZSBjb25zdHJ1Y3RvciB3aXRoIHRoZSBy aWdodCBwYXJhbWV0ZXJzLgotICAgIHByaW50IEYgIiAgICByZXR1cm4gJHtpbnRlcmZhY2VOYW1l fTo6Y3JlYXRlKCRjb25zdHJ1Y3RvclRhZ05hbWUsIGRvY3VtZW50IjsKKyAgICBwcmludCBGICIg ICAgcmV0dXJuICR7aW50ZXJmYWNlTmFtZX06OmNyZWF0ZSgkY29uc3RydWN0b3JUYWdOYW1lIjsK KyAgICBwcmludCBGICgkZW5hYmxlZFRhZ3N7JHRhZ05hbWV9e2NvbnN0cnVjdG9yVGFrZXNEb2N1 bWVudFJlZmVyZW5jZX0gPyAiLCAqZG9jdW1lbnQiIDogIiwgZG9jdW1lbnQiKTsKICAgICBwcmlu dCBGICIsIGZvcm1FbGVtZW50IiBpZiAkZW5hYmxlZFRhZ3N7JHRhZ05hbWV9e2NvbnN0cnVjdG9y TmVlZHNGb3JtRWxlbWVudH07CiAgICAgcHJpbnQgRiAiLCBjcmVhdGVkQnlQYXJzZXIiIGlmICRl bmFibGVkVGFnc3skdGFnTmFtZX17Y29uc3RydWN0b3JOZWVkc0NyZWF0ZWRCeVBhcnNlcn07CiAg ICAgcHJpbnQgRiAiKTtcbn1cbiI7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCShy ZXZpc2lvbiAxNTU3NzEpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY2MSw3ICs2NjEsNyBAQCBTdHJpbmcgY3JlYXRlTWFya3VwKGNvbnN0 IFJhbmdlKiByYW5nZSwgCiBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGNyZWF0ZUZyYWdt ZW50RnJvbU1hcmt1cChEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IFN0cmluZyYgbWFya3VwLCBj b25zdCBTdHJpbmcmIGJhc2VVUkwsIFBhcnNlckNvbnRlbnRQb2xpY3kgcGFyc2VyQ29udGVudFBv bGljeSkKIHsKICAgICAvLyBXZSB1c2UgYSBmYWtlIGJvZHkgZWxlbWVudCBoZXJlIHRvIHRyaWNr IHRoZSBIVE1MIHBhcnNlciB0byB1c2luZyB0aGUgSW5Cb2R5IGluc2VydGlvbiBtb2RlLgotICAg IFJlZlB0cjxIVE1MQm9keUVsZW1lbnQ+IGZha2VCb2R5ID0gSFRNTEJvZHlFbGVtZW50OjpjcmVh dGUoZG9jdW1lbnQpOworICAgIFJlZlB0cjxIVE1MQm9keUVsZW1lbnQ+IGZha2VCb2R5ID0gSFRN TEJvZHlFbGVtZW50OjpjcmVhdGUoKmRvY3VtZW50KTsKICAgICBSZWZQdHI8RG9jdW1lbnRGcmFn bWVudD4gZnJhZ21lbnQgPSBEb2N1bWVudEZyYWdtZW50OjpjcmVhdGUoZG9jdW1lbnQpOwogCiAg ICAgZnJhZ21lbnQtPnBhcnNlSFRNTChtYXJrdXAsIGZha2VCb2R5LmdldCgpLCBwYXJzZXJDb250 ZW50UG9saWN5KTsKQEAgLTk5Niw3ICs5OTYsNyBAQCBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21l bnQ+IGNyZWF0ZUZyYWdtCiAgICAgICAgIC8vIEJhc2VkIG9uIHRoZSBkb2N1bWVudGF0aW9uIEkg Y2FuIGZpbmQsIGl0IGxvb2tzIGxpa2Ugd2Ugd2FudCB0byBzdGFydCBwYXJzaW5nIHRoZSBmcmFn bWVudCBpbiB0aGUgSW5Cb2R5IGluc2VydGlvbiBtb2RlLgogICAgICAgICAvLyBVbmZvcnR1bmF0 ZWx5LCB0aGF0J3MgYW4gaW1wbGVtZW50YXRpb24gZGV0YWlsIG9mIHRoZSBwYXJzZXIuCiAgICAg ICAgIC8vIFdlIGFjaGlldmUgdGhhdCBlZmZlY3QgaGVyZSBieSBwYXNzaW5nIGluIGEgZmFrZSBi b2R5IGVsZW1lbnQgYXMgY29udGV4dCBmb3IgdGhlIGZyYWdtZW50LgotICAgICAgICBSZWZQdHI8 SFRNTEJvZHlFbGVtZW50PiBmYWtlQm9keSA9IEhUTUxCb2R5RWxlbWVudDo6Y3JlYXRlKG91dHB1 dERvYyk7CisgICAgICAgIFJlZlB0cjxIVE1MQm9keUVsZW1lbnQ+IGZha2VCb2R5ID0gSFRNTEJv ZHlFbGVtZW50OjpjcmVhdGUoKm91dHB1dERvYyk7CiAgICAgICAgIGZyYWdtZW50LT5wYXJzZUhU TUwoc291cmNlU3RyaW5nLCBmYWtlQm9keS5nZXQoKSk7CiAgICAgfSBlbHNlIGlmIChzb3VyY2VN SU1FVHlwZSA9PSAidGV4dC9wbGFpbiIpCiAgICAgICAgIGZyYWdtZW50LT5wYXJzZXJBcHBlbmRD aGlsZChUZXh0OjpjcmVhdGUob3V0cHV0RG9jLCBzb3VyY2VTdHJpbmcpKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5jcHAJKHJldmlzaW9uIDE1NTc3MSkKKysrIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDIsMTggKzQyLDE4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNwYWNlIEhU TUxOYW1lczsKIAotSFRNTEJvZHlFbGVtZW50OjpIVE1MQm9keUVsZW1lbnQoY29uc3QgUXVhbGlm aWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvY3VtZW50KQotICAgIDogSFRNTEVsZW1lbnQo dGFnTmFtZSwgZG9jdW1lbnQpCitIVE1MQm9keUVsZW1lbnQ6OkhUTUxCb2R5RWxlbWVudChjb25z dCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCYgZG9jdW1lbnQpCisgICAgOiBIVE1M RWxlbWVudCh0YWdOYW1lLCAmZG9jdW1lbnQpCiB7CiAgICAgQVNTRVJUKGhhc1RhZ05hbWUoYm9k eVRhZykpOwogfQogCi1QYXNzUmVmUHRyPEhUTUxCb2R5RWxlbWVudD4gSFRNTEJvZHlFbGVtZW50 OjpjcmVhdGUoRG9jdW1lbnQqIGRvY3VtZW50KQorUGFzc1JlZlB0cjxIVE1MQm9keUVsZW1lbnQ+ IEhUTUxCb2R5RWxlbWVudDo6Y3JlYXRlKERvY3VtZW50JiBkb2N1bWVudCkKIHsKICAgICByZXR1 cm4gYWRvcHRSZWYobmV3IEhUTUxCb2R5RWxlbWVudChib2R5VGFnLCBkb2N1bWVudCkpOwogfQog Ci1QYXNzUmVmUHRyPEhUTUxCb2R5RWxlbWVudD4gSFRNTEJvZHlFbGVtZW50OjpjcmVhdGUoY29u c3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvY3VtZW50KQorUGFzc1JlZlB0 cjxIVE1MQm9keUVsZW1lbnQ+IEhUTUxCb2R5RWxlbWVudDo6Y3JlYXRlKGNvbnN0IFF1YWxpZmll ZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50JiBkb2N1bWVudCkKIHsKICAgICByZXR1cm4gYWRvcHRS ZWYobmV3IEhUTUxCb2R5RWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkpOwogfQpJbmRleDogU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oCShyZXZpc2lvbiAxNTU3NzEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw4 ICszMiw4IEBAIGNsYXNzIERvY3VtZW50OwogCiBjbGFzcyBIVE1MQm9keUVsZW1lbnQgRklOQUwg OiBwdWJsaWMgSFRNTEVsZW1lbnQgewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPEhU TUxCb2R5RWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8 SFRNTEJvZHlFbGVtZW50PiBjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Kik7 CisgICAgc3RhdGljIFBhc3NSZWZQdHI8SFRNTEJvZHlFbGVtZW50PiBjcmVhdGUoRG9jdW1lbnQm KTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxIVE1MQm9keUVsZW1lbnQ+IGNyZWF0ZShjb25zdCBR dWFsaWZpZWROYW1lJiwgRG9jdW1lbnQmKTsKICAgICB2aXJ0dWFsIH5IVE1MQm9keUVsZW1lbnQo KTsKIAogICAgIFN0cmluZyBhTGluaygpIGNvbnN0OwpAQCAtNjgsNyArNjgsNyBAQCBwdWJsaWM6 CiAjZW5kaWYKIAogcHJpdmF0ZToKLSAgICBIVE1MQm9keUVsZW1lbnQoY29uc3QgUXVhbGlmaWVk TmFtZSYsIERvY3VtZW50Kik7CisgICAgSFRNTEJvZHlFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5h bWUmLCBEb2N1bWVudCYpOwogCiAgICAgdmlydHVhbCB2b2lkIHBhcnNlQXR0cmlidXRlKGNvbnN0 IFF1YWxpZmllZE5hbWUmLCBjb25zdCBBdG9taWNTdHJpbmcmKSBPVkVSUklERTsKICAgICB2aXJ0 dWFsIGJvb2wgaXNQcmVzZW50YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYpIGNv bnN0IE9WRVJSSURFOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFnTmFtZXMuaW4K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFnTmFtZXMuaW4JKHJldmlz aW9uIDE1NTc3MSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhZ05hbWVzLmluCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMCw3ICsyMCw3IEBAIGJkbyBpbnRlcmZhY2VOYW1lPUhUTUxFbGVtZW50 CiBiZ3NvdW5kIGludGVyZmFjZU5hbWU9SFRNTEVsZW1lbnQKIGJpZyBpbnRlcmZhY2VOYW1lPUhU TUxFbGVtZW50CiBibG9ja3F1b3RlIGludGVyZmFjZU5hbWU9SFRNTFF1b3RlRWxlbWVudAotYm9k eQorYm9keSBjb25zdHJ1Y3RvclRha2VzRG9jdW1lbnRSZWZlcmVuY2UKIGJyIGludGVyZmFjZU5h bWU9SFRNTEJSRWxlbWVudAogYnV0dG9uIGNvbnN0cnVjdG9yTmVlZHNGb3JtRWxlbWVudAogY2Fu dmFzIGdlbmVyYXRlVHlwZUhlbHBlcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZp ZXdTb3VyY2VEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MVmlld1NvdXJjZURvY3VtZW50LmNwcAkocmV2aXNpb24gMTU1NzcxKQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MVmlld1NvdXJjZURvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NzIsNyArNzIsNyBAQCB2b2lkIEhUTUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZUNvbnRhCiB7 CiAgICAgUmVmUHRyPEhUTUxIdG1sRWxlbWVudD4gaHRtbCA9IEhUTUxIdG1sRWxlbWVudDo6Y3Jl YXRlKHRoaXMpOwogICAgIHBhcnNlckFwcGVuZENoaWxkKGh0bWwpOwotICAgIFJlZlB0cjxIVE1M Qm9keUVsZW1lbnQ+IGJvZHkgPSBIVE1MQm9keUVsZW1lbnQ6OmNyZWF0ZSh0aGlzKTsKKyAgICBS ZWZQdHI8SFRNTEJvZHlFbGVtZW50PiBib2R5ID0gSFRNTEJvZHlFbGVtZW50OjpjcmVhdGUoKnRo aXMpOwogICAgIGh0bWwtPnBhcnNlckFwcGVuZENoaWxkKGJvZHkpOwogICAgIC8vIENyZWF0ZSBh IGxpbmUgZ3V0dGVyIGRpdiB0aGF0IGNhbiBiZSB1c2VkIHRvIG1ha2Ugc3VyZSB0aGUgZ3V0dGVy IGV4dGVuZHMgZG93biB0aGUgaGVpZ2h0IG9mIHRoZSB3aG9sZQogICAgIC8vIGRvY3VtZW50Lgo=