12136 2007-01-06 00:43:31 -0800 REGRESSION: Counters-related leaks 2007-01-06 04:22:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/4215/DumpRenderTree-leaks.txt Regression P1 Normal --- 1 mitz webkit-unassigned darin oldest_to_newest 36743 0 mitz 2007-01-06 00:43:31 -0800 Many leaks like this: Call stack: [thread ffffffff]: | 0x0 | start | _start | main | dumpRenderTree | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] | -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] | WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) | WebCore::MainResourceLoader::didFinishLoading() | WebCore::FrameLoader::finishedLoading() | WebCore::DocumentLoader::finishedLoading() | WebCore::FrameLoader::end() | WebCore::FrameLoader::endIfNotLoading() | WebCore::Document::finishParsing() | WebCore::HTMLTokenizer::finish() | WebCore::HTMLTokenizer::end() | WebCore::HTMLParser::finished() | WebCore::Document::finishedParsing() | WebCore::FrameLoader::finishedParsing() | WebCore::FrameLoader::checkCompleted() | WebCore::FrameLoader::checkEmitLoadEvent() | WebCore::Document::implicitClose() | WebCore::FrameView::layout(bool) | WebCore::RenderView::layout() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderCounter::calcMinMaxWidth() | WebCore::RenderCounter::originalString() const | WebCore::counter(WebCore::RenderObject*, WebCore::AtomicString const&, bool) | operator new(unsigned long) | WTF::fastMalloc(unsigned long) 36734 1 12255 mitz 2007-01-06 03:27:23 -0800 Created attachment 12255 Delete child counter nodes, don't just remove them from the node map 36721 2 ddkilzer 2007-01-06 04:22:40 -0800 Committed revision 18639. 12255 2007-01-06 03:27:23 -0800 2007-01-06 03:46:52 -0800 Delete child counter nodes, don't just remove them from the node map 12136_r1.patch text/plain 1091 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODYzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDEtMDYgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTM2CisgICAgICAgICAg UkVHUkVTU0lPTjogQ291bnRlcnMtcmVsYXRlZCBsZWFrcworCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckNvdW50ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGVzdHJveUNvdW50ZXJOb2Rl Q2hpbGRyZW4pOiBEZWxldGUgdGhlIGNoaWxkIGNvdW50ZXIgbm9kZXMuCisKIDIwMDctMDEtMDUg IEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbGVhc2UgYnVp bGQgZml4LgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAJKHJldmlzaW9uIDE4 NjM4KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI2MCw2ICsyNjAsNyBAQCBzdGF0aWMgdm9pZCBkZXN0cm95Q291bnRlck5vZGVDaGls ZHJlbihBCiAgICAgICAgIGNoaWxkLT5wYXJlbnQoKS0+cmVtb3ZlQ2hpbGQoY2hpbGQpOwogICAg ICAgICBBU1NFUlQoY291bnRlck1hcHMoKS5nZXQoY2hpbGQtPnJlbmRlcmVyKCkpLT5nZXQoaWRl bnRpZmllcikgPT0gY2hpbGQpOwogICAgICAgICBjb3VudGVyTWFwcygpLmdldChjaGlsZC0+cmVu ZGVyZXIoKSktPnJlbW92ZShpZGVudGlmaWVyKTsKKyAgICAgICAgZGVsZXRlIGNoaWxkOwogICAg IH0KIH0KIAo=