121359 2013-09-14 10:00:20 -0700 REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData 2013-09-14 14:10:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue kling rniwa oldest_to_newest 929244 0 zan 2013-09-14 10:00:20 -0700 REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData 929245 1 211652 zan 2013-09-14 10:02:50 -0700 Created attachment 211652 Patch 929247 2 zan 2013-09-14 10:06:18 -0700 The regressions after r155228 seem to be specific to the GTK port that doesn't necessarily return a valid DocumentFragment in DragData::asFragment, but can't produce the expected results anymore after the PassRefPtr<Range> in documentFragmentAsText() is left null. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r155768%20(40745)/results.html 929294 3 211652 darin 2013-09-14 14:01:58 -0700 Comment on attachment 211652 Patch Oops! 929297 4 211652 zan 2013-09-14 14:10:42 -0700 Comment on attachment 211652 Patch Clearing flags on attachment: 211652 Committed r155785: <http://trac.webkit.org/changeset/155785> 929298 5 zan 2013-09-14 14:10:49 -0700 All reviewed patches have been landed. Closing bug. 211652 2013-09-14 10:02:50 -0700 2013-09-14 14:10:42 -0700 Patch bug-121359-20130914100250.patch text/plain 1960 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZkNTA0ZGYzNDM0MjI4 YWU3ZWIyMTFkODJkOGM1NzdiMzA0NzFhYi4uYmI5YmIwZjViMWQzMWU5NTdlZTgyNzQzNTM0M2M5 NTAxNTM3ZGFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTE0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIx NTUyMjgpOiBDYWxsIHRvIERyYWdEYXRhOjphc0ZyYWdtZW50KCkgbnVsbGlmaWVzIFBhc3NSZWZQ dHI8UmFuZ2U+IGluIGRvY3VtZW50RnJhZ21lbnRGcm9tRHJhZ0RhdGEKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTM1OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpkb2N1bWVudEZyYWdtZW50RnJvbURyYWdEYXRhKTogUGFz cyB0aGUgbmFrZWQgcG9pbnRlciBhcyB0aGUgUGFzc1JlZlB0cjxSYW5nZT4gYXJndW1lbnQgdG8g dGhlIERyYWdEYXRhOjphc0ZyYWdtZW50KCkKKyAgICAgICAgY2FsbC4gVGhlIG5ha2VkIHBvaW50 ZXIgd2lsbCBnZXQgd3JhcHBlZCBhbmQgcHJvdGVjdGVkIGJ5IGEgbmV3IFBhc3NSZWZQdHIuIFBh c3NpbmcgdGhlIG9yaWdpbmFsIFBhc3NSZWZQdHIgd2lsbCBhbHNvIGNyZWF0ZQorICAgICAgICBh IG5ldyBQYXNzUmVmUHRyLCBidXQgd2lsbCBsZWFrIHRoZSByZWZlcmVuY2Ugb2YgdGhlIG9yaWdp bmFsIG9uZSwgbGVhdmluZyBpdHMgcG9pbnRlciBudWxsaWZpZWQuCisKIDIwMTMtMDktMTQgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBJbmplY3RlZFNjcmlwdFNvdXJjZV9qcyBhbmQgSW5qZWN0ZWRTY3JpcHRDYW52YXNNb2R1 bGVTb3VyY2VfanMgc2hvdWxkIGJlIG1pbmlmaWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRy b2xsZXIuY3BwCmluZGV4IGZjZjJkNzljMWIyYWMxYTE5ZGQ2MDE2NmIxMmNiNjA2Mzk4N2IzMWIu LjAxNDdiYjUyODFjMTM1NGU5ZjQxMGZiODllZGFhZTJhMzIzYzFiZGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC0xMjQsNyArMTI0LDcgQEAgc3RhdGljIFBhc3NS ZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gZG9jdW1lbnRGcmFnbWVudEZyb21EcmFnRGF0YShEcmFn RGF0YSogZHJhZ0QKIAogICAgIERvY3VtZW50JiBkb2N1bWVudCA9IGNvbnRleHQtPm93bmVyRG9j dW1lbnQoKTsKICAgICBpZiAoZHJhZ0RhdGEtPmNvbnRhaW5zQ29tcGF0aWJsZUNvbnRlbnQoKSkg ewotICAgICAgICBpZiAoUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGRy YWdEYXRhLT5hc0ZyYWdtZW50KGZyYW1lLCBjb250ZXh0LCBhbGxvd1BsYWluVGV4dCwgY2hvc2VQ bGFpblRleHQpKQorICAgICAgICBpZiAoUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFn bWVudCA9IGRyYWdEYXRhLT5hc0ZyYWdtZW50KGZyYW1lLCBjb250ZXh0LmdldCgpLCBhbGxvd1Bs YWluVGV4dCwgY2hvc2VQbGFpblRleHQpKQogICAgICAgICAgICAgcmV0dXJuIGZyYWdtZW50Owog CiAgICAgICAgIGlmIChkcmFnRGF0YS0+Y29udGFpbnNVUkwoZnJhbWUsIERyYWdEYXRhOjpEb05v dENvbnZlcnRGaWxlbmFtZXMpKSB7Cg==