121332 2013-09-13 17:05:35 -0700 FTL JIT broke after r155711 2013-09-13 17:28:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 929067 0 msaboff 2013-09-13 17:05:35 -0700 After the "invert stack" patch landed, the FTL JIT broke. 929072 1 211606 msaboff 2013-09-13 17:16:39 -0700 Created attachment 211606 Patch Four fixes to get FTL JIT working with an inverted JSC stack. 929074 2 211606 ggaren 2013-09-13 17:19:18 -0700 Comment on attachment 211606 Patch r=mef 929078 3 msaboff 2013-09-13 17:28:06 -0700 Committed r155735: <http://trac.webkit.org/changeset/155735> 211606 2013-09-13 17:16:39 -0700 2013-09-13 17:19:18 -0700 Patch 121332.patch text/plain 4645 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NzMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEzLTA5LTEzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEZUTCBKSVQgYnJva2UgYWZ0ZXIgcjE1NTcxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgT1NSIGVudHJ5IHRvIHVzZSB0aGUgbG9jYWwg dmFyaWFibGUncyBpbmRleCBpbnN0ZWFkIG9mIGl0cyBWaXJ0dWFsUmVnaXN0ZXIuCisgICAgICAg IEluaXRpYWxpemVkIEV4aXRBcmd1bWVudEZvck9wZXJhbmQ6Om1fb3BlcmFuZCB0byBJbnZhbGlk VmlydHVhbFJlZ2lzdGVyIGluc3RlYWQgb2YgLTEuCisgICAgICAgIEZpeGVkIGNvbXBpbGVDYWxs T3JDb25zdHJ1Y3QoKSB0byB1cGRhdGUgbG9jYWxzIG9uIGNhbGxmcmFtZSBnb2luZyBkb3duLgor ICAgICAgICBGaXhlZCBwcmVwYXJlT1NSRW50cnkoKSB0byBncm93IHN0YWNrIGRvd24gaWYgbmVl ZGVkLgorCisgICAgICAgICogZnRsL0ZUTEV4aXRBcmd1bWVudEZvck9wZXJhbmQuaDoKKyAgICAg ICAgKEpTQzo6RlRMOjpFeGl0QXJndW1lbnRGb3JPcGVyYW5kOjpFeGl0QXJndW1lbnRGb3JPcGVy YW5kKToKKyAgICAgICAgKiBmdGwvRlRMTGluay5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6bGlu ayk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6 RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUV4dHJhY3RPU1JFbnRyeUxvY2FsKToKKyAgICAg ICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUNhbGxPckNvbnN0cnVjdCk6Cisg ICAgICAgICogZnRsL0ZUTE9TUkVudHJ5LmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpwcmVwYXJl T1NSRW50cnkpOgorCiAyMDEzLTA5LTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgREZHIEFJIGFzc3VtZXMgdGhhdCBUb1RoaXMgY2FuIG5ldmVyIHJldHVybiBu b24tb2JqZWN0IGlmIGl0IGlzIHBhc3NlZCBhbiBvYmplY3QsIGFuZCBvcGVyYXRpb25Ub1RoaXMg d2lsbCBnZXQgdGhlIHdyb25nIHZhbHVlIG9mIGlzU3RyaWN0TW9kZSgpIGlmIHRoZXJlJ3MgaW5s aW5pbmcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMRXhpdEFyZ3VtZW50Rm9y T3BlcmFuZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMRXhp dEFyZ3VtZW50Rm9yT3BlcmFuZC5oCShyZXZpc2lvbiAxNTU3MTApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTEV4aXRBcmd1bWVudEZvck9wZXJhbmQuaAkod29ya2luZyBjb3B5KQpA QCAtMzEsMTMgKzMxLDE0IEBACiAjaWYgRU5BQkxFKEZUTF9KSVQpCiAKICNpbmNsdWRlICJGVExF eGl0QXJndW1lbnQuaCIKKyNpbmNsdWRlICJWaXJ0dWFsUmVnaXN0ZXIuaCIKIAogbmFtZXNwYWNl IEpTQyB7IG5hbWVzcGFjZSBGVEwgewogCiBjbGFzcyBFeGl0QXJndW1lbnRGb3JPcGVyYW5kIHsK IHB1YmxpYzoKICAgICBFeGl0QXJndW1lbnRGb3JPcGVyYW5kKCkKLSAgICAgICAgOiBtX29wZXJh bmQoLTEpCisgICAgICAgIDogbV9vcGVyYW5kKEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIpCiAgICAg ewogICAgIH0KICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTGluay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMaW5rLmNwcAko cmV2aXNpb24gMTU1NzExKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMaW5rLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzUsNyArNzUsNyBAQCB2b2lkIGxpbmsoU3RhdGUmIHN0YXRl KQogICAgICAgICAvLyBQbGFudCBhIGNoZWNrIHRoYXQgc3VmZmljaWVudCBzcGFjZSBpcyBhdmFp bGFibGUgaW4gdGhlIEpTU3RhY2suCiAgICAgICAgIC8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYyOTEKICAgICAgICAgaml0LmFkZFB0cigKLSAgICAg ICAgICAgIENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKC1jb2RlQmxvY2stPm1fbnVtQ2FsbGVl UmVnaXN0ZXJzICogc2l6ZW9mKFJlZ2lzdGVyKSksCisgICAgICAgICAgICBDQ2FsbEhlbHBlcnM6 OlRydXN0ZWRJbW0zMihsb2NhbFRvT3BlcmFuZChjb2RlQmxvY2stPm1fbnVtQ2FsbGVlUmVnaXN0 ZXJzKSAqIHNpemVvZihSZWdpc3RlcikpLAogICAgICAgICAgICAgR1BSSW5mbzo6Y2FsbEZyYW1l UmVnaXN0ZXIsIEdQUkluZm86OnJlZ1QxKTsKICAgICAgICAgQ0NhbGxIZWxwZXJzOjpKdW1wIHN0 YWNrQ2hlY2sgPSBqaXQuYnJhbmNoUHRyKAogICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpBYm92 ZSwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCShyZXZpc2lvbiAxNTU3MTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQ2LDcgKzU0Niw3IEBAIHBy aXZhdGU6CiAgICAgewogICAgICAgICBFbmNvZGVkSlNWYWx1ZSogYnVmZmVyID0gc3RhdGljX2Nh c3Q8RW5jb2RlZEpTVmFsdWUqPigKICAgICAgICAgICAgIG1fZnRsU3RhdGUuaml0Q29kZS0+ZnRs Rm9yT1NSRW50cnkoKS0+ZW50cnlCdWZmZXIoKS0+ZGF0YUJ1ZmZlcigpKTsKLSAgICAgICAgc2V0 SlNWYWx1ZShtX291dC5sb2FkNjQobV9vdXQuYWJzb2x1dGUoYnVmZmVyICsgbV9ub2RlLT51bmxp bmtlZExvY2FsKCkpKSk7CisgICAgICAgIHNldEpTVmFsdWUobV9vdXQubG9hZDY0KG1fb3V0LmFi c29sdXRlKGJ1ZmZlciArIG9wZXJhbmRUb0xvY2FsKG1fbm9kZS0+dW5saW5rZWRMb2NhbCgpKSkp KTsKICAgICB9CiAgICAgCiAgICAgdm9pZCBjb21waWxlR2V0TG9jYWwoKQpAQCAtMTg2Myw3ICsx ODYzLDcgQEAgcHJpdmF0ZToKICAgICAgICAgCiAgICAgICAgIExWYWx1ZSBjYWxsZWVGcmFtZSA9 IG1fb3V0LmFkZCgKICAgICAgICAgICAgIG1fY2FsbEZyYW1lLAotICAgICAgICAgICAgbV9vdXQu Y29uc3RJbnRQdHIoc2l6ZW9mKFJlZ2lzdGVyKSAqIGNvZGVCbG9jaygpLT5tX251bUNhbGxlZVJl Z2lzdGVycykpOworICAgICAgICAgICAgbV9vdXQuY29uc3RJbnRQdHIoc2l6ZW9mKFJlZ2lzdGVy KSAqIGxvY2FsVG9PcGVyYW5kKGNvZGVCbG9jaygpLT5tX251bUNhbGxlZVJlZ2lzdGVycykpKTsK ICAgICAgICAgCiAgICAgICAgIG1fb3V0LnN0b3JlMzIoCiAgICAgICAgICAgICBtX291dC5jb25z dEludDMyKG51bVBhc3NlZEFyZ3MgKyBkdW1teVRoaXNBcmd1bWVudCksCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9TUkVudHJ5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9TUkVudHJ5LmNwcAkocmV2aXNpb24gMTU1NzEwKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFbnRyeS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc3LDggKzc3LDggQEAgdm9pZCogcHJlcGFyZU9TUkVudHJ5KAogICAgIGZvciAoaW50IGxv Y2FsID0gdmFsdWVzLm51bWJlck9mTG9jYWxzKCk7IGxvY2FsLS07KQogICAgICAgICBzY3JhdGNo W2xvY2FsXSA9IEpTVmFsdWU6OmVuY29kZSh2YWx1ZXMubG9jYWwobG9jYWwpKTsKICAgICAKLSAg ICB1bnNpZ25lZCBzdGFja0ZyYW1lU2l6ZSA9IGVudHJ5Q29kZUJsb2NrLT5tX251bUNhbGxlZVJl Z2lzdGVyczsKLSAgICBpZiAoIXZtLmludGVycHJldGVyLT5zdGFjaygpLmdyb3coJmV4ZWMtPnJl Z2lzdGVycygpW3N0YWNrRnJhbWVTaXplXSkpIHsKKyAgICBpbnQgc3RhY2tGcmFtZVNpemUgPSBl bnRyeUNvZGVCbG9jay0+bV9udW1DYWxsZWVSZWdpc3RlcnM7CisgICAgaWYgKCF2bS5pbnRlcnBy ZXRlci0+c3RhY2soKS5ncm93KCZleGVjLT5yZWdpc3RlcnMoKVtsb2NhbFRvT3BlcmFuZChzdGFj a0ZyYW1lU2l6ZSldKSkgewogICAgICAgICBpZiAoT3B0aW9uczo6dmVyYm9zZU9TUigpKQogICAg ICAgICAgICAgZGF0YUxvZygiICAgIE9TUiBmYWlsZWQgYmNhdXNlIHN0YWNrIGdyb3d0aCBmYWls ZWQuXG4iKTsKICAgICAgICAgcmV0dXJuIDA7Cg==