12133 2007-01-05 14:22:14 -0800 Form buttons don't receive click events if the mouse is dragged before releasing 2007-01-26 09:39:24 -0800 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC Windows XP RESOLVED FIXED http://google.com P2 Normal --- 1 occupant4 webkit-unassigned ap mrowe oldest_to_newest 36823 0 occupant4 2007-01-05 14:22:14 -0800 (Windows only, probably because Mac uses native widgets) 1. Visit any page with a form submission button (such as google.com). 2. Press the left mouse button on the form button, but don't release. 3. Move the mouse a small amount, keeping the cursor within the button. 4. Release the button. If the mouse moved at all before you release, the form button will not be clicked. This happens because invalidateClick() is called in EventHandler::handleMouseMoveEvent(), which resets the click count and prevents further mouse-up events from dispatching a click. I don't think simply removing that call is the right move, though. 36810 1 hyatt 2007-01-05 14:25:35 -0800 ToT Mac does not use native widgets. 36782 2 12250 occupant4 2007-01-05 15:53:11 -0800 Created attachment 12250 simple fix The click should only be invalidated if the move starts a selection - otherwise, it makes more sense to allow mouse movements during clicks. 36731 3 ap 2007-01-06 02:33:21 -0800 It would be good to know why this doesn't happen on Mac. See also: bug 8150. 36616 4 12250 darin 2007-01-06 16:57:20 -0800 Comment on attachment 12250 simple fix r=me 36270 5 occupant4 2007-01-08 13:41:35 -0800 Oops - this bug is a dupe of http://bugs.webkit.org/show_bug.cgi?id=8150 . My "simple fix" patch fixes the first two cases in that bug's attached test case (http://bugs.webkit.org/attachment.cgi?id=7480). The third case still results in no click if the mouse is moved. If you test the third case in Firefox, you'll see that a click is registered if and only if nothing is selected as a result of a drag - as soon as text is selected, the click is invalidated. In IE7, the click is never invalidated - as long as the mouseup is in the same element as the mousedown, it's a click. Not sure which behavior we'd prefer. 36273 6 occupant4 2007-01-08 13:58:47 -0800 Simply removing the called to invalidateClick() altogether gives us behavior identical to Firefox. 34270 7 mrowe 2007-01-18 17:38:59 -0800 Should this patch be landed as-is, or do you intend to update it so that we match Firefox? 34159 8 12565 occupant4 2007-01-19 18:07:06 -0800 Created attachment 12565 alternate fix, matches firefox I would prefer if we matched Firefox's behavior. It seems more correct to me. 34160 9 12565 darin 2007-01-19 19:15:12 -0800 Comment on attachment 12565 alternate fix, matches firefox OK, sounds fine. 32491 10 darin 2007-01-26 09:39:24 -0800 I'm being sloppy here, not following our usual process and landing this change without an automated test. Next time I really need to do "review-" on a patch that fixes a bug that does not include a regression test for the fix. Committed revision 19158. 12250 2007-01-05 15:53:11 -0800 2007-01-06 16:57:20 -0800 simple fix click.patch text/plain 1381 occupant4 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODYzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDctMDEtMDUgIERleCBEZWFjb24gIDxvY2N1cGFudDRAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdB Uk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgICogcGFnZS9F dmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVN b3VzZU1vdmVFdmVudCk6CisKIDIwMDctMDEtMDUgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEh5YXR0LgpJbmRleDogV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAJKHJldmlzaW9uIDE4NjE4KQorKysgV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTMwNyw3ICszMDcsNiBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxl TW91c2VNb3ZlRXZlbnQoCiAjZW5kaWYKIAogICAgIG1fbW91c2VEb3duTWF5U3RhcnREcmFnID0g ZmFsc2U7Ci0gICAgaW52YWxpZGF0ZUNsaWNrKCk7CiAKICAgICBpZiAobV9tb3VzZURvd25NYXlT dGFydEF1dG9zY3JvbGwpIHsgICAgICAgICAgICAKICAgICAgICAgLy8gSWYgdGhlIHNlbGVjdGlv biBpcyBjb250YWluZWQgaW4gYSBsYXllciB0aGF0IGNhbiBzY3JvbGwsIHRoYXQgbGF5ZXIgc2hv dWxkIGhhbmRsZSB0aGUgYXV0b3Njcm9sbApAQCAtMzIyLDYgKzMyMSw4IEBAIGJvb2wgRXZlbnRI YW5kbGVyOjpoYW5kbGVNb3VzZU1vdmVFdmVudCgKICAgICBpZiAoIShtX21vdXNlRG93bk1heVN0 YXJ0U2VsZWN0ICYmIGlubmVyTm9kZS0+cmVuZGVyZXIoKS0+c2hvdWxkU2VsZWN0KCkpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpbnZhbGlkYXRlQ2xpY2soKTsKKwogICAgIC8vIGhh bmRsZSBtYWtpbmcgc2VsZWN0aW9uCiAgICAgSW50UG9pbnQgdlBvaW50ID0gbV9mcmFtZS0+dmll dygpLT53aW5kb3dUb0NvbnRlbnRzKGV2ZW50LmV2ZW50KCkucG9zKCkpOyAgICAgICAgCiAgICAg VmlzaWJsZVBvc2l0aW9uIHBvcyhpbm5lck5vZGUtPnJlbmRlcmVyKCktPnBvc2l0aW9uRm9yUG9p bnQodlBvaW50KSk7Cg== 12565 2007-01-19 18:07:06 -0800 2007-01-19 19:15:12 -0800 alternate fix, matches firefox click-2.patch text/plain 1017 occupant4 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODkxNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDctMDEtMTkgIERleCBEZWFjb24gIDxvY2N1cGFudDRAZ21haWwu Y29tPgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZU1vdmVFdmVudCk6CisJUmVtb3ZlZCBhIGNhbGwg dG8gaW52YWxpZGF0ZUNsaWNrKCksIHNpbmNlIHdlIGRvbid0IHdhbnQgdG8gY2FuY2VsIGEKKwlj bGljayBpZiB0aGUgbW91c2UgbW92ZXMuCisKIDIwMDctMDEtMTcgIEFkZWxlIFBldGVyc29uICA8 YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBhbmQgSm9obi4K SW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiAxODkxNCkKKysrIFdlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDQsNyArMzA0LDYgQEAgYm9v bCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlTW92ZUV2ZW50KAogI2VuZGlmCiAKICAgICBtX21v dXNlRG93bk1heVN0YXJ0RHJhZyA9IGZhbHNlOwotICAgIGludmFsaWRhdGVDbGljaygpOwogCiAg ICAgaWYgKG1fbW91c2VEb3duTWF5U3RhcnRBdXRvc2Nyb2xsKSB7ICAgICAgICAgICAgCiAgICAg ICAgIC8vIElmIHRoZSBzZWxlY3Rpb24gaXMgY29udGFpbmVkIGluIGEgbGF5ZXIgdGhhdCBjYW4g c2Nyb2xsLCB0aGF0IGxheWVyIHNob3VsZCBoYW5kbGUgdGhlIGF1dG9zY3JvbGwK