121315 2013-09-13 12:41:00 -0700 Inspector Server: queue messages sent before socket connection is established 2013-09-16 16:27:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 121391 P2 Normal --- 1 gustavo gustavo cgarcia commit-queue graouts joepeck timothy oldest_to_newest 928955 0 gustavo 2013-09-13 12:41:00 -0700 Inspector Server: queue messages sent before socket connection is established 928956 1 211576 gustavo 2013-09-13 12:46:16 -0700 Created attachment 211576 Patch 929780 2 211576 timothy 2013-09-16 09:59:24 -0700 Comment on attachment 211576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211576&action=review > Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:118 > + remoteConnected: function() > + { > + for (i = 0; i < this._messagesQueue.length; i++) > + WebInspector.socket.send(this._messagesQueue[i]); > + > + delete this._messagesQueue; > + }, > + > sendMessageToBackend: function(message) > { > + // Messages may be sent before the websocket is connected, in which case > + // queue them for sending as soon as the connection is established. > if (WebInspector.socket) > WebInspector.socket.send(message); > + else > + this._messagesQueue.push(message); This duplicates a patch I have on bug 121391. 929781 3 timothy 2013-09-16 10:04:48 -0700 *** This bug has been marked as a duplicate of bug 121391 *** 211576 2013-09-13 12:46:16 -0700 2013-09-16 09:59:24 -0700 Patch bug-121315-20130913164615.patch text/plain 4091 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCmluZGV4IDBkZDYwN2Y4N2FjMDI4N2JmYjZh ZTVmNGU0ODk2NGYzY2NjNThjNGMuLjhiNDczYWVhZDAyYjFjODU5MjE4ODdmYzY5N2IyNjFhMWMw ZjljNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuY3BwCkBAIC0yNjIsNiArMjYyLDEwIEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRI b3N0OjpzZW5kTWVzc2FnZVRvQmFja2VuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiAgICAgICAg IG1fY2xpZW50LT5zZW5kTWVzc2FnZVRvQmFja2VuZChtZXNzYWdlKTsKIH0KIAordm9pZCBJbnNw ZWN0b3JGcm9udGVuZEhvc3Q6OnJlbW90ZUNvbm5lY3RlZCgpCit7Cit9CisKICNpZiBFTkFCTEUo Q09OVEVYVF9NRU5VUykKIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpzaG93Q29udGV4dE1l bnUoRXZlbnQqIGV2ZW50LCBjb25zdCBWZWN0b3I8Q29udGV4dE1lbnVJdGVtPiYgaXRlbXMpCiB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRI b3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmgK aW5kZXggZTA5YzBmYjVhMThjYmJiNjYyMDczYzVhZDMxYzMzMWFhMzAyNmIzNS4uNzA4OGExNTc4 NDc5ODFiNDQ0YTU4ZjlkNGEzYjYwMTQxYzI5NTY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaApAQCAtODEsNiArODEsNyBAQCBwdWJs aWM6CiAgICAgLy8gQ2FsbGVkIGZyb20gW0N1c3RvbV0gaW1wbGVtZW50YXRpb25zLgogICAgIHZv aWQgc2hvd0NvbnRleHRNZW51KEV2ZW50KiwgY29uc3QgVmVjdG9yPENvbnRleHRNZW51SXRlbT4m IGl0ZW1zKTsKICAgICB2b2lkIHNlbmRNZXNzYWdlVG9CYWNrZW5kKGNvbnN0IFN0cmluZyYgbWVz c2FnZSk7CisgICAgdm9pZCByZW1vdGVDb25uZWN0ZWQoKTsKIAogICAgIFN0cmluZyBsb2FkUmVz b3VyY2VTeW5jaHJvbm91c2x5KGNvbnN0IFN0cmluZyYgdXJsKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAppbmRleCBiMWUyODkx YmM3ZjhkNmY3MjY1ZTVjZWQ4OWUxZDE5MjJmYjIwOTE5Li5lNjcxYzM1NDg3ZWU3YjY1YWUxMDIz NjJhMjBlYjg3ZTQ5OTY5OWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbApAQCAtNjMsNiArNjMsNyBAQAogICAgIFtDdXN0b21d IERPTVN0cmluZyBwb3J0KCk7CiAgICAgW0N1c3RvbV0gdm9pZCBzaG93Q29udGV4dE1lbnUoTW91 c2VFdmVudCBldmVudCwgYW55IGl0ZW1zKTsKICAgICB2b2lkIHNlbmRNZXNzYWdlVG9CYWNrZW5k KERPTVN0cmluZyBtZXNzYWdlKTsKKyAgICB2b2lkIHJlbW90ZUNvbm5lY3RlZCgpOwogCiAgICAg W0N1c3RvbV0gdm9pZCByZWNvcmRBY3Rpb25UYWtlbih1bnNpZ25lZCBsb25nIGFjdGlvbkNvZGUp OwogICAgIFtDdXN0b21dIHZvaWQgcmVjb3JkUGFuZWxTaG93bih1bnNpZ25lZCBsb25nIHBhbmVs Q29kZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9J bnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcwppbmRleCAzZWUwYzQ4MDg4NTRk OGJlNWNiNzkyZTcyYTdiYWQzMjc2OThlNWQxLi5iNTI3MmIzODAwNWYwMTQ2ZWM5YjAxMmUxOWQ3 ZTc1NmEzNWQ3YjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKQEAgLTM0LDYg KzM0LDcgQEAgaWYgKCF3aW5kb3cuSW5zcGVjdG9yRnJvbnRlbmRIb3N0KSB7CiAgICAgV2ViSW5z cGVjdG9yLkluc3BlY3RvckZyb250ZW5kSG9zdFN0dWIgPSBmdW5jdGlvbigpCiAgICAgewogICAg ICAgICB0aGlzLl9hdHRhY2hlZFdpbmRvd0hlaWdodCA9IDA7CisgICAgICAgIHRoaXMuX21lc3Nh Z2VzUXVldWUgPSBbXTsKICAgICB9CiAKICAgICBXZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRl bmRIb3N0U3R1Yi5wcm90b3R5cGUgPSB7CkBAIC05OSwxMCArMTAwLDIyIEBAIGlmICghd2luZG93 Lkluc3BlY3RvckZyb250ZW5kSG9zdCkgewogICAgICAgICB7CiAgICAgICAgIH0sCiAKKyAgICAg ICAgcmVtb3RlQ29ubmVjdGVkOiBmdW5jdGlvbigpCisgICAgICAgIHsKKyAgICAgICAgICAgIGZv ciAoaSA9IDA7IGkgPCB0aGlzLl9tZXNzYWdlc1F1ZXVlLmxlbmd0aDsgaSsrKQorICAgICAgICAg ICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQuc2VuZCh0aGlzLl9tZXNzYWdlc1F1ZXVlW2ldKTsK KworICAgICAgICAgICAgZGVsZXRlIHRoaXMuX21lc3NhZ2VzUXVldWU7CisgICAgICAgIH0sCisK ICAgICAgICAgc2VuZE1lc3NhZ2VUb0JhY2tlbmQ6IGZ1bmN0aW9uKG1lc3NhZ2UpCiAgICAgICAg IHsKKyAgICAgICAgICAgIC8vIE1lc3NhZ2VzIG1heSBiZSBzZW50IGJlZm9yZSB0aGUgd2Vic29j a2V0IGlzIGNvbm5lY3RlZCwgaW4gd2hpY2ggY2FzZQorICAgICAgICAgICAgLy8gcXVldWUgdGhl bSBmb3Igc2VuZGluZyBhcyBzb29uIGFzIHRoZSBjb25uZWN0aW9uIGlzIGVzdGFibGlzaGVkLgog ICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5zb2NrZXQpCiAgICAgICAgICAgICAgICAgV2Vi SW5zcGVjdG9yLnNvY2tldC5zZW5kKG1lc3NhZ2UpOworICAgICAgICAgICAgZWxzZQorICAgICAg ICAgICAgICAgIHRoaXMuX21lc3NhZ2VzUXVldWUucHVzaChtZXNzYWdlKTsKICAgICAgICAgfSwK IAogICAgICAgICBsb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5OiBmdW5jdGlvbih1cmwpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwppbmRleCA3Yzg5MjlhMmUx NzhhYzIwN2ZmODRmZTMyOGQ0ZDU3YWYzMzgzY2JkLi5kODc4ODNkMjkxODU3MTg2M2IwNjRmYThm YmY2MDcxYjViZWNhOGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01haW4uanMKQEAgLTExMTQsNiArMTExNCw5IEBAIFdlYkluc3BlY3Rvci5faW5pdGlhbGl6ZVdl YlNvY2tldElmTmVlZGVkID0gZnVuY3Rpb24oKQogICAgIGZ1bmN0aW9uIGNyZWF0ZVNvY2tldCgp CiAgICAgewogICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0ID0gc29ja2V0OworCisgICAgICAg IEluc3BlY3RvckZyb250ZW5kSG9zdC5yZW1vdGVDb25uZWN0ZWQoKTsKKwogICAgICAgICBXZWJJ bnNwZWN0b3Iuc29ja2V0LmFkZEV2ZW50TGlzdGVuZXIoIm1lc3NhZ2UiLCBmdW5jdGlvbihtZXNz YWdlKSB7IEluc3BlY3RvckJhY2tlbmQuZGlzcGF0Y2gobWVzc2FnZS5kYXRhKTsgfSk7CiAgICAg ICAgIFdlYkluc3BlY3Rvci5zb2NrZXQuYWRkRXZlbnRMaXN0ZW5lcigiZXJyb3IiLCBmdW5jdGlv bihlcnJvcikgeyBjb25zb2xlLmVycm9yKGVycm9yKTsgfSk7CiAgICAgfQo=