121314 2013-09-13 11:56:45 -0700 CodeGeneratorJS doesn't generate header includes for sequence<type> 2014-03-26 10:23:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson cdumez commit-queue esprehn+autocc kondapallykalyan tonikitoo oldest_to_newest 928947 0 eric.carlson 2013-09-13 11:56:45 -0700 The code generator doesn't include headers for a type introduced in a sequence<> parameter. 928958 1 211577 eric.carlson 2013-09-13 12:52:48 -0700 Created attachment 211577 Proposed patch 928987 2 211577 commit-queue 2013-09-13 13:36:11 -0700 Comment on attachment 211577 Proposed patch Clearing flags on attachment: 211577 Committed r155718: <http://trac.webkit.org/changeset/155718> 928988 3 commit-queue 2013-09-13 13:36:14 -0700 All reviewed patches have been landed. Closing bug. 211577 2013-09-13 12:52:48 -0700 2013-09-13 13:36:11 -0700 Proposed patch js_sequence_includes_4.txt text/plain 7038 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTcxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTEzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENvZGVHZW5lcmF0b3JK UyBkb2Vzbid0IGdlbmVyYXRlIGhlYWRlciBpbmNsdWRlcyBmb3Igc2VxdWVuY2U8dHlwZT4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTMxNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChTa2lwSW5jbHVkZUhlYWRlcik6 IERvbid0IHJldHVybiBmYWxzZSBmb3Igc2VxdWVuY2UgYW5kIGFycmF5IHR5cGVzLgorICAgICAg ICAoQWRkSW5jbHVkZXNGb3JUeXBlKTogRG8gYWRkIGluY2x1ZGVzIGZvciBzZXF1ZW5jZSBhbmQg YXJyYXkgdHlwZXMuCisgICAgICAgIChHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50YXRpb24pOgor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RUeXBlZGVmcy5jcHA6IFJl Z2VuZXJhdGVkCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdFR5cGVk ZWZzLmg6IERpdHRvLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0VHlwZWRl ZnMuaWRsOiBBZGQgYSBtZXRob2QgdGhhdCB0YWtlcyBhIHNlcXVlbmNlPFRlc3RFdmVudFRhcmdl dD4uCisKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckpTLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCShyZXZpc2lvbiAxNTU1NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29ya2luZyBjb3B5KQpAQCAtMjA2LDcg KzIwNiw2IEBAIHN1YiBTa2lwSW5jbHVkZUhlYWRlcgogICAgIG15ICR0eXBlID0gc2hpZnQ7CiAK ICAgICByZXR1cm4gMSBpZiAkY29kZUdlbmVyYXRvci0+U2tpcEluY2x1ZGVIZWFkZXIoJHR5cGUp OwotICAgIHJldHVybiAxIGlmICRjb2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5cGUoJHR5cGUp IG9yICRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHR5cGUpOwogICAgIHJldHVybiAkdHlw ZXNXaXRob3V0SGVhZGVyeyR0eXBlfTsKIH0KIApAQCAtMjI1LDYgKzIyNCwxOSBAQCBzdWIgQWRk SW5jbHVkZXNGb3JUeXBlCiAgICAgICAgICRpbmNsdWRlc1JlZi0+eyJKU0N1c3RvbVhQYXRoTlNS ZXNvbHZlci5oIn0gPSAxOwogICAgIH0gZWxzaWYgKCRpc0NhbGxiYWNrICYmICRjb2RlR2VuZXJh dG9yLT5Jc1dyYXBwZXJUeXBlKCR0eXBlKSkgewogICAgICAgICAkaW5jbHVkZXNSZWYtPnsiSlMk e3R5cGV9LmgifSA9IDE7CisgICAgfSBlbHNpZiAoJGNvZGVHZW5lcmF0b3ItPkdldFNlcXVlbmNl VHlwZSgkdHlwZSkgb3IgJGNvZGVHZW5lcmF0b3ItPkdldEFycmF5VHlwZSgkdHlwZSkpIHsKKyAg ICAgICAgbXkgJGFycmF5VHlwZSA9ICRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHR5cGUp OworICAgICAgICBteSAkc2VxdWVuY2VUeXBlID0gJGNvZGVHZW5lcmF0b3ItPkdldFNlcXVlbmNl VHlwZSgkdHlwZSk7CisgICAgICAgIG15ICRhcnJheU9yU2VxdWVuY2VUeXBlID0gJGFycmF5VHlw ZSB8fCAkc2VxdWVuY2VUeXBlOworCisgICAgICAgIGlmICgkYXJyYXlUeXBlIGVxICJET01TdHJp bmciKSB7CisgICAgICAgICAgICAkaW5jbHVkZXNSZWYtPnsiSlNET01TdHJpbmdMaXN0LmgifSA9 IDE7CisgICAgICAgICAgICAkaW5jbHVkZXNSZWYtPnsiRE9NU3RyaW5nTGlzdC5oIn0gPSAxOwor ICAgICAgICB9IGVsc2lmICgkY29kZUdlbmVyYXRvci0+SXNSZWZQdHJUeXBlKCRhcnJheU9yU2Vx dWVuY2VUeXBlKSkgeworICAgICAgICAgICAgJGluY2x1ZGVzUmVmLT57IkpTJHthcnJheU9yU2Vx dWVuY2VUeXBlfS5oIn0gPSAxOworICAgICAgICAgICAgJGluY2x1ZGVzUmVmLT57IiR7YXJyYXlP clNlcXVlbmNlVHlwZX0uaCJ9ID0gMTsKKyAgICAgICAgfQorICAgICAgICAkaW5jbHVkZXNSZWYt PnsiPHJ1bnRpbWUvSlNBcnJheS5oPiJ9ID0gMTsKICAgICB9IGVsc2UgewogICAgICAgICAjIGRl ZmF1bHQsIGluY2x1ZGUgdGhlIHNhbWUgbmFtZWQgZmlsZQogICAgICAgICAkaW5jbHVkZXNSZWYt PnsiJHt0eXBlfS5oIn0gPSAxOwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L1Rlc3RUeXBlZGVmcy5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RUeXBlZGVmcy5pZGwJKHJldmlzaW9uIDE1NTU3NSkKKysr IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0VHlwZWRlZnMuaWRsCSh3 b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSw4IEBACiAgICAgW1JhaXNlc0V4Y2VwdGlvbl0gQVJS QVlfT0ZfU1RSSU5HUyBzdHJpbmdBcnJheUZ1bmN0aW9uKEFSUkFZX09GX1NUUklOR1MgdmFsdWVz KTsKICAgICBbUmFpc2VzRXhjZXB0aW9uXSBTVFJJTkdbXSBzdHJpbmdBcnJheUZ1bmN0aW9uMihT VFJJTkdbXSB2YWx1ZXMpOwogCisgICAgYm9vbGVhbiBjYWxsV2l0aFNlcXVlbmNlVGhhdFJlcXVp cmVzSW5jbHVkZShzZXF1ZW5jZTxUZXN0RXZlbnRUYXJnZXQ+IHNlcXVlbmNlQXJnKTsKKwogICAg IC8vIEV4Y2VwdGlvbnMKICAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIG1ldGhvZFdpdGhFeGNl cHRpb24oKTsKICAgICBbR2V0dGVyUmFpc2VzRXhjZXB0aW9uXSBhdHRyaWJ1dGUgbG9uZyBhdHRy V2l0aEdldHRlckV4Y2VwdGlvbjsKQEAgLTc1LDMgKzc3LDQgQEAgdHlwZWRlZiBUZXN0Q2FsbGJh Y2sgICAgICAgICAgICAgICBURVNUXwogdHlwZWRlZiBUZXN0U3ViT2JqQ29uc3RydWN0b3IgICAg ICBUOwogdHlwZWRlZiBJbnQzMkFycmF5ICAgICAgICAgICAgICAgICBBUlJBWTsKIHR5cGVkZWYg RE9NRXhjZXB0aW9uICAgICAgICAgICAgICAgRTsKK3R5cGVkZWYgVGVzdEV2ZW50VGFyZ2V0ICAg ICAgICAgICAgVEVTVF9FVkVOVF9UQVJHRVQ7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0VHlwZWRlZnMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RUeXBlZGVmcy5jcHAJKHJl dmlzaW9uIDE1NTU3NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9K Uy9KU1Rlc3RUeXBlZGVmcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJKU1NWR1BvaW50LmgiCiAjaW5jbHVkZSAiSlNTZXJpYWxpemVkU2NyaXB0VmFsdWUu aCIKICNpbmNsdWRlICJKU1Rlc3RDYWxsYmFjay5oIgorI2luY2x1ZGUgIkpTVGVzdEV2ZW50VGFy Z2V0LmgiCiAjaW5jbHVkZSAiSlNUZXN0U3ViT2JqLmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogI2lu Y2x1ZGUgIlNWR1BvaW50LmgiCkBAIC0xMTksNiArMTIwLDcgQEAgc3RhdGljIGNvbnN0IEhhc2hU YWJsZVZhbHVlIEpTVGVzdFR5cGVkZQogICAgIHsgImltbXV0YWJsZVBvaW50RnVuY3Rpb24iLCBE b250RGVsZXRlIHwgSlNDOjpGdW5jdGlvbiwgKGludHB0cl90KXN0YXRpY19jYXN0PE5hdGl2ZUZ1 bmN0aW9uPihqc1Rlc3RUeXBlZGVmc1Byb3RvdHlwZUZ1bmN0aW9uSW1tdXRhYmxlUG9pbnRGdW5j dGlvbiksIChpbnRwdHJfdCkwLCBOb0ludHJpbnNpYyB9LAogICAgIHsgInN0cmluZ0FycmF5RnVu Y3Rpb24iLCBEb250RGVsZXRlIHwgSlNDOjpGdW5jdGlvbiwgKGludHB0cl90KXN0YXRpY19jYXN0 PE5hdGl2ZUZ1bmN0aW9uPihqc1Rlc3RUeXBlZGVmc1Byb3RvdHlwZUZ1bmN0aW9uU3RyaW5nQXJy YXlGdW5jdGlvbiksIChpbnRwdHJfdCkxLCBOb0ludHJpbnNpYyB9LAogICAgIHsgInN0cmluZ0Fy cmF5RnVuY3Rpb24yIiwgRG9udERlbGV0ZSB8IEpTQzo6RnVuY3Rpb24sIChpbnRwdHJfdClzdGF0 aWNfY2FzdDxOYXRpdmVGdW5jdGlvbj4oanNUZXN0VHlwZWRlZnNQcm90b3R5cGVGdW5jdGlvblN0 cmluZ0FycmF5RnVuY3Rpb24yKSwgKGludHB0cl90KTEsIE5vSW50cmluc2ljIH0sCisgICAgeyAi Y2FsbFdpdGhTZXF1ZW5jZVRoYXRSZXF1aXJlc0luY2x1ZGUiLCBEb250RGVsZXRlIHwgSlNDOjpG dW5jdGlvbiwgKGludHB0cl90KXN0YXRpY19jYXN0PE5hdGl2ZUZ1bmN0aW9uPihqc1Rlc3RUeXBl ZGVmc1Byb3RvdHlwZUZ1bmN0aW9uQ2FsbFdpdGhTZXF1ZW5jZVRoYXRSZXF1aXJlc0luY2x1ZGUp LCAoaW50cHRyX3QpMSwgTm9JbnRyaW5zaWMgfSwKICAgICB7ICJtZXRob2RXaXRoRXhjZXB0aW9u IiwgRG9udERlbGV0ZSB8IEpTQzo6RnVuY3Rpb24sIChpbnRwdHJfdClzdGF0aWNfY2FzdDxOYXRp dmVGdW5jdGlvbj4oanNUZXN0VHlwZWRlZnNQcm90b3R5cGVGdW5jdGlvbk1ldGhvZFdpdGhFeGNl cHRpb24pLCAoaW50cHRyX3QpMCwgTm9JbnRyaW5zaWMgfSwKICAgICB7IDAsIDAsIDAsIDAsIE5v SW50cmluc2ljIH0KIH07CkBAIC01MjcsNiArNTI5LDI0IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwganNUZXN0VHlwZWQKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7 CiB9CiAKK0VuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwganNUZXN0VHlwZWRlZnNQcm90b3R5 cGVGdW5jdGlvbkNhbGxXaXRoU2VxdWVuY2VUaGF0UmVxdWlyZXNJbmNsdWRlKEV4ZWNTdGF0ZSog ZXhlYykKK3sKKyAgICBKU1ZhbHVlIHRoaXNWYWx1ZSA9IGV4ZWMtPmhvc3RUaGlzVmFsdWUoKTsK KyAgICBpZiAoIXRoaXNWYWx1ZS5pbmhlcml0cyhKU1Rlc3RUeXBlZGVmczo6aW5mbygpKSkKKyAg ICAgICAgcmV0dXJuIHRocm93Vk1UeXBlRXJyb3IoZXhlYyk7CisgICAgSlNUZXN0VHlwZWRlZnMq IGNhc3RlZFRoaXMgPSBqc0Nhc3Q8SlNUZXN0VHlwZWRlZnMqPihhc09iamVjdCh0aGlzVmFsdWUp KTsKKyAgICBBU1NFUlRfR0NfT0JKRUNUX0lOSEVSSVRTKGNhc3RlZFRoaXMsIEpTVGVzdFR5cGVk ZWZzOjppbmZvKCkpOworICAgIFRlc3RUeXBlZGVmcyogaW1wbCA9IHN0YXRpY19jYXN0PFRlc3RU eXBlZGVmcyo+KGNhc3RlZFRoaXMtPmltcGwoKSk7CisgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291 bnQoKSA8IDEpCisgICAgICAgIHJldHVybiB0aHJvd1ZNRXJyb3IoZXhlYywgY3JlYXRlTm90RW5v dWdoQXJndW1lbnRzRXJyb3IoZXhlYykpOworICAgIFZlY3RvcjxSZWZQdHI8VGVzdEV2ZW50VGFy Z2V0PiA+IHNlcXVlbmNlQXJnKCh0b1JlZlB0ck5hdGl2ZUFycmF5PFRlc3RFdmVudFRhcmdldCwg SlNUZXN0RXZlbnRUYXJnZXQ+KGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApLCAmdG9UZXN0RXZlbnRU YXJnZXQpKSk7CisgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQorICAgICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworCisgICAgSlNDOjpKU1ZhbHVlIHJlc3Vs dCA9IGpzQm9vbGVhbihpbXBsLT5jYWxsV2l0aFNlcXVlbmNlVGhhdFJlcXVpcmVzSW5jbHVkZShz ZXF1ZW5jZUFyZykpOworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUocmVzdWx0KTsKK30KKwog RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBqc1Rlc3RUeXBlZGVmc1Byb3RvdHlwZUZ1bmN0 aW9uTWV0aG9kV2l0aEV4Y2VwdGlvbihFeGVjU3RhdGUqIGV4ZWMpCiB7CiAgICAgSlNWYWx1ZSB0 aGlzVmFsdWUgPSBleGVjLT5ob3N0VGhpc1ZhbHVlKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0VHlwZWRlZnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0VHlwZWRlZnMuaAko cmV2aXNpb24gMTU1NTc1KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdFR5cGVkZWZzLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1MSw2ICsxNTEsNyBAQCBK U0M6OkVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwganNUZXN0CiBKU0M6OkVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwganNUZXN0VHlwZWRlZnNQcm90b3R5cGVGdW5jdGlvbkltbXV0YWJs ZVBvaW50RnVuY3Rpb24oSlNDOjpFeGVjU3RhdGUqKTsKIEpTQzo6RW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBqc1Rlc3RUeXBlZGVmc1Byb3RvdHlwZUZ1bmN0aW9uU3RyaW5nQXJyYXlGdW5j dGlvbihKU0M6OkV4ZWNTdGF0ZSopOwogSlNDOjpFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGpzVGVzdFR5cGVkZWZzUHJvdG90eXBlRnVuY3Rpb25TdHJpbmdBcnJheUZ1bmN0aW9uMihKU0M6 OkV4ZWNTdGF0ZSopOworSlNDOjpFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdFR5 cGVkZWZzUHJvdG90eXBlRnVuY3Rpb25DYWxsV2l0aFNlcXVlbmNlVGhhdFJlcXVpcmVzSW5jbHVk ZShKU0M6OkV4ZWNTdGF0ZSopOwogSlNDOjpFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpz VGVzdFR5cGVkZWZzUHJvdG90eXBlRnVuY3Rpb25NZXRob2RXaXRoRXhjZXB0aW9uKEpTQzo6RXhl Y1N0YXRlKik7CiAvLyBBdHRyaWJ1dGVzCiAK