121296 2013-09-13 05:25:48 -0700 [GTK] Fails to compile if the build directory is in a different partition 2013-09-14 11:02:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto berto cgarcia mrobinson oldest_to_newest 928793 0 berto 2013-09-13 05:25:48 -0700 The problem is the os.link() call in gtkdoc.py 928796 1 211543 berto 2013-09-13 05:27:04 -0700 Created attachment 211543 Patch 929193 2 berto 2013-09-14 01:35:08 -0700 Committed r155757: <http://trac.webkit.org/changeset/155757> 929235 3 mrobinson 2013-09-14 08:51:51 -0700 os.symlink doesn't work on Windows. 929236 4 mrobinson 2013-09-14 08:52:28 -0700 I think it sometimes works in cygwin, but not always. 929237 5 berto 2013-09-14 09:07:46 -0700 Maybe we can try link() first and use symlink() if it fails. 929243 6 211651 berto 2013-09-14 09:54:00 -0700 Created attachment 211651 Patch Ok, this patch reverts to using os.link() and only uses os.symlink() as a fallback. 929252 7 211651 mrobinson 2013-09-14 10:42:57 -0700 Comment on attachment 211651 Patch Great. Thanks! 929254 8 berto 2013-09-14 11:02:44 -0700 Committed r155772: <http://trac.webkit.org/changeset/155772> 211543 2013-09-13 05:27:04 -0700 2013-09-14 09:54:00 -0700 Patch 121296.diff text/plain 1122 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5Nzcx M2E4Li5hZjdkMzBhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDktMTMgIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGYWlscyB0byBjb21waWxlIGlmIHRoZSBi dWlsZCBkaXJlY3RvcnkgaXMgaW4gYSBkaWZmZXJlbnQgcGFydGl0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyOTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc3ltbGlua3MgaW5zdGVhZCBv ZiBoYXJkIGxpbmtzIHRvIHN1cHBvcnQgYnVpbGRpbmcgb24gYQorICAgICAgICBkaWZmZXJlbnQg ZmlsZSBzeXN0ZW0uCisKKyAgICAgICAgKiBndGsvZ3RrZG9jLnB5OgorICAgICAgICAoR1RLRG9j Ll9jb3B5X2RvY19maWxlc190b19vdXRwdXRfZGlyLmNvcHlfZmlsZV9yZXBsYWNpbmdfZXhpc3Rp bmcpOgorCiAyMDEzLTA5LTEzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBHaXZlIGFjdGlvbnMgaW4gUmFuZ2UgY2xhc3MgTk9OX1NIT1VUSU5HX05BTUVTCmRpZmYg LS1naXQgYS9Ub29scy9ndGsvZ3RrZG9jLnB5IGIvVG9vbHMvZ3RrL2d0a2RvYy5weQppbmRleCA0 NDNkZmM3Li5mZGZmNzYxIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvZ3RrZG9jLnB5CisrKyBiL1Rv b2xzL2d0ay9ndGtkb2MucHkKQEAgLTIyMiw3ICsyMjIsNyBAQCBjbGFzcyBHVEtEb2Mob2JqZWN0 KToKICAgICAgICAgICAgIHNlbGYuX2RlbGV0ZV9maWxlX2lmX2V4aXN0cyhkZXN0KQogCiAgICAg ICAgICAgICBzZWxmLmxvZ2dlci5kZWJ1ZygnY3JlYXRlZCAlcycsIGRlc3QpCi0gICAgICAgICAg ICBvcy5saW5rKHNyYywgZGVzdCkKKyAgICAgICAgICAgIG9zLnN5bWxpbmsoc3JjLCBkZXN0KQog CiAgICAgICAgIGRlZiBjb3B5X2FsbF9maWxlc19pbl9kaXJlY3Rvcnkoc3JjLCBkZXN0KToKICAg ICAgICAgICAgIGZvciBwYXRoIGluIG9zLmxpc3RkaXIoc3JjKToK 211651 2013-09-14 09:54:00 -0700 2013-09-14 10:42:57 -0700 Patch 121296.diff text/plain 1335 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNGMz MjE0Li42NDY5OWQwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTMtMDktMTQgIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBGYWlscyB0byBjb21waWxlIGlmIHRoZSBi dWlsZCBkaXJlY3RvcnkgaXMgaW4gYSBkaWZmZXJlbnQgcGFydGl0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyOTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHVzaW5nIG9zLnN5 bWxpbmsoKSB0byBpbnN0YWxsIHRoZSBndGstZG9jIHRlbXBsYXRlcywKKyAgICAgICAgdXNlIG9z LmxpbmsoKSBmaXJzdCBhbmQgZmFsbCBiYWNrIHRvIG9zLnN5bWxpbmsoKSBpZiBpdCBmYWlscy4K KworICAgICAgICAqIGd0ay9ndGtkb2MucHk6CisgICAgICAgIChHVEtEb2MuX2NvcHlfZG9jX2Zp bGVzX3RvX291dHB1dF9kaXIuY29weV9maWxlX3JlcGxhY2luZ19leGlzdGluZyk6CisKKzIwMTMt MDktMTQgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RL XSBXZWJLaXRHVEsrIGlzIGxpbmtpbmcgYWdhaW5zdCBsaWJ4c2x0IGluIHRvbyBtYW55IHBsYWNl cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMzU2 CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9ndGtkb2MucHkgYi9Ub29scy9ndGsvZ3RrZG9jLnB5 CmluZGV4IGZkZmY3NjEuLmU5Yzc5OTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9ndGtkb2MucHkK KysrIGIvVG9vbHMvZ3RrL2d0a2RvYy5weQpAQCAtMjIyLDcgKzIyMiwxMCBAQCBjbGFzcyBHVEtE b2Mob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYuX2RlbGV0ZV9maWxlX2lmX2V4aXN0cyhkZXN0 KQogCiAgICAgICAgICAgICBzZWxmLmxvZ2dlci5kZWJ1ZygnY3JlYXRlZCAlcycsIGRlc3QpCi0g ICAgICAgICAgICBvcy5zeW1saW5rKHNyYywgZGVzdCkKKyAgICAgICAgICAgIHRyeToKKyAgICAg ICAgICAgICAgICBvcy5saW5rKHNyYywgZGVzdCkKKyAgICAgICAgICAgIGV4Y2VwdCBPU0Vycm9y OgorICAgICAgICAgICAgICAgIG9zLnN5bWxpbmsoc3JjLCBkZXN0KQogCiAgICAgICAgIGRlZiBj b3B5X2FsbF9maWxlc19pbl9kaXJlY3Rvcnkoc3JjLCBkZXN0KToKICAgICAgICAgICAgIGZvciBw YXRoIGluIG9zLmxpc3RkaXIoc3JjKToK