121294 2013-09-13 05:07:46 -0700 [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2 2013-09-20 08:46:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned apinheiro cgarcia commit-queue gustavo mrobinson zan oldest_to_newest 928776 0 mario 2013-09-13 05:07:46 -0700 Many CRITICAL errors like the following can be seen now in the GTK bots when running the TestWebKitAPI/TestWebKit2 test suite (see [1]): [...] [==========] Running 51 tests from 3 test cases. [----------] Global test environment set-up. [----------] 38 tests from WebKit2 [ RUN ] WebKit2.AboutBlankLoad ** (TestWebKit2:29498): CRITICAL **: socket_embed_hook: assertion `spi_global_register != NULL' failed [ OK ] WebKit2.AboutBlankLoad (171 ms) [ RUN ] WebKit2.CloseThenTerminate ** (TestWebKit2:29498): CRITICAL **: socket_embed_hook: assertion `spi_global_register != NULL' failed [ OK ] WebKit2.CloseThenTerminate (172 ms) [ RUN ] WebKit2.CookieManager ** (TestWebKit2:29498): CRITICAL **: socket_embed_hook: assertion `spi_global_register != NULL' failed [ OK ] WebKit2.CookieManager (154 ms) [ RUN ] WebKit2.DidNotHandleKeyDown [...] The problem seems to be that the ATK bridge is being properly initialized for the first time that gtk_main() is being called (i.e. for the first test), but then shutdown after that point and never initialized again. Thus, this seems to be a GTK+ bug to me, but still we need to find a way to deal with it here in WebKit IMHO. [1] http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/40662/steps/API%20tests/logs/stdio 928794 1 mario 2013-09-13 05:26:02 -0700 I just filed the appropriate bug in GTK+ and attached a patch to it: https://bugzilla.gnome.org/show_bug.cgi?id=708024 I will provide a similar solution (which I already tested and works) for WebKitGTK+'s jhbuild environment (as a patch for gtk 3.6), so we can bring some sanity to our bots as well in the meanwhile. 928799 2 211545 mario 2013-09-13 05:32:57 -0700 Created attachment 211545 Patch proposal Here comes the patch that seems to fix the issue for our version of GTK+. I'm not setting the r? flag yet since I'd rather wait for the patch to be applied first in upstream GTK+ Once that happens, I'll come back here and set the flag if it gets accepted. 929580 3 mario 2013-09-16 02:06:29 -0700 Adding Zan to CC, just to keep him on the loop (I guess he might be interested) 929771 4 211804 mario 2013-09-16 09:48:48 -0700 Created attachment 211804 Patch proposal After some discussion on #a11y with other GTK+/GAIL developers (Alejandro Pinheiro, Benjamin Otte), we seem to agree the right thing to do is to remove the call to _gtk_accessibility_shutdown() completely, since it made sense in the times of the atk-bridge being loaded as a module, but it does not anymore. Check the full IRC log in [1], which has been finally been marked as duplicate of [2] where a final patch has been proposed and accepted (to commit only after the freeze). Hence, I'm proposing now a similar patch here to cope with the issue in WebKitGTK's internal jhbuild in the meanwhile. Please review. [1] https://bugzilla.gnome.org/show_bug.cgi?id=708024 [2] https://bugzilla.gnome.org/show_bug.cgi?id=684076 931247 5 mario 2013-09-20 03:20:41 -0700 (In reply to comment #4) > Created an attachment (id=211804) [details] > Patch proposal > > After some discussion on #a11y with other GTK+/GAIL developers (Alejandro Pinheiro, Benjamin Otte), we seem to agree the right thing to do is to remove the call to _gtk_accessibility_shutdown() completely, since it made sense in the times of the atk-bridge being loaded as a module, but it does not anymore. Check the full IRC log in [1], which has been finally been marked as duplicate of [2] where a final patch has been proposed and accepted (to commit only after the freeze). > > Hence, I'm proposing now a similar patch here to cope with the issue in WebKitGTK's internal jhbuild in the meanwhile. Please review. > > [1] https://bugzilla.gnome.org/show_bug.cgi?id=708024 > [2] https://bugzilla.gnome.org/show_bug.cgi?id=684076 Ping reviewers? I think this is quite straightforward fix (even if it's temporary while not in GTK 3.12), and would help get rid of those crazy CRITICALs in the bots. It will not take much time. Promised :) 931357 6 211804 mario 2013-09-20 08:23:44 -0700 Comment on attachment 211804 Patch proposal Thanks for the review, Martin 931366 7 211804 commit-queue 2013-09-20 08:46:18 -0700 Comment on attachment 211804 Patch proposal Clearing flags on attachment: 211804 Committed r156167: <http://trac.webkit.org/changeset/156167> 931367 8 commit-queue 2013-09-20 08:46:21 -0700 All reviewed patches have been landed. Closing bug. 211545 2013-09-13 05:32:57 -0700 2013-09-16 09:48:48 -0700 Patch proposal 0001-2013-09-13-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 3481 mario RnJvbSA4MzkyYzU4NTdjMmVhNmI1MjIzNDJlNjQ2NDY2NDkzODQ3ODFhYjM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogRnJpLCAxMyBTZXAgMjAxMyAxMzozMDoxOSArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDktMTMgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0dUS10gc29ja2V0X2VtYmVkX2hvb2sgaGl0dGluZyBOVUxMLWNo ZWNrIGFzc2VydGlvbiBydW5uaW5nIFRlc3RXZWJLaXQyCiAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTI5NAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiAgICAgICAgUHJvdmlkZSBhIG5ldyBwYXRjaCB0byBkZWFsIHdpdGggdGhl IGlzc3VlIGluIHRoZSBHVEsrIG1vZHVsZSBmcm9tCiAgICAgICAgdGhlIGludGVybmFsIGpoYnVp bGQgZW52aXJvbm1lbnQuIFRoaXMgaXNzdWUgaGFzIGJlZW4gcmVwb3J0ZWQKICAgICAgICB1cHN0 cmVhbSAoc2VlIGh0dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD03MDgw MjQpLgoKICAgICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6IEFwcGx5IHRoZSBuZXcgcGF0Y2gg dG8gdGhlIEdUSysgbW9kdWxlLgogICAgICAgICogZ3RrL3BhdGNoZXMvZ3RrLTMuNi1taXNwbGFj ZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1ndGttYWluLnBhdGNoOiBBZGRlZC4KLS0tCiBUb29s cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysr KysrKysrKysrKwogVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgICA0ICsrKy0KIC4uLi1taXNwbGFjZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1n dGttYWluLnBhdGNoIHwgICAyMSArKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2Vk LCAzOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgVG9v bHMvZ3RrL3BhdGNoZXMvZ3RrLTMuNi1taXNwbGFjZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1n dGttYWluLnBhdGNoCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDE1NjY4ZjEuLjVlNjQxY2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wOS0xMyAgTWFyaW8g U2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtd IHNvY2tldF9lbWJlZF9ob29rIGhpdHRpbmcgTlVMTC1jaGVjayBhc3NlcnRpb24gcnVubmluZyBU ZXN0V2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIxMjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUHJvdmlkZSBhIG5ldyBwYXRjaCB0byBkZWFsIHdpdGggdGhlIGlzc3VlIGluIHRoZSBHVEsr IG1vZHVsZSBmcm9tCisgICAgICAgIHRoZSBpbnRlcm5hbCBqaGJ1aWxkIGVudmlyb25tZW50LiBU aGlzIGlzc3VlIGhhcyBiZWVuIHJlcG9ydGVkCisgICAgICAgIHVwc3RyZWFtIChzZWUgaHR0cHM6 Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTcwODAyNCkuCisKKyAgICAgICAg KiBndGsvamhidWlsZC5tb2R1bGVzOiBBcHBseSB0aGUgbmV3IHBhdGNoIHRvIHRoZSBHVEsrIG1v ZHVsZS4KKyAgICAgICAgKiBndGsvcGF0Y2hlcy9ndGstMy42LW1pc3BsYWNlZC1hMTF5LWluaXRp YWxpemF0aW9uLWluLWd0a21haW4ucGF0Y2g6IEFkZGVkLgorCiAyMDEzLTA5LTExICBHYWJvciBB YnJhaGFtICA8YWJyaG1AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFBlcmZvcm1hbmNlIHRl c3RlciBib3RzIHNob3VsZCByZXBvcnQgdGhlIG51bWJlciBvZiBmYWlsaW5nIHRlc3RzCmRpZmYg LS1naXQgYS9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9k dWxlcwppbmRleCA4OGQwMTQ2Li41MGNmYjM1IDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWls ZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKQEAgLTE1MSw3ICsxNTEs OSBAQAogICAgIDwvZGVwZW5kZW5jaWVzPgogICAgIDxicmFuY2ggbW9kdWxlPSIvcHViL0dOT01F L3NvdXJjZXMvZ3RrKy8zLjYvZ3RrKy0zLjYuMC50YXIueHoiIHZlcnNpb249IjMuNi4wIgogICAg ICAgICAgICAgcmVwbz0iZnRwLmdub21lLm9yZyIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1Njpl MTNmNDUyMjVhNzk1ZWJlOWU0MDQ3NDg2ZmE1N2IzMjMyZTZhMjE1Mzk5ODM3NzVkYjZjZDRhZTkw NDZiMDQ5Ii8+CisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZTEzZjQ1MjI1YTc5NWViZTllNDA0 NzQ4NmZhNTdiMzIzMmU2YTIxNTM5OTgzNzc1ZGI2Y2Q0YWU5MDQ2YjA0OSI+CisgICAgICA8cGF0 Y2ggZmlsZT0iZ3RrLTMuNi1taXNwbGFjZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1ndGttYWlu LnBhdGNoIiBzdHJpcD0iMSIvPgorICAgIDwvYnJhbmNoPgogICA8L2F1dG90b29scz4KIAogICA8 YXV0b3Rvb2xzIGlkPSJnbGliIgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL3BhdGNoZXMvZ3RrLTMu Ni1taXNwbGFjZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1ndGttYWluLnBhdGNoIGIvVG9vbHMv Z3RrL3BhdGNoZXMvZ3RrLTMuNi1taXNwbGFjZWQtYTExeS1pbml0aWFsaXphdGlvbi1pbi1ndGtt YWluLnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjZlNTRhMjEKLS0t IC9kZXYvbnVsbAorKysgYi9Ub29scy9ndGsvcGF0Y2hlcy9ndGstMy42LW1pc3BsYWNlZC1hMTF5 LWluaXRpYWxpemF0aW9uLWluLWd0a21haW4ucGF0Y2gKQEAgLTAsMCArMSwyMSBAQAorLS0tIGd0 aystMy42LjAvZ3RrL2d0a21haW4uYwkyMDEyLTA5LTE4IDE2OjM0OjQyLjAwMDAwMDAwMCArMDEw MAorKysrIGd0aystMy42LjAvZ3RrL2d0a21haW4uYwkyMDEzLTA5LTEzIDEwOjQzOjAyLjIwMTM2 ODE3OCArMDEwMAorQEAgLTczMiw4ICs3MzIsNiBAQAorICAgICB7CisgICAgICAgX2d0a19tb2R1 bGVzX2luaXQgKGFyZ2MsIGFyZ3YsIE5VTEwpOworICAgICB9CistCistICBfZ3RrX2FjY2Vzc2li aWxpdHlfaW5pdCAoKTsKKyB9CisgCisgCitAQCAtMTE1Miw2ICsxMTUwLDkgQEAKKyB7CisgICBH TWFpbkxvb3AgKmxvb3A7CisgCisrICBpZiAoZ3RrX21haW5fbG9vcF9sZXZlbCA9PSAwKQorKyAg ICBfZ3RrX2FjY2Vzc2liaWxpdHlfaW5pdCAoKTsKKysKKyAgIGd0a19tYWluX2xvb3BfbGV2ZWwr KzsKKyAKKyAgIGxvb3AgPSBnX21haW5fbG9vcF9uZXcgKE5VTEwsIFRSVUUpOwotLSAKMS43LjEw LjQKCg== 211804 2013-09-16 09:48:48 -0700 2013-09-20 08:46:18 -0700 Patch proposal 0001-GTK-socket_embed_hook-hitting-NULL-check-assertion-r.patch text/plain 3906 mario RnJvbSA4ZmQ4OTE5Njk2ODRhNjUwOTg2ZjFkOGU2MmY5M2ViMGI0YmZkNGYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogTW9uLCAxNiBTZXAgMjAxMyAxNzo0MDo1NSArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIFtHVEtdIHNvY2tldF9lbWJlZF9ob29rIGhpdHRpbmcgTlVMTC1jaGVjayBhc3NlcnRp b24gcnVubmluZwogVGVzdFdlYktpdDIgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMTI5NAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpQcm92aWRlIGEgbmV3 IHBhdGNoIHRvIGRlYWwgd2l0aCB0aGUgaXNzdWUgaW4gdGhlIEdUSysgbW9kdWxlIGZyb20KdGhl IGludGVybmFsIGpoYnVpbGQgZW52aXJvbm1lbnQuIFRoaXMgaXNzdWUgaGFzIGJlZW4gcmVwb3J0 ZWQKdXBzdHJlYW0gKHNlZSBodHRwczovL2J1Z3ppbGxhLmdub21lLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzA4MDI0KS4KCiogZ3RrL2poYnVpbGQubW9kdWxlczogQXBwbHkgdGhlIG5ldyBwYXRjaCB0 byB0aGUgR1RLKyBtb2R1bGUuCiogZ3RrL3BhdGNoZXMvZ3RrLTMuNi1kby1ub3Qtc2h1dGRvd24t YWNjZXNzaWJpbGl0eS5wYXRjaDogQWRkZWQuCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysKIFRvb2xzL2d0ay9qaGJ1 aWxkLm1vZHVsZXMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArLQogLi4uL2d0ay0z LjYtZG8tbm90LXNodXRkb3duLWFjY2Vzc2liaWxpdHkucGF0Y2ggICAgfCAgIDM5ICsrKysrKysr KysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBUb29scy9ndGsvcGF0Y2hlcy9ndGstMy42LWRvLW5v dC1zaHV0ZG93bi1hY2Nlc3NpYmlsaXR5LnBhdGNoCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDU4MzRhN2EuLjhhMDQ4MTEgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxMy0wOS0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtHVEtdIHNvY2tldF9lbWJlZF9ob29rIGhpdHRpbmcgTlVMTC1jaGVjayBh c3NlcnRpb24gcnVubmluZyBUZXN0V2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUHJvdmlkZSBhIG5ldyBwYXRjaCB0byBkZWFsIHdpdGggdGhl IGlzc3VlIGluIHRoZSBHVEsrIG1vZHVsZSBmcm9tCisgICAgICAgIHRoZSBpbnRlcm5hbCBqaGJ1 aWxkIGVudmlyb25tZW50LiBUaGlzIGlzc3VlIGhhcyBiZWVuIHJlcG9ydGVkCisgICAgICAgIHVw c3RyZWFtIChzZWUgaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTcw ODAyNCkuCisKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOiBBcHBseSB0aGUgbmV3IHBh dGNoIHRvIHRoZSBHVEsrIG1vZHVsZS4KKyAgICAgICAgKiBndGsvcGF0Y2hlcy9ndGstMy42LWRv LW5vdC1zaHV0ZG93bi1hY2Nlc3NpYmlsaXR5LnBhdGNoOiBBZGRlZC4KKwogMjAxMy0wOS0xNSAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgTWFrZSB0aGUg R0RCIHdlYmtpdC5weSBzY3JpcHQgY29tcGF0aWJsZSB3aXRoIFB5dGhvbiB2MwpkaWZmIC0tZ2l0 IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMK aW5kZXggODhkMDE0Ni4uMWFmNWUyOSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9k dWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0xNTEsNyArMTUxLDkgQEAK ICAgICA8L2RlcGVuZGVuY2llcz4KICAgICA8YnJhbmNoIG1vZHVsZT0iL3B1Yi9HTk9NRS9zb3Vy Y2VzL2d0aysvMy42L2d0aystMy42LjAudGFyLnh6IiB2ZXJzaW9uPSIzLjYuMCIKICAgICAgICAg ICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZTEzZjQ1 MjI1YTc5NWViZTllNDA0NzQ4NmZhNTdiMzIzMmU2YTIxNTM5OTgzNzc1ZGI2Y2Q0YWU5MDQ2YjA0 OSIvPgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmUxM2Y0NTIyNWE3OTVlYmU5ZTQwNDc0ODZm YTU3YjMyMzJlNmEyMTUzOTk4Mzc3NWRiNmNkNGFlOTA0NmIwNDkiPgorICAgICAgPHBhdGNoIGZp bGU9Imd0ay0zLjYtZG8tbm90LXNodXRkb3duLWFjY2Vzc2liaWxpdHkucGF0Y2giIHN0cmlwPSIx Ii8+CisgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9Imds aWIiCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvcGF0Y2hlcy9ndGstMy42LWRvLW5vdC1zaHV0ZG93 bi1hY2Nlc3NpYmlsaXR5LnBhdGNoIGIvVG9vbHMvZ3RrL3BhdGNoZXMvZ3RrLTMuNi1kby1ub3Qt c2h1dGRvd24tYWNjZXNzaWJpbGl0eS5wYXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi45NDYzNmM3Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvZ3RrL3BhdGNoZXMvZ3Rr LTMuNi1kby1ub3Qtc2h1dGRvd24tYWNjZXNzaWJpbGl0eS5wYXRjaApAQCAtMCwwICsxLDM5IEBA CistLS0gZ3RrKy0zLjYuMC9ndGsvZ3RrbWFpbi5jCTIwMTItMDktMTggMTY6MzQ6NDIuMDAwMDAw MDAwICswMTAwCisrKysgZ3RrKy0zLjYuMC9ndGsvZ3RrbWFpbi5jCTIwMTMtMDktMTYgMTc6MzY6 NTguMDQ2NTQ2NTQ1ICswMTAwCitAQCAtNjcxLDcgKzY3MSw2IEBACisgCisgLyogWFhYOiBSZW1v dmUgbWUgYWZ0ZXIgZ2V0dGluZyByaWQgb2YgZ2FpbCAqLworIGV4dGVybiB2b2lkIF9ndGtfYWNj ZXNzaWJpbGl0eV9pbml0ICh2b2lkKTsKKy1leHRlcm4gdm9pZCBfZ3RrX2FjY2Vzc2liaWxpdHlf c2h1dGRvd24gKHZvaWQpOworIAorIHN0YXRpYyB2b2lkCisgZG9fcG9zdF9wYXJzZV9pbml0aWFs aXphdGlvbiAoaW50ICAgICphcmdjLAorQEAgLTExODAsOCArMTE3OSw2IEBACisgCisgICAgICAg LyogU3luY2hyb25pemUgdGhlIHJlY2VudCBtYW5hZ2VyIHNpbmdsZXRvbiAqLworICAgICAgIF9n dGtfcmVjZW50X21hbmFnZXJfc3luYyAoKTsKKy0KKy0gICAgICBfZ3RrX2FjY2Vzc2liaWxpdHlf c2h1dGRvd24gKCk7CisgICAgIH0KKyB9CisgCistLS0gZ3RrKy0zLjYuMC9ndGsvZ3RrYXBwbGlj YXRpb24uYwkyMDEyLTA5LTI0IDAwOjU3OjMwLjAwMDAwMDAwMCArMDEwMAorKysrIGd0aystMy42 LjAvZ3RrL2d0a2FwcGxpY2F0aW9uLmMJMjAxMy0wOS0xNiAxNzozNzoyMy4xNTQ2NzEwNTEgKzAx MDAKK0BAIC00Nyw4ICs0Nyw2IEBACisgI2luY2x1ZGUgPGdkay94MTEvZ2RreC5oPgorICNlbmRp ZgorIAorLWV4dGVybiB2b2lkIF9ndGtfYWNjZXNzaWJpbGl0eV9zaHV0ZG93biAodm9pZCk7Cist CisgLyoqCisgICogU0VDVElPTjpndGthcHBsaWNhdGlvbgorICAqIEB0aXRsZTogR3RrQXBwbGlj YXRpb24KK0BAIC00MzMsOCArNDMxLDYgQEAKKyAgIC8qIFN5bmNocm9uaXplIHRoZSByZWNlbnQg bWFuYWdlciBzaW5nbGV0b24gKi8KKyAgIF9ndGtfcmVjZW50X21hbmFnZXJfc3luYyAoKTsKKyAK Ky0gIF9ndGtfYWNjZXNzaWJpbGl0eV9zaHV0ZG93biAoKTsKKy0KKyAgIEdfQVBQTElDQVRJT05f Q0xBU1MgKGd0a19hcHBsaWNhdGlvbl9wYXJlbnRfY2xhc3MpCisgICAgIC0+c2h1dGRvd24gKGFw cGxpY2F0aW9uKTsKKyB9Ci0tIAoxLjcuMTAuNAoK