121291 2013-09-13 04:41:58 -0700 OwnArrayPtr: Never allow implicit pointer conversion 2013-09-13 08:24:59 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca benjamin cmarcelo commit-queue darin kling koivisto oldest_to_newest 928768 0 mikhail.pozdnyakov 2013-09-13 04:41:58 -0700 We should never allow implicit pointer conversion in OwnArrayPtr (remove template copy constructor & template assignment operator), as: 1) it is never used (no surprise :) ) 2) It's inappropriate to have as arrays do not interact well with polymorphism. The following example illustrates possible problem: OwnArrayPtr<Base> ptr = adoptArrayPtr(new Derived[10]); // sizeof(Derived) > sizeof(Base) for (int i = 0; i < 10; ++i) { ptr[i].func(); // Crashes here. } Crash is because sizeof(Base) is used inside OwnArrayPtr::operator[] to access an element by index. 928771 1 211538 mikhail.pozdnyakov 2013-09-13 04:49:37 -0700 Created attachment 211538 patch 928845 2 211538 andersca 2013-09-13 08:02:32 -0700 Comment on attachment 211538 patch Nice! (We've been talking about replacing uses of OwnArrayPtr<T> with std::unique_ptr<T[]> instead if that something you want to explore later!) 928858 3 211538 commit-queue 2013-09-13 08:24:56 -0700 Comment on attachment 211538 patch Clearing flags on attachment: 211538 Committed r155701: <http://trac.webkit.org/changeset/155701> 928859 4 commit-queue 2013-09-13 08:24:59 -0700 All reviewed patches have been landed. Closing bug. 211538 2013-09-13 04:49:37 -0700 2013-09-13 08:24:56 -0700 patch bug121291 text/plain 2427 mikhail.pozdnyakov Y29tbWl0IGY4ZDY5ZTNkMmIwNjUwYzk3NmMxYmJlZjBiN2Y4ZTRjZmY0ODUxNTQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIFNlcCAxMyAxNDo0Nzo0NyAyMDEzICswMzAwCgogICAgYnVnMTIxMjkxCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBiYmU2 NjBmLi4xOTUxODhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTEzICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIE93bkFy cmF5UHRyOiBOZXZlciBhbGxvdyBpbXBsaWNpdCBwb2ludGVyIGNvbnZlcnNpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTI5MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBuZXZlciBh bGxvdyBpbXBsaWNpdCBwb2ludGVyIGNvbnZlcnNpb24gaW4gT3duQXJyYXlQdHIgCisgICAgICAg IGFuZCByZW1vdmUgaXRzIHRlbXBsYXRlIGNvcHkgY29uc3RydWN0b3IgJiB0ZW1wbGF0ZSBhc3Np Z25tZW50IG9wZXJhdG9yLCBhczoKKyAgICAgICAgLSB0aGVzZSBtZXRob2RzIGFyZSBuZXZlciB1 c2VkCisgICAgICAgIC0gdGhlc2UgbWV0aG9kcyBhcmUgaW5hcHByb3ByaWF0ZSB0byBoYXZlIGlu IE93bkFycmF5UHRyIGFzIGFycmF5cyBkbyBub3QKKyAgICAgICAgICBpbnRlcmFjdCB3ZWxsIHdp dGggcG9seW1vcnBoaXNtLgorCisgICAgICAgICogd3RmL093bkFycmF5UHRyLmg6CisKIDIwMTMt MDktMTIgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAg ICBCaXRtYXAncyBXb3JkVHlwZSBzaG91bGQgYmUgYSB0ZW1wbGF0ZSBwYXJhbWV0ZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL093bkFycmF5UHRyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Pd25B cnJheVB0ci5oCmluZGV4IDgxNGIzMjMuLjJkZDBhMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL093bkFycmF5UHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvT3duQXJyYXlQdHIuaApAQCAt MzcsNyArMzcsNiBAQCBwdWJsaWM6CiAgICAgT3duQXJyYXlQdHIoKSA6IG1fcHRyKG51bGxwdHIp IHsgfQogICAgIE93bkFycmF5UHRyKHN0ZDo6bnVsbHB0cl90KSA6IG1fcHRyKG51bGxwdHIpIHsg fQogICAgIE93bkFycmF5UHRyKE93bkFycmF5UHRyJiYpOwotICAgIHRlbXBsYXRlPHR5cGVuYW1l IFU+IE93bkFycmF5UHRyKE93bkFycmF5UHRyPFU+JiYpOwogCiAgICAgfk93bkFycmF5UHRyKCkg eyBkZWxldGVPd25lZEFycmF5UHRyKG1fcHRyKTsgfQogCkBAIC01OSw3ICs1OCw2IEBAIHB1Ymxp YzoKIAogICAgIE93bkFycmF5UHRyJiBvcGVyYXRvcj0oc3RkOjpudWxscHRyX3QpIHsgY2xlYXIo KTsgcmV0dXJuICp0aGlzOyB9CiAgICAgT3duQXJyYXlQdHImIG9wZXJhdG9yPShPd25BcnJheVB0 ciYmKTsKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBPd25BcnJheVB0ciYgb3BlcmF0b3I9KE93 bkFycmF5UHRyPFU+JiYpOwogCiAgICAgdm9pZCBzd2FwKE93bkFycmF5UHRyJiBvKSB7IHN0ZDo6 c3dhcChtX3B0ciwgby5tX3B0cik7IH0KIApAQCAtNzYsMTIgKzc0LDYgQEAgaW5saW5lIE93bkFy cmF5UHRyPFQ+OjpPd25BcnJheVB0cihPd25BcnJheVB0ciYmIG90aGVyKQogewogfQogCi10ZW1w bGF0ZTx0eXBlbmFtZSBUPiB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgotaW5saW5lIE93bkFycmF5UHRy PFQ+OjpPd25BcnJheVB0cihPd25BcnJheVB0cjxVPiYmIG90aGVyKQotICAgIDogbV9wdHIob3Ro ZXIubGVha1B0cigpKQotewotfQotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogaW5saW5lIHZvaWQg T3duQXJyYXlQdHI8VD46OmNsZWFyKCkKIHsKQEAgLTEwNiwxNCArOTgsNiBAQCBpbmxpbmUgT3du QXJyYXlQdHI8VD4mIE93bkFycmF5UHRyPFQ+OjpvcGVyYXRvcj0oT3duQXJyYXlQdHImJiBvdGhl cikKICAgICByZXR1cm4gKnRoaXM7CiB9CiAKLXRlbXBsYXRlPHR5cGVuYW1lIFQ+IHRlbXBsYXRl PHR5cGVuYW1lIFU+Ci1pbmxpbmUgT3duQXJyYXlQdHI8VD4mIE93bkFycmF5UHRyPFQ+OjpvcGVy YXRvcj0oT3duQXJyYXlQdHI8VT4mJiBvdGhlcikKLXsKLSAgICBhdXRvIHB0ciA9IHN0ZDo6bW92 ZShvdGhlcik7Ci0gICAgc3dhcChwdHIpOwotICAgIHJldHVybiAqdGhpczsKLX0KLQogdGVtcGxh dGUgPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lkIHN3YXAoT3duQXJyYXlQdHI8VD4mIGEsIE93bkFy cmF5UHRyPFQ+JiBiKQogewogICAgIGEuc3dhcChiKTsK