121288 2013-09-13 03:44:02 -0700 Remove support for anonymous deprecated flexboxes. 2013-09-13 05:21:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kling koivisto kondapallykalyan oldest_to_newest 928750 0 kling 2013-09-13 03:44:02 -0700 Looks like this is not needed anymore. 928755 1 211533 kling 2013-09-13 03:59:14 -0700 Created attachment 211533 Patch 928756 2 koivisto 2013-09-13 04:03:02 -0700 Nice! 928757 3 211533 koivisto 2013-09-13 04:04:01 -0700 Comment on attachment 211533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211533&action=review > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:-135 > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChrome); > - else if (url.protocolIs("chrome-extension")) > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChromeExtension); > - else > - FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxWebContent); I guess we can nuke those FeatureObserver enum values too. 928788 4 211533 kling 2013-09-13 05:21:33 -0700 Comment on attachment 211533 Patch Clearing flags on attachment: 211533 Committed r155689: <http://trac.webkit.org/changeset/155689> 928789 5 kling 2013-09-13 05:21:38 -0700 All reviewed patches have been landed. Closing bug. 211533 2013-09-13 03:59:14 -0700 2013-09-13 05:21:32 -0700 Patch bug-121288.diff text/plain 5729 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3M2UzNTVkLi41N2FjZTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTMtMDktMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbW92ZSBzdXBwb3J0IGZvciBhbm9ueW1vdXMgZGVwcmVjYXRlZCBmbGV4Ym94ZXMuCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjEyODg+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIG5vIHJlbWFpbmluZyBpbnRl cm5hbCBjbGllbnRzIG9mIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveCwKKyAgICAgICAgTnVr ZSBhIEZJWE1FIGZyb20gcjE0MzY0MyB3aGVyZSB0aGUgbW92ZSB0byBiYXNpbmcgcmVuZGVyZXJz IG9uIG5ldyBmbGV4Ym94IHN0YXJ0ZWQuCisKKyAgICAgICAgVGhpcyB3YXMgdGhlIG9ubHkgdXNl ciBvZiBhbm9ueW1vdXMgZGVwcmVjYXRlZCBmbGV4Ym94LCBzbyByZW1vdmVkIHRoZSBhYmlsaXR5 IHRvCisgICAgICAgIGNvbnN0cnVjdCB0aG9zZS4KKworICAgICAgICBBbHNvIHJlbW92ZWQgc29t ZSBDaHJvbWUtcmVsYXRlZCBmZWF0dXJlIG9ic2VydmF0aW9uIGd1bmsgZnJvbSBjb25zdHJ1Y3Rv ci4KKworMjAxMy0wOS0xMyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAg ICAgICAgW0NUVEVdIFJlbmRlclRhYmxlQ29sIGlzIG5ldmVyIGFub255bW91cy4KICAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMTI4Nj4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKaW5kZXggZGZjOTExOS4uOTZjMTcwZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC02OTA2LDExICs2OTA2LDcgQEAgUmVuZGVyQmxv Y2sqIFJlbmRlckJsb2NrOjpjcmVhdGVBbm9ueW1vdXNXaXRoUGFyZW50UmVuZGVyZXJBbmREaXNw bGF5KGNvbnN0IFJlbmQKICAgICAvLyBGSVhNRTogRG8gd2UgbmVlZCB0byBjb252ZXJ0IGFsbCBv dXIgaW5saW5lIGRpc3BsYXlzIHRvIGJsb2NrLXR5cGUgaW4gdGhlIGFub255bW91cyBsb2dpYyA/ CiAgICAgRURpc3BsYXkgbmV3RGlzcGxheTsKICAgICBSZW5kZXJCbG9jayogbmV3Qm94ID0gMDsK LSAgICBpZiAoZGlzcGxheSA9PSBCT1ggfHwgZGlzcGxheSA9PSBJTkxJTkVfQk9YKSB7Ci0gICAg ICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBjYXNlIG9uY2Ugd2UgaGF2ZSBlbGltaW5hdGVkIGFs bCBpbnRlcm5hbCB1c2VycyBvZiBvbGQgZmxleGJveAotICAgICAgICBuZXdCb3ggPSBSZW5kZXJE ZXByZWNhdGVkRmxleGlibGVCb3g6OmNyZWF0ZUFub255bW91cygmcGFyZW50LT5kb2N1bWVudCgp KTsKLSAgICAgICAgbmV3RGlzcGxheSA9IEJPWDsKLSAgICB9IGVsc2UgaWYgKGRpc3BsYXkgPT0g RkxFWCB8fCBkaXNwbGF5ID09IElOTElORV9GTEVYKSB7CisgICAgaWYgKGRpc3BsYXkgPT0gRkxF WCB8fCBkaXNwbGF5ID09IElOTElORV9GTEVYKSB7CiAgICAgICAgIG5ld0JveCA9IFJlbmRlckZs ZXhpYmxlQm94OjpjcmVhdGVBbm9ueW1vdXMoJnBhcmVudC0+ZG9jdW1lbnQoKSk7CiAgICAgICAg IG5ld0Rpc3BsYXkgPSBGTEVYOwogICAgIH0gZWxzZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCmluZGV4IGRj ZjU1MTAuLmJmMDA2ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCkBAIC0xMjAsMzEgKzEyMCwxNyBAQCBw cml2YXRlOgogICAgIGludCBtX29yZGluYWxJdGVyYXRpb247CiB9OwogCi1SZW5kZXJEZXByZWNh dGVkRmxleGlibGVCb3g6OlJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveChFbGVtZW50KiBlbGVt ZW50KQotICAgIDogUmVuZGVyQmxvY2soZWxlbWVudCkKK1JlbmRlckRlcHJlY2F0ZWRGbGV4aWJs ZUJveDo6UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94KEVsZW1lbnQmIGVsZW1lbnQpCisgICAg OiBSZW5kZXJCbG9jaygmZWxlbWVudCkKIHsKICAgICBzZXRDaGlsZHJlbklubGluZShmYWxzZSk7 IC8vIEFsbCBvZiBvdXIgY2hpbGRyZW4gbXVzdCBiZSBibG9jay1sZXZlbAogICAgIG1fc3RyZXRj aGluZ0NoaWxkcmVuID0gZmFsc2U7Ci0gICAgaWYgKCFpc0Fub255bW91cygpKSB7Ci0gICAgICAg IGNvbnN0IEtVUkwmIHVybCA9IGRvY3VtZW50KCkudXJsKCk7Ci0gICAgICAgIGlmICh1cmwucHJv dG9jb2xJcygiY2hyb21lIikpCi0gICAgICAgICAgICBGZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUo JmRvY3VtZW50KCksIEZlYXR1cmVPYnNlcnZlcjo6RGVwcmVjYXRlZEZsZXhib3hDaHJvbWUpOwot ICAgICAgICBlbHNlIGlmICh1cmwucHJvdG9jb2xJcygiY2hyb21lLWV4dGVuc2lvbiIpKQotICAg ICAgICAgICAgRmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKCZkb2N1bWVudCgpLCBGZWF0dXJlT2Jz ZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94Q2hyb21lRXh0ZW5zaW9uKTsKLSAgICAgICAgZWxzZQot ICAgICAgICAgICAgRmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKCZkb2N1bWVudCgpLCBGZWF0dXJl T2JzZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94V2ViQ29udGVudCk7Ci0gICAgfQotfQogCi1SZW5k ZXJEZXByZWNhdGVkRmxleGlibGVCb3g6On5SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3goKQot eworICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZSgmZG9jdW1lbnQoKSwgRmVhdHVyZU9ic2Vy dmVyOjpEZXByZWNhdGVkRmxleGJveFdlYkNvbnRlbnQpOwogfQogCi1SZW5kZXJEZXByZWNhdGVk RmxleGlibGVCb3gqIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveDo6Y3JlYXRlQW5vbnltb3Vz KERvY3VtZW50KiBkb2N1bWVudCkKK1JlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveDo6flJlbmRl ckRlcHJlY2F0ZWRGbGV4aWJsZUJveCgpCiB7Ci0gICAgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxl Qm94KiByZW5kZXJlciA9IG5ldyAoZG9jdW1lbnQtPnJlbmRlckFyZW5hKCkpIFJlbmRlckRlcHJl Y2F0ZWRGbGV4aWJsZUJveCgwKTsKLSAgICByZW5kZXJlci0+c2V0RG9jdW1lbnRGb3JBbm9ueW1v dXMoZG9jdW1lbnQpOwotICAgIHJldHVybiByZW5kZXJlcjsKIH0KIAogc3RhdGljIExheW91dFVu aXQgbWFyZ2luV2lkdGhGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5oCmluZGV4 IDkwNmIwMTkuLjBjNTk0ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmgKQEAgLTMxLDEwICszMSwxMCBAQCBjbGFz cyBGbGV4Qm94SXRlcmF0b3I7CiAKIGNsYXNzIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveCBG SU5BTCA6IHB1YmxpYyBSZW5kZXJCbG9jayB7CiBwdWJsaWM6Ci0gICAgUmVuZGVyRGVwcmVjYXRl ZEZsZXhpYmxlQm94KEVsZW1lbnQqKTsKKyAgICBleHBsaWNpdCBSZW5kZXJEZXByZWNhdGVkRmxl eGlibGVCb3goRWxlbWVudCYpOwogICAgIHZpcnR1YWwgflJlbmRlckRlcHJlY2F0ZWRGbGV4aWJs ZUJveCgpOwogCi0gICAgc3RhdGljIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveCogY3JlYXRl QW5vbnltb3VzKERvY3VtZW50Kik7CisgICAgRWxlbWVudCYgZXhpc3RpbmdFbGVtZW50KCkgY29u c3QgeyByZXR1cm4gKlJlbmRlckJsb2NrOjplbGVtZW50KCk7IH0KIAogICAgIHZpcnR1YWwgY29u c3QgY2hhciogcmVuZGVyTmFtZSgpIGNvbnN0OwogCkBAIC01MSw3ICs1MSw5IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgcGxhY2VDaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBjb25zdCBMYXlvdXRQb2lu dCYgbG9jYXRpb24sIExheW91dFNpemUqIGNoaWxkTGF5b3V0RGVsdGEgPSAwKTsKIAotcHJvdGVj dGVkOgorcHJpdmF0ZToKKyAgICB2b2lkIGVsZW1lbnQoKSBjb25zdCBXVEZfREVMRVRFRF9GVU5D VElPTjsKKwogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhM YXlvdXRVbml0JiBtaW5Mb2dpY2FsV2lkdGgsIExheW91dFVuaXQmIG1heExvZ2ljYWxXaWR0aCkg Y29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2Fs V2lkdGhzKCkgT1ZFUlJJREU7CiAKQEAgLTYxLDExICs2MywxMCBAQCBwcm90ZWN0ZWQ6CiAgICAg Ym9vbCBpc1ZlcnRpY2FsKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS0+Ym94T3JpZW50KCkgPT0g VkVSVElDQUw7IH0KICAgICBib29sIGlzSG9yaXpvbnRhbCgpIGNvbnN0IHsgcmV0dXJuIHN0eWxl KCktPmJveE9yaWVudCgpID09IEhPUklaT05UQUw7IH0KIAotICAgIGJvb2wgbV9zdHJldGNoaW5n Q2hpbGRyZW47Ci0KLXByaXZhdGU6CiAgICAgdm9pZCBhcHBseUxpbmVDbGFtcChGbGV4Qm94SXRl cmF0b3ImLCBib29sIHJlbGF5b3V0Q2hpbGRyZW4pOwogICAgIHZvaWQgY2xlYXJMaW5lQ2xhbXAo KTsKKworICAgIGJvb2wgbV9zdHJldGNoaW5nQ2hpbGRyZW47CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4 IDA2NjhiM2YuLjg2ZDllMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwCkBAIC0yMjgsNyArMjI4LDcgQEAgUmVuZGVyT2JqZWN0KiBSZW5kZXJPYmplY3Q6OmNy ZWF0ZU9iamVjdChFbGVtZW50KiBlbGVtZW50LCBSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAgICAg IHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJUYWJsZUNhcHRpb24oZWxlbWVudCk7CiAgICAgY2Fz ZSBCT1g6CiAgICAgY2FzZSBJTkxJTkVfQk9YOgotICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkg UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94KGVsZW1lbnQpOworICAgICAgICByZXR1cm4gbmV3 IChhcmVuYSkgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94KCplbGVtZW50KTsKICAgICBjYXNl IEZMRVg6CiAgICAgY2FzZSBJTkxJTkVfRkxFWDoKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEp IFJlbmRlckZsZXhpYmxlQm94KGVsZW1lbnQpOwo=