121259 2013-09-12 14:28:35 -0700 [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled 2013-09-12 15:21:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 berto berto cgarcia commit-queue dbates mrobinson oldest_to_newest 928491 0 berto 2013-09-12 14:28:35 -0700 This is what we get if we try to compile with --no-video: CXX Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o In file included from ../../Source/WTF/wtf/Platform.h:650:0, from ../../Source/JavaScriptCore/config.h:30, from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26: ../../Source/WTF/wtf/FeatureDefines.h:874:2: error: #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)" 928493 1 211476 berto 2013-09-12 14:34:46 -0700 Created attachment 211476 Patch Here's the patch. It makes VIDEO_TRACK follow VIDEO. Of course it's also possible to have a flag to configure them separately. Should we do that instead? 928509 2 211476 mrobinson 2013-09-12 14:53:38 -0700 Comment on attachment 211476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211476&action=review > Tools/ChangeLog:9 > + Make VIDEO_TRACK configurable because it needs to be disabled if > + VIDEO is also disabled. Not sure I understand the change, since you say "because it needs to be disabled if VIDEO is also disabled," but it was always disabled before. What you are doing here is enabling VIDEO_TRACK for release builds if video is enabled. Perhaps you're really after some interaction with build-webkit? 928516 3 211476 mrobinson 2013-09-12 15:01:52 -0700 Comment on attachment 211476 Patch Apologies for how confusing the interaction of build-webkit and configure is, but the features defined in SetupWebKitFeatures.m4 describe the setup for release builds. We do not want to enable video track yet for release builds, so this patch isn't really correct. Furthermore, WebKitFeatureOverrides.txt should override any value you use here, I'm not sure it works. 928522 4 berto 2013-09-12 15:21:31 -0700 You're right, running build-webkit with --no-video-track is enough, for some reason I thought it was not working. Sorry for the noise! 211476 2013-09-12 14:34:46 -0700 2013-09-12 15:01:51 -0700 Patch 121259.diff text/plain 2652 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwNWI3NWU4Li41MTY3NWI4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDktMTIgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBEbyBub3QgZW5hYmxlIFZJREVPX1RSQUNLIGlmIFZJREVPIGlzIGRpc2FibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyNTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgVklE RU9fVFJBQ0sgb25seSBpZiBWSURFTyBpcyBlbmFibGVkLCBvdGhlcndpc2UgV2ViS2l0R1RLKwor ICAgICAgICB3b24ndCBidWlsZC4KKworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvU2V0dXBX ZWJLaXRGZWF0dXJlcy5tNDoKKwogMjAxMy0wOS0xMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1h cmlvLnByYWRhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBHYWlsIGRlcGVu ZGVuY3kgZnJvbSBidWlsZCBzeXN0ZW0gZm9yIEdUSzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRv dG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJL aXRGZWF0dXJlcy5tNAppbmRleCAwOGM4YWU4Li5mOWRjZGNkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv YXV0b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMubTQKKysrIGIvU291cmNlL2F1dG90b29scy9T ZXR1cFdlYktpdEZlYXR1cmVzLm00CkBAIC0yNCw5ICsyNCw5IEBAIGVsc2UKIGZpCiAKIGlmIHRl c3QgIiRlbmFibGVfdmlkZW8iID0gInllcyI7IHRoZW4KLSAgICBDT05GSUdVUkFCTEVfRkVBVFVS RV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfVklERU89MSIK KyAgICBDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVf REVGSU5FUyBFTkFCTEVfVklERU89MSBFTkFCTEVfVklERU9fVFJBQ0s9MSIKIGVsc2UKLSAgICBD T05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVGSU5F UyBFTkFCTEVfVklERU89MCIKKyAgICBDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTPSIkQ09O RklHVVJBQkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfVklERU89MCBFTkFCTEVfVklERU9fVFJB Q0s9MCIKIGZpCiAKIGlmIHRlc3QgIiRlbmFibGVfY3NzX3NoYWRlcnMiID0gInllcyI7IHRoZW4K QEAgLTE4MSw3ICsxODEsNiBAQCAkc3JjZGlyL1Rvb2xzL2d0ay9nZW5lcmF0ZS1mZWF0dXJlLWRl ZmluZXMtZmlsZXMgJENPTkZJR1VSQUJMRV9GRUFUVVJFX0RFRklORVMgXAogICAgIEVOQUJMRV9U T1VDSF9JQ09OX0xPQURJTkc9MCBcCiAgICAgRU5BQkxFX1VTRVJfVElNSU5HPTAgXAogICAgIEVO QUJMRV9WSUJSQVRJT049MCBcCi0gICAgRU5BQkxFX1ZJREVPX1RSQUNLPTAgXAogICAgIEVOQUJM RV9WSUVXX01PREVfQ1NTX01FRElBPTEgXAogICAgIEVOQUJMRV9XRUJfU09DS0VUUz0xIFwKICAg ICBFTkFCTEVfV0VCX1RJTUlORz0xIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA0MWFlMzEyLi4xNDZlNjFjIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDkt MTIgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBE byBub3QgZW5hYmxlIFZJREVPX1RSQUNLIGlmIFZJREVPIGlzIGRpc2FibGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyNTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFZJREVPX1RSQUNLIGNv bmZpZ3VyYWJsZSBiZWNhdXNlIGl0IG5lZWRzIHRvIGJlIGRpc2FibGVkIGlmCisgICAgICAgIFZJ REVPIGlzIGFsc28gZGlzYWJsZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06 CisgICAgICAgIChidWlsZEF1dG90b29sc1Byb2plY3QpOgorCiAyMDEzLTA5LTEyICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJ1ZGltZW50YXJ5 IHN1cHBvcnQgZm9yIG1vdmUtb25seSB0eXBlcyBhcyB2YWx1ZXMgaW4gSGFzaE1hcApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtCmluZGV4IGQ5MDIyZmQuLjNlOWRhZWYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5OTQs NiArMTk5NCw3IEBAIHN1YiBidWlsZEF1dG90b29sc1Byb2plY3QoJEApCiAgICAgICAgICJzdmci ID0+IDEsCiAgICAgICAgICJzdmctZm9udHMiID0+IDEsCiAgICAgICAgICJ2aWRlbyIgPT4gMSwK KyAgICAgICAgInZpZGVvLXRyYWNrIiA9PiAxLAogICAgICAgICAid2ViZ2wiID0+IDEsCiAgICAg ICAgICJ3ZWItYXVkaW8iID0+IDEsCiAgICAgKTsK