121253 2013-09-12 13:31:38 -0700 DFG::GenerationInfo init/fill methods shouldn't duplicate a bunch of logic 2013-09-12 13:39:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 121064 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 928459 0 fpizlo 2013-09-12 13:31:38 -0700 Add initGPR/fillGPR helpers. 928460 1 211466 fpizlo 2013-09-12 13:32:29 -0700 Created attachment 211466 the patch 928462 2 fpizlo 2013-09-12 13:39:24 -0700 Landed in http://trac.webkit.org/changeset/155645 211466 2013-09-12 13:32:29 -0700 2013-09-12 13:33:30 -0700 the patch blah.patch text/plain 6533 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NjQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTA5LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpHZW5lcmF0aW9uSW5mbyBpbml0L2ZpbGwgbWV0aG9kcyBzaG91bGRuJ3QgZHVwbGljYXRl IGEgYnVuY2ggb2YgbG9naWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMTI1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZGZnL0RGR0dlbmVyYXRpb25JbmZvLmg6CisgICAgICAgIChKU0M6OkRGRzo6 R2VuZXJhdGlvbkluZm86OmluaXRHUFIpOgorICAgICAgICAoSlNDOjpERkc6OkdlbmVyYXRpb25J bmZvOjppbml0SW50MzIpOgorICAgICAgICAoSlNDOjpERkc6OkdlbmVyYXRpb25JbmZvOjppbml0 SlNWYWx1ZSk6CisgICAgICAgIChKU0M6OkRGRzo6R2VuZXJhdGlvbkluZm86OmluaXRDZWxsKToK KyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmF0aW9uSW5mbzo6aW5pdEJvb2xlYW4pOgorICAgICAg ICAoSlNDOjpERkc6OkdlbmVyYXRpb25JbmZvOjppbml0U3RvcmFnZSk6CisgICAgICAgIChKU0M6 OkRGRzo6R2VuZXJhdGlvbkluZm86OmZpbGxHUFIpOgorICAgICAgICAoSlNDOjpERkc6OkdlbmVy YXRpb25JbmZvOjpmaWxsSlNWYWx1ZSk6CisgICAgICAgIChKU0M6OkRGRzo6R2VuZXJhdGlvbklu Zm86OmZpbGxDZWxsKToKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmF0aW9uSW5mbzo6ZmlsbElu dDMyKToKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmF0aW9uSW5mbzo6ZmlsbEJvb2xlYW4pOgor ICAgICAgICAoSlNDOjpERkc6OkdlbmVyYXRpb25JbmZvOjpmaWxsU3RvcmFnZSk6CisKIDIwMTMt MDktMTIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBmaXggbWlzcGVsbGluZyAoU3BlY3VhbHRlIC0+IFNwZWN1bGF0ZSkgdGhhdCBJIGludHJv ZHVjZWQgaW4gYW4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR2VuZXJhdGlv bkluZm8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dlbmVy YXRpb25JbmZvLmgJKHJldmlzaW9uIDE1NTU5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHR2VuZXJhdGlvbkluZm8uaAkod29ya2luZyBjb3B5KQpAQCAtNjksMTEgKzY5LDEyIEBA IHB1YmxpYzoKICAgICAgICAgbV9pc0NvbnN0YW50ID0gdHJ1ZTsKICAgICAgICAgQVNTRVJUKG1f dXNlQ291bnQpOwogICAgIH0KLSAgICB2b2lkIGluaXRJbnQzMihOb2RlKiBub2RlLCB1aW50MzJf dCB1c2VDb3VudCwgR1BSUmVnIGdwcikKKyAgICB2b2lkIGluaXRHUFIoTm9kZSogbm9kZSwgdWlu dDMyX3QgdXNlQ291bnQsIEdQUlJlZyBncHIsIERhdGFGb3JtYXQgZm9ybWF0KQogICAgIHsKKyAg ICAgICAgQVNTRVJUKGdwciAhPSBJbnZhbGlkR1BSUmVnKTsKICAgICAgICAgbV9ub2RlID0gbm9k ZTsKICAgICAgICAgbV91c2VDb3VudCA9IHVzZUNvdW50OwotICAgICAgICBtX3JlZ2lzdGVyRm9y bWF0ID0gRGF0YUZvcm1hdEludDMyOworICAgICAgICBtX3JlZ2lzdGVyRm9ybWF0ID0gZm9ybWF0 OwogICAgICAgICBtX3NwaWxsRm9ybWF0ID0gRGF0YUZvcm1hdE5vbmU7CiAgICAgICAgIG1fY2Fu RmlsbCA9IGZhbHNlOwogICAgICAgICB1LmdwciA9IGdwcjsKQEAgLTgxLDIwICs4MiwxNSBAQCBw dWJsaWM6CiAgICAgICAgIG1faXNDb25zdGFudCA9IGZhbHNlOwogICAgICAgICBBU1NFUlQobV91 c2VDb3VudCk7CiAgICAgfQorICAgIHZvaWQgaW5pdEludDMyKE5vZGUqIG5vZGUsIHVpbnQzMl90 IHVzZUNvdW50LCBHUFJSZWcgZ3ByKQorICAgIHsKKyAgICAgICAgaW5pdEdQUihub2RlLCB1c2VD b3VudCwgZ3ByLCBEYXRhRm9ybWF0SW50MzIpOworICAgIH0KICNpZiBVU0UoSlNWQUxVRTY0KQog ICAgIHZvaWQgaW5pdEpTVmFsdWUoTm9kZSogbm9kZSwgdWludDMyX3QgdXNlQ291bnQsIEdQUlJl ZyBncHIsIERhdGFGb3JtYXQgZm9ybWF0ID0gRGF0YUZvcm1hdEpTKQogICAgIHsKICAgICAgICAg QVNTRVJUKGZvcm1hdCAmIERhdGFGb3JtYXRKUyk7Ci0KLSAgICAgICAgbV9ub2RlID0gbm9kZTsK LSAgICAgICAgbV91c2VDb3VudCA9IHVzZUNvdW50OwotICAgICAgICBtX3JlZ2lzdGVyRm9ybWF0 ID0gZm9ybWF0OwotICAgICAgICBtX3NwaWxsRm9ybWF0ID0gRGF0YUZvcm1hdE5vbmU7Ci0gICAg ICAgIG1fY2FuRmlsbCA9IGZhbHNlOwotICAgICAgICB1LmdwciA9IGdwcjsKLSAgICAgICAgbV9i b3JuRm9yT1NSID0gZmFsc2U7Ci0gICAgICAgIG1faXNDb25zdGFudCA9IGZhbHNlOwotICAgICAg ICBBU1NFUlQobV91c2VDb3VudCk7CisgICAgICAgIGluaXRHUFIobm9kZSwgdXNlQ291bnQsIGdw ciwgZm9ybWF0KTsKICAgICB9CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQogICAgIHZvaWQgaW5p dEpTVmFsdWUoTm9kZSogbm9kZSwgdWludDMyX3QgdXNlQ291bnQsIEdQUlJlZyB0YWdHUFIsIEdQ UlJlZyBwYXlsb2FkR1BSLCBEYXRhRm9ybWF0IGZvcm1hdCA9IERhdGFGb3JtYXRKUykKQEAgLTEx NSwyNyArMTExLDExIEBAIHB1YmxpYzoKICNlbmRpZgogICAgIHZvaWQgaW5pdENlbGwoTm9kZSog bm9kZSwgdWludDMyX3QgdXNlQ291bnQsIEdQUlJlZyBncHIpCiAgICAgewotICAgICAgICBtX25v ZGUgPSBub2RlOwotICAgICAgICBtX3VzZUNvdW50ID0gdXNlQ291bnQ7Ci0gICAgICAgIG1fcmVn aXN0ZXJGb3JtYXQgPSBEYXRhRm9ybWF0Q2VsbDsKLSAgICAgICAgbV9zcGlsbEZvcm1hdCA9IERh dGFGb3JtYXROb25lOwotICAgICAgICBtX2NhbkZpbGwgPSBmYWxzZTsKLSAgICAgICAgdS5ncHIg PSBncHI7Ci0gICAgICAgIG1fYm9ybkZvck9TUiA9IGZhbHNlOwotICAgICAgICBtX2lzQ29uc3Rh bnQgPSBmYWxzZTsKLSAgICAgICAgQVNTRVJUKG1fdXNlQ291bnQpOworICAgICAgICBpbml0R1BS KG5vZGUsIHVzZUNvdW50LCBncHIsIERhdGFGb3JtYXRDZWxsKTsKICAgICB9CiAgICAgdm9pZCBp bml0Qm9vbGVhbihOb2RlKiBub2RlLCB1aW50MzJfdCB1c2VDb3VudCwgR1BSUmVnIGdwcikKICAg ICB7Ci0gICAgICAgIG1fbm9kZSA9IG5vZGU7Ci0gICAgICAgIG1fdXNlQ291bnQgPSB1c2VDb3Vu dDsKLSAgICAgICAgbV9yZWdpc3RlckZvcm1hdCA9IERhdGFGb3JtYXRCb29sZWFuOwotICAgICAg ICBtX3NwaWxsRm9ybWF0ID0gRGF0YUZvcm1hdE5vbmU7Ci0gICAgICAgIG1fY2FuRmlsbCA9IGZh bHNlOwotICAgICAgICB1LmdwciA9IGdwcjsKLSAgICAgICAgbV9ib3JuRm9yT1NSID0gZmFsc2U7 Ci0gICAgICAgIG1faXNDb25zdGFudCA9IGZhbHNlOwotICAgICAgICBBU1NFUlQobV91c2VDb3Vu dCk7CisgICAgICAgIGluaXRHUFIobm9kZSwgdXNlQ291bnQsIGdwciwgRGF0YUZvcm1hdEJvb2xl YW4pOwogICAgIH0KICAgICB2b2lkIGluaXREb3VibGUoTm9kZSogbm9kZSwgdWludDMyX3QgdXNl Q291bnQsIEZQUlJlZyBmcHIpCiAgICAgewpAQCAtMTUyLDE1ICsxMzIsNyBAQCBwdWJsaWM6CiAg ICAgfQogICAgIHZvaWQgaW5pdFN0b3JhZ2UoTm9kZSogbm9kZSwgdWludDMyX3QgdXNlQ291bnQs IEdQUlJlZyBncHIpCiAgICAgewotICAgICAgICBtX25vZGUgPSBub2RlOwotICAgICAgICBtX3Vz ZUNvdW50ID0gdXNlQ291bnQ7Ci0gICAgICAgIG1fcmVnaXN0ZXJGb3JtYXQgPSBEYXRhRm9ybWF0 U3RvcmFnZTsKLSAgICAgICAgbV9zcGlsbEZvcm1hdCA9IERhdGFGb3JtYXROb25lOwotICAgICAg ICBtX2NhbkZpbGwgPSBmYWxzZTsKLSAgICAgICAgdS5ncHIgPSBncHI7Ci0gICAgICAgIG1fYm9y bkZvck9TUiA9IGZhbHNlOwotICAgICAgICBtX2lzQ29uc3RhbnQgPSBmYWxzZTsKLSAgICAgICAg QVNTRVJUKG1fdXNlQ291bnQpOworICAgICAgICBpbml0R1BSKG5vZGUsIHVzZUNvdW50LCBncHIs IERhdGFGb3JtYXRTdG9yYWdlKTsKICAgICB9CiAKICAgICAvLyBHZXQgdGhlIG5vZGUgdGhhdCBw cm9kdWNlZCB0aGlzIHZhbHVlLgpAQCAtMzA0LDYgKzI3NiwxNSBAQCBwdWJsaWM6CiAgICAgICAg IG1fc3BpbGxGb3JtYXQgPSBEYXRhRm9ybWF0Tm9uZTsKICAgICAgICAgbV9jYW5GaWxsID0gZmFs c2U7CiAgICAgfQorICAgIAorICAgIHZvaWQgZmlsbEdQUihWYXJpYWJsZUV2ZW50U3RyZWFtJiBz dHJlYW0sIEdQUlJlZyBncHIsIERhdGFGb3JtYXQgZm9ybWF0KQorICAgIHsKKyAgICAgICAgQVNT RVJUKGdwciAhPSBJbnZhbGlkR1BSUmVnKTsKKyAgICAgICAgbV9yZWdpc3RlckZvcm1hdCA9IGZv cm1hdDsKKyAgICAgICAgdS5ncHIgPSBncHI7CisgICAgICAgIGlmIChtX2Jvcm5Gb3JPU1IpCisg ICAgICAgICAgICBhcHBlbmRGaWxsKEZpbGwsIHN0cmVhbSk7CisgICAgfQogCiAgICAgLy8gUmVj b3JkIHRoYXQgdGhpcyB2YWx1ZSBpcyBmaWxsZWQgaW50byBtYWNoaW5lIHJlZ2lzdGVycywKICAg ICAvLyB0cmFja2luZyB3aGljaCByZWdpc3RlcnMsIGFuZCB3aGF0IGZvcm1hdCB0aGUgdmFsdWUg aGFzLgpAQCAtMzExLDExICsyOTIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBmaWxsSlNWYWx1ZShW YXJpYWJsZUV2ZW50U3RyZWFtJiBzdHJlYW0sIEdQUlJlZyBncHIsIERhdGFGb3JtYXQgZm9ybWF0 ID0gRGF0YUZvcm1hdEpTKQogICAgIHsKICAgICAgICAgQVNTRVJUKGZvcm1hdCAmIERhdGFGb3Jt YXRKUyk7Ci0gICAgICAgIG1fcmVnaXN0ZXJGb3JtYXQgPSBmb3JtYXQ7Ci0gICAgICAgIHUuZ3By ID0gZ3ByOwotICAgICAgICAKLSAgICAgICAgaWYgKG1fYm9ybkZvck9TUikKLSAgICAgICAgICAg IGFwcGVuZEZpbGwoRmlsbCwgc3RyZWFtKTsKKyAgICAgICAgZmlsbEdQUihzdHJlYW0sIGdwciwg Zm9ybWF0KTsKICAgICB9CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQogICAgIHZvaWQgZmlsbEpT VmFsdWUoVmFyaWFibGVFdmVudFN0cmVhbSYgc3RyZWFtLCBHUFJSZWcgdGFnR1BSLCBHUFJSZWcg cGF5bG9hZEdQUiwgRGF0YUZvcm1hdCBmb3JtYXQgPSBEYXRhRm9ybWF0SlMpCkBAIC0zMzAsMjgg KzMwNywxNiBAQCBwdWJsaWM6CiAgICAgfQogICAgIHZvaWQgZmlsbENlbGwoVmFyaWFibGVFdmVu dFN0cmVhbSYgc3RyZWFtLCBHUFJSZWcgZ3ByKQogICAgIHsKLSAgICAgICAgbV9yZWdpc3RlckZv cm1hdCA9IERhdGFGb3JtYXRDZWxsOwotICAgICAgICB1LmdwciA9IGdwcjsKLSAgICAgICAgCi0g ICAgICAgIGlmIChtX2Jvcm5Gb3JPU1IpCi0gICAgICAgICAgICBhcHBlbmRGaWxsKEZpbGwsIHN0 cmVhbSk7CisgICAgICAgIGZpbGxHUFIoc3RyZWFtLCBncHIsIERhdGFGb3JtYXRDZWxsKTsKICAg ICB9CiAjZW5kaWYKICAgICB2b2lkIGZpbGxJbnQzMihWYXJpYWJsZUV2ZW50U3RyZWFtJiBzdHJl YW0sIEdQUlJlZyBncHIpCiAgICAgewotICAgICAgICBtX3JlZ2lzdGVyRm9ybWF0ID0gRGF0YUZv cm1hdEludDMyOwotICAgICAgICB1LmdwciA9IGdwcjsKLSAgICAgICAgCi0gICAgICAgIGlmICht X2Jvcm5Gb3JPU1IpCi0gICAgICAgICAgICBhcHBlbmRGaWxsKEZpbGwsIHN0cmVhbSk7CisgICAg ICAgIGZpbGxHUFIoc3RyZWFtLCBncHIsIERhdGFGb3JtYXRJbnQzMik7CiAgICAgfQogICAgIHZv aWQgZmlsbEJvb2xlYW4oVmFyaWFibGVFdmVudFN0cmVhbSYgc3RyZWFtLCBHUFJSZWcgZ3ByKQog ICAgIHsKLSAgICAgICAgbV9yZWdpc3RlckZvcm1hdCA9IERhdGFGb3JtYXRCb29sZWFuOwotICAg ICAgICB1LmdwciA9IGdwcjsKLSAgICAgICAgCi0gICAgICAgIGlmIChtX2Jvcm5Gb3JPU1IpCi0g ICAgICAgICAgICBhcHBlbmRGaWxsKEZpbGwsIHN0cmVhbSk7CisgICAgICAgIGZpbGxHUFIoc3Ry ZWFtLCBncHIsIERhdGFGb3JtYXRCb29sZWFuKTsKICAgICB9CiAgICAgdm9pZCBmaWxsRG91Ymxl KFZhcmlhYmxlRXZlbnRTdHJlYW0mIHN0cmVhbSwgRlBSUmVnIGZwcikKICAgICB7CkBAIC0zNjQs MTEgKzMyOSw3IEBAIHB1YmxpYzoKICAgICB9CiAgICAgdm9pZCBmaWxsU3RvcmFnZShWYXJpYWJs ZUV2ZW50U3RyZWFtJiBzdHJlYW0sIEdQUlJlZyBncHIpCiAgICAgewotICAgICAgICBtX3JlZ2lz dGVyRm9ybWF0ID0gRGF0YUZvcm1hdFN0b3JhZ2U7Ci0gICAgICAgIHUuZ3ByID0gZ3ByOwotICAg ICAgICAKLSAgICAgICAgaWYgKG1fYm9ybkZvck9TUikKLSAgICAgICAgICAgIGFwcGVuZEZpbGwo RmlsbCwgc3RyZWFtKTsKKyAgICAgICAgZmlsbEdQUihzdHJlYW0sIGdwciwgRGF0YUZvcm1hdFN0 b3JhZ2UpOwogICAgIH0KIAogICAgIGJvb2wgYWxpdmUoKQo=