121238 2013-09-12 10:52:15 -0700 Bitmap's WordType should be a template parameter 2013-09-12 15:26:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121074 1 mhahnenberg mhahnenberg benjamin cmarcelo commit-queue ggaren oldest_to_newest 928377 0 mhahnenberg 2013-09-12 10:52:15 -0700 The code is written as if it already is. We just need to lift it out of the class. 928396 1 211449 mhahnenberg 2013-09-12 11:18:25 -0700 Created attachment 211449 Patch 928432 2 211449 darin 2013-09-12 12:34:28 -0700 Comment on attachment 211449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211449&action=review > Source/WTF/ChangeLog:26 > + (WTF::::Bitmap): > + (WTF::::get): > + (WTF::::set): > + (WTF::::testAndSet): > + (WTF::::testAndClear): > + (WTF::::concurrentTestAndSet): > + (WTF::::concurrentTestAndClear): > + (WTF::::clear): > + (WTF::::clearAll): > + (WTF::::nextPossiblyUnset): > + (WTF::::findRunOfZeros): > + (WTF::::count): > + (WTF::::isEmpty): > + (WTF::::isFull): The prepare-ChangeLog script made a mess here. I suggest inserting the class name Bitmap into these function names. 928437 3 mhahnenberg 2013-09-12 12:47:50 -0700 Committed r155640: <http://trac.webkit.org/changeset/155640> 928523 4 ggaren 2013-09-12 15:22:21 -0700 Are you planning to use an 'unsigned char' WordType in the GC? Two thoughts: (1) I wonder if we should just mandate "byte at a time" for bitmap. Why do we need to customize? (2) It's important to preserve some of the "machine word at a time" optimizations even if the client requests a byte word size. For example, nextPossiblyUnset should work a machine word at a time. 928525 5 mhahnenberg 2013-09-12 15:26:10 -0700 (In reply to comment #4) > Are you planning to use an 'unsigned char' WordType in the GC? > Yep. It allows us to be more accurate when we're checking for mark bits (i.e. there's only 7 other objects that could confuse us into taking the slow path rather than 31). > Two thoughts: > > (1) I wonder if we should just mandate "byte at a time" for bitmap. Why do we need to customize? > I thought it would be better to leave the choice to the client, although I guess before this patch the client didn't have a choice either. > (2) It's important to preserve some of the "machine word at a time" optimizations even if the client requests a byte word size. For example, nextPossiblyUnset should work a machine word at a time. Okay. I filed https://bugs.webkit.org/show_bug.cgi?id=121266. 211449 2013-09-12 11:18:25 -0700 2013-09-12 12:34:28 -0700 Patch bug-121238-20130912111821.patch text/plain 7391 mhahnenberg SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTU2MzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDEzLTA5LTEyICBNYXJrIEhhaG5lbmJlcmcgIDxt aGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQml0bWFwJ3MgV29yZFR5cGUgc2hvdWxk IGJlIGEgdGVtcGxhdGUgcGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjEyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgY29kZSBpcyB3cml0dGVuIGFzIGlmIGl0IGFscmVhZHkgaXMu IFdlIGp1c3QgbmVlZCB0byBsaWZ0IGl0IG91dCBvZiB0aGUgY2xhc3MuCisgICAgICAgIFRoaXMg c2ltcGxpZmllcyBjb2RlIHRoYXQgd2FudHMgdG8gbG9hZCwgZm9yIGV4YW1wbGUsIGEgc2luZ2xl IGJ5dGUgcmF0aGVyIHRoYW4gYW4gCisgICAgICAgIGVudGlyZSAzMi1iaXQgd29yZC4gCisKKyAg ICAgICAgKiB3dGYvQml0bWFwLmg6CisgICAgICAgIChXVEY6Ojo6Qml0bWFwKToKKyAgICAgICAg KFdURjo6OjpnZXQpOgorICAgICAgICAoV1RGOjo6OnNldCk6CisgICAgICAgIChXVEY6Ojo6dGVz dEFuZFNldCk6CisgICAgICAgIChXVEY6Ojo6dGVzdEFuZENsZWFyKToKKyAgICAgICAgKFdURjo6 Ojpjb25jdXJyZW50VGVzdEFuZFNldCk6CisgICAgICAgIChXVEY6Ojo6Y29uY3VycmVudFRlc3RB bmRDbGVhcik6CisgICAgICAgIChXVEY6Ojo6Y2xlYXIpOgorICAgICAgICAoV1RGOjo6OmNsZWFy QWxsKToKKyAgICAgICAgKFdURjo6OjpuZXh0UG9zc2libHlVbnNldCk6CisgICAgICAgIChXVEY6 Ojo6ZmluZFJ1bk9mWmVyb3MpOgorICAgICAgICAoV1RGOjo6OmNvdW50KToKKyAgICAgICAgKFdU Rjo6Ojppc0VtcHR5KToKKyAgICAgICAgKFdURjo6Ojppc0Z1bGwpOgorCiAyMDEzLTA5LTEyICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJ1ZGlt ZW50YXJ5IHN1cHBvcnQgZm9yIG1vdmUtb25seSB0eXBlcyBhcyB2YWx1ZXMgaW4gSGFzaE1hcApJ bmRleDogU291cmNlL1dURi93dGYvQml0bWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93 dGYvQml0bWFwLmgJKHJldmlzaW9uIDE1NTYzMikKKysrIFNvdXJjZS9XVEYvd3RmL0JpdG1hcC5o CSh3b3JraW5nIGNvcHkpCkBAIC0zNiwxMSArMzYsOCBAQCBlbnVtIEJpdG1hcEF0b21pY01vZGUg ewogICAgIEJpdG1hcEF0b21pYwogfTsKIAotdGVtcGxhdGU8c2l6ZV90IHNpemUsIEJpdG1hcEF0 b21pY01vZGUgYXRvbWljTW9kZSA9IEJpdG1hcE5vdEF0b21pYz4KK3RlbXBsYXRlPHNpemVfdCBz aXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGUgPSBCaXRtYXBOb3RBdG9taWMsIHR5cGVu YW1lIFdvcmRUeXBlID0gdWludDMyX3Q+CiBjbGFzcyBCaXRtYXAgewotcHJpdmF0ZToKLSAgICB0 eXBlZGVmIHVpbnQzMl90IFdvcmRUeXBlOwotCiBwdWJsaWM6CiAgICAgQml0bWFwKCk7CiAKQEAg LTU5LDggKzU2LDggQEAgcHVibGljOgogICAgIHNpemVfdCBpc0Z1bGwoKSBjb25zdDsKIAogcHJp dmF0ZToKLSAgICBzdGF0aWMgY29uc3QgV29yZFR5cGUgd29yZFNpemUgPSBzaXplb2YoV29yZFR5 cGUpICogODsKLSAgICBzdGF0aWMgY29uc3QgV29yZFR5cGUgd29yZHMgPSAoc2l6ZSArIHdvcmRT aXplIC0gMSkgLyB3b3JkU2l6ZTsKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgd29yZFNpemUg PSBzaXplb2YoV29yZFR5cGUpICogODsKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgd29yZHMg PSAoc2l6ZSArIHdvcmRTaXplIC0gMSkgLyB3b3JkU2l6ZTsKIAogICAgIC8vIHRoZSBsaXRlcmFs ICcxJyBpcyBvZiB0eXBlIHNpZ25lZCBpbnQuICBXZSB3YW50IHRvIHVzZSBhbiB1bnNpZ25lZAog ICAgIC8vIHZlcnNpb24gb2YgdGhlIGNvcnJlY3Qgc2l6ZSB3aGVuIGRvaW5nIHRoZSBjYWxjdWxh dGlvbnMgYmVjYXVzZSBpZgpAQCAtNzIsMjYgKzY5LDI2IEBAIHByaXZhdGU6CiAgICAgRml4ZWRB cnJheTxXb3JkVHlwZSwgd29yZHM+IGJpdHM7CiB9OwogCi10ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwg Qml0bWFwQXRvbWljTW9kZSBhdG9taWNNb2RlPgotaW5saW5lIEJpdG1hcDxzaXplLCBhdG9taWNN b2RlPjo6Qml0bWFwKCkKK3RlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0 b21pY01vZGUsIHR5cGVuYW1lIFdvcmRUeXBlPgoraW5saW5lIEJpdG1hcDxzaXplLCBhdG9taWNN b2RlLCBXb3JkVHlwZT46OkJpdG1hcCgpCiB7CiAgICAgY2xlYXJBbGwoKTsKIH0KIAotdGVtcGxh dGU8c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZT4KLWlubGluZSBib29s IEJpdG1hcDxzaXplLCBhdG9taWNNb2RlPjo6Z2V0KHNpemVfdCBuKSBjb25zdAordGVtcGxhdGU8 c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZSwgdHlwZW5hbWUgV29yZFR5 cGU+CitpbmxpbmUgYm9vbCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZSwgV29yZFR5cGU+OjpnZXQo c2l6ZV90IG4pIGNvbnN0CiB7CiAgICAgcmV0dXJuICEhKGJpdHNbbiAvIHdvcmRTaXplXSAmIChv bmUgPDwgKG4gJSB3b3JkU2l6ZSkpKTsKIH0KIAotdGVtcGxhdGU8c2l6ZV90IHNpemUsIEJpdG1h cEF0b21pY01vZGUgYXRvbWljTW9kZT4KLWlubGluZSB2b2lkIEJpdG1hcDxzaXplLCBhdG9taWNN b2RlPjo6c2V0KHNpemVfdCBuKQordGVtcGxhdGU8c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01v ZGUgYXRvbWljTW9kZSwgdHlwZW5hbWUgV29yZFR5cGU+CitpbmxpbmUgdm9pZCBCaXRtYXA8c2l6 ZSwgYXRvbWljTW9kZSwgV29yZFR5cGU+OjpzZXQoc2l6ZV90IG4pCiB7CiAgICAgYml0c1tuIC8g d29yZFNpemVdIHw9IChvbmUgPDwgKG4gJSB3b3JkU2l6ZSkpOwogfQogCi10ZW1wbGF0ZTxzaXpl X3Qgc2l6ZSwgQml0bWFwQXRvbWljTW9kZSBhdG9taWNNb2RlPgotaW5saW5lIGJvb2wgQml0bWFw PHNpemUsIGF0b21pY01vZGU+Ojp0ZXN0QW5kU2V0KHNpemVfdCBuKQordGVtcGxhdGU8c2l6ZV90 IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZSwgdHlwZW5hbWUgV29yZFR5cGU+Citp bmxpbmUgYm9vbCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZSwgV29yZFR5cGU+Ojp0ZXN0QW5kU2V0 KHNpemVfdCBuKQogewogICAgIFdvcmRUeXBlIG1hc2sgPSBvbmUgPDwgKG4gJSB3b3JkU2l6ZSk7 CiAgICAgc2l6ZV90IGluZGV4ID0gbiAvIHdvcmRTaXplOwpAQCAtMTAwLDggKzk3LDggQEAgaW5s aW5lIGJvb2wgQml0bWFwPHNpemUsIGF0b21pY01vZGU+Ojp0ZQogICAgIHJldHVybiByZXN1bHQ7 CiB9CiAKLXRlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGU+ Ci1pbmxpbmUgYm9vbCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZT46OnRlc3RBbmRDbGVhcihzaXpl X3QgbikKK3RlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGUs IHR5cGVuYW1lIFdvcmRUeXBlPgoraW5saW5lIGJvb2wgQml0bWFwPHNpemUsIGF0b21pY01vZGUs IFdvcmRUeXBlPjo6dGVzdEFuZENsZWFyKHNpemVfdCBuKQogewogICAgIFdvcmRUeXBlIG1hc2sg PSBvbmUgPDwgKG4gJSB3b3JkU2l6ZSk7CiAgICAgc2l6ZV90IGluZGV4ID0gbiAvIHdvcmRTaXpl OwpAQCAtMTEwLDggKzEwNyw4IEBAIGlubGluZSBib29sIEJpdG1hcDxzaXplLCBhdG9taWNNb2Rl Pjo6dGUKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi10ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwgQml0 bWFwQXRvbWljTW9kZSBhdG9taWNNb2RlPgotaW5saW5lIGJvb2wgQml0bWFwPHNpemUsIGF0b21p Y01vZGU+Ojpjb25jdXJyZW50VGVzdEFuZFNldChzaXplX3QgbikKK3RlbXBsYXRlPHNpemVfdCBz aXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGUsIHR5cGVuYW1lIFdvcmRUeXBlPgoraW5s aW5lIGJvb2wgQml0bWFwPHNpemUsIGF0b21pY01vZGUsIFdvcmRUeXBlPjo6Y29uY3VycmVudFRl c3RBbmRTZXQoc2l6ZV90IG4pCiB7CiAgICAgaWYgKGF0b21pY01vZGUgPT0gQml0bWFwTm90QXRv bWljKQogICAgICAgICByZXR1cm4gdGVzdEFuZFNldChuKTsKQEAgLTEzMCw4ICsxMjcsOCBAQCBp bmxpbmUgYm9vbCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZT46OmNvCiAgICAgcmV0dXJuIGZhbHNl OwogfQogCi10ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwgQml0bWFwQXRvbWljTW9kZSBhdG9taWNNb2Rl PgotaW5saW5lIGJvb2wgQml0bWFwPHNpemUsIGF0b21pY01vZGU+Ojpjb25jdXJyZW50VGVzdEFu ZENsZWFyKHNpemVfdCBuKQordGVtcGxhdGU8c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUg YXRvbWljTW9kZSwgdHlwZW5hbWUgV29yZFR5cGU+CitpbmxpbmUgYm9vbCBCaXRtYXA8c2l6ZSwg YXRvbWljTW9kZSwgV29yZFR5cGU+Ojpjb25jdXJyZW50VGVzdEFuZENsZWFyKHNpemVfdCBuKQog ewogICAgIGlmIChhdG9taWNNb2RlID09IEJpdG1hcE5vdEF0b21pYykKICAgICAgICAgcmV0dXJu IHRlc3RBbmRDbGVhcihuKTsKQEAgLTE1MCwyOCArMTQ3LDI4IEBAIGlubGluZSBib29sIEJpdG1h cDxzaXplLCBhdG9taWNNb2RlPjo6Y28KICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdGVtcGxhdGU8 c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZT4KLWlubGluZSB2b2lkIEJp dG1hcDxzaXplLCBhdG9taWNNb2RlPjo6Y2xlYXIoc2l6ZV90IG4pCit0ZW1wbGF0ZTxzaXplX3Qg c2l6ZSwgQml0bWFwQXRvbWljTW9kZSBhdG9taWNNb2RlLCB0eXBlbmFtZSBXb3JkVHlwZT4KK2lu bGluZSB2b2lkIEJpdG1hcDxzaXplLCBhdG9taWNNb2RlLCBXb3JkVHlwZT46OmNsZWFyKHNpemVf dCBuKQogewogICAgIGJpdHNbbiAvIHdvcmRTaXplXSAmPSB+KG9uZSA8PCAobiAlIHdvcmRTaXpl KSk7CiB9CiAKLXRlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01v ZGU+Ci1pbmxpbmUgdm9pZCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZT46OmNsZWFyQWxsKCkKK3Rl bXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGUsIHR5cGVuYW1l IFdvcmRUeXBlPgoraW5saW5lIHZvaWQgQml0bWFwPHNpemUsIGF0b21pY01vZGUsIFdvcmRUeXBl Pjo6Y2xlYXJBbGwoKQogewogICAgIG1lbXNldChiaXRzLmRhdGEoKSwgMCwgc2l6ZW9mKGJpdHMp KTsKIH0KIAotdGVtcGxhdGU8c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9k ZT4KLWlubGluZSBzaXplX3QgQml0bWFwPHNpemUsIGF0b21pY01vZGU+OjpuZXh0UG9zc2libHlV bnNldChzaXplX3Qgc3RhcnQpIGNvbnN0Cit0ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwgQml0bWFwQXRv bWljTW9kZSBhdG9taWNNb2RlLCB0eXBlbmFtZSBXb3JkVHlwZT4KK2lubGluZSBzaXplX3QgQml0 bWFwPHNpemUsIGF0b21pY01vZGUsIFdvcmRUeXBlPjo6bmV4dFBvc3NpYmx5VW5zZXQoc2l6ZV90 IHN0YXJ0KSBjb25zdAogewogICAgIGlmICghfmJpdHNbc3RhcnQgLyB3b3JkU2l6ZV0pCiAgICAg ICAgIHJldHVybiAoKHN0YXJ0IC8gd29yZFNpemUpICsgMSkgKiB3b3JkU2l6ZTsKICAgICByZXR1 cm4gc3RhcnQgKyAxOwogfQogCi10ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwgQml0bWFwQXRvbWljTW9k ZSBhdG9taWNNb2RlPgotaW5saW5lIGludDY0X3QgQml0bWFwPHNpemUsIGF0b21pY01vZGU+Ojpm aW5kUnVuT2ZaZXJvcyhzaXplX3QgcnVuTGVuZ3RoKSBjb25zdAordGVtcGxhdGU8c2l6ZV90IHNp emUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZSwgdHlwZW5hbWUgV29yZFR5cGU+Citpbmxp bmUgaW50NjRfdCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZSwgV29yZFR5cGU+OjpmaW5kUnVuT2Za ZXJvcyhzaXplX3QgcnVuTGVuZ3RoKSBjb25zdAogewogICAgIGlmICghcnVuTGVuZ3RoKSAKICAg ICAgICAgcnVuTGVuZ3RoID0gMTsgCkBAIC0xOTAsOCArMTg3LDggQEAgaW5saW5lIGludDY0X3Qg Qml0bWFwPHNpemUsIGF0b21pY01vZGU+OgogICAgIHJldHVybiAtMTsKIH0KIAotdGVtcGxhdGU8 c2l6ZV90IHNpemUsIEJpdG1hcEF0b21pY01vZGUgYXRvbWljTW9kZT4KLWlubGluZSBzaXplX3Qg Qml0bWFwPHNpemUsIGF0b21pY01vZGU+Ojpjb3VudChzaXplX3Qgc3RhcnQpIGNvbnN0Cit0ZW1w bGF0ZTxzaXplX3Qgc2l6ZSwgQml0bWFwQXRvbWljTW9kZSBhdG9taWNNb2RlLCB0eXBlbmFtZSBX b3JkVHlwZT4KK2lubGluZSBzaXplX3QgQml0bWFwPHNpemUsIGF0b21pY01vZGUsIFdvcmRUeXBl Pjo6Y291bnQoc2l6ZV90IHN0YXJ0KSBjb25zdAogewogICAgIHNpemVfdCByZXN1bHQgPSAwOwog ICAgIGZvciAoIDsgKHN0YXJ0ICUgd29yZFNpemUpOyArK3N0YXJ0KSB7CkBAIC0yMDMsOCArMjAw LDggQEAgaW5saW5lIHNpemVfdCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9kZT46OgogICAgIHJldHVy biByZXN1bHQ7CiB9CiAKLXRlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0 b21pY01vZGU+Ci1pbmxpbmUgc2l6ZV90IEJpdG1hcDxzaXplLCBhdG9taWNNb2RlPjo6aXNFbXB0 eSgpIGNvbnN0Cit0ZW1wbGF0ZTxzaXplX3Qgc2l6ZSwgQml0bWFwQXRvbWljTW9kZSBhdG9taWNN b2RlLCB0eXBlbmFtZSBXb3JkVHlwZT4KK2lubGluZSBzaXplX3QgQml0bWFwPHNpemUsIGF0b21p Y01vZGUsIFdvcmRUeXBlPjo6aXNFbXB0eSgpIGNvbnN0CiB7CiAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCB3b3JkczsgKytpKQogICAgICAgICBpZiAoYml0c1tpXSkKQEAgLTIxMiw4ICsyMDks OCBAQCBpbmxpbmUgc2l6ZV90IEJpdG1hcDxzaXplLCBhdG9taWNNb2RlPjo6CiAgICAgcmV0dXJu IHRydWU7CiB9CiAKLXRlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21p Y01vZGU+Ci1pbmxpbmUgc2l6ZV90IEJpdG1hcDxzaXplLCBhdG9taWNNb2RlPjo6aXNGdWxsKCkg Y29uc3QKK3RlbXBsYXRlPHNpemVfdCBzaXplLCBCaXRtYXBBdG9taWNNb2RlIGF0b21pY01vZGUs IHR5cGVuYW1lIFdvcmRUeXBlPgoraW5saW5lIHNpemVfdCBCaXRtYXA8c2l6ZSwgYXRvbWljTW9k ZSwgV29yZFR5cGU+Ojppc0Z1bGwoKSBjb25zdAogewogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgd29yZHM7ICsraSkKICAgICAgICAgaWYgKH5iaXRzW2ldKQo=