121235 2013-09-12 10:37:52 -0700 Remove unneeded casts once we upgrade to a version of Visual Studio that is not broken 2016-05-02 13:35:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bfulgham peavo achristensen bfulgham eric.carlson peavo simon.fraser oldest_to_newest 928372 0 bfulgham 2013-09-12 10:37:52 -0700 We had to add casts in a number of places to work around a Visual Studio 2010 compiler bug. We should revisit this from time to time (perhaps after the switch to VS2012) to see if we can remove these casts. Locations: 1. WebCore/loader/archive/ArchiveFactory.cpp 2. WebCore/css/MediaQueryEvaluator.cpp 3. Autogenerated Files: JSSVGElementWrapperFactory.cpp JSHTMLElementWrapperFactory.cpp --> Modified in WebCore/dom/make_names.pl 928381 1 bfulgham 2013-09-12 10:55:04 -0700 The changes we want to back out were landed in http://trac.webkit.org/changeset/155630. 973384 2 eric.carlson 2014-01-29 09:25:39 -0800 Can the unneeded casts be removed now? 1188503 3 simon.fraser 2016-04-28 21:18:04 -0700 How about now? 1188728 4 bfulgham 2016-04-29 11:25:55 -0700 (In reply to comment #3) > How about now? I'll bet they can! Per, could you please try and propose a patch? 1189327 5 277892 peavo 2016-05-01 23:15:41 -0700 Created attachment 277892 Patch 1189494 6 peavo 2016-05-02 13:34:11 -0700 Thanks for reviewing :) 1189495 7 peavo 2016-05-02 13:35:12 -0700 Committed r200336: <http://trac.webkit.org/changeset/200336> 277892 2016-05-01 23:15:41 -0700 2016-05-02 00:27:12 -0700 Patch bug-121235-20160502081616.patch text/plain 5824 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDMxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA1LTAxICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQg Y2FzdHMgb25jZSB3ZSB1cGdyYWRlIHRvIGEgdmVyc2lvbiBvZiBWaXN1YWwgU3R1ZGlvIHRoYXQg aXMgbm90IGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIxMjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBjc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjph bnlfcG9pbnRlck1lZGlhRmVhdHVyZUV2YWwpOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRnVu Y3Rpb25NYXApOgorICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBsOgorICAgICAgICAocHJpbnRX cmFwcGVyRmFjdG9yeUNwcEZpbGUpOgorICAgICAgICAqIGxvYWRlci9hcmNoaXZlL0FyY2hpdmVG YWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFyY2hpdmVNSU1FVHlwZXMpOgorICAgICAg ICAqIHJlbmRlcmluZy9zdmcvU1ZHUGF0aERhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXBk YXRlUGF0aEZyb21HcmFwaGljc0VsZW1lbnQpOgorCiAyMDE2LTA1LTAxICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIHN0cmluZy1iYXNlZCBlbnVt ZXJhdGlvbnMgaW4gVGV4dFRyYWNrLCBhbmQgZWxpbWluYXRlIHN1cHBvcnQgZm9yIHN0cmluZy1i YXNlZCBlbnVtZXJhdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZh bHVhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUV2 YWx1YXRvci5jcHAJKHJldmlzaW9uIDIwMDIzNikKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9NZWRp YVF1ZXJ5RXZhbHVhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzIxLDE0ICs3MjEsMTIgQEAg c3RhdGljIGJvb2wgYW55X3BvaW50ZXJNZWRpYUZlYXR1cmVFdmFsKAogICAgIHJldHVybiBwb2lu dGVyTWVkaWFGZWF0dXJlRXZhbCh2YWx1ZSwgY3NzVG9MZW5ndGhDb252ZXJzaW9uRGF0YSwgZnJh bWUsIHByZWZpeCk7CiB9CiAKLS8vIEZJWE1FOiBSZW1vdmUgdW5uZWNlc3NhcnkgJyYnIGZyb20g dGhlIGZvbGxvd2luZyAnQUREX1RPX0ZVTkNUSU9OTUFQJyBkZWZpbml0aW9uCi0vLyBvbmNlIHdl IHN3aXRjaCB0byBhIG5vbi1icm9rZW4gVmlzdWFsIFN0dWRpbyBjb21waWxlci4gIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyMzUKIHN0YXRpYyB2b2lkIGNyZWF0 ZUZ1bmN0aW9uTWFwKCkKIHsKICAgICAvLyBDcmVhdGUgdGhlIHRhYmxlLgogICAgIGdGdW5jdGlv bk1hcCA9IG5ldyBGdW5jdGlvbk1hcDsKICNkZWZpbmUgQUREX1RPX0ZVTkNUSU9OTUFQKG5hbWUs IHN0cikgIFwKLSAgICBnRnVuY3Rpb25NYXAtPnNldChuYW1lIyNNZWRpYUZlYXR1cmUuaW1wbCgp LCAmbmFtZSMjTWVkaWFGZWF0dXJlRXZhbCk7CisgICAgZ0Z1bmN0aW9uTWFwLT5zZXQobmFtZSMj TWVkaWFGZWF0dXJlLmltcGwoKSwgbmFtZSMjTWVkaWFGZWF0dXJlRXZhbCk7CiAgICAgQ1NTX01F RElBUVVFUllfTkFNRVNfRk9SX0VBQ0hfTUVESUFGRUFUVVJFKEFERF9UT19GVU5DVElPTk1BUCk7 CiAjdW5kZWYgQUREX1RPX0ZVTkNUSU9OTUFQCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20v bWFrZV9uYW1lcy5wbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1l cy5wbAkocmV2aXNpb24gMjAwMjM2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMu cGwJKHdvcmtpbmcgY29weSkKQEAgLTEyOTYsOSArMTI5Niw3IEBAIEVORAogICAgICAgICAgICAg JHVjVGFnID0gJGVuYWJsZWRUYWdzeyR0YWd9e0pTSW50ZXJmYWNlTmFtZX07CiAgICAgICAgIH0K IAotICAgICAgICAjIEZJWE1FIFJlbW92ZSB1bm5lY2Vzc2FyeSAnJicgZnJvbSB0aGUgZm9sbG93 aW5nIChwcmludCkgbGluZSBvbmNlIHdlIHN3aXRjaCB0byBhIG5vbi1icm9rZW4gVmlzdWFsIFN0 dWRpbyBjb21waWxlci4KLSAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIxMjM1OgotICAgICAgICBwcmludCBGICIgICAgICAgIHsgJHt0YWd9VGFnLCAm Y3JlYXRlJHt1Y1RhZ31XcmFwcGVyIH0sXG4iOworICAgICAgICBwcmludCBGICIgICAgICAgIHsg JHt0YWd9VGFnLCBjcmVhdGUke3VjVGFnfVdyYXBwZXIgfSxcbiI7CiAKICAgICAgICAgaWYgKCRj b25kaXRpb25hbCkgewogICAgICAgICAgICAgcHJpbnQgRiAiI2VuZGlmXG4iOwpJbmRleDogU291 cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcmNoaXZlL0FyY2hpdmVGYWN0b3J5LmNwcAkocmV2 aXNpb24gMjAwMjM2KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZh Y3RvcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCwxNCArNjQsMTIgQEAgc3RhdGljIEFyY2hp dmVNSU1FVHlwZXNNYXAmIGFyY2hpdmVNSU1FVAogICAgIGlmIChpbml0aWFsaXplZCkKICAgICAg ICAgcmV0dXJuIG1pbWVUeXBlczsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgdW5uZWNlc3Nhcnkg J3N0YXRpY19jYXN0PFJhd0RhdGFDcmVhdGlvbkZ1bmN0aW9uKj4nIGZyb20gdGhlIGZvbGxvd2lu ZyAnbWltZVR5cGVzLnNldCcgb3BlcmF0aW9ucwotICAgIC8vIG9uY2Ugd2Ugc3dpdGNoIHRvIGEg bm9uLWJyb2tlbiBWaXN1YWwgU3R1ZGlvIGNvbXBpbGVyLiAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMTIzNQogI2lmIEVOQUJMRShXRUJfQVJDSElWRSkgJiYgVVNF KENGKQotICAgIG1pbWVUeXBlcy5nZXQoKS5zZXQoImFwcGxpY2F0aW9uL3gtd2ViYXJjaGl2ZSIs IHN0YXRpY19jYXN0PFJhd0RhdGFDcmVhdGlvbkZ1bmN0aW9uKj4oJmFyY2hpdmVGYWN0b3J5Q3Jl YXRlPExlZ2FjeVdlYkFyY2hpdmU+KSk7CisgICAgbWltZVR5cGVzLmdldCgpLnNldCgiYXBwbGlj YXRpb24veC13ZWJhcmNoaXZlIiwgYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TGVnYWN5V2ViQXJjaGl2 ZT4pOwogI2VuZGlmCiAjaWYgRU5BQkxFKE1IVE1MKQotICAgIG1pbWVUeXBlcy5nZXQoKS5zZXQo Im11bHRpcGFydC9yZWxhdGVkIiwgc3RhdGljX2Nhc3Q8UmF3RGF0YUNyZWF0aW9uRnVuY3Rpb24q PigmYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TUhUTUxBcmNoaXZlPikpOwotICAgIG1pbWVUeXBlcy5n ZXQoKS5zZXQoImFwcGxpY2F0aW9uL3gtbWltZWFyY2hpdmUiLCBzdGF0aWNfY2FzdDxSYXdEYXRh Q3JlYXRpb25GdW5jdGlvbio+KCZhcmNoaXZlRmFjdG9yeUNyZWF0ZTxNSFRNTEFyY2hpdmU+KSk7 CisgICAgbWltZVR5cGVzLmdldCgpLnNldCgibXVsdGlwYXJ0L3JlbGF0ZWQiLCBhcmNoaXZlRmFj dG9yeUNyZWF0ZTxNSFRNTEFyY2hpdmU+KTsKKyAgICBtaW1lVHlwZXMuZ2V0KCkuc2V0KCJhcHBs aWNhdGlvbi94LW1pbWVhcmNoaXZlIiwgYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TUhUTUxBcmNoaXZl Pik7CiAjZW5kaWYKIAogICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdmcvU1ZHUGF0aERhdGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUGF0aERhdGEuY3BwCShyZXZpc2lvbiAyMDAyMzYpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1BhdGhEYXRhLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTU4LDEzICsxNTgsMTMgQEAgdm9pZCB1cGRhdGVQYXRoRnJvbUdyYXBoaWNzRWxl bWVudChTVkdFbAogICAgIHN0YXRpYyBIYXNoTWFwPEF0b21pY1N0cmluZ0ltcGwqLCBQYXRoVXBk YXRlRnVuY3Rpb24+KiBtYXAgPSAwOwogICAgIGlmICghbWFwKSB7CiAgICAgICAgIG1hcCA9IG5l dyBIYXNoTWFwPEF0b21pY1N0cmluZ0ltcGwqLCBQYXRoVXBkYXRlRnVuY3Rpb24+OwotICAgICAg ICBtYXAtPnNldChTVkdOYW1lczo6Y2lyY2xlVGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgJnVwZGF0 ZVBhdGhGcm9tQ2lyY2xlRWxlbWVudCk7Ci0gICAgICAgIG1hcC0+c2V0KFNWR05hbWVzOjplbGxp cHNlVGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgJnVwZGF0ZVBhdGhGcm9tRWxsaXBzZUVsZW1lbnQp OwotICAgICAgICBtYXAtPnNldChTVkdOYW1lczo6bGluZVRhZy5sb2NhbE5hbWUoKS5pbXBsKCks ICZ1cGRhdGVQYXRoRnJvbUxpbmVFbGVtZW50KTsKLSAgICAgICAgbWFwLT5zZXQoU1ZHTmFtZXM6 OnBhdGhUYWcubG9jYWxOYW1lKCkuaW1wbCgpLCAmdXBkYXRlUGF0aEZyb21QYXRoRWxlbWVudCk7 Ci0gICAgICAgIG1hcC0+c2V0KFNWR05hbWVzOjpwb2x5Z29uVGFnLmxvY2FsTmFtZSgpLmltcGwo KSwgJnVwZGF0ZVBhdGhGcm9tUG9seWdvbkVsZW1lbnQpOwotICAgICAgICBtYXAtPnNldChTVkdO YW1lczo6cG9seWxpbmVUYWcubG9jYWxOYW1lKCkuaW1wbCgpLCAmdXBkYXRlUGF0aEZyb21Qb2x5 bGluZUVsZW1lbnQpOwotICAgICAgICBtYXAtPnNldChTVkdOYW1lczo6cmVjdFRhZy5sb2NhbE5h bWUoKS5pbXBsKCksICZ1cGRhdGVQYXRoRnJvbVJlY3RFbGVtZW50KTsKKyAgICAgICAgbWFwLT5z ZXQoU1ZHTmFtZXM6OmNpcmNsZVRhZy5sb2NhbE5hbWUoKS5pbXBsKCksIHVwZGF0ZVBhdGhGcm9t Q2lyY2xlRWxlbWVudCk7CisgICAgICAgIG1hcC0+c2V0KFNWR05hbWVzOjplbGxpcHNlVGFnLmxv Y2FsTmFtZSgpLmltcGwoKSwgdXBkYXRlUGF0aEZyb21FbGxpcHNlRWxlbWVudCk7CisgICAgICAg IG1hcC0+c2V0KFNWR05hbWVzOjpsaW5lVGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgdXBkYXRlUGF0 aEZyb21MaW5lRWxlbWVudCk7CisgICAgICAgIG1hcC0+c2V0KFNWR05hbWVzOjpwYXRoVGFnLmxv Y2FsTmFtZSgpLmltcGwoKSwgdXBkYXRlUGF0aEZyb21QYXRoRWxlbWVudCk7CisgICAgICAgIG1h cC0+c2V0KFNWR05hbWVzOjpwb2x5Z29uVGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgdXBkYXRlUGF0 aEZyb21Qb2x5Z29uRWxlbWVudCk7CisgICAgICAgIG1hcC0+c2V0KFNWR05hbWVzOjpwb2x5bGlu ZVRhZy5sb2NhbE5hbWUoKS5pbXBsKCksIHVwZGF0ZVBhdGhGcm9tUG9seWxpbmVFbGVtZW50KTsK KyAgICAgICAgbWFwLT5zZXQoU1ZHTmFtZXM6OnJlY3RUYWcubG9jYWxOYW1lKCkuaW1wbCgpLCB1 cGRhdGVQYXRoRnJvbVJlY3RFbGVtZW50KTsKICAgICB9CiAKICAgICBpZiAoUGF0aFVwZGF0ZUZ1 bmN0aW9uIHBhdGhVcGRhdGVGdW5jdGlvbiA9IG1hcC0+Z2V0KGVsZW1lbnQtPmxvY2FsTmFtZSgp LmltcGwoKSkpCg==