121232 2013-09-12 10:06:14 -0700 If UI delegate abort window.close() then second window.close() is a no-op 2016-08-11 02:19:31 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows XP NEW P2 Normal --- 1 CEC49BC5-C186-483E-A513-9DF2DEEAE27E webkit-unassigned ap bfulgham pvollan oldest_to_newest 928359 0 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2013-09-12 10:06:14 -0700 In WebView::closeWindowSoon() (WebView.cpp) m_closeWindowTimer is set to a timer, unless it’s already non-zero, in which case the function immediately returns. Since m_closeWindowTimer is never set back to zero (even after the timer has fired), it means that if the HTML calls window.close() and the UI delegate decides not to dispose the web view, then any future call to window.close() will be a no-op. A fix is likely to let WebView::closeWindowTimerFired() set “m_closeWindowTimer = 0;” (WebView.cpp) 932606 1 ap 2013-09-24 10:03:06 -0700 Good catch. Allan, would you be willing to submit a patch with a fix? Please see <http://www.webkit.org/coding/contributing.html> for some pointers and guidelines. Changing platform from Mac to Windows, as the quoted code is in Windows WebKit. 935378 2 213159 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2013-10-02 03:18:16 -0700 Created attachment 213159 Fix missing zeroing of timer 935379 3 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2013-10-02 03:20:18 -0700 It should be a one line change which I attached a patch for. I didn’t do any changelog, run tests, etc. as I do not have a build environment for WebKit. I ran into the issue working with the system’s standard WebView on OS X 10.8.4 and read through the source of WebKit to figure out why it didn’t behave as expected. 935380 4 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2013-10-02 03:24:08 -0700 Disregard that patch, it leaks the timer. Will update. 935383 5 213161 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2013-10-02 03:30:28 -0700 Created attachment 213161 Fix missing zeroing of timer (2) This deletes the timer and replaces the previous patch. 1219097 6 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2016-08-10 13:17:55 -0700 Bump 1219117 7 ap 2016-08-10 14:00:43 -0700 The patch is not marked for review, and doesn't have a ChangeLog. While we are grateful for a contribution in any form, following the normal process can make it move faster. 1219287 8 CEC49BC5-C186-483E-A513-9DF2DEEAE27E 2016-08-11 02:19:31 -0700 As I am unfamiliar with your normal process and does not have a WebKit build environment (the patch was submitted only because it was requested from me), I would be grateful if someone else can follow the required steps to get this bug fixed. 213159 2013-10-02 03:18:16 -0700 2013-10-02 03:18:16 -0700 Fix missing zeroing of timer WebView.patch text/plain 340 CEC49BC5-C186-483E-A513-9DF2DEEAE27E SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNTU1MjUpCisrKyBTb3VyY2UvV2Vi S2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI3Niw2ICsxMjc2LDcgQEAK IAogdm9pZCBXZWJWaWV3OjpjbG9zZVdpbmRvd1RpbWVyRmlyZWQoKQogeworICAgIG1fY2xvc2VX aW5kb3dUaW1lciA9IDA7CiAgICAgY2xvc2VXaW5kb3coKTsKICAgICBSZWxlYXNlKCk7CiB9Cg== 213161 2013-10-02 03:30:28 -0700 2013-10-02 03:30:28 -0700 Fix missing zeroing of timer (2) webkit.patch text/plain 372 CEC49BC5-C186-483E-A513-9DF2DEEAE27E SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNTU1MjUpCisrKyBTb3VyY2UvV2Vi S2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI3Niw2ICsxMjc2LDggQEAK IAogdm9pZCBXZWJWaWV3OjpjbG9zZVdpbmRvd1RpbWVyRmlyZWQoKQogeworICAgIGRlbGV0ZSBt X2Nsb3NlV2luZG93VGltZXI7CisgICAgbV9jbG9zZVdpbmRvd1RpbWVyID0gMDsKICAgICBjbG9z ZVdpbmRvdygpOwogICAgIFJlbGVhc2UoKTsKIH0K