121218 2013-09-12 02:00:12 -0700 [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped 2013-09-12 03:53:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 928195 0 cgarcia 2013-09-12 02:00:12 -0700 It simply does nothing. This is because skipping the entire suite was added to skip tests when they can't be run because of the environment, for example to skip the a11y tests when the at-spi daemons fail to start. However, some tests have been skipped entirely lately because they fail or timeout under xvfb, but the script now allows to run tests without xvfb. I think we should disable tests that are impossible to run because of the environment instead of skipping them, and make skip options work with all skipped tests. 928196 1 211408 cgarcia 2013-09-12 02:05:12 -0700 Created attachment 211408 Patch 928233 2 cgarcia 2013-09-12 03:53:57 -0700 Committed r155605: <http://trac.webkit.org/changeset/155605> 211408 2013-09-12 02:05:12 -0700 2013-09-12 03:34:57 -0700 Patch run-gtk-tests-disabled.diff text/plain 3212 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMDQ3 OTM4Li44NzVhN2E2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTMtMDktMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHMgb3B0 aW9uIC0tc2tpcHBlZD1pZ25vcmUgZG9lc24ndCB3b3JrIHdoZW4gdGhlIGVudGlyZSBzdWl0ZSBp cyBza2lwcGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjEyMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTa2lwcGluZyB0aGUgZW50aXJlIHN1aXRlIHdhcyBhZGRlZCB0byBza2lwIHRlc3RzIHdoZW4g dGhleSBjYW4ndAorICAgICAgICBiZSBydW4gYmVjYXVzZSBvZiB0aGUgZW52aXJvbm1lbnQsIGZv ciBleGFtcGxlIHRvIHNraXAgdGhlIGExMXkKKyAgICAgICAgdGVzdHMgd2hlbiB0aGUgYXQtc3Bp IGRhZW1vbnMgZmFpbCB0byBzdGFydC4gVGhpcyBpcyBubyBsb25nZXIKKyAgICAgICAgdHJ1ZSBm b3IgYWxsIHRoZSBjYXNlcywgc28gd2UgY2FuIGRpc2FibGUgdGhlIHRlc3RzIHRoYXQgYXJlCisg ICAgICAgIGltcG9zc2libGUgdG8gcnVuIGluc3RlYWQgb2Ygc2tpcHBpbmcgdGhlbS4KKworICAg ICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIuX19pbml0 X18pOiBJbml0aWFsaXplIHRoZSBza2lwcGVkIHRlc3RzIGxpc3QuCisgICAgICAgIChUZXN0UnVu bmVyLl9zZXR1cF90ZXN0aW5nX2Vudmlyb25tZW50KTogQWRkCisgICAgICAgIFRlc3RXZWJLaXRB Y2Nlc3NpYmlsaXR5IHBhdGggdG8gdGhlIGxpc3Qgb2YgZGlzYWJsZWQgdGVzdHMgd2hlbgorICAg ICAgICBhdC1zcGkgZGFlbW9uIGZhaWwgdG8gc3RhcnQuCisgICAgICAgIChUZXN0UnVubmVyLl9z aG91bGRfcnVuX3Rlc3RfcHJvZ3JhbSk6IENoZWNrIGZpcnN0IGlmIHRoZSB0ZXN0CisgICAgICAg IHByb2dyYW0gaXMgZGlzYWJsZWQgYW5kIHRoZW4gd2hldGhlciBpdCdzIHNraXBwZWQgaG9ub3Jp bmcgdGhlCisgICAgICAgIHNraXBwZWQgY29tbWFuZCBsaW5lIG9wdGlvbi4KKwogMjAxMy0wOS0x MSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jb20+ CiAKICAgICAgICAgW0dUS10gTW92ZSB0byB0aGUgbmV3IHdlYiBpbnNwZWN0b3IKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10 ZXN0cwppbmRleCAxZDI5ZThhLi5kY2MyODYyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC05Miw2ICs5 Miw3IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAgICAgICAgIHNlbGYuX3Byb2dyYW1zX3BhdGggPSBj b21tb24uYnVpbGRfcGF0aF9mb3JfYnVpbGRfdHlwZXMoKHNlbGYuX2J1aWxkX3R5cGUsKSwgIlBy b2dyYW1zIikKICAgICAgICAgc2VsZi5fdGVzdHMgPSBzZWxmLl9nZXRfdGVzdHModGVzdHMpCiAg ICAgICAgIHNlbGYuX3NraXBwZWRfdGVzdHMgPSBUZXN0UnVubmVyLlNLSVBQRUQKKyAgICAgICAg c2VsZi5fZGlzYWJsZWRfdGVzdHMgPSBbXQogICAgICAgICBpZiBub3Qgc3lzLnN0ZG91dC5pc2F0 dHkoKToKICAgICAgICAgICAgIHNlbGYuX3R0eV9jb2xvcnNfcGF0dGVybiA9IHJlLmNvbXBpbGUo IlwwMzNcW1swLTk7XSptIikKIApAQCAtMTk3LDggKzE5OCw4IEBAIGNsYXNzIFRlc3RSdW5uZXI6 CiAKICAgICAgICAgIyBJZiB3ZSBjYW5ub3Qgc3RhcnQgdGhlIGFjY2Vzc2liaWxpdHkgZGFlbW9u cywgd2UgY2FuIGp1c3Qgc2tpcCB0aGUgYWNjZXNzaWJpbGl0eSB0ZXN0cy4KICAgICAgICAgaWYg bm90IHNlbGYuX3N0YXJ0X2FjY2Vzc2liaWxpdHlfZGFlbW9ucygpOgotICAgICAgICAgICAgcHJp bnQgIkNvdWxkIG5vdCBzdGFydCBhY2Nlc3NpYmlsaXR5IGJ1cywgc28gc2tpcHBpbmcgVGVzdFdl YktpdEFjY2Vzc2liaWxpdHkiCi0gICAgICAgICAgICBzZWxmLl9za2lwcGVkX3Rlc3RzLmFwcGVu ZChTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RXZWJLaXRBY2Nlc3NpYmlsaXR5Iiwg U2tpcHBlZFRlc3QuRU5USVJFX1NVSVRFLCAiQ291bGQgbm90IHN0YXJ0IGFjY2Vzc2liaWxpdHkg YnVzIikpCisgICAgICAgICAgICBwcmludCAiQ291bGQgbm90IHN0YXJ0IGFjY2Vzc2liaWxpdHkg YnVzLCBzbyBkaXNhYmxpbmcgVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkiCisgICAgICAgICAgICBz ZWxmLl9kaXNhYmxlZF90ZXN0cy5hcHBlbmQoIldlYktpdDJBUElUZXN0cy9UZXN0V2ViS2l0QWNj ZXNzaWJpbGl0eSIpCiAgICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgX3RlYXJfZG93bl90 ZXN0aW5nX2Vudmlyb25tZW50KHNlbGYpOgpAQCAtMjIwLDggKzIyMSwxMyBAQCBjbGFzcyBUZXN0 UnVubmVyOgogICAgICAgICByZXR1cm4gdGVzdF9jYXNlcwogCiAgICAgZGVmIF9zaG91bGRfcnVu X3Rlc3RfcHJvZ3JhbShzZWxmLCB0ZXN0X3Byb2dyYW0pOgotICAgICAgICAjIFRoaXMgaXMgbm90 IGFmZmVjdGVkIGJ5IHRoZSBjb21tYW5kLWxpbmUgYXJndW1lbnRzLCBzaW5jZSBwcm9ncmFtcyBh cmUgc2tpcHBlZCBmb3IKLSAgICAgICAgIyBwcm9ibGVtcyBpbiB0aGUgaGFybmVzcywgc3VjaCBh cyBmYWlsaW5nIHRvIHN0YXJ0IHRoZSBhY2Nlc3NpYmlsaXR5IGJ1cy4KKyAgICAgICAgZm9yIGRp c2FibGVkX3Rlc3QgaW4gc2VsZi5fZGlzYWJsZWRfdGVzdHM6CisgICAgICAgICAgICBpZiB0ZXN0 X3Byb2dyYW0uZW5kc3dpdGgoZGlzYWJsZWRfdGVzdCk6CisgICAgICAgICAgICAgICAgcmV0dXJu IEZhbHNlCisKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5za2lwcGVkX2FjdGlvbiAhPSAnc2tp cCc6CisgICAgICAgICAgICByZXR1cm4gVHJ1ZQorCiAgICAgICAgIGZvciBza2lwcGVkIGluIHNl bGYuX3NraXBwZWRfdGVzdHM6CiAgICAgICAgICAgICBpZiB0ZXN0X3Byb2dyYW0uZW5kc3dpdGgo c2tpcHBlZC50ZXN0KSBhbmQgc2tpcHBlZC5za2lwX2VudGlyZV9zdWl0ZSgpOgogICAgICAgICAg ICAgICAgIHJldHVybiBGYWxzZQo=