121215 2013-09-11 23:52:55 -0700 [mac] Check For Framework Include Consistency build phase checks the wrong framework 2013-09-14 14:35:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 121216 1 mitz webkit-unassigned buildbot mrowe rniwa oldest_to_newest 928176 0 mitz 2013-09-11 23:52:55 -0700 The Check For Framework Include Consistency build phase invokes check-for-webkit-framework-include-consistency, which is hard-coded to check WebKit.framework rather than the target’s build product. 928180 1 211405 mitz 2013-09-12 00:00:13 -0700 Created attachment 211405 Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework 928181 2 mitz 2013-09-12 00:01:19 -0700 Note: this can’t be landed as-is until bug 121216 is fixed. 928184 3 211405 buildbot 2013-09-12 00:21:53 -0700 Comment on attachment 211405 Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework Attachment 211405 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1856048 928187 4 211405 buildbot 2013-09-12 00:40:41 -0700 Comment on attachment 211405 Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework Attachment 211405 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1843048 929305 5 mitz 2013-09-14 14:35:12 -0700 Fixed in <http://trac.webkit.org/r155788>. 211405 2013-09-12 00:00:13 -0700 2013-09-12 00:40:41 -0700 Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework 121215_r1.diff text/plain 2496 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTU5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA5LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgW21hY10gQ2hlY2sgRm9yIEZyYW1ld29yayBJbmNsdWRlIENvbnNpc3RlbmN5IGJ1 aWxkIHBoYXNlIGNoZWNrcyB0aGUgd3JvbmcgZnJhbWV3b3JrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyMTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvY2hlY2stZm9yLXdlYmtpdC1m cmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeTogUmVwbGFjZWQgaGFyZC1jb2RlZCBwYXRocyB0 bworICAgICAgICBXZWJLaXQuZnJhbWV3b3Jr4oCZcyBIZWFkZXJzIGFuZCBQcml2YXRlSGVhZGVy cyBkaXJlY3RvcmllcyB3aXRoIHRoZSBjdXJyZW50IHRhcmdldOKAmXMKKyAgICAgICAgcHVibGlj IGFuZCBwcml2YXRlIGhlYWRlcnMgZm9sZGVyIHBhdGhzLiBBbHNvIHR3ZWFrZWQgdGhlIGVycm9y IG1lc3NhZ2Vz4oCZIGZvcm1hdCB0byBtYWtlCisgICAgICAgIFhjb2RlIHJlY29nbml6ZSB0aGVt IGFzIGVycm9ycy4KKwogMjAxMy0wOS0xMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIFRyeSB0byBmaXggR0NDIGJ1aWxkcy4KSW5kZXg6IFRvb2xzL1Nj cmlwdHMvY2hlY2stZm9yLXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2NoZWNrLWZvci13ZWJraXQtZnJhbWV3b3JrLWluY2x1 ZGUtY29uc2lzdGVuY3kJKHJldmlzaW9uIDE1NTU5NSkKKysrIFRvb2xzL1NjcmlwdHMvY2hlY2st Zm9yLXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQkod29ya2luZyBjb3B5KQpA QCAtMSw2ICsxLDYgQEAKICMhL3Vzci9iaW4vZW52IHJ1YnkKIAotIyBDb3B5cmlnaHQgKEMpIDIw MTAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTAs IDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMg bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCkBAIC0yNSw3ICsyNSw2IEBACiAKIAogYmFzZV9kaXJlY3RvcnkgPSBFTlZbJ1RB UkdFVF9CVUlMRF9ESVInXSBvciB0aHJvdyAiVW5hYmxlIHRvIGZpbmQgVEFSR0VUX0JVSUxEX0RJ UiBpbiB0aGUgZW52aXJvbm1lbnQhIgotaXNfc2hhbGxvd19idW5kbGUgPSAoRU5WWydTSEFMTE9X X0JVTkRMRSddIHx8ICJOTyIpLnVwY2FzZSA9PSAiWUVTIgogCiBEaXIuY2hkaXIgYmFzZV9kaXJl Y3RvcnkKIApAQCAtMzgsMTIgKzM3LDExIEBAICRlcnJvcl9wcmludGVkID0gZmFsc2UKIAogZGVm IHByaW50X2Vycm9yIG1zZwogICAkZXJyb3JfcHJpbnRlZCA9IHRydWUKLSAgU1RERVJSLnB1dHMg IkVSUk9SOiAje21zZ30iCisgIFNUREVSUi5wdXRzICJlcnJvcjogI3ttc2d9IgogZW5kCiAKLWRl ZiBidWlsZF9oZWFkZXJfbWFwcyBpc19zaGFsbG93X2J1bmRsZQotICBjdXJyZW50X3ZlcnNpb25f cGF0aCA9IGlzX3NoYWxsb3dfYnVuZGxlID8gIiIgOiAiVmVyc2lvbnMvQS8iCi0gIGFsbF9oZWFk ZXJzID0gYGZpbmQgV2ViS2l0LmZyYW1ld29yay8je2N1cnJlbnRfdmVyc2lvbl9wYXRofXssUHJp dmF0ZX1IZWFkZXJzIC10eXBlIGYgLW5hbWUgJyouaCdgLnNwbGl0CitkZWYgYnVpbGRfaGVhZGVy X21hcHMKKyAgYWxsX2hlYWRlcnMgPSBgZmluZCAje0VOVlsnUFVCTElDX0hFQURFUlNfRk9MREVS X1BBVEgnXX0gI3tFTlZbJ1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSCddfSAtdHlwZSBmIC1u YW1lICcqLmgnYC5zcGxpdAogCiAgIGFsbF9oZWFkZXJzLmVhY2ggZG8gfGhlYWRlcnwKICAgICBp ZiAvXC9IZWFkZXJzXC8oLiopLy5tYXRjaChoZWFkZXIpCkBAIC05Miw3ICs5MCw3IEBAIGRlZiB2 ZXJpZnlfaW5jbHVkZXMoaGVhZGVyLCBwZXJtaXR0ZWRfdHkKICAgZW5kCiBlbmQKIAotYnVpbGRf aGVhZGVyX21hcHMgaXNfc2hhbGxvd19idW5kbGUKK2J1aWxkX2hlYWRlcl9tYXBzCiAKICRIRUFE RVJTX0JZX1RZUEUuZWFjaCBkbyB8aGVhZGVyX3R5cGUsIGhlYWRlcnN8CiAgIHBlcm1pdHRlZF90 eXBlcyA9ICRQRVJNSVRURURfSU5DTFVERV9UWVBFU1toZWFkZXJfdHlwZV0K