<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>121189</bug_id>
          
          <creation_ts>2013-09-11 16:02:06 -0700</creation_ts>
          <short_desc>check-webkit-style complains about &quot;int&quot; bitfield types.</short_desc>
          <delta_ts>2013-09-12 09:53:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>ASSIGNED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Saboff">msaboff</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>ap</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>928026</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-09-11 16:02:06 -0700</bug_when>
    <thetext>in Tools/Scripts/webkitpy/style/checkers/cpp.py around line 3110, we check to see whether a bitfield is declared with signed, unsigned or bool.  The check is done by looking for all the other types.

    # Check for plain bitfields declared without either &quot;singed&quot; or &quot;unsigned&quot;.
    # Most compilers treat such bitfields as signed, but there are still compilers like
    # RVCT 4.0 that use unsigned by default.
    matched = re.match(r&apos;\s*((const|mutable)\s+)?(char|(short(\s+int)?)|int|long(\s+(long|int))?)\s+[a-zA-Z_][a-zA-Z0-9_]*\s*:\s*\d+\s*;&apos;, line)

It seems a little strange that short, int and long types are on the &quot;bad&quot; list as these are clearly signed values.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>928352</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-09-12 09:53:11 -0700</bug_when>
    <thetext>It sounds like the comment before the check says that int is not necessarily signed when in bitfield.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>