121184 2013-09-11 14:54:11 -0700 REGRESSION (r155561): extract-localizable-strings can miss strings 2013-09-11 15:06:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 mitz webkit-unassigned commit-queue darin mrowe oldest_to_newest 927991 0 211355 mitz 2013-09-11 14:54:11 -0700 Created attachment 211355 Don’t discard lines while waiting for ) or ] I didn’t notice that I’d introduced this bug because it doesn’t affect any of the files update-webkit-localizable-strings processes. 927995 1 commit-queue 2013-09-11 15:05:20 -0700 Attachment 211355 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/extract-localizable-strings']" exit_code: 1 Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 927997 2 mitz 2013-09-11 15:06:32 -0700 Fixed in <http://trac.webkit.org/r155568>. 211355 2013-09-11 14:54:11 -0700 2013-09-11 15:03:56 -0700 Don’t discard lines while waiting for ) or ] fix-r155561-regression.diff text/plain 1121 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTU2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEzLTA5LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgRml4ZWQgYSByZWdyZXNzaW9uIGZyb20gcjE1NTU2MS4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvZXh0cmFjdC1sb2Nh bGl6YWJsZS1zdHJpbmdzOiBEb27igJl0IGRpc2NhcmQgbGluZXMgaWYgd2UgYXJlIHdhaXRpbmcg Zm9yIGEgY2xvc2luZworICAgICAgICBwYXJlbnRoZXNpcyBvciBicmFja2V0LgorCiAyMDEzLTA5 LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgdXBkYXRlLXdl YmtpdC1sb2NhbGl6YWJsZS1zdHJpbmdzIGlzIGF0IGxlYXN0IDUuOHggc2xvd2VyIHRoYW4gaXQg c2hvdWxkIGJlCkluZGV4OiBUb29scy9TY3JpcHRzL2V4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5n cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2V4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5n cwkocmV2aXNpb24gMTU1NTYxKQorKysgVG9vbHMvU2NyaXB0cy9leHRyYWN0LWxvY2FsaXphYmxl LXN0cmluZ3MJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw3ICsxNDUsNyBAQCBmb3IgbXkgJGZpbGUg KHNvcnQgQGZpbGVzKSB7CiAgICAgICAgICAgICAkaW5Db21tZW50ID0gMDsKICAgICAgICAgfQog Ci0gICAgICAgIG5leHQgdW5sZXNzIC8oXCJ8XC9cKikvOworICAgICAgICBuZXh0IHVubGVzcyBk ZWZpbmVkICRuZXN0aW5nTGV2ZWwgb3IgLyhcInxcL1wqKS87CiAgICAgCiAgICAgICAgICMgSGFu ZGxlIGFsbCB0aGUgdG9rZW5zIGluIHRoZSBsaW5lLgogICAgICAgICB3aGlsZSAocy1eXHMqKFsj XHddK3wvXCp8Ly98W14jXHcvJyIoKVxbXF0sXSt8LiktLSkgewo=