121178 2013-09-11 12:43:08 -0700 update-webkit-localizable-strings is at least 5.8x slower than it should be 2013-09-11 14:02:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz darin jberlin mrowe oldest_to_newest 927935 0 mitz 2013-09-11 12:43:08 -0700 update-webkit-localizable-strings is at least 5.8x slower than it should be 927940 1 211342 mitz 2013-09-11 12:59:53 -0700 Created attachment 211342 Make update-webkit-localizable-strings 5.8x faster 927969 2 darin 2013-09-11 13:56:39 -0700 There are lots of tricks to make regular expressions faster in perl. For example, I think non-capturing parentheses are faster, and maybe two separate regular expressions might be faster than then using “|”. 927970 3 mitz 2013-09-11 14:02:14 -0700 Fixed in <http://trac.webkit.org/r155561>. 211342 2013-09-11 12:59:53 -0700 2013-09-11 13:55:28 -0700 Make update-webkit-localizable-strings 5.8x faster bug-121178-20130911125958.patch text/plain 1341 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTU1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTA5LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgdXBkYXRlLXdlYmtpdC1sb2NhbGl6YWJsZS1zdHJpbmdzIGlzIGF0IGxlYXN0IDUu OHggc2xvd2VyIHRoYW4gaXQgc2hvdWxkIGJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjExNzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvZXh0cmFjdC1sb2NhbGl6YWJsZS1zdHJpbmdz OiBRdWlja2x5IHNraXAgb3ZlciBsaW5lcyB0aGF0IGNvbnRhaW4gbmVpdGhlciAiIG5vciAvKi4K KyAgICAgICAgTm90ZSB0aGF0IHRoaXMgZG9lcyBub3QgY2hhbmdlIGZ1bmN0aW9uYWxpdHksIGJl Y2F1c2UgdGhlIHNjcmlwdCBhbHJlYWR5IGRvZXMgbm90IHVuZGVyc3RhbmQKKyAgICAgICAgdGhl IGxpbmUgY29udGludWF0aW9uIHNlcXVlbmNlIChiYWNrc2xhc2ggZm9sbG93ZWQgYnkgYSBuZXds aW5lKS4KKwogMjAxMy0wOS0xMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIFZlY3Rvcjo6YXBwZW5kIGRvZXNuJ3Qgd29yayBpZiBlbGVtZW50IHR5cGUg aGFzIG92ZXJsb2FkZWQgb3BlcmF0b3ImCkluZGV4OiBUb29scy9TY3JpcHRzL2V4dHJhY3QtbG9j YWxpemFibGUtc3RyaW5ncwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2V4dHJhY3QtbG9j YWxpemFibGUtc3RyaW5ncwkocmV2aXNpb24gMTU1MTIzKQorKysgVG9vbHMvU2NyaXB0cy9leHRy YWN0LWxvY2FsaXphYmxlLXN0cmluZ3MJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw2ICsxNDQsOCBA QCBmb3IgbXkgJGZpbGUgKHNvcnQgQGZpbGVzKSB7CiAgICAgICAgICAgICBuZXh0IHVubGVzcyBz LS4qXCovLS07CiAgICAgICAgICAgICAkaW5Db21tZW50ID0gMDsKICAgICAgICAgfQorCisgICAg ICAgIG5leHQgdW5sZXNzIC8oXCJ8XC9cKikvOwogICAgIAogICAgICAgICAjIEhhbmRsZSBhbGwg dGhlIHRva2VucyBpbiB0aGUgbGluZS4KICAgICAgICAgd2hpbGUgKHMtXlxzKihbI1x3XSt8L1wq fC8vfFteI1x3LyciKClcW1xdLF0rfC4pLS0pIHsK