121176 2013-09-11 12:19:42 -0700 HTMLEntityTable could use char to reduce binary size 2013-09-11 13:45:55 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser rniwa andersca commit-queue esprehn+autocc rniwa oldest_to_newest 927924 0 simon.fraser 2013-09-11 12:19:42 -0700 static const UChar zwnjSemicolonEntityName[] = {'z', 'w', 'n', 'j', ';'}; static const HTMLEntityTableEntry staticEntityTable[2231] = { { AEligEntityName, 5, 0x000C6, 0 }, Pretty sure we could use char to save space. Symbols says: 0x0000000000eada30 ( 0xd130) WebCore::(anonymous namespace)::staticEntityTable [NameNList, MangledNameNList, NList] 0x0000000000d6cc30 ( 0xa) WebCore::(anonymous namespace)::AEligEntityName [NameNList, MangledNameNList, NList] etc. 927931 1 rniwa 2013-09-11 12:32:37 -0700 Let's fix this. 927933 2 211340 rniwa 2013-09-11 12:41:30 -0700 Created attachment 211340 Fixes the bug 927963 3 rniwa 2013-09-11 13:45:55 -0700 Committed r155559: <http://trac.webkit.org/changeset/155559> 211340 2013-09-11 12:41:30 -0700 2013-09-11 12:42:40 -0700 Fixes the bug bug-121176-20130911124130.patch text/plain 3484 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTU1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEhUTUxFbnRpdHlUYWJsZSBjb3Vs ZCB1c2UgY2hhciB0byByZWR1Y2UgYmluYXJ5IHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTE3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBMQ2hhciBpbnN0ZWFkLgorCisgICAgICAgICog aHRtbC9wYXJzZXIvSFRNTEVudGl0eVBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M RW50aXR5UGFyc2VyOjpjb25zdW1lTmFtZWRFbnRpdHkpOgorICAgICAgICAqIGh0bWwvcGFyc2Vy L0hUTUxFbnRpdHlUYWJsZS5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVudGl0eVRhYmxlRW50 cnk6Omxhc3RDaGFyYWN0ZXIpOgorICAgICAgICAqIGh0bWwvcGFyc2VyL2NyZWF0ZS1odG1sLWVu dGl0eS10YWJsZToKKwogMjAxMy0wOS0xMSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBuZXN0ZWQgdW5pY29kZS1iaWRpOiBpc29sYXRlCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRW50aXR5UGFyc2VyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRW50aXR5UGFyc2VyLmNw cAkocmV2aXNpb24gMTU1NTQ5KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVu dGl0eVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMCw3ICsxMDAsNyBAQCBwdWJsaWM6 CiAgICAgICAgICAgICB1bmNvbnN1bWVDaGFyYWN0ZXJzKHNvdXJjZSwgY29uc3VtZWRDaGFyYWN0 ZXJzKTsKICAgICAgICAgICAgIGNvbnN1bWVkQ2hhcmFjdGVycy5jbGVhcigpOwogICAgICAgICAg ICAgY29uc3QgaW50IGxlbmd0aCA9IGVudGl0eVNlYXJjaC5tb3N0UmVjZW50TWF0Y2goKS0+bGVu Z3RoOwotICAgICAgICAgICAgY29uc3QgVUNoYXIqIHJlZmVyZW5jZSA9IGVudGl0eVNlYXJjaC5t b3N0UmVjZW50TWF0Y2goKS0+ZW50aXR5OworICAgICAgICAgICAgY29uc3QgTENoYXIqIHJlZmVy ZW5jZSA9IGVudGl0eVNlYXJjaC5tb3N0UmVjZW50TWF0Y2goKS0+ZW50aXR5OwogICAgICAgICAg ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICAgICAgICAgIGNj ID0gc291cmNlLmN1cnJlbnRDaGFyKCk7CiAgICAgICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChy ZWZlcmVuY2UsIGNjID09ICpyZWZlcmVuY2UrKyk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MRW50aXR5VGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MRW50aXR5VGFibGUuaAkocmV2aXNpb24gMTU1NTQ5KQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVudGl0eVRhYmxlLmgJKHdvcmtpbmcgY29weSkKQEAg LTMxLDkgKzMxLDkgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RydWN0IEhUTUxFbnRpdHlU YWJsZUVudHJ5IHsKLSAgICBVQ2hhciBsYXN0Q2hhcmFjdGVyKCkgY29uc3QgeyByZXR1cm4gZW50 aXR5W2xlbmd0aCAtIDFdOyB9CisgICAgTENoYXIgbGFzdENoYXJhY3RlcigpIGNvbnN0IHsgcmV0 dXJuIGVudGl0eVtsZW5ndGggLSAxXTsgfQogCi0gICAgY29uc3QgVUNoYXIqIGVudGl0eTsKKyAg ICBjb25zdCBMQ2hhciogZW50aXR5OwogICAgIGludCBsZW5ndGg7CiAgICAgVUNoYXIzMiBmaXJz dFZhbHVlOwogICAgIFVDaGFyMzIgc2Vjb25kVmFsdWU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9jcmVhdGUtaHRtbC1lbnRpdHktdGFibGUKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvaHRtbC9wYXJzZXIvY3JlYXRlLWh0bWwtZW50aXR5LXRhYmxlCShyZXZpc2lvbiAx NTU1NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9jcmVhdGUtaHRtbC1lbnRpdHkt dGFibGUJKHdvcmtpbmcgY29weSkKQEAgLTQyLDEwICs0Miw2IEBAIGRlZiBjb252ZXJ0X2VudGl0 eV90b19jcHBfbmFtZShlbnRpdHkpOgogICAgIHJldHVybiAiJXMlcyIgJSAoZW50aXR5LCBwb3N0 Zml4KQogCiAKLWRlZiBjb252ZXJ0X2VudGl0eV90b191Y2hhcl9hcnJheShlbnRpdHkpOgotICAg IHJldHVybiAieyclcyd9IiAlICInLCAnIi5qb2luKGVudGl0eSkKLQotCiBkZWYgY29udmVydF92 YWx1ZV90b19pbnQodmFsdWUpOgogICAgIGlmIG5vdCB2YWx1ZToKICAgICAgICAgcmV0dXJuICIw IjsKQEAgLTc4LDYgKzc0LDcgQEAgb3V0cHV0X2ZpbGUgPSBvcGVuKG91dHB1dF9wYXRoLCAidyIp CiAKIG91dHB1dF9maWxlLndyaXRlKCIiIi8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xl LCBJbmMuIEFsbCBSaWdodHMgUmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMgQXBwbGUg SW5jLiBBbGwgUmlnaHRzIFJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC0xMTMsOSArMTEwLDcgQEAgbmFtZXNwYWNlIHsKICIiIikKIAogZm9yIGVudHJ5IGluIGVu dHJpZXM6Ci0gICAgb3V0cHV0X2ZpbGUud3JpdGUoInN0YXRpYyBjb25zdCBVQ2hhciAlc1tdID0g JXM7XG4iICUgKAotICAgICAgICBjb252ZXJ0X2VudGl0eV90b19jcHBfbmFtZShlbnRyeVtFTlRJ VFldKSwKLSAgICAgICAgY29udmVydF9lbnRpdHlfdG9fdWNoYXJfYXJyYXkoZW50cnlbRU5USVRZ XSkpKQorICAgIG91dHB1dF9maWxlLndyaXRlKCJzdGF0aWMgY29uc3QgTENoYXIgJXNbXSA9IFwi JXNcIjtcbiIgJSAoY29udmVydF9lbnRpdHlfdG9fY3BwX25hbWUoZW50cnlbRU5USVRZXSksIGVu dHJ5W0VOVElUWV0pKQogCiBvdXRwdXRfZmlsZS53cml0ZSgiIiIKIHN0YXRpYyBjb25zdCBIVE1M RW50aXR5VGFibGVFbnRyeSBzdGF0aWNFbnRpdHlUYWJsZVslc10gPSB7XG4iIiIgJSBlbnRpdHlf Y291bnQpCg==