121175 2013-09-11 12:02:03 -0700 Vector::append doesn't work if element type has overloaded operator& 2013-09-24 14:48:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 927909 0 andersca 2013-09-11 12:02:03 -0700 Vector::append doesn't work if element type has overloaded operator& 927910 1 211339 andersca 2013-09-11 12:03:24 -0700 Created attachment 211339 Patch 927915 2 211339 bfulgham 2013-09-11 12:05:59 -0700 Comment on attachment 211339 Patch Wow! Nice fix. r=me. 928010 3 211339 darin 2013-09-11 15:16:41 -0700 Comment on attachment 211339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211339&action=review > Source/WTF/ChangeLog:12 > + (WTF::::appendSlowCase): > + (WTF::::uncheckedAppend): Lame prepare-ChangeLog script left out Vector. 932731 4 andersca 2013-09-24 14:48:24 -0700 This was landed. 211339 2013-09-11 12:03:24 -0700 2013-09-11 15:16:41 -0700 Patch bug-121175-20130911120324.patch text/plain 2991 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1NTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhiOGQwOGZhNGQyMTYzMzQ5ZjczNGVh OTI3YTViMzRjYmUwZDYyMmYuLmVjNDRkZGY2ZGE1MGI5MTFkMzRlNTk4NGU1ZTI2ZGFlMmY3MTA2 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTMtMDktMTEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBWZWN0b3I6OmFwcGVuZCBkb2Vzbid0IHdvcmsg aWYgZWxlbWVudCB0eXBlIGhhcyBvdmVybG9hZGVkIG9wZXJhdG9yJgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMTc1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHN0ZDo6YWRkcmVzc29mIHRvIGdl dCB0aGUgYWRkcmVzcyBvZiB0aGUgZ2l2ZW4gb2JqZWN0LgorCisgICAgICAgICogd3RmL1ZlY3Rv ci5oOgorICAgICAgICAoV1RGOjo6OmFwcGVuZFNsb3dDYXNlKToKKyAgICAgICAgKFdURjo6Ojp1 bmNoZWNrZWRBcHBlbmQpOgorCisyMDEzLTA5LTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CisKICAgICAgICAgVmVjdG9yQnVmZmVyOjpzd2FwIGRvZXNuJ3QgbmVlZCB0 byB1c2Ugc3RkOjpzd2FwX3JhbmdlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIxMTY0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1ZlY3Rv ci5oIGIvU291cmNlL1dURi93dGYvVmVjdG9yLmgKaW5kZXggYjZiZmJlMDc3ZGRjZmJmYTEwOTU5 NDkwMmIyYTliOTRkMmQ4OTY2Yi4uM2YwZDQ1NGExMzQyNGEyZGM3NmE4MzdlMTNjZThkY2I5ZDg3 ZDQ0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVmVjdG9yLmgKKysrIGIvU291cmNlL1dU Ri93dGYvVmVjdG9yLmgKQEAgLTEwNTMsNyArMTA1Myw3IEBAIHZvaWQgVmVjdG9yPFQsIGlubGlu ZUNhcGFjaXR5LCBPdmVyZmxvd0hhbmRsZXI+OjphcHBlbmRTbG93Q2FzZShVJiYgdmFsdWUpCiB7 CiAgICAgQVNTRVJUKHNpemUoKSA9PSBjYXBhY2l0eSgpKTsKIAotICAgIGF1dG8gcHRyID0gJnZh bHVlOworICAgIGF1dG8gcHRyID0gc3RkOjphZGRyZXNzb2YodmFsdWUpOwogICAgIHB0ciA9IGV4 cGFuZENhcGFjaXR5KHNpemUoKSArIDEsIHB0cik7CiAgICAgaWYgKCFiZWdpbigpKQogICAgICAg ICByZXR1cm47CkBAIC0xMDY5LDcgKzEwNjksOCBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXpl X3QgaW5saW5lQ2FwYWNpdHksIHR5cGVuYW1lIE92ZXJmbG93SGFuZGxlcj4gdGVtcGxhdGU8dAog aW5saW5lIHZvaWQgVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5LCBPdmVyZmxvd0hhbmRsZXI+Ojp1 bmNoZWNrZWRBcHBlbmQoVSYmIHZhbHVlKQogewogICAgIEFTU0VSVChzaXplKCkgPCBjYXBhY2l0 eSgpKTsKLSAgICBhdXRvIHB0ciA9ICZ2YWx1ZTsKKworICAgIGF1dG8gcHRyID0gc3RkOjphZGRy ZXNzb2YodmFsdWUpOwogICAgIG5ldyAoTm90TnVsbCwgZW5kKCkpIFQoc3RkOjpmb3J3YXJkPFU+ KCpwdHIpKTsKICAgICArK21fc2l6ZTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0MjMyZmY1ZjQzMmRjODc5MzViZTk3OGE4NmM3ODE0N2Zi OTcyY2ZjLi5jNzNkMGFkMzE3NzM2NmU1YzczYTA2MmUzZGQ4Y2NmOTFiMTY2ZjhmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMDktMTEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAor ICAgICAgICBWZWN0b3I6OmFwcGVuZCBkb2Vzbid0IHdvcmsgaWYgZWxlbWVudCB0eXBlIGhhcyBv dmVybG9hZGVkIG9wZXJhdG9yJgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIxMTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGEgdGVzdCBjYXNlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvVmVjdG9yLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCisy MDEzLTA5LTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAg ICAgSW1wbGVtZW50IFZlY3Rvcjo6YXBwZW5kIGZvciBtb3ZlLW9ubHkgdHlwZXMKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDgwNQogCmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9WZWN0b3IuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvVmVjdG9yLmNwcAppbmRleCBhYjEwZjZiZjM5NDgyMTU5MWNh MjhmNjI3MjkyMTIwZGI1ZTUzMDg0Li40MGI0ZjU4YjVmM2JkN2FjNDEzNzAwOTBhMzY5YTc0NTgz NjY4NTg2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9WZWN0b3Iu Y3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1ZlY3Rvci5jcHAKQEAgLTYw LDYgKzYwLDE3IEBAIFRFU1QoV1RGX1ZlY3RvciwgSXRlcmF0b3IpCiAgICAgRVhQRUNUX1RSVUUo ZW5kID09IGl0KTsKIH0KIAorVEVTVChXVEZfVmVjdG9yLCBPdmVybG9hZGVkT3BlcmF0b3JBbXBl cnNhbmQpCit7CisgICAgc3RydWN0IFRlc3QgeworICAgIHByaXZhdGU6CisgICAgICAgIFRlc3Qq IG9wZXJhdG9yJigpOworICAgIH07CisKKyAgICBWZWN0b3I8VGVzdD4gdmVjdG9yOworICAgIHZl Y3Rvci5hcHBlbmQoVGVzdCgpKTsKK30KKwogVEVTVChXVEZfVmVjdG9yLCBSZXZlcnNlKQogewog ICAgIFZlY3RvcjxpbnQ+IGludFZlY3RvcjsK