121153 2013-09-11 04:17:53 -0700 [WinCairo] Compile errors. 2013-09-11 10:20:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue oldest_to_newest 927720 0 peavo 2013-09-11 04:17:53 -0700 There are a couple of compile errors in WebCore: ..\page\win\FrameCairoWin.cpp(38): error C2248: 'WTF::GDIObject::GDIObject' : cannot access private member declared in class 'WTF::GDIObject' with [ T=HBITMAP ] \include\private\wtf/win/GDIObject.h(68) : see declaration of 'WTF::GDIObject::GDIObject' with [ T=HBITMAP ] ..\platform\graphics\win\FontCustomPlatformDataCairo.cpp(64): error C2664: 'cairo_win32_font_face_create_for_hfont' : cannot convert parameter 1 from 'WTF::GDIObject' to 'HFONT' with [ T=HFONT ] No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called 927722 1 211298 peavo 2013-09-11 04:24:48 -0700 Created attachment 211298 Patch 927817 2 211298 bfulgham 2013-09-11 09:26:17 -0700 Comment on attachment 211298 Patch r=me. Thanks for fixing this. I'll probably break a few more things before I am done :-( 927830 3 211298 commit-queue 2013-09-11 09:49:41 -0700 Comment on attachment 211298 Patch Clearing flags on attachment: 211298 Committed r155537: <http://trac.webkit.org/changeset/155537> 927831 4 commit-queue 2013-09-11 09:49:42 -0700 All reviewed patches have been landed. Closing bug. 927845 5 peavo 2013-09-11 10:20:14 -0700 (In reply to comment #2) > (From update of attachment 211298 [details]) > r=me. Thanks for fixing this. I'll probably break a few more things before I am done :-( No worries, thanks for reviewing :) 211298 2013-09-11 04:24:48 -0700 2013-09-11 09:49:41 -0700 Patch bug-121153-20130911132439.patch text/plain 1951 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTUxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTExICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjExNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBhZ2Uvd2luL0ZyYW1lQ2Fpcm9XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aW1h Z2VGcm9tUmVjdCk6IFJldHVybiBlbXB0eSBHRElPYmplY3QuCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3Mvd2luL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFDYWlyby5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjpmb250UGxhdGZvcm1EYXRhKTogR2V0IGFj dHVhbCBoYW5kbGUgZnJvbSBHRElPYmplY3QuCisKIDIwMTMtMDktMTAgIE1hcmlvIFNhbmNoZXog UHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBSZWltcGxl bWVudCBhdGtfdGV4dF9nZXRfdGV4dF8qX29mZnNldCBmb3IgTElORSBib3VuZGFyaWVzCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3dpbi9GcmFtZUNhaXJvV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wYWdlL3dpbi9GcmFtZUNhaXJvV2luLmNwcAkocmV2aXNpb24gMTU1 NTAyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS93aW4vRnJhbWVDYWlyb1dpbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM1LDcgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogR0RJT2JqZWN0 PEhCSVRNQVA+IGltYWdlRnJvbVJlY3QoY29uc3QgRnJhbWUqLCBJbnRSZWN0JikKIHsKICAgICBu b3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBudWxscHRyOworICAgIHJldHVybiBHRElPYmpl Y3Q8SEJJVE1BUD4oKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFDYWly by5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L0ZvbnRDdXN0b21QbGF0Zm9ybURhdGFDYWlyby5jcHAJKHJldmlzaW9uIDE1NTUwMikKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q3VzdG9tUGxhdGZvcm1EYXRh Q2Fpcm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSw3ICs2MSw3IEBAIEZvbnRQbGF0Zm9ybURh dGEgRm9udEN1c3RvbVBsYXRmb3JtRGF0YToKIAogICAgIGF1dG8gaGZvbnQgPSBhZG9wdEdESU9i amVjdCg6OkNyZWF0ZUZvbnRJbmRpcmVjdCgmbG9nRm9udCkpOwogCi0gICAgY2Fpcm9fZm9udF9m YWNlX3QqIGZvbnRGYWNlID0gY2Fpcm9fd2luMzJfZm9udF9mYWNlX2NyZWF0ZV9mb3JfaGZvbnQo aGZvbnQpOworICAgIGNhaXJvX2ZvbnRfZmFjZV90KiBmb250RmFjZSA9IGNhaXJvX3dpbjMyX2Zv bnRfZmFjZV9jcmVhdGVfZm9yX2hmb250KGhmb250LmdldCgpKTsKIAogICAgIEZvbnRQbGF0Zm9y bURhdGEgZm9udFBsYXRmb3JtRGF0YShoZm9udC5sZWFrKCksIGZvbnRGYWNlLCBzaXplLCBib2xk LCBpdGFsaWMpOwogCg==