121150 2013-09-11 03:20:55 -0700 autogen.sh: fix removal of autom4te.cache 2013-09-11 04:15:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cgarcia oldest_to_newest 927704 0 berto 2013-09-11 03:20:55 -0700 autom4te.cache doesn't harm other than taking a bit of space in the hard drive. It can be safely removed anyway. However at the moment we have rm -f $top_srcdir/autom4te.cache which doesn't work since 1) autom4te.cache is a directory 2) $top_srcdir is not defined in autogen.sh Best case, that's equivalent to rm -f /autom4te.cache, which does nothing since that file doesn't exist. Worst case, the user has $top_srcdir set to some value and funny surprises happen. Since we can guarantee that we're in the root directory of the WebKit tree we can just run rm -rf autom4te.cache And this should be run _after_ autoreconf since it's not needed by anyone else. 927705 1 211293 berto 2013-09-11 03:24:20 -0700 Created attachment 211293 Patch 927708 2 211293 cgarcia 2013-09-11 03:28:49 -0700 Comment on attachment 211293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211293&action=review Thanks! > ChangeLog:9 > + Fix incorrect removal of autom4te.cache and put it after the > + autoreconf call. Could you briefly explain here why it was wrong, the explanation in the bug summary is great. 927718 3 berto 2013-09-11 04:15:01 -0700 Committed r155517: <http://trac.webkit.org/changeset/155517> 211293 2013-09-11 03:24:20 -0700 2013-09-11 03:28:49 -0700 Patch 121150.diff text/plain 1067 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzMTE4ODUyLi40NzgyNTAy IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTMtMDktMTEgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAorICAgICAg ICBhdXRvZ2VuLnNoOiBmaXggcmVtb3ZhbCBvZiBhdXRvbTR0ZS5jYWNoZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMTUwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGluY29ycmVjdCByZW1vdmFs IG9mIGF1dG9tNHRlLmNhY2hlIGFuZCBwdXQgaXQgYWZ0ZXIgdGhlCisgICAgICAgIGF1dG9yZWNv bmYgY2FsbC4KKworICAgICAgICAqIGF1dG9nZW4uc2g6CisKKzIwMTMtMDktMTEgIEFsYmVydG8g R2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnF1b3RlZCAkT1JJR0RJUiBp biBhdXRvZ2VuLnNoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTUxMgogCmRpZmYgLS1naXQgYS9hdXRvZ2VuLnNoIGIvYXV0b2dlbi5zaAppbmRleCBj NjY4OGQ0Li5iZWZkNDI5IDEwMDc1NQotLS0gYS9hdXRvZ2VuLnNoCisrKyBiL2F1dG9nZW4uc2gK QEAgLTgsOCArOCw2IEBAIHRlc3QgLXogIiRzcmNkaXIiICYmIHNyY2Rpcj0uCiBPUklHRElSPWBw d2RgCiBjZCAiJHNyY2RpciIgfHwgZXhpdCAxCiAKLXJtIC1mICR0b3Bfc3JjZGlyL2F1dG9tNHRl LmNhY2hlCi0KIHRvdWNoIFJFQURNRSBJTlNUQUxMCiAKIGlmIHRlc3QgLXogYHdoaWNoIGF1dG9y ZWNvbmZgOyB0aGVuCkBAIC0xNyw2ICsxNSw3IEBAIGlmIHRlc3QgLXogYHdoaWNoIGF1dG9yZWNv bmZgOyB0aGVuCiAgICAgZXhpdCAxCiBmaQogYXV0b3JlY29uZiAtLXZlcmJvc2UgLS1pbnN0YWxs IC1JIFNvdXJjZS9hdXRvdG9vbHMgJEFDTE9DQUxfRkxBR1N8fCBleGl0ICQ/CitybSAtcmYgYXV0 b200dGUuY2FjaGUKIAogY2QgIiRPUklHRElSIiB8fCBleGl0IDEKIAo=