12111 2007-01-04 06:45:56 -0800 Uninitialized variable in -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:] 2008-01-01 15:37:04 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P2 Normal --- 16700 1 jim.correia webkit-unassigned ap ddkilzer opendarwin oldest_to_newest 37158 0 jim.correia 2007-01-04 06:45:56 -0800 -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:] has the following code in its implementation: if ([[request URL] isFileURL]) { BOOL isDirectory; [[NSFileManager defaultManager] fileExistsAtPath:[[request URL] path] isDirectory:&isDirectory]; if (isDirectory) { [listener ignore]; isDirectory is only filled in by the NSFileManager method in the case that the file exists. In all other cases we are using an uninitialized variable. Initializing the variable is sufficient to solve the problem. See also rdar://problem/4908081 37133 1 ddkilzer 2007-01-04 11:05:39 -0800 (In reply to comment #0) > isDirectory is only filled in by the NSFileManager method in the case that the > file exists. In all other cases we are using an uninitialized variable. > Initializing the variable is sufficient to solve the problem. Does the BOOL type not default to 'false' if not explicitly set? 37116 2 ap 2007-01-04 11:56:27 -0800 Confirmed (automatic BOOL variables aren't automatically initialized). Is this just a potential problem, or there are real life circumstances where the delegate gets called for a non-existent object? 37039 3 jim.correia 2007-01-04 14:08:50 -0800 Yes, it is a real life problem in my application. (I provided more details in radar, which I realize is only readable by Apple people.) Essentially I'm using a custom URL protocol to load web archives to avoid the problem where WebKit will load the original resource from the network or filesystem (which may no longer exist.) I'm not rewriting the URLs, only providing data, so the web policy delegate will see the original file url which doesn't point to an existing path. 36950 4 12235 ddkilzer 2007-01-04 23:05:16 -0800 Created attachment 12235 Patch v1 The obvious fix. 36947 5 12235 beidson 2007-01-04 23:11:42 -0800 Comment on attachment 12235 Patch v1 surly you mean "BOOL isDirectory = NO"? otherwise r+ 36935 6 12236 ddkilzer 2007-01-04 23:21:50 -0800 Created attachment 12236 Patch v2 (change false to NO) Now with correct-style points! 36927 7 ddkilzer 2007-01-04 23:38:48 -0800 Committed revision 18612. 65941 8 opendarwin 2008-01-01 14:52:40 -0800 This was not a good fix. -[NSFileManager fileExistsAtPath:isDirectory] may or may not modify the variable isDirectory; that's a private implementation detail of NSFileManager. What should be done is to check the return value of [[NSFileManager defaultManager] fileExistsAtPath:[[request URL] path] isDirectory:&isDirectory] before using isDirectory. 65946 9 ddkilzer 2008-01-01 15:09:07 -0800 (In reply to comment #8) > This was not a good fix. -[NSFileManager fileExistsAtPath:isDirectory] may or > may not modify the variable isDirectory; that's a private implementation detail > of NSFileManager. > > What should be done is to check the return value of [[NSFileManager > defaultManager] fileExistsAtPath:[[request URL] path] isDirectory:&isDirectory] > before using isDirectory. Please open a new bug. 65952 10 ddkilzer 2008-01-01 15:36:37 -0800 (In reply to comment #9) > (In reply to comment #8) > > This was not a good fix. -[NSFileManager fileExistsAtPath:isDirectory] may or > > may not modify the variable isDirectory; that's a private implementation detail > > of NSFileManager. > > > > What should be done is to check the return value of [[NSFileManager > > defaultManager] fileExistsAtPath:[[request URL] path] isDirectory:&isDirectory] > > before using isDirectory. > > Please open a new bug. Bug 16700. http://trac.webkit.org/projects/webkit/changeset/18612 http://developer.apple.com/documentation/Cocoa/Reference/Foundation/Classes/NSFileManager_Class/Reference/Reference.html#//apple_ref/occ/instm/NSFileManager/fileExistsAtPath:isDirectory: 12235 2007-01-04 23:05:16 -0800 2007-01-04 23:21:50 -0800 Patch v1 bug-12111-v1.diff text/plain 1292 ddkilzer SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTg2MTEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMDctMDEtMDUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBm aXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMTEKKyAgICAgICAg ICBVbmluaXRpYWxpemVkIHZhcmlhYmxlIGluIC1bV2ViRGVmYXVsdFBvbGljeURlbGVnYXRlIHdl YlZpZXc6ZGVjaWRlUG9saWN5Rm9yTUlNRVR5cGU6cmVxdWVzdDpmcmFtZTpkZWNpc2lvbkxpc3Rl bmVyOl0KKworICAgICAgICAqIERlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVn YXRlLm06IEluaXRpYWxpemUgaXNEaXJlY3RvcnkuCisKIDIwMDctMDEtMDQgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmLgpJbmRleDog V2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVnYXRlLm0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVnYXRl Lm0JKHJldmlzaW9uIDE4NjEwKQorKysgV2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVs dFBvbGljeURlbGVnYXRlLm0JKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDcgQEAgc3RhdGlj IFdlYkRlZmF1bHRQb2xpY3lEZWxlZ2F0ZSAqc2hhcmVkRAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBkZWNpc2lvbkxpc3RlbmVyOihpZCA8V2ViUG9saWN5RGVjaXNpb25M aXN0ZW5lcj4pbGlzdGVuZXI7CiB7CiAgICAgaWYgKFtbcmVxdWVzdCBVUkxdIGlzRmlsZVVSTF0p IHsKLSAgICAgICAgQk9PTCBpc0RpcmVjdG9yeTsKKyAgICAgICAgQk9PTCBpc0RpcmVjdG9yeSA9 IGZhbHNlOwogICAgICAgICBbW05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGZpbGVFeGlz dHNBdFBhdGg6W1tyZXF1ZXN0IFVSTF0gcGF0aF0gaXNEaXJlY3Rvcnk6JmlzRGlyZWN0b3J5XTsK ICAgICAgICAgCiAgICAgICAgIGlmIChpc0RpcmVjdG9yeSkgewo= 12236 2007-01-04 23:21:50 -0800 2007-01-04 23:41:30 -0800 Patch v2 (change false to NO) bug-12111-v2.diff text/plain 1289 ddkilzer SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTg2MTEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMDctMDEtMDUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBm aXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMTEKKyAgICAgICAg ICBVbmluaXRpYWxpemVkIHZhcmlhYmxlIGluIC1bV2ViRGVmYXVsdFBvbGljeURlbGVnYXRlIHdl YlZpZXc6ZGVjaWRlUG9saWN5Rm9yTUlNRVR5cGU6cmVxdWVzdDpmcmFtZTpkZWNpc2lvbkxpc3Rl bmVyOl0KKworICAgICAgICAqIERlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVn YXRlLm06IEluaXRpYWxpemUgaXNEaXJlY3RvcnkuCisKIDIwMDctMDEtMDQgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmLgpJbmRleDog V2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVnYXRlLm0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFBvbGljeURlbGVnYXRl Lm0JKHJldmlzaW9uIDE4NjEwKQorKysgV2ViS2l0L0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVs dFBvbGljeURlbGVnYXRlLm0JKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDcgQEAgc3RhdGlj IFdlYkRlZmF1bHRQb2xpY3lEZWxlZ2F0ZSAqc2hhcmVkRAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBkZWNpc2lvbkxpc3RlbmVyOihpZCA8V2ViUG9saWN5RGVjaXNpb25M aXN0ZW5lcj4pbGlzdGVuZXI7CiB7CiAgICAgaWYgKFtbcmVxdWVzdCBVUkxdIGlzRmlsZVVSTF0p IHsKLSAgICAgICAgQk9PTCBpc0RpcmVjdG9yeTsKKyAgICAgICAgQk9PTCBpc0RpcmVjdG9yeSA9 IE5POwogICAgICAgICBbW05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGZpbGVFeGlzdHNB dFBhdGg6W1tyZXF1ZXN0IFVSTF0gcGF0aF0gaXNEaXJlY3Rvcnk6JmlzRGlyZWN0b3J5XTsKICAg ICAgICAgCiAgICAgICAgIGlmIChpc0RpcmVjdG9yeSkgewo=