121109 2013-09-10 12:20:55 -0700 AX: Mac platform is not using accessibilityTitle from the Base implementation 2013-09-11 00:36:29 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jdiggs mario webkit-bug-importer oldest_to_newest 927412 0 cfleizach 2013-09-10 12:20:55 -0700 In WebAccessibilityObjectWrapperBase there are accessibilityTitle and Description methods. The WebAccessibilityObjectWrapperMac subclass is not using these and instead duplicating them (for some reason), and they're starting to diverge! 927413 1 webkit-bug-importer 2013-09-10 12:21:06 -0700 <rdar://problem/14956940> 927593 2 211265 cfleizach 2013-09-10 17:08:38 -0700 Created attachment 211265 patch 927672 3 211265 commit-queue 2013-09-11 00:36:27 -0700 Comment on attachment 211265 patch Clearing flags on attachment: 211265 Committed r155505: <http://trac.webkit.org/changeset/155505> 927673 4 commit-queue 2013-09-11 00:36:29 -0700 All reviewed patches have been landed. Closing bug. 211265 2013-09-10 17:08:38 -0700 2013-09-11 00:36:27 -0700 patch patch text/plain 7246 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTQ5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA5LTEwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKKyAgICAgICAgQVg6IE1hYyBwbGF0Zm9y bSBpcyBub3QgdXNpbmcgYWNjZXNzaWJpbGl0eVRpdGxlIGZyb20gdGhlIEJhc2UgaW1wbGVtZW50 YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MTEwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZSB0aGUgTWFjIHBsYXRmb3JtIG92ZXJyaWRlcyBvZiBhY2Nlc3NpYmlsaXR5VGl0bGUsIERl c2NyaXB0aW9uLCBIZWxwVGV4dC4gCisgICAgICAgIFRoZSBCYXNlIGltcGxlbWVudGF0aW9uIGhh cyB0aGVzZSBhbmQgd2UgY2FuIHNoYXJlIHRoZW0gYmV0d2VlbiBpT1MgYW5kIE1hYworCisgICAg ICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJCYXNl Lm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckJhc2UgYWNjZXNz aWJpbGl0eVRpdGxlXSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy QmFzZSBhY2Nlc3NpYmlsaXR5RGVzY3JpcHRpb25dKToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5 L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbToKKworMjAxMy0wOS0xMCAg Q2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCiAgICAgICAgIEFYOiBBWFZh bHVlL0FYTWVudUl0ZW1NYXJrQ2hhciBub3QgZGVmaW5lZCBmb3IgbWVudWl0ZW1yYWRpbyAoc2hv dWxkIGJlIGZhbHNlICgwKSB3aXRoIGFyaWEtY2hlY2tlZD1taXhlZCB8IHVuZGVmaW5lZCkKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDM3MgogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlckJhc2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJCYXNlLm1tCShyZXZpc2lvbiAx NTU0OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0V3JhcHBlckJhc2UubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4MiwxMSArMTgyLDYg QEAKICAgICAgICAgLy8gdGhhdCB0ZXh0IGFzIG91ciB0aXRsZS4KICAgICAgICAgaWYgKHRleHQu dGV4dFNvdXJjZSA9PSBMYWJlbEJ5RWxlbWVudFRleHQgJiYgIW1fb2JqZWN0LT5leHBvc2VzVGl0 bGVVSUVsZW1lbnQoKSkKICAgICAgICAgICAgIHJldHVybiB0ZXh0LnRleHQ7Ci0gICAgICAgIAot ICAgICAgICAvLyBGSVhNRTogVGhlIHRpdGxlIHRhZyBpcyB1c2VkIGluIGNlcnRhaW4gY2FzZXMg Zm9yIHRoZSB0aXRsZS4gVGhpcyB1c2FnZSBzaG91bGQKLSAgICAgICAgLy8gcHJvYmFibHkgYmUg aW4gdGhlIGRlc2NyaXB0aW9uIGZpZWxkIHNpbmNlIGl0J3Mgbm90ICJ2aXNpYmxlIi4KLSAgICAg ICAgaWYgKHRleHQudGV4dFNvdXJjZSA9PSBUaXRsZVRhZ1RleHQgJiYgIVtzZWxmIHRpdGxlVGFn U2hvdWxkQmVVc2VkSW5EZXNjcmlwdGlvbkZpZWxkXSkKLSAgICAgICAgICAgIHJldHVybiB0ZXh0 LnRleHQ7CiAgICAgfQogICAgIAogICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nXTsKQEAgLTIw MywxMyArMTk4LDIzIEBACiAgICAgbV9vYmplY3QtPmFjY2Vzc2liaWxpdHlUZXh0KHRleHRPcmRl cik7CiAgICAgCiAgICAgdW5zaWduZWQgbGVuZ3RoID0gdGV4dE9yZGVyLnNpemUoKTsKKyAgICBi b29sIHZpc2libGVUZXh0QXZhaWxhYmxlID0gZmFsc2U7CiAgICAgZm9yICh1bnNpZ25lZCBrID0g MDsgayA8IGxlbmd0aDsgaysrKSB7CiAgICAgICAgIGNvbnN0IEFjY2Vzc2liaWxpdHlUZXh0JiB0 ZXh0ID0gdGV4dE9yZGVyW2tdOwogICAgICAgICAKICAgICAgICAgaWYgKHRleHQudGV4dFNvdXJj ZSA9PSBBbHRlcm5hdGl2ZVRleHQpCiAgICAgICAgICAgICByZXR1cm4gdGV4dC50ZXh0OwogICAg ICAgICAKLSAgICAgICAgaWYgKHRleHQudGV4dFNvdXJjZSA9PSBUaXRsZVRhZ1RleHQgJiYgW3Nl bGYgdGl0bGVUYWdTaG91bGRCZVVzZWRJbkRlc2NyaXB0aW9uRmllbGRdKQorICAgICAgICBzd2l0 Y2ggKHRleHQudGV4dFNvdXJjZSkgeworICAgICAgICBjYXNlIFZpc2libGVUZXh0OgorICAgICAg ICBjYXNlIENoaWxkcmVuVGV4dDoKKyAgICAgICAgY2FzZSBMYWJlbEJ5RWxlbWVudFRleHQ6Cisg ICAgICAgICAgICB2aXNpYmxlVGV4dEF2YWlsYWJsZSA9IHRydWU7CisgICAgICAgIGRlZmF1bHQ6 CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgaWYgKHRl eHQudGV4dFNvdXJjZSA9PSBUaXRsZVRhZ1RleHQgJiYgIXZpc2libGVUZXh0QXZhaWxhYmxlKQog ICAgICAgICAgICAgcmV0dXJuIHRleHQudGV4dDsKICAgICB9CiAgICAgCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1h Yy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQkocmV2aXNpb24gMTU1NDkyKQorKysgU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5OTEsMTEwICsxOTkxLDYgQEAKICAgICByZXR1 cm4gW3NlbGYgcmVtb3RlQWNjZXNzaWJpbGl0eVBhcmVudE9iamVjdF07CiB9CiAKLS8vIFRoaXMg c2hvdWxkIGJlIHRoZSAidmlzaWJsZSIgdGV4dCB0aGF0J3MgYWN0dWFsbHkgb24gdGhlIHNjcmVl biBpZiBwb3NzaWJsZS4KLS8vIElmIHRoZXJlJ3MgYWx0ZXJuYXRpdmUgdGV4dCwgdGhhdCBjYW4g b3ZlcnJpZGUgdGhlIHRpdGxlLgotLSAoTlNTdHJpbmcgKilhY2Nlc3NpYmlsaXR5VGl0bGUKLXsK LSAgICAvLyBTdGF0aWMgdGV4dCBvYmplY3RzIHNob3VsZCBub3QgaGF2ZSBhIHRpdGxlLiBJdHMg Y29udGVudCBpcyBjb21tdW5pY2F0ZWQgaW4gaXRzIEFYVmFsdWUuCi0gICAgaWYgKG1fb2JqZWN0 LT5yb2xlVmFsdWUoKSA9PSBTdGF0aWNUZXh0Um9sZSkKLSAgICAgICAgcmV0dXJuIFtOU1N0cmlu ZyBzdHJpbmddOwotICAgIAotICAgIC8vIEEgZmlsZSB1cGxvYWQgYnV0dG9uIHByZXNlbnRzIGEg Y2hhbGxlbmdlIGJlY2F1c2UgaXQgaGFzIGJ1dHRvbiB0ZXh0IGFuZCBhIHZhbHVlLCBidXQgdGhl Ci0gICAgLy8gQVBJIGRvZXNuJ3Qgc3VwcG9ydCB0aGlzIHBhcmFkaWdtLgotICAgIC8vIFRoZSBj b21wcm9taXNlIGlzIHRvIHJldHVybiB0aGUgYnV0dG9uIHR5cGUgaW4gdGhlIHJvbGUgZGVzY3Jp cHRpb24gYW5kIHRoZSB2YWx1ZSBvZiB0aGUgZmlsZSBwYXRoIGluIHRoZSB0aXRsZQotICAgIGlm IChtX29iamVjdC0+aXNGaWxlVXBsb2FkQnV0dG9uKCkpCi0gICAgICAgIHJldHVybiBtX29iamVj dC0+c3RyaW5nVmFsdWUoKTsKLSAgICAKLSAgICBWZWN0b3I8QWNjZXNzaWJpbGl0eVRleHQ+IHRl eHRPcmRlcjsKLSAgICBtX29iamVjdC0+YWNjZXNzaWJpbGl0eVRleHQodGV4dE9yZGVyKTsKLSAg ICAKLSAgICB1bnNpZ25lZCBsZW5ndGggPSB0ZXh0T3JkZXIuc2l6ZSgpOwotICAgIGZvciAodW5z aWduZWQgayA9IDA7IGsgPCBsZW5ndGg7IGsrKykgewotICAgICAgICBjb25zdCBBY2Nlc3NpYmls aXR5VGV4dCYgdGV4dCA9IHRleHRPcmRlcltrXTsKLSAgICAgICAgCi0gICAgICAgIC8vIElmIHdl IGhhdmUgYWx0ZXJuYXRpdmUgdGV4dCwgdGhlbiB3ZSBzaG91bGQgbm90IGV4cG9zZSBhIHRpdGxl LgotICAgICAgICBpZiAodGV4dC50ZXh0U291cmNlID09IEFsdGVybmF0aXZlVGV4dCkKLSAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICAKLSAgICAgICAgLy8gT25jZSB3ZSBlbmNvdW50ZXIgdmlz aWJsZSB0ZXh0LCBvciB0aGUgdGV4dCBmcm9tIG91ciBjaGlsZHJlbiB0aGF0IHNob3VsZCBiZSB1 c2VkIGZvcmVtb3N0LgotICAgICAgICBpZiAodGV4dC50ZXh0U291cmNlID09IFZpc2libGVUZXh0 IHx8IHRleHQudGV4dFNvdXJjZSA9PSBDaGlsZHJlblRleHQpCi0gICAgICAgICAgICByZXR1cm4g dGV4dC50ZXh0OwotICAgICAgICAKLSAgICAgICAgLy8gSWYgdGhlcmUncyBhbiBlbGVtZW50IHRo YXQgbGFiZWxzIHRoaXMgb2JqZWN0IGFuZCBpdCdzIG5vdCBleHBvc2VkLCB0aGVuIHdlIHNob3Vs ZCB1c2UKLSAgICAgICAgLy8gdGhhdCB0ZXh0IGFzIG91ciB0aXRsZS4KLSAgICAgICAgaWYgKHRl eHQudGV4dFNvdXJjZSA9PSBMYWJlbEJ5RWxlbWVudFRleHQgJiYgIW1fb2JqZWN0LT5leHBvc2Vz VGl0bGVVSUVsZW1lbnQoKSkKLSAgICAgICAgICAgIHJldHVybiB0ZXh0LnRleHQ7Ci0gICAgfQot ICAgIAotICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nXTsKLX0KLQotLSAoTlNTdHJpbmcgKilh Y2Nlc3NpYmlsaXR5RGVzY3JpcHRpb24KLXsKLSAgICAvLyBTdGF0aWMgdGV4dCBvYmplY3RzIHNo b3VsZCBub3QgaGF2ZSBhIGRlc2NyaXB0aW9uLiBJdHMgY29udGVudCBpcyBjb21tdW5pY2F0ZWQg aW4gaXRzIEFYVmFsdWUuCi0gICAgLy8gT25lIGV4Y2VwdGlvbiBpcyB0aGUgbWVkaWEgY29udHJv bCBsYWJlbHMgdGhhdCBoYXZlIGEgdmFsdWUgYW5kIGEgZGVzY3JpcHRpb24uIFRob3NlIGFyZSBz ZXQgcHJvZ3JhbWF0aWNhbGx5LgotICAgIGlmIChtX29iamVjdC0+cm9sZVZhbHVlKCkgPT0gU3Rh dGljVGV4dFJvbGUgJiYgIW1fb2JqZWN0LT5pc01lZGlhQ29udHJvbExhYmVsKCkpCi0gICAgICAg IHJldHVybiBbTlNTdHJpbmcgc3RyaW5nXTsKLSAgICAKLSAgICBWZWN0b3I8QWNjZXNzaWJpbGl0 eVRleHQ+IHRleHRPcmRlcjsKLSAgICBtX29iamVjdC0+YWNjZXNzaWJpbGl0eVRleHQodGV4dE9y ZGVyKTsKLSAgICAKLSAgICB1bnNpZ25lZCBsZW5ndGggPSB0ZXh0T3JkZXIuc2l6ZSgpOwotICAg IGJvb2wgdmlzaWJsZVRleHRBdmFpbGFibGUgPSBmYWxzZTsKLSAgICBmb3IgKHVuc2lnbmVkIGsg PSAwOyBrIDwgbGVuZ3RoOyBrKyspIHsKLSAgICAgICAgY29uc3QgQWNjZXNzaWJpbGl0eVRleHQm IHRleHQgPSB0ZXh0T3JkZXJba107Ci0gICAgICAgIAotICAgICAgICBpZiAodGV4dC50ZXh0U291 cmNlID09IEFsdGVybmF0aXZlVGV4dCkKLSAgICAgICAgICAgIHJldHVybiB0ZXh0LnRleHQ7Ci0g ICAgICAgIAotICAgICAgICBzd2l0Y2ggKHRleHQudGV4dFNvdXJjZSkgewotICAgICAgICBjYXNl IFZpc2libGVUZXh0OgotICAgICAgICBjYXNlIENoaWxkcmVuVGV4dDoKLSAgICAgICAgY2FzZSBM YWJlbEJ5RWxlbWVudFRleHQ6Ci0gICAgICAgICAgICB2aXNpYmxlVGV4dEF2YWlsYWJsZSA9IHRy dWU7Ci0gICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAg ICAgICAKLSAgICAgICAgaWYgKHRleHQudGV4dFNvdXJjZSA9PSBUaXRsZVRhZ1RleHQgJiYgIXZp c2libGVUZXh0QXZhaWxhYmxlKQotICAgICAgICAgICAgcmV0dXJuIHRleHQudGV4dDsKLSAgICB9 Ci0gICAgCi0gICAgcmV0dXJuIFtOU1N0cmluZyBzdHJpbmddOwotfQotCi0tIChOU1N0cmluZyAq KWFjY2Vzc2liaWxpdHlIZWxwVGV4dAotewotICAgIFZlY3RvcjxBY2Nlc3NpYmlsaXR5VGV4dD4g dGV4dE9yZGVyOwotICAgIG1fb2JqZWN0LT5hY2Nlc3NpYmlsaXR5VGV4dCh0ZXh0T3JkZXIpOwot ICAgIAotICAgIHVuc2lnbmVkIGxlbmd0aCA9IHRleHRPcmRlci5zaXplKCk7Ci0gICAgYm9vbCBk ZXNjcmlwdGl2ZVRleHRBdmFpbGFibGUgPSBmYWxzZTsKLSAgICBmb3IgKHVuc2lnbmVkIGsgPSAw OyBrIDwgbGVuZ3RoOyBrKyspIHsKLSAgICAgICAgY29uc3QgQWNjZXNzaWJpbGl0eVRleHQmIHRl eHQgPSB0ZXh0T3JkZXJba107Ci0gICAgICAgIAotICAgICAgICBpZiAodGV4dC50ZXh0U291cmNl ID09IEhlbHBUZXh0IHx8IHRleHQudGV4dFNvdXJjZSA9PSBTdW1tYXJ5VGV4dCkKLSAgICAgICAg ICAgIHJldHVybiB0ZXh0LnRleHQ7Ci0gICAgICAgIAotICAgICAgICAvLyBJZiBhbiBlbGVtZW50 IGRvZXMgTk9UIGhhdmUgb3RoZXIgZGVzY3JpcHRpdmUgdGV4dCB0aGUgdGl0bGUgdGFnIHNob3Vs ZCBiZSB1c2VkIGFzIGl0cyBkZXNjcmlwdGl2ZSB0ZXh0LgotICAgICAgICAvLyBCdXQsIGlmIHRo b3NlIEFSRSBhdmFpbGFibGUsIHRoZW4gdGhlIHRpdGxlIHRhZyBzaG91bGQgYmUgdXNlZCBmb3Ig aGVscCB0ZXh0IGluc3RlYWQuCi0gICAgICAgIHN3aXRjaCAodGV4dC50ZXh0U291cmNlKSB7Ci0g ICAgICAgICAgICBjYXNlIEFsdGVybmF0aXZlVGV4dDoKLSAgICAgICAgICAgIGNhc2UgVmlzaWJs ZVRleHQ6Ci0gICAgICAgICAgICBjYXNlIENoaWxkcmVuVGV4dDoKLSAgICAgICAgICAgIGNhc2Ug TGFiZWxCeUVsZW1lbnRUZXh0OgotICAgICAgICAgICAgICAgIGRlc2NyaXB0aXZlVGV4dEF2YWls YWJsZSA9IHRydWU7Ci0gICAgICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICB9Ci0gICAgICAgIAotICAgICAgICBpZiAodGV4dC50ZXh0U291cmNlID09IFRp dGxlVGFnVGV4dCAmJiBkZXNjcmlwdGl2ZVRleHRBdmFpbGFibGUpCi0gICAgICAgICAgICByZXR1 cm4gdGV4dC50ZXh0OwotICAgIH0KLSAgICAKLSAgICByZXR1cm4gW05TU3RyaW5nIHN0cmluZ107 Ci19Ci0KIC8vIEZJWE1FOiBzcGxpdCB1cCB0aGlzIGZ1bmN0aW9uIGluIGEgYmV0dGVyIHdheS4K IC8vIHN1Z2dlc3Rpb25zOiBVc2UgYSBoYXNoIHRhYmxlIHRoYXQgbWFwcyBhdHRyaWJ1dGUgbmFt ZXMgdG8gZnVuY3Rpb24gY2FsbHMsCiAvLyBvciBtYXliZSBwb2ludGVycyB0byBtZW1iZXIgZnVu Y3Rpb25zCg==