121093 2013-09-10 06:13:24 -0700 [GTK] The code generator produces a warning if a parameter can be NULL 2013-09-10 06:31:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto berto cdumez commit-queue oldest_to_newest 927272 0 berto 2013-09-10 06:13:24 -0700 Here's the warning: GEN DerivedSources/webkitdom/WebKitDOMDOMWindow.h Use of uninitialized value $CodeGeneratorGObject::cBody[129] in print at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1536. The problem is in the generator of the g_return_if_fail() checks at the beginning of each method. If a particular parameter can be null the generator returns an undefined value instead of an empty string. 927274 1 211194 berto 2013-09-10 06:15:13 -0700 Created attachment 211194 Patch 927277 2 211194 cdumez 2013-09-10 06:25:11 -0700 Comment on attachment 211194 Patch r=me 927280 3 berto 2013-09-10 06:31:45 -0700 Committed r155435: <http://trac.webkit.org/changeset/155435> 211194 2013-09-10 06:15:13 -0700 2013-09-10 06:25:11 -0700 Patch 121093.diff text/plain 1235 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZTQ3Yjg5Li5hMTc1ZDllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDktMTAgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBUaGUgY29kZSBnZW5lcmF0b3IgcHJvZHVjZXMgYSB3YXJuaW5nIGlmIGEgcGFy YW1ldGVyIGNhbiBiZSBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjEwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZXR1cm4gYW4gZW1wdHkgc3RyaW5nIGluc3RlYWQgb2YgYW4gdW5kZWZpbmVk IHZhbHVlIGlmIGEKKyAgICAgICAgcGFydGljdWxhciBwYXJhbWV0ZXIgZG9lc24ndCBuZWVkIHRv IGJlIGNoZWNrZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtOgorICAgICAgICAoR2V0R1JldHVybk1hY3JvKToKKwogMjAxMy0wOS0xMCAgQW5k cmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgdG9Gb29FbGVtZW50KCkg c2hvdWxkIHVzZSBzdGF0aWNfY2FzdCwgbm90IHJlaW50ZXJwcmV0X2Nhc3QuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQppbmRleCBhN2VlMjFkLi4yMjhmMGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTg0Myw3ICs4NDMs NyBAQCBzdWIgR2V0R1JldHVybk1hY3JvIHsKICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAg ICAgIGlmIChQYXJhbUNhbkJlTnVsbCgkZnVuY3Rpb25OYW1lLCAkcGFyYW1OYW1lKSkgewotICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgcmV0dXJuICIiOwogICAgICAgICB9CiAgICAg ICAgICRjb25kaXRpb24gPSAiJHBhcmFtTmFtZSI7CiAgICAgfQo=