12109 2007-01-04 04:22:55 -0800 layer visibility incorrect in some cases 2022-01-13 23:20:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 koivisto koivisto mitz simon.fraser oldest_to_newest 37174 0 koivisto 2007-01-04 04:22:55 -0800 Mishandling of sublayers in RenderLayer::updateVisibilityStatus() can cause a layer that has visible content be marked as not having any. 37172 1 12212 koivisto 2007-01-04 04:25:16 -0800 Created attachment 12212 test case 37170 2 12214 koivisto 2007-01-04 04:36:44 -0800 Created attachment 12214 fixed My original visibility crawl loop is screwed up, it does not check nodes that are succeeding siblings of layered nodes. 36919 3 12214 hyatt 2007-01-05 00:16:21 -0800 Comment on attachment 12214 fixed r=me 36722 4 ddkilzer 2007-01-06 04:26:09 -0800 Committed in r18616 by antti with test case LayoutTests/fast/layers/layer-visibility-sublayer.html. 36725 5 mitz 2007-01-06 05:52:25 -0800 The layout test is invalid, giving the same results with and without the patch. Reopening the bug until a valid layout test is checked in. 36729 6 12214 ddkilzer 2007-01-06 07:42:36 -0800 Comment on attachment 12214 fixed Clearing hyatt's r+ so this doesn't show up in commit queue. 1830822 7 koivisto 2022-01-13 23:18:19 -0800 Doesn't seem like the test was ever fixed but we likely have coverage elsewhere by now. 1830824 8 mitz 2022-01-13 23:20:03 -0800 OK. 12212 2007-01-04 04:25:16 -0800 2007-01-04 04:25:16 -0800 test case visibility-sublayer-bug.html text/html 2017 koivisto PGh0bWw+CjxzdHlsZT4KLnJlZCB7IGJvcmRlcjogMnB4IHNvbGlkIHJlZCB9Ci5ncmVlbiB7IGJv cmRlcjogMnB4IHNvbGlkIGdyZWVuIH0KLnZpc2libGUgeyB2aXNpYmlsaXR5OiB2aXNpYmxlfQou aW52aXNpYmxlIHsgdmlzaWJpbGl0eTogaGlkZGVufQovLy5pbnZpc2libGU6aG92ZXIgeyB2aXNp YmlsaXR5OiB2aXNpYmxlfQouYWJzdG9wIHsgcG9zaXRpb246IGFic29sdXRlOyBsZWZ0OjA7IHJp Z2h0OjA7IGhlaWdodDozMHB4ICAgfQouYWJzIHsgcG9zaXRpb246IGFic29sdXRlOyBsZWZ0OjA7 IHJpZ2h0OjA7IHRvcDowOyBib3R0b206MCB9Cjwvc3R5bGU+Cgo8c2NyaXB0Pgp2YXIgbm9kZTE7 CnZhciBub2RlMjsKZnVuY3Rpb24gZG90ZXN0KCkKewoKLy8yNApkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnMjRjJykuc3R5bGUuc2V0UHJvcGVydHkoJ3Zpc2liaWxpdHknLCdoaWRkZW4nLCcnKTsK ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJzI0YScpLnJlbW92ZUNoaWxkKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCcyNGInKSk7CgovLzI1CmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCcyNWMnKS5z dHlsZS5zZXRQcm9wZXJ0eSgndmlzaWJpbGl0eScsJ2hpZGRlbicsJycpOwpkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnMjVhJykucmVtb3ZlQ2hpbGQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJzI1 YicpKTsKCi8vMjYKZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJzI2YycpLnN0eWxlLnNldFByb3Bl cnR5KCd2aXNpYmlsaXR5JywnaGlkZGVuJywnJyk7CmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCcy NmEnKS5yZW1vdmVDaGlsZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnMjZiJykpOwpzZXRUaW1l b3V0KGRvdGVzdDIsMjApOwp9CgpmdW5jdGlvbiBkb3Rlc3QyKCkKewoKLy94eAovL2RvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCcyMycpLnN0eWxlLnNldFByb3BlcnR5KCd2aXNpYmlsaXR5JywnaGlk ZGVuJywnJyk7Cn0KCjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5IG9ubG9hZD0ic2V0VGltZW91dChk b3Rlc3QsMjApIj4KPGJyPjxicj48YnI+PGJyPgoyNCBncmVlbiBib3ggd2l0aCB3b3JkIG9rOgo8 ZGl2IGlkPSIyNGEiIGNsYXNzPSJpbnZpc2libGUgYWJzdG9wIHJlZCI+CjxkaXYgY2xhc3M9ImFi cyBpbnZpc2libGUgcmVkIj4KPHNwYW4+YmxhaDwvc3Bhbj4KPC9kaXY+CjxkaXYgaWQ9IjI0YiIg Y2xhc3M9ImFicyBpbnZpc2libGUgcmVkIj4KPC9kaXY+CjxkaXYgaWQ9IjI0YyIgY2xhc3M9InZp c2libGUgcmVkIj4KPC9kaXY+CjxkaXYgY2xhc3M9InZpc2libGUgZ3JlZW4iPgpvawo8L2Rpdj4K PC9kaXY+Cjxicj48YnI+PGJyPjxicj4KCjI1IGdyZWVuIGJveCB3aXRoIHdvcmQgb2s6CjxkaXYg aWQ9IjI1YSIgY2xhc3M9ImludmlzaWJsZSBhYnN0b3AgcmVkIj4KPGRpdiBjbGFzcz0iaW52aXNp YmxlIHJlZCI+CjwvZGl2Pgo8ZGl2IGNsYXNzPSJhYnMgaW52aXNpYmxlIHJlZCI+CjwvZGl2Pgo8 ZGl2IGlkPSIyNWIiIGNsYXNzPSJhYnMgaW52aXNpYmxlIHJlZCI+CjxzcGFuPmJsYWg8L3NwYW4+ CjwvZGl2Pgo8ZGl2IGlkPSIyNWMiIGNsYXNzPSJ2aXNpYmxlIHJlZCI+CjwvZGl2Pgo8ZGl2IGNs YXNzPSJ2aXNpYmxlIGdyZWVuIj4Kb2sKPC9kaXY+CjwvZGl2Pgo8YnI+PGJyPjxicj48YnI+Cgoy NiBncmVlbiBib3ggd2l0aCB3b3JkIG9rOgo8ZGl2IGlkPSIyNmEiIGNsYXNzPSJpbnZpc2libGUg YWJzdG9wIHJlZCI+CjxkaXYgY2xhc3M9ImludmlzaWJsZSByZWQiPgo8ZGl2PmJsYWg8L2Rpdj4K PC9kaXY+CjxkaXYgY2xhc3M9ImFicyBpbnZpc2libGUgcmVkIj4KPHNwYW4+YmxhaDwvc3Bhbj4K PC9kaXY+CjxkaXYgaWQ9IjI2YiIgY2xhc3M9ImFicyBpbnZpc2libGUgcmVkIj4KPHNwYW4+Ymxh aDwvc3Bhbj4KPC9kaXY+CjxkaXYgaWQ9IjI2YyIgY2xhc3M9InZpc2libGUgcmVkIj4KPC9kaXY+ CjxkaXYgY2xhc3M9InZpc2libGUgZ3JlZW4iPgpvawo8L2Rpdj4KPC9kaXY+Cjxicj48YnI+PGJy Pjxicj4KPC9ib2R5Pgo8L2h0bWw+Cg== 12214 2007-01-04 04:36:44 -0800 2010-06-10 14:25:49 -0700 fixed visibility-sublayer.patch text/plain 1329 koivisto SW5kZXg6IFJlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBSZW5kZXJMYXllci5jcHAJKHJl dmlzaW9uIDE4NTUzKQorKysgUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTIs MjAgKzI5MiwyMCBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVWaXNpYmlsaXR5U3RhdHVzCiAg ICAgICAgICAgICBtX2hhc1Zpc2libGVDb250ZW50ID0gZmFsc2U7CiAgICAgICAgICAgICBSZW5k ZXJPYmplY3QqIHIgPSBtX29iamVjdC0+Zmlyc3RDaGlsZCgpOwogICAgICAgICAgICAgd2hpbGUg KHIpIHsKLSAgICAgICAgICAgICAgICBpZiAoci0+c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJ U0lCTEUpIHsKKyAgICAgICAgICAgICAgICBpZiAoci0+c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09 IFZJU0lCTEUgJiYgIXItPmxheWVyKCkpIHsKICAgICAgICAgICAgICAgICAgICAgbV9oYXNWaXNp YmxlQ29udGVudCA9IHRydWU7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgICAgICBpZiAoci0+Zmlyc3RDaGlsZCgpICYmICFyLT5maXJz dENoaWxkKCktPmxheWVyKCkpCisgICAgICAgICAgICAgICAgaWYgKHItPmZpcnN0Q2hpbGQoKSAm JiAhci0+bGF5ZXIoKSkKICAgICAgICAgICAgICAgICAgICAgciA9IHItPmZpcnN0Q2hpbGQoKTsK LSAgICAgICAgICAgICAgICBlbHNlIGlmIChyLT5uZXh0U2libGluZygpICYmICFyLT5uZXh0U2li bGluZygpLT5sYXllcigpKQorICAgICAgICAgICAgICAgIGVsc2UgaWYgKHItPm5leHRTaWJsaW5n KCkpCiAgICAgICAgICAgICAgICAgICAgIHIgPSByLT5uZXh0U2libGluZygpOwogICAgICAgICAg ICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgICAgICB3aGlsZSAociAmJiAoIXItPm5leHRT aWJsaW5nKCkgfHwgci0+bmV4dFNpYmxpbmcoKS0+bGF5ZXIoKSkpIHsKKyAgICAgICAgICAgICAg ICAgICAgZG8gewogICAgICAgICAgICAgICAgICAgICAgICAgciA9IHItPnBhcmVudCgpOwogICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKHI9PW1fb2JqZWN0KQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHIgPSAwOwotICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAg ICAgIH0gd2hpbGUgKHIgJiYgIXItPm5leHRTaWJsaW5nKCkpOwogICAgICAgICAgICAgICAgICAg ICBpZiAocikKICAgICAgICAgICAgICAgICAgICAgICAgIHIgPSByLT5uZXh0U2libGluZygpOwog ICAgICAgICAgICAgICAgIH0K