<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>121079</bug_id>
          
          <creation_ts>2013-09-09 23:26:56 -0700</creation_ts>
          <short_desc>structure of frame tree is not correct in WINCE port.</short_desc>
          <delta_ts>2013-11-04 16:45:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Zhuang Zhigang">zhuangzg</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>paroga</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>927159</commentid>
    <comment_count>0</comment_count>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-09-09 23:26:56 -0700</bug_when>
    <thetext>We are working on WINCE port.When we open some contents that contain frames, sometimes we can&apos;t get expected results.
We checked the code of WebView in WINCE port. We think the method of WebView::createFrame is not correct.
The frame that used as parent frame is the main frame. So, when a child frame is created, it is created as child of main frame. In the end, all the children frames (even children of children) are created as child of main frame.

This can be resolved by passing the correct parent frame from FrameLoaderClientWinCE::createFrame to WebView::createFrame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931920</commentid>
    <comment_count>1</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2013-09-22 13:06:14 -0700</bug_when>
    <thetext>Can you post a patch for that to this bug? See http://www.webkit.org/coding/contributing.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>932018</commentid>
    <comment_count>2</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-09-22 22:42:48 -0700</bug_when>
    <thetext>This might have regressed with bugs #119964 and #120092.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>932525</commentid>
    <comment_count>3</comment_count>
      <attachid>212460</attachid>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-09-24 06:25:43 -0700</bug_when>
    <thetext>Created attachment 212460
Change structure of frame tree in WINCE port.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945454</commentid>
    <comment_count>4</comment_count>
      <attachid>212460</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2013-10-31 01:45:07 -0700</bug_when>
    <thetext>Comment on attachment 212460
Change structure of frame tree in WINCE port.

Please set the r? flag to get the patch reviewed and into the tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945552</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-10-31 09:45:58 -0700</bug_when>
    <thetext>This patch seems to have a bunch of improper line-endings.  Can you reupload the patch with matching EOL encoding as the source files in the repository.

The EWS bots cannot apply the patch, and so we cannot confirm that there are no regressions when adding this to the archive.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945557</commentid>
    <comment_count>6</comment_count>
      <attachid>212460</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-10-31 09:52:27 -0700</bug_when>
    <thetext>Comment on attachment 212460
Change structure of frame tree in WINCE port.

This patch looks fine to me, but it cannot be applied by our bot system. I&apos;m marking it r- to correct the line-endings, otherwise it looks good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945797</commentid>
    <comment_count>7</comment_count>
      <attachid>215704</attachid>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-10-31 18:02:42 -0700</bug_when>
    <thetext>Created attachment 215704
A new patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945800</commentid>
    <comment_count>8</comment_count>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-10-31 18:04:31 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; This patch seems to have a bunch of improper line-endings.  Can you reupload the patch with matching EOL encoding as the source files in the repository.
&gt; 
&gt; The EWS bots cannot apply the patch, and so we cannot confirm that there are no regressions when adding this to the archive.
&gt; 
&gt; Thanks!
A new patch was uploaded, and I have checked it with Tools/Scripts/check-webkit-style. Please check it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945858</commentid>
    <comment_count>9</comment_count>
      <attachid>215704</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2013-11-01 01:18:58 -0700</bug_when>
    <thetext>Comment on attachment 215704
A new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215704&amp;action=review

&gt; Source/WebKit/wince/WebView.cpp:161
&gt; +    Frame* parentFrame = frame;

Why do this additional assignment? Just rename the parameter name of the function.

Otherwise looks ok to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945870</commentid>
    <comment_count>10</comment_count>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-11-01 02:33:29 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 215704 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=215704&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/wince/WebView.cpp:161
&gt; &gt; +    Frame* parentFrame = frame;
&gt; 
&gt; Why do this additional assignment? Just rename the parameter name of the function.
&gt; 
&gt; Otherwise looks ok to me.
I changed the name because I think parentFrame is a suitable name for this variable. Anyway I will change it back and upload a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945871</commentid>
    <comment_count>11</comment_count>
      <attachid>215725</attachid>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-11-01 02:35:09 -0700</bug_when>
    <thetext>Created attachment 215725
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945882</commentid>
    <comment_count>12</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2013-11-01 03:33:51 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #9)
&gt; &gt; (From update of attachment 215704 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=215704&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebKit/wince/WebView.cpp:161
&gt; &gt; &gt; +    Frame* parentFrame = frame;
&gt; &gt; 
&gt; &gt; Why do this additional assignment? Just rename the parameter name of the function.
&gt; &gt; 
&gt; &gt; Otherwise looks ok to me.
&gt; I changed the name because I think parentFrame is a suitable name for this variable. Anyway I will change it back and upload a new patch.

Renaming it to parentFrame is ok, but the assignment of &quot;parentFrame = frame&quot; is not necessary. Just rename frame (last parameter of the method) to parentFrame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945969</commentid>
    <comment_count>13</comment_count>
      <attachid>215725</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2013-11-01 11:49:54 -0700</bug_when>
    <thetext>Comment on attachment 215725
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215725&amp;action=review

&gt; Source/WebKit/wince/WebView.cpp:159
&gt;  PassRefPtr&lt;Frame&gt; WebView::createFrame(const URL&amp; url, const String&amp; name, HTMLFrameOwnerElement* ownerElement, const String&amp; referrer,
&gt; -                                       bool /*allowsScrolling*/, int /*marginWidth*/, int /*marginHeight*/)
&gt; +    bool /*allowsScrolling*/, int /*marginWidth*/, int /*marginHeight*/, Frame* frame)

Argument should be named parentFrame.

&gt; Source/WebKit/wince/WebView.h:72
&gt; +    PassRefPtr&lt;WebCore::Frame&gt; createFrame(const WebCore::URL&amp;, const WTF::String&amp;, WebCore::HTMLFrameOwnerElement*, const WTF::String&amp;, bool, int, int, WebCore::Frame*);

Should give the arguments names here, except the ones that are obvious from the type along. The meanings of the strings, bool, ints, and frame are not obvious.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>946532</commentid>
    <comment_count>14</comment_count>
      <attachid>215886</attachid>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-11-03 20:12:30 -0800</bug_when>
    <thetext>Created attachment 215886
updated patch according to opinion of review results</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>946533</commentid>
    <comment_count>15</comment_count>
    <who name="Zhuang Zhigang">zhuangzg</who>
    <bug_when>2013-11-03 20:21:08 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; (From update of attachment 215725 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=215725&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/wince/WebView.cpp:159
&gt; &gt;  PassRefPtr&lt;Frame&gt; WebView::createFrame(const URL&amp; url, const String&amp; name, HTMLFrameOwnerElement* ownerElement, const String&amp; referrer,
&gt; &gt; -                                       bool /*allowsScrolling*/, int /*marginWidth*/, int /*marginHeight*/)
&gt; &gt; +    bool /*allowsScrolling*/, int /*marginWidth*/, int /*marginHeight*/, Frame* frame)
&gt; 
&gt; Argument should be named parentFrame.
&gt; 
Yes, I see.
Argument name was changed.
Then removed assignment for &quot;coreFrame&quot; and changed remaining of &quot;coreFrame&quot; to &quot;parentFrame&quot;.

&gt; &gt; Source/WebKit/wince/WebView.h:72
&gt; &gt; +    PassRefPtr&lt;WebCore::Frame&gt; createFrame(const WebCore::URL&amp;, const WTF::String&amp;, WebCore::HTMLFrameOwnerElement*, const WTF::String&amp;, bool, int, int, WebCore::Frame*);
&gt; 
&gt; Should give the arguments names here, except the ones that are obvious from the type along. The meanings of the strings, bool, ints, and frame are not obvious.
OK, I added the arguments names for these strings, bool, ints, and frame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>946890</commentid>
    <comment_count>16</comment_count>
      <attachid>215886</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-04 16:45:01 -0800</bug_when>
    <thetext>Comment on attachment 215886
updated patch according to opinion of review results

Clearing flags on attachment: 215886

Committed r158616: &lt;http://trac.webkit.org/changeset/158616&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>946891</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-04 16:45:03 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212460</attachid>
            <date>2013-09-24 06:25:43 -0700</date>
            <delta_ts>2013-11-01 02:35:09 -0700</delta_ts>
            <desc>Change structure of frame tree in WINCE port.</desc>
            <filename>frame.patch</filename>
            <type>text/plain</type>
            <size>3769</size>
            <attacher name="Zhuang Zhigang">zhuangzg</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291
cmNlL1dlYktpdC93aW5jZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjMyNSkNCisrKyBTb3VyY2Uv
V2ViS2l0L3dpbmNlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNiBAQA0K
KzIwMTMtMDktMjQgIFpodWFuZyBaaGlnYW5nICA8emh1YW5nemdAY24uZnVqaXRzdS5jb20+CisK
KyAgICAgICAgQ2hhbmdlIHN0cnVjdHVyZSBvZiBmcmFtZSB0cmVlIGluIFdJTkNFIHBvcnQuCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAwOTIKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVT
dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V2luQ0UuY3BwOgorCShXZWJLaXQ6OkZyYW1lTG9hZGVy
Q2xpZW50V2luQ0U6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKwkoV2Vi
Vmlldzo6Y3JlYXRlRnJhbWUpOgorICAgICAgICAqIFdlYlZpZXcuaDoKKwogMjAxMy0wOS0xNiAg
RW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVz
ZWQgZnVuY3Rpb24gZGlkU2V0U2VsZWN0aW9uVHlwZXNGb3JQYXN0ZWJvYXJkIGZyb20gRWRpdG9y
Q2xpZW50LgpJbmRleDogU291cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv
YWRlckNsaWVudFdpbkNFLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9XZWJLaXQvd2luY2Uv
V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRXaW5DRS5jcHAJKHJldmlzaW9uIDE1NjMy
NSkNCisrKyBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xp
ZW50V2luQ0UuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTcwLDcgKzE3MCw3IEBADQogUGFzc1Jl
ZlB0cjxGcmFtZT4gRnJhbWVMb2FkZXJDbGllbnRXaW5DRTo6Y3JlYXRlRnJhbWUoY29uc3QgS1VS
TCYgdXJsLCBjb25zdCBTdHJpbmcmIG5hbWUsIEhUTUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJF
bGVtZW50LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGNvbnN0IFN0cmluZyYgcmVmZXJyZXIsIGJvb2wgYWxsb3dzU2Nyb2xsaW5nLCBpbnQgbWFyZ2lu
V2lkdGgsIGludCBtYXJnaW5IZWlnaHQpCiB7Ci0gICAgcmV0dXJuIG1fd2ViVmlldy0+Y3JlYXRl
RnJhbWUodXJsLCBuYW1lLCBvd25lckVsZW1lbnQsIHJlZmVycmVyLCBhbGxvd3NTY3JvbGxpbmcs
IG1hcmdpbldpZHRoLCBtYXJnaW5IZWlnaHQpOworICAgIHJldHVybiBtX3dlYlZpZXctPmNyZWF0
ZUZyYW1lKHVybCwgbmFtZSwgb3duZXJFbGVtZW50LCByZWZlcnJlciwgYWxsb3dzU2Nyb2xsaW5n
LCBtYXJnaW5XaWR0aCwgbWFyZ2luSGVpZ2h0LCBtX2ZyYW1lKTsKIH0KIAogdm9pZCBGcmFtZUxv
YWRlckNsaWVudFdpbkNFOjpyZWRpcmVjdERhdGFUb1BsdWdpbihXaWRnZXQqIHBsdWdpbldpZGdl
dCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViVmlldy5jcHANCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0t
LSBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNTYzMjUpDQorKysg
U291cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTE1Niwx
NSArMTU2LDE1IEBADQogfQogCiBQYXNzUmVmUHRyPEZyYW1lPiBXZWJWaWV3OjpjcmVhdGVGcmFt
ZShjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgbmFtZSwgSFRNTEZyYW1lT3duZXJFbGVt
ZW50KiBvd25lckVsZW1lbnQsIGNvbnN0IFN0cmluZyYgcmVmZXJyZXIsCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIC8qYWxsb3dzU2Nyb2xsaW5nKi8sIGludCAv
Km1hcmdpbldpZHRoKi8sIGludCAvKm1hcmdpbkhlaWdodCovKQorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgYm9vbCAvKmFsbG93c1Njcm9sbGluZyovLCBpbnQgLyptYXJn
aW5XaWR0aCovLCBpbnQgLyptYXJnaW5IZWlnaHQqLywgRnJhbWUqIGZyYW1lKQogewotICAgIEZy
YW1lKiBjb3JlRnJhbWUgPSBtX2ZyYW1lOworICAgIEZyYW1lKiBwYXJlbnRGcmFtZSA9IGZyYW1l
OwogCiAgICAgV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudFdpbkNFICpsb2FkZXJDbGllbnQgPSBu
ZXcgV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudFdpbkNFKHRoaXMpOwogICAgIFJlZlB0cjxGcmFt
ZT4gY2hpbGRGcmFtZSA9IEZyYW1lOjpjcmVhdGUobV9wYWdlLCBvd25lckVsZW1lbnQsIGxvYWRl
ckNsaWVudCk7CiAgICAgbG9hZGVyQ2xpZW50LT5zZXRGcmFtZShjaGlsZEZyYW1lLmdldCgpKTsK
IAotICAgIGNvcmVGcmFtZS0+dHJlZSgpLmFwcGVuZENoaWxkKGNoaWxkRnJhbWUpOworICAgIHBh
cmVudEZyYW1lLT50cmVlKCkuYXBwZW5kQ2hpbGQoY2hpbGRGcmFtZSk7CiAgICAgY2hpbGRGcmFt
ZS0+dHJlZSgpLnNldE5hbWUobmFtZSk7CiAgICAgY2hpbGRGcmFtZS0+aW5pdCgpOwogCkBAIC0x
NzIsNyArMTcyLDcgQEANCiAgICAgaWYgKCFjaGlsZEZyYW1lLT5wYWdlKCkpCiAgICAgICAgIHJl
dHVybiAwOwogCi0gICAgY29yZUZyYW1lLT5sb2FkZXIoKS5sb2FkVVJMSW50b0NoaWxkRnJhbWUo
dXJsLCByZWZlcnJlciwgY2hpbGRGcmFtZS5nZXQoKSk7CisgICAgcGFyZW50RnJhbWUtPmxvYWRl
cigpLmxvYWRVUkxJbnRvQ2hpbGRGcmFtZSh1cmwsIHJlZmVycmVyLCBjaGlsZEZyYW1lLmdldCgp
KTsKIAogICAgIC8vIFRoZSBmcmFtZSdzIG9ubG9hZCBoYW5kbGVyIG1heSBoYXZlIHJlbW92ZWQg
aXQgZnJvbSB0aGUgZG9jdW1lbnQuCiAgICAgaWYgKCFjaGlsZEZyYW1lLT50cmVlKCkucGFyZW50
KCkpCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuaA0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t
IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViVmlldy5oCShyZXZpc2lvbiAxNTYzMjUpDQorKysgU291
cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmgJKHdvcmtpbmcgY29weSkNCkBAIC02OSw3ICs2OSw3
IEBADQogCiAgICAgdm9pZCBmcmFtZVJlY3QoUkVDVCogcmVjdCkgY29uc3Q7CiAKLSAgICBQYXNz
UmVmUHRyPFdlYkNvcmU6OkZyYW1lPiBjcmVhdGVGcmFtZShjb25zdCBXZWJDb3JlOjpLVVJMJiwg
Y29uc3QgV1RGOjpTdHJpbmcmLCBXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqLCBjb25z
dCBXVEY6OlN0cmluZyYsIGJvb2wsIGludCwgaW50KTsKKyAgICBQYXNzUmVmUHRyPFdlYkNvcmU6
OkZyYW1lPiBjcmVhdGVGcmFtZShjb25zdCBXZWJDb3JlOjpLVVJMJiwgY29uc3QgV1RGOjpTdHJp
bmcmLCBXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqLCBjb25zdCBXVEY6OlN0cmluZyYs
IGJvb2wsIGludCwgaW50LCBXZWJDb3JlOjpGcmFtZSopOwogCiAgICAgLy8gSmF2YVNjcmlwdCBE
aWFsb2cKICAgICB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChjb25zdCBXVEY6OlN0cmluZyYgbWVz
c2FnZSk7Cg==
</data>
<flag name="review"
          id="237096"
          type_id="1"
          status="-"
          setter="bfulgham"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215704</attachid>
            <date>2013-10-31 18:02:42 -0700</date>
            <delta_ts>2013-11-03 20:12:30 -0800</delta_ts>
            <desc>A new patch</desc>
            <filename>patch_121079.txt</filename>
            <type>text/plain</type>
            <size>3706</size>
            <attacher name="Zhuang Zhigang">zhuangzg</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll
bnRXaW5DRS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3Vw
cG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNwcAkocmV2aXNpb24gMTU4NDExKQorKysgU291
cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDcgKzE3MCw3IEBACiBQYXNzUmVmUHRyPEZyYW1lPiBG
cmFtZUxvYWRlckNsaWVudFdpbkNFOjpjcmVhdGVGcmFtZShjb25zdCBVUkwmIHVybCwgY29uc3Qg
U3RyaW5nJiBuYW1lLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcm
IHJlZmVycmVyLCBib29sIGFsbG93c1Njcm9sbGluZywgaW50IG1hcmdpbldpZHRoLCBpbnQgbWFy
Z2luSGVpZ2h0KQogewotICAgIHJldHVybiBtX3dlYlZpZXctPmNyZWF0ZUZyYW1lKHVybCwgbmFt
ZSwgb3duZXJFbGVtZW50LCByZWZlcnJlciwgYWxsb3dzU2Nyb2xsaW5nLCBtYXJnaW5XaWR0aCwg
bWFyZ2luSGVpZ2h0KTsKKyAgICByZXR1cm4gbV93ZWJWaWV3LT5jcmVhdGVGcmFtZSh1cmwsIG5h
bWUsIG93bmVyRWxlbWVudCwgcmVmZXJyZXIsIGFsbG93c1Njcm9sbGluZywgbWFyZ2luV2lkdGgs
IG1hcmdpbkhlaWdodCwgbV9mcmFtZSk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRXaW5D
RTo6cmVkaXJlY3REYXRhVG9QbHVnaW4oV2lkZ2V0KiBwbHVnaW5XaWRnZXQpCkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3dpbmNlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dp
bmNlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NDEzKQorKysgU291cmNlL1dlYktpdC93aW5jZS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMC0zMSAgWmh1
YW5nIFpoaWdhbmcgIDx6aHVhbmd6Z0Bjbi5mdWppdHN1LmNvbT4KKworICAgICAgICBDaGFuZ2Ug
c3RydWN0dXJlIG9mIGZyYW1lIHRyZWUgaW4gV0lOQ0UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTA3OQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk
ZXJDbGllbnRXaW5DRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50V2lu
Q0U6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZp
ZXc6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3Lmg6CisKIDIwMTMtMTAtMDMgIFNh
bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgc2hvdWxkUnViYmVy
QmFuZEluRGlyZWN0aW9uIGZyb20gdGhlIFdLQnVuZGxlUGFnZVVJQ2xpZW50CkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv
d2luY2UvV2ViVmlldy5jcHAJKHJldmlzaW9uIDE1ODQxMSkKKysrIFNvdXJjZS9XZWJLaXQvd2lu
Y2UvV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NiwxNSArMTU2LDE1IEBACiB9CiAK
IFBhc3NSZWZQdHI8RnJhbWU+IFdlYlZpZXc6OmNyZWF0ZUZyYW1lKGNvbnN0IFVSTCYgdXJsLCBj
b25zdCBTdHJpbmcmIG5hbWUsIEhUTUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJFbGVtZW50LCBj
b25zdCBTdHJpbmcmIHJlZmVycmVyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgYm9vbCAvKmFsbG93c1Njcm9sbGluZyovLCBpbnQgLyptYXJnaW5XaWR0aCovLCBpbnQg
LyptYXJnaW5IZWlnaHQqLykKKyAgICBib29sIC8qYWxsb3dzU2Nyb2xsaW5nKi8sIGludCAvKm1h
cmdpbldpZHRoKi8sIGludCAvKm1hcmdpbkhlaWdodCovLCBGcmFtZSogZnJhbWUpCiB7Ci0gICAg
RnJhbWUqIGNvcmVGcmFtZSA9IG1fZnJhbWU7CisgICAgRnJhbWUqIHBhcmVudEZyYW1lID0gZnJh
bWU7CiAKICAgICBXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50V2luQ0UgKmxvYWRlckNsaWVudCA9
IG5ldyBXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50V2luQ0UodGhpcyk7CiAgICAgUmVmUHRyPEZy
YW1lPiBjaGlsZEZyYW1lID0gRnJhbWU6OmNyZWF0ZShtX3BhZ2UsIG93bmVyRWxlbWVudCwgbG9h
ZGVyQ2xpZW50KTsKICAgICBsb2FkZXJDbGllbnQtPnNldEZyYW1lKGNoaWxkRnJhbWUuZ2V0KCkp
OwogCi0gICAgY29yZUZyYW1lLT50cmVlKCkuYXBwZW5kQ2hpbGQoY2hpbGRGcmFtZSk7CisgICAg
cGFyZW50RnJhbWUtPnRyZWUoKS5hcHBlbmRDaGlsZChjaGlsZEZyYW1lKTsKICAgICBjaGlsZEZy
YW1lLT50cmVlKCkuc2V0TmFtZShuYW1lKTsKICAgICBjaGlsZEZyYW1lLT5pbml0KCk7CiAKQEAg
LTE3Miw3ICsxNzIsNyBAQAogICAgIGlmICghY2hpbGRGcmFtZS0+cGFnZSgpKQogICAgICAgICBy
ZXR1cm4gMDsKIAotICAgIGNvcmVGcmFtZS0+bG9hZGVyKCkubG9hZFVSTEludG9DaGlsZEZyYW1l
KHVybCwgcmVmZXJyZXIsIGNoaWxkRnJhbWUuZ2V0KCkpOworICAgIHBhcmVudEZyYW1lLT5sb2Fk
ZXIoKS5sb2FkVVJMSW50b0NoaWxkRnJhbWUodXJsLCByZWZlcnJlciwgY2hpbGRGcmFtZS5nZXQo
KSk7CiAKICAgICAvLyBUaGUgZnJhbWUncyBvbmxvYWQgaGFuZGxlciBtYXkgaGF2ZSByZW1vdmVk
IGl0IGZyb20gdGhlIGRvY3VtZW50LgogICAgIGlmICghY2hpbGRGcmFtZS0+dHJlZSgpLnBhcmVu
dCgpKQpJbmRleDogU291cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
U291cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmgJKHJldmlzaW9uIDE1ODQxMSkKKysrIFNvdXJj
ZS9XZWJLaXQvd2luY2UvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC02OSw3ICs2OSw3IEBA
CiAKICAgICB2b2lkIGZyYW1lUmVjdChSRUNUKiByZWN0KSBjb25zdDsKIAotICAgIFBhc3NSZWZQ
dHI8V2ViQ29yZTo6RnJhbWU+IGNyZWF0ZUZyYW1lKGNvbnN0IFdlYkNvcmU6OlVSTCYsIGNvbnN0
IFdURjo6U3RyaW5nJiwgV2ViQ29yZTo6SFRNTEZyYW1lT3duZXJFbGVtZW50KiwgY29uc3QgV1RG
OjpTdHJpbmcmLCBib29sLCBpbnQsIGludCk7CisgICAgUGFzc1JlZlB0cjxXZWJDb3JlOjpGcmFt
ZT4gY3JlYXRlRnJhbWUoY29uc3QgV2ViQ29yZTo6VVJMJiwgY29uc3QgV1RGOjpTdHJpbmcmLCBX
ZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqLCBjb25zdCBXVEY6OlN0cmluZyYsIGJvb2ws
IGludCwgaW50LCBXZWJDb3JlOjpGcmFtZSopOwogCiAgICAgLy8gSmF2YVNjcmlwdCBEaWFsb2cK
ICAgICB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChjb25zdCBXVEY6OlN0cmluZyYgbWVzc2FnZSk7
Cg==
</data>
<flag name="review"
          id="238499"
          type_id="1"
          status="-"
          setter="paroga"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215725</attachid>
            <date>2013-11-01 02:35:09 -0700</date>
            <delta_ts>2013-11-03 20:12:30 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>patch_121079_2.txt</filename>
            <type>text/plain</type>
            <size>3139</size>
            <attacher name="Zhuang Zhigang">zhuangzg</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll
bnRXaW5DRS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3Vw
cG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNwcAkocmV2aXNpb24gMTU4NDExKQorKysgU291
cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDcgKzE3MCw3IEBACiBQYXNzUmVmUHRyPEZyYW1lPiBG
cmFtZUxvYWRlckNsaWVudFdpbkNFOjpjcmVhdGVGcmFtZShjb25zdCBVUkwmIHVybCwgY29uc3Qg
U3RyaW5nJiBuYW1lLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcm
IHJlZmVycmVyLCBib29sIGFsbG93c1Njcm9sbGluZywgaW50IG1hcmdpbldpZHRoLCBpbnQgbWFy
Z2luSGVpZ2h0KQogewotICAgIHJldHVybiBtX3dlYlZpZXctPmNyZWF0ZUZyYW1lKHVybCwgbmFt
ZSwgb3duZXJFbGVtZW50LCByZWZlcnJlciwgYWxsb3dzU2Nyb2xsaW5nLCBtYXJnaW5XaWR0aCwg
bWFyZ2luSGVpZ2h0KTsKKyAgICByZXR1cm4gbV93ZWJWaWV3LT5jcmVhdGVGcmFtZSh1cmwsIG5h
bWUsIG93bmVyRWxlbWVudCwgcmVmZXJyZXIsIGFsbG93c1Njcm9sbGluZywgbWFyZ2luV2lkdGgs
IG1hcmdpbkhlaWdodCwgbV9mcmFtZSk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRXaW5D
RTo6cmVkaXJlY3REYXRhVG9QbHVnaW4oV2lkZ2V0KiBwbHVnaW5XaWRnZXQpCkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3dpbmNlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dp
bmNlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NDEzKQorKysgU291cmNlL1dlYktpdC93aW5jZS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMC0zMSAgWmh1
YW5nIFpoaWdhbmcgIDx6aHVhbmd6Z0Bjbi5mdWppdHN1LmNvbT4KKworICAgICAgICBDaGFuZ2Ug
c3RydWN0dXJlIG9mIGZyYW1lIHRyZWUgaW4gV0lOQ0UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTA3OQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk
ZXJDbGllbnRXaW5DRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50V2lu
Q0U6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZp
ZXc6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3Lmg6CisKIDIwMTMtMTAtMDMgIFNh
bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgc2hvdWxkUnViYmVy
QmFuZEluRGlyZWN0aW9uIGZyb20gdGhlIFdLQnVuZGxlUGFnZVVJQ2xpZW50CkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv
d2luY2UvV2ViVmlldy5jcHAJKHJldmlzaW9uIDE1ODQxMSkKKysrIFNvdXJjZS9XZWJLaXQvd2lu
Y2UvV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Niw5ICsxNTYsOSBAQAogfQogCiBQ
YXNzUmVmUHRyPEZyYW1lPiBXZWJWaWV3OjpjcmVhdGVGcmFtZShjb25zdCBVUkwmIHVybCwgY29u
c3QgU3RyaW5nJiBuYW1lLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwgY29u
c3QgU3RyaW5nJiByZWZlcnJlciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGJvb2wgLyphbGxvd3NTY3JvbGxpbmcqLywgaW50IC8qbWFyZ2luV2lkdGgqLywgaW50IC8q
bWFyZ2luSGVpZ2h0Ki8pCisgICAgYm9vbCAvKmFsbG93c1Njcm9sbGluZyovLCBpbnQgLyptYXJn
aW5XaWR0aCovLCBpbnQgLyptYXJnaW5IZWlnaHQqLywgRnJhbWUqIGZyYW1lKQogewotICAgIEZy
YW1lKiBjb3JlRnJhbWUgPSBtX2ZyYW1lOworICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBmcmFtZTsK
IAogICAgIFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnRXaW5DRSAqbG9hZGVyQ2xpZW50ID0gbmV3
IFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnRXaW5DRSh0aGlzKTsKICAgICBSZWZQdHI8RnJhbWU+
IGNoaWxkRnJhbWUgPSBGcmFtZTo6Y3JlYXRlKG1fcGFnZSwgb3duZXJFbGVtZW50LCBsb2FkZXJD
bGllbnQpOwpJbmRleDogU291cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmgKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1dlYktpdC93aW5jZS9XZWJWaWV3LmgJKHJldmlzaW9uIDE1ODQxMSkKKysrIFNv
dXJjZS9XZWJLaXQvd2luY2UvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC02OSw3ICs2OSw3
IEBACiAKICAgICB2b2lkIGZyYW1lUmVjdChSRUNUKiByZWN0KSBjb25zdDsKIAotICAgIFBhc3NS
ZWZQdHI8V2ViQ29yZTo6RnJhbWU+IGNyZWF0ZUZyYW1lKGNvbnN0IFdlYkNvcmU6OlVSTCYsIGNv
bnN0IFdURjo6U3RyaW5nJiwgV2ViQ29yZTo6SFRNTEZyYW1lT3duZXJFbGVtZW50KiwgY29uc3Qg
V1RGOjpTdHJpbmcmLCBib29sLCBpbnQsIGludCk7CisgICAgUGFzc1JlZlB0cjxXZWJDb3JlOjpG
cmFtZT4gY3JlYXRlRnJhbWUoY29uc3QgV2ViQ29yZTo6VVJMJiwgY29uc3QgV1RGOjpTdHJpbmcm
LCBXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqLCBjb25zdCBXVEY6OlN0cmluZyYsIGJv
b2wsIGludCwgaW50LCBXZWJDb3JlOjpGcmFtZSopOwogCiAgICAgLy8gSmF2YVNjcmlwdCBEaWFs
b2cKICAgICB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChjb25zdCBXVEY6OlN0cmluZyYgbWVzc2Fn
ZSk7Cg==
</data>
<flag name="review"
          id="238522"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215886</attachid>
            <date>2013-11-03 20:12:30 -0800</date>
            <delta_ts>2013-11-04 16:45:00 -0800</delta_ts>
            <desc>updated patch according to opinion of review results</desc>
            <filename>patch_121079_3.txt</filename>
            <type>text/plain</type>
            <size>3738</size>
            <attacher name="Zhuang Zhigang">zhuangzg</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll
bnRXaW5DRS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3Vw
cG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNwcAkocmV2aXNpb24gMTU4NTUxKQorKysgU291
cmNlL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFdpbkNFLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtMTcxLDcgKzE3MSw3IEBACiBQYXNzUmVmUHRyPEZyYW1lPiBG
cmFtZUxvYWRlckNsaWVudFdpbkNFOjpjcmVhdGVGcmFtZShjb25zdCBVUkwmIHVybCwgY29uc3Qg
U3RyaW5nJiBuYW1lLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwKICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcm
IHJlZmVycmVyLCBib29sIGFsbG93c1Njcm9sbGluZywgaW50IG1hcmdpbldpZHRoLCBpbnQgbWFy
Z2luSGVpZ2h0KQogewotICAgIHJldHVybiBtX3dlYlZpZXctPmNyZWF0ZUZyYW1lKHVybCwgbmFt
ZSwgb3duZXJFbGVtZW50LCByZWZlcnJlciwgYWxsb3dzU2Nyb2xsaW5nLCBtYXJnaW5XaWR0aCwg
bWFyZ2luSGVpZ2h0KTsKKyAgICByZXR1cm4gbV93ZWJWaWV3LT5jcmVhdGVGcmFtZSh1cmwsIG5h
bWUsIG93bmVyRWxlbWVudCwgcmVmZXJyZXIsIGFsbG93c1Njcm9sbGluZywgbWFyZ2luV2lkdGgs
IG1hcmdpbkhlaWdodCwgbV9mcmFtZSk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRXaW5D
RTo6cmVkaXJlY3REYXRhVG9QbHVnaW4oV2lkZ2V0KiBwbHVnaW5XaWRnZXQpCkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3dpbmNlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dp
bmNlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NTU0KQorKysgU291cmNlL1dlYktpdC93aW5jZS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMS0wMyAgWmh1
YW5nIFpoaWdhbmcgIDx6aHVhbmd6Z0Bjbi5mdWppdHN1LmNvbT4KKworICAgICAgICBDaGFuZ2Ug
c3RydWN0dXJlIG9mIGZyYW1lIHRyZWUgaW4gV0lOQ0UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTA3OQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk
ZXJDbGllbnRXaW5DRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50V2lu
Q0U6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZp
ZXc6OmNyZWF0ZUZyYW1lKToKKyAgICAgICAgKiBXZWJWaWV3Lmg6CisKIDIwMTMtMTEtMDMgIFBh
dHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTkNFXSBS
ZXBsYWNlIE93blB0ciB3aXRoIEdESU9iamVjdApJbmRleDogU291cmNlL1dlYktpdC93aW5jZS9X
ZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuY3Bw
CShyZXZpc2lvbiAxNTg1NTEpCisrKyBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0xNTcsMTUgKzE1NywxMyBAQAogfQogCiBQYXNzUmVmUHRyPEZyYW1l
PiBXZWJWaWV3OjpjcmVhdGVGcmFtZShjb25zdCBVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBuYW1l
LCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwgY29uc3QgU3RyaW5nJiByZWZl
cnJlciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgLyphbGxv
d3NTY3JvbGxpbmcqLywgaW50IC8qbWFyZ2luV2lkdGgqLywgaW50IC8qbWFyZ2luSGVpZ2h0Ki8p
CisgICAgYm9vbCAvKmFsbG93c1Njcm9sbGluZyovLCBpbnQgLyptYXJnaW5XaWR0aCovLCBpbnQg
LyptYXJnaW5IZWlnaHQqLywgRnJhbWUqIHBhcmVudEZyYW1lKQogewotICAgIEZyYW1lKiBjb3Jl
RnJhbWUgPSBtX2ZyYW1lOwotCiAgICAgV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudFdpbkNFICps
b2FkZXJDbGllbnQgPSBuZXcgV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudFdpbkNFKHRoaXMpOwog
ICAgIFJlZlB0cjxGcmFtZT4gY2hpbGRGcmFtZSA9IEZyYW1lOjpjcmVhdGUobV9wYWdlLCBvd25l
ckVsZW1lbnQsIGxvYWRlckNsaWVudCk7CiAgICAgbG9hZGVyQ2xpZW50LT5zZXRGcmFtZShjaGls
ZEZyYW1lLmdldCgpKTsKIAotICAgIGNvcmVGcmFtZS0+dHJlZSgpLmFwcGVuZENoaWxkKGNoaWxk
RnJhbWUpOworICAgIHBhcmVudEZyYW1lLT50cmVlKCkuYXBwZW5kQ2hpbGQoY2hpbGRGcmFtZSk7
CiAgICAgY2hpbGRGcmFtZS0+dHJlZSgpLnNldE5hbWUobmFtZSk7CiAgICAgY2hpbGRGcmFtZS0+
aW5pdCgpOwogCkBAIC0xNzMsNyArMTcxLDcgQEAKICAgICBpZiAoIWNoaWxkRnJhbWUtPnBhZ2Uo
KSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBjb3JlRnJhbWUtPmxvYWRlcigpLmxvYWRVUkxJ
bnRvQ2hpbGRGcmFtZSh1cmwsIHJlZmVycmVyLCBjaGlsZEZyYW1lLmdldCgpKTsKKyAgICBwYXJl
bnRGcmFtZS0+bG9hZGVyKCkubG9hZFVSTEludG9DaGlsZEZyYW1lKHVybCwgcmVmZXJyZXIsIGNo
aWxkRnJhbWUuZ2V0KCkpOwogCiAgICAgLy8gVGhlIGZyYW1lJ3Mgb25sb2FkIGhhbmRsZXIgbWF5
IGhhdmUgcmVtb3ZlZCBpdCBmcm9tIHRoZSBkb2N1bWVudC4KICAgICBpZiAoIWNoaWxkRnJhbWUt
PnRyZWUoKS5wYXJlbnQoKSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViVmlldy5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luY2UvV2ViVmlldy5oCShyZXZpc2lvbiAxNTg1
NTEpCisrKyBTb3VyY2UvV2ViS2l0L3dpbmNlL1dlYlZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAt
NjksNyArNjksOCBAQAogCiAgICAgdm9pZCBmcmFtZVJlY3QoUkVDVCogcmVjdCkgY29uc3Q7CiAK
LSAgICBQYXNzUmVmUHRyPFdlYkNvcmU6OkZyYW1lPiBjcmVhdGVGcmFtZShjb25zdCBXZWJDb3Jl
OjpVUkwmLCBjb25zdCBXVEY6OlN0cmluZyYsIFdlYkNvcmU6OkhUTUxGcmFtZU93bmVyRWxlbWVu
dCosIGNvbnN0IFdURjo6U3RyaW5nJiwgYm9vbCwgaW50LCBpbnQpOworICAgIFBhc3NSZWZQdHI8
V2ViQ29yZTo6RnJhbWU+IGNyZWF0ZUZyYW1lKGNvbnN0IFdlYkNvcmU6OlVSTCYsIGNvbnN0IFdU
Rjo6U3RyaW5nJiBuYW1lLCBXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqLCAKKyAgICAg
ICAgY29uc3QgV1RGOjpTdHJpbmcmIHJlZmVycmVyLCBib29sIGFsbG93U2Nyb2xsaW5nLCBpbnQg
bWFyZ2luV2lkdGgsIGludCBtYXJnaW5IZWlnaHQsIFdlYkNvcmU6OkZyYW1lKiBwYXJlbnRGcmFt
ZSk7CiAKICAgICAvLyBKYXZhU2NyaXB0IERpYWxvZwogICAgIHZvaWQgcnVuSmF2YVNjcmlwdEFs
ZXJ0KGNvbnN0IFdURjo6U3RyaW5nJiBtZXNzYWdlKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>