121057 2013-09-09 16:04:36 -0700 There should be one "invalid" virtual register constant 2013-09-09 23:08:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 118758 1 msaboff msaboff oldest_to_newest 926977 0 msaboff 2013-09-09 16:04:36 -0700 This is in preparation for inverting the JSC stack. Currently a virtual register value of -1 is used as an invalid virtual register. When the stack is inverted, -1 will be a valid register. Some places in the code use a literal -1 while others use the enum InvalidVirtualRegister. All places should use the InvalidVirtualRegister enum and its value should be a reasonable "invalid" value. 926983 1 211113 msaboff 2013-09-09 16:21:05 -0700 Created attachment 211113 Patch 927143 2 msaboff 2013-09-09 23:08:44 -0700 Committed r155420: <http://trac.webkit.org/changeset/155420> 211113 2013-09-09 16:21:05 -0700 2013-09-09 16:29:51 -0700 Patch 121057.patch text/plain 7060 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEzLTA5LTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFRoZXJlIHNob3VsZCBiZSBvbmUgImludmFsaWQiIHZpcnR1YWwgcmVnaXN0ZXIgY29uc3Rh bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTA1 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaWZ5 IGFsbCByZWZlcmVuY2VzIHRvIGFuIGludmFsaWQgdmlydHVhbCByZWdpc3RlciB0byBiZSB0aGUg ZW51bSBJbnZhbGlkVmlydHVhbFJlZ2lzdGVyLgorICAgICAgICBDaGFuZ2VkIHRoZSB2YWx1ZSBv ZiBJbnZhbGlkVmlydHVhbFJlZ2lzdGVyIHRvIGJlIG1heGltdW0gaW50ZWdlciB2YWx1ZS4KKwor ICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6 OnNldEFyZ3VtZW50c1JlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjp1c2VzQXJn dW1lbnRzKToKKyAgICAgICAgKiBieXRlY29kZS9MYXp5T3BlcmFuZFZhbHVlUHJvZmlsZS5oOgor ICAgICAgICAoSlNDOjpMYXp5T3BlcmFuZFZhbHVlUHJvZmlsZUtleTo6TGF6eU9wZXJhbmRWYWx1 ZVByb2ZpbGVLZXkpOgorICAgICAgICAoSlNDOjpMYXp5T3BlcmFuZFZhbHVlUHJvZmlsZUtleTo6 b3BlcmF0b3IhKToKKyAgICAgICAgKEpTQzo6TGF6eU9wZXJhbmRWYWx1ZVByb2ZpbGVLZXk6Omlz SGFzaFRhYmxlRGVsZXRlZFZhbHVlKToKKyAgICAgICAgKEpTQzo6TGF6eU9wZXJhbmRWYWx1ZVBy b2ZpbGU6OkxhenlPcGVyYW5kVmFsdWVQcm9maWxlKToKKyAgICAgICAgKiBieXRlY29kZS9Vbmxp bmtlZENvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OlVubGlua2VkQ29kZUJsb2NrOjpVbmxp bmtlZENvZGVCbG9jayk6CisgICAgICAgICogYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaDoK KyAgICAgICAgKEpTQzo6VW5saW5rZWRDb2RlQmxvY2s6OnVzZXNBcmd1bWVudHMpOgorICAgICAg ICAoSlNDOjpVbmxpbmtlZENvZGVCbG9jazo6dXNlc0dsb2JhbE9iamVjdCk6CisgICAgICAgICog Ynl0ZWNvZGUvVmlydHVhbFJlZ2lzdGVyLmg6CisKIDIwMTMtMDktMDkgIE1pY2hhZWwgU2Fib2Zm ICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgV3JvbmcgZm9yIFNsb3dQYXRoQ2FsbCB0 byBsb2FkIGNhbGxGcmFtZSByZWcgZnJvbSB2bS50b3BDYWxsRnJhbWUgYWZ0ZXIgY2FsbApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkocmV2aXNpb24g MTU1Mzk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zMjQsNyArMzI0LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRB cmd1bWVudHNSZWdpc3RlcihpbnQgYXJndW1lbnRzUmVnaXN0ZXIpCiAgICAgewotICAgICAgICBB U1NFUlQoYXJndW1lbnRzUmVnaXN0ZXIgIT0gLTEpOworICAgICAgICBBU1NFUlQoYXJndW1lbnRz UmVnaXN0ZXIgIT0gKGludClJbnZhbGlkVmlydHVhbFJlZ2lzdGVyKTsKICAgICAgICAgbV9hcmd1 bWVudHNSZWdpc3RlciA9IGFyZ3VtZW50c1JlZ2lzdGVyOwogICAgICAgICBBU1NFUlQodXNlc0Fy Z3VtZW50cygpKTsKICAgICB9CkBAIC0zNTQsNyArMzU0LDcgQEAgcHVibGljOgogICAgICAgICAg ICAgcmV0dXJuIEludmFsaWRWaXJ0dWFsUmVnaXN0ZXI7CiAgICAgICAgIHJldHVybiBhY3RpdmF0 aW9uUmVnaXN0ZXIoKTsKICAgICB9Ci0gICAgYm9vbCB1c2VzQXJndW1lbnRzKCkgY29uc3QgeyBy ZXR1cm4gbV9hcmd1bWVudHNSZWdpc3RlciAhPSAtMTsgfQorICAgIGJvb2wgdXNlc0FyZ3VtZW50 cygpIGNvbnN0IHsgcmV0dXJuIG1fYXJndW1lbnRzUmVnaXN0ZXIgIT0gKGludClJbnZhbGlkVmly dHVhbFJlZ2lzdGVyOyB9CiAKICAgICBib29sIG5lZWRzQWN0aXZhdGlvbigpIGNvbnN0CiAgICAg ewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xhenlPcGVyYW5kVmFsdWVQ cm9maWxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xh enlPcGVyYW5kVmFsdWVQcm9maWxlLmgJKHJldmlzaW9uIDE1NTM5NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9MYXp5T3BlcmFuZFZhbHVlUHJvZmlsZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zMiw2ICszMiw3IEBACiAKICNpbmNsdWRlICJDb25jdXJyZW50SklUTG9jay5oIgog I2luY2x1ZGUgIlZhbHVlUHJvZmlsZS5oIgorI2luY2x1ZGUgIlZpcnR1YWxSZWdpc3Rlci5oIgog I2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAj aW5jbHVkZSA8d3RmL093blB0ci5oPgpAQCAtNDUsMTMgKzQ2LDEzIEBAIGNsYXNzIExhenlPcGVy YW5kVmFsdWVQcm9maWxlS2V5IHsKIHB1YmxpYzoKICAgICBMYXp5T3BlcmFuZFZhbHVlUHJvZmls ZUtleSgpCiAgICAgICAgIDogbV9ieXRlY29kZU9mZnNldCgwKSAvLyAwID0gZW1wdHkgdmFsdWUK LSAgICAgICAgLCBtX29wZXJhbmQoLTEpIC8vIG5vdCBhIHZhbGlkIG9wZXJhbmQgaW5kZXggaW4g b3VyIGN1cnJlbnQgc2NoZW1lCisgICAgICAgICwgbV9vcGVyYW5kKEludmFsaWRWaXJ0dWFsUmVn aXN0ZXIpIC8vIG5vdCBhIHZhbGlkIG9wZXJhbmQgaW5kZXggaW4gb3VyIGN1cnJlbnQgc2NoZW1l CiAgICAgewogICAgIH0KICAgICAKICAgICBMYXp5T3BlcmFuZFZhbHVlUHJvZmlsZUtleShXVEY6 Okhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpCiAgICAgICAgIDogbV9ieXRlY29kZU9mZnNldCgx KSAvLyAxID0gZGVsZXRlZCB2YWx1ZQotICAgICAgICAsIG1fb3BlcmFuZCgtMSkgLy8gbm90IGEg dmFsaWQgb3BlcmFuZCBpbmRleCBpbiBvdXIgY3VycmVudCBzY2hlbWUKKyAgICAgICAgLCBtX29w ZXJhbmQoSW52YWxpZFZpcnR1YWxSZWdpc3RlcikgLy8gbm90IGEgdmFsaWQgb3BlcmFuZCBpbmRl eCBpbiBvdXIgY3VycmVudCBzY2hlbWUKICAgICB7CiAgICAgfQogICAgIApAQCAtNTksMTIgKzYw LDEyIEBAIHB1YmxpYzoKICAgICAgICAgOiBtX2J5dGVjb2RlT2Zmc2V0KGJ5dGVjb2RlT2Zmc2V0 KQogICAgICAgICAsIG1fb3BlcmFuZChvcGVyYW5kKQogICAgIHsKLSAgICAgICAgQVNTRVJUKG9w ZXJhbmQgIT0gLTEpOworICAgICAgICBBU1NFUlQob3BlcmFuZCAhPSBJbnZhbGlkVmlydHVhbFJl Z2lzdGVyKTsKICAgICB9CiAgICAgCiAgICAgYm9vbCBvcGVyYXRvciEoKSBjb25zdAogICAgIHsK LSAgICAgICAgcmV0dXJuIG1fb3BlcmFuZCA9PSAtMTsKKyAgICAgICAgcmV0dXJuIG1fb3BlcmFu ZCA9PSBJbnZhbGlkVmlydHVhbFJlZ2lzdGVyOwogICAgIH0KICAgICAKICAgICBib29sIG9wZXJh dG9yPT0oY29uc3QgTGF6eU9wZXJhbmRWYWx1ZVByb2ZpbGVLZXkmIG90aGVyKSBjb25zdApAQCAt OTEsNyArOTIsNyBAQCBwdWJsaWM6CiAgICAgCiAgICAgYm9vbCBpc0hhc2hUYWJsZURlbGV0ZWRW YWx1ZSgpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gbV9vcGVyYW5kID09IC0xICYmIG1f Ynl0ZWNvZGVPZmZzZXQ7CisgICAgICAgIHJldHVybiBtX29wZXJhbmQgPT0gSW52YWxpZFZpcnR1 YWxSZWdpc3RlciAmJiBtX2J5dGVjb2RlT2Zmc2V0OwogICAgIH0KIHByaXZhdGU6IAogICAgIHVu c2lnbmVkIG1fYnl0ZWNvZGVPZmZzZXQ7CkBAIC0xMjgsNyArMTI5LDcgQEAgbmFtZXNwYWNlIEpT QyB7CiBzdHJ1Y3QgTGF6eU9wZXJhbmRWYWx1ZVByb2ZpbGUgOiBwdWJsaWMgTWluaW1hbFZhbHVl UHJvZmlsZSB7CiAgICAgTGF6eU9wZXJhbmRWYWx1ZVByb2ZpbGUoKQogICAgICAgICA6IE1pbmlt YWxWYWx1ZVByb2ZpbGUoKQotICAgICAgICAsIG1fb3BlcmFuZCgtMSkKKyAgICAgICAgLCBtX29w ZXJhbmQoSW52YWxpZFZpcnR1YWxSZWdpc3RlcikKICAgICB7CiAgICAgfQogICAgIApJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxv Y2suY3BwCShyZXZpc2lvbiAxNTUzOTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTQsOCArMTk0LDgg QEAgVW5saW5rZWRDb2RlQmxvY2s6OlVubGlua2VkQ29kZUJsb2NrKFZNKgogICAgICwgbV9udW1D YWxsZWVSZWdpc3RlcnMoMCkKICAgICAsIG1fbnVtUGFyYW1ldGVycygwKQogICAgICwgbV92bSh2 bSkKLSAgICAsIG1fYXJndW1lbnRzUmVnaXN0ZXIoLTEpCi0gICAgLCBtX2dsb2JhbE9iamVjdFJl Z2lzdGVyKC0xKQorICAgICwgbV9hcmd1bWVudHNSZWdpc3RlcigoaW50KUludmFsaWRWaXJ0dWFs UmVnaXN0ZXIpCisgICAgLCBtX2dsb2JhbE9iamVjdFJlZ2lzdGVyKChpbnQpSW52YWxpZFZpcnR1 YWxSZWdpc3RlcikKICAgICAsIG1fbmVlZHNGdWxsU2NvcGVDaGFpbihpbmZvLm1fbmVlZHNBY3Rp dmF0aW9uKQogICAgICwgbV91c2VzRXZhbChpbmZvLm1fdXNlc0V2YWwpCiAgICAgLCBtX2lzTnVt ZXJpY0NvbXBhcmVGdW5jdGlvbihmYWxzZSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCShyZXZpc2lvbiAxNTUzOTcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaAkod29y a2luZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1ZGUgIlJlZ0V4cC5oIgogI2luY2x1 ZGUgIlNwZWNpYWxQb2ludGVyLmgiCiAjaW5jbHVkZSAiU3ltYm9sVGFibGUuaCIKKyNpbmNsdWRl ICJWaXJ0dWFsUmVnaXN0ZXIuaCIKIAogI2luY2x1ZGUgPHd0Zi9Db21wcmVzc2lvbi5oPgogI2lu Y2x1ZGUgPHd0Zi9SZWZDb3VudGVkQXJyYXkuaD4KQEAgLTI1NywxMSArMjU4LDExIEBAIHB1Ymxp YzoKICAgICB2b2lkIHNldEFjdGl2YXRpb25SZWdpc3RlcihpbnQgYWN0aXZhdGlvblJlZ2lzdGVy KSB7IG1fYWN0aXZhdGlvblJlZ2lzdGVyID0gYWN0aXZhdGlvblJlZ2lzdGVyOyB9CiAKICAgICB2 b2lkIHNldEFyZ3VtZW50c1JlZ2lzdGVyKGludCBhcmd1bWVudHNSZWdpc3RlcikgeyBtX2FyZ3Vt ZW50c1JlZ2lzdGVyID0gYXJndW1lbnRzUmVnaXN0ZXI7IH0KLSAgICBib29sIHVzZXNBcmd1bWVu dHMoKSBjb25zdCB7IHJldHVybiBtX2FyZ3VtZW50c1JlZ2lzdGVyICE9IC0xOyB9CisgICAgYm9v bCB1c2VzQXJndW1lbnRzKCkgY29uc3QgeyByZXR1cm4gbV9hcmd1bWVudHNSZWdpc3RlciAhPSAo aW50KUludmFsaWRWaXJ0dWFsUmVnaXN0ZXI7IH0KICAgICBpbnQgYXJndW1lbnRzUmVnaXN0ZXIo KSBjb25zdCB7IHJldHVybiBtX2FyZ3VtZW50c1JlZ2lzdGVyOyB9CiAKIAotICAgIGJvb2wgdXNl c0dsb2JhbE9iamVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fZ2xvYmFsT2JqZWN0UmVnaXN0ZXIgIT0g LTE7IH0KKyAgICBib29sIHVzZXNHbG9iYWxPYmplY3QoKSBjb25zdCB7IHJldHVybiBtX2dsb2Jh bE9iamVjdFJlZ2lzdGVyICE9IChpbnQpSW52YWxpZFZpcnR1YWxSZWdpc3RlcjsgfQogICAgIHZv aWQgc2V0R2xvYmFsT2JqZWN0UmVnaXN0ZXIoaW50IGdsb2JhbE9iamVjdFJlZ2lzdGVyKSB7IG1f Z2xvYmFsT2JqZWN0UmVnaXN0ZXIgPSBnbG9iYWxPYmplY3RSZWdpc3RlcjsgfQogICAgIGludCBn bG9iYWxPYmplY3RSZWdpc3RlcigpIGNvbnN0IHsgcmV0dXJuIG1fZ2xvYmFsT2JqZWN0UmVnaXN0 ZXI7IH0KIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ZpcnR1YWxSZWdp c3Rlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9WaXJ0 dWFsUmVnaXN0ZXIuaAkocmV2aXNpb24gMTU1Mzk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL1ZpcnR1YWxSZWdpc3Rlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3 IEBAIG5hbWVzcGFjZSBKU0MgewogCiAvLyBUeXBlIGZvciBhIHZpcnR1YWwgcmVnaXN0ZXIgbnVt YmVyIChzcGlsbCBsb2NhdGlvbikuCiAvLyBVc2luZyBhbiBlbnVtIHRvIG1ha2UgdGhpcyB0eXBl LWNoZWNrZWQgYXQgY29tcGlsZSB0aW1lLCB0byBhdmVydCBwcm9ncmFtbWVyIGVycm9ycy4KLWVu dW0gVmlydHVhbFJlZ2lzdGVyIHsgSW52YWxpZFZpcnR1YWxSZWdpc3RlciA9IC0xIH07CitlbnVt IFZpcnR1YWxSZWdpc3RlciB7IEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIgPSAweDdmZmZmZmZmIH07 CiBDT01QSUxFX0FTU0VSVChzaXplb2YoVmlydHVhbFJlZ2lzdGVyKSA9PSBzaXplb2YoaW50KSwg VmlydHVhbFJlZ2lzdGVyX2lzXzMyYml0KTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==