121045 2013-09-09 13:51:27 -0700 CopiedSpace::startedCopying should not call MarkedSpace::capacity 2013-09-12 10:57:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121074 1 mhahnenberg mhahnenberg oldest_to_newest 926883 0 mhahnenberg 2013-09-09 13:51:27 -0700 MarkedSpace::capacity() iterates every block in MarkedSpace. Heap has m_totalBytesVisited, which is a good enough approximation of the size of MarkedSpace and it's O(1) so we should use it instead. 926884 1 211079 mhahnenberg 2013-09-09 13:52:38 -0700 Created attachment 211079 Patch 927006 2 211123 mhahnenberg 2013-09-09 17:13:21 -0700 Created attachment 211123 Patch 927008 3 mhahnenberg 2013-09-09 17:14:45 -0700 I was getting a small but persistent slow down on kraken with the first version, so I tried just keeping track as we add and remove MarkedBlocks from the MarkedSpace. This version didn't show any slowdown. 927009 4 211123 ggaren 2013-09-09 17:17:35 -0700 Comment on attachment 211123 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211123&action=review r=me > Source/JavaScriptCore/heap/MarkedSpace.h:135 > + size_t m_totalCapacity; I think "capacity" is a slightly better name here. We don't have a concept of "partial capacity" in this class. 927019 5 mhahnenberg 2013-09-09 17:34:19 -0700 Committed r155406: <http://trac.webkit.org/changeset/155406> 211079 2013-09-09 13:52:38 -0700 2013-09-09 17:13:19 -0700 Patch bug-121045-20130909135231.patch text/plain 1545 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1Mzc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA5LTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29waWVkU3BhY2U6OnN0YXJ0ZWRDb3B5aW5nIHNob3VsZCBub3QgY2FsbCBNYXJr ZWRTcGFjZTo6Y2FwYWNpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMTA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1hcmtlZFNwYWNlOjpjYXBhY2l0eSgpIGl0ZXJhdGVzIGV2ZXJ5IGJsb2NrIGlu IE1hcmtlZFNwYWNlLiBIZWFwIGhhcyBtX3RvdGFsQnl0ZXNWaXNpdGVkLCB3aGljaCAKKyAgICAg ICAgaXMgYSBnb29kIGVub3VnaCBhcHByb3hpbWF0aW9uIG9mIHRoZSBzaXplIG9mIE1hcmtlZFNw YWNlIGFuZCBpdCdzIE8oMSkgc28gd2Ugc2hvdWxkIHVzZSBpdCBpbnN0ZWFkLgorCisgICAgICAg ICogaGVhcC9Db3BpZWRTcGFjZS5jcHA6CisgICAgICAgIChKU0M6OkNvcGllZFNwYWNlOjpzdGFy dGVkQ29weWluZyk6CisKIDIwMTMtMDktMDggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBCZWdpbiBtb3Zpbmcgb2ZmIG9mIFR5cGVUcmFpdHMuaApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmNwcAkocmV2aXNpb24g MTU1MzY1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMTcsNyArMjE3LDcgQEAgdm9pZCBDb3BpZWRTcGFjZTo6c3RhcnRl ZENvcHlpbmcoKQogICAgICAgICBibG9jayA9IG5leHQ7CiAgICAgfQogCi0gICAgZG91YmxlIG1h cmtlZFNwYWNlQnl0ZXMgPSBtX2hlYXAtPm9iamVjdFNwYWNlKCkuY2FwYWNpdHkoKTsKKyAgICBk b3VibGUgbWFya2VkU3BhY2VCeXRlcyA9IG1faGVhcC0+bV90b3RhbEJ5dGVzVmlzaXRlZDsKICAg ICBkb3VibGUgdG90YWxGcmFnbWVudGF0aW9uID0gKChkb3VibGUpdG90YWxMaXZlQnl0ZXMgKyBt YXJrZWRTcGFjZUJ5dGVzKSAvICgoZG91YmxlKXRvdGFsVXNhYmxlQnl0ZXMgKyBtYXJrZWRTcGFj ZUJ5dGVzKTsKICAgICBtX3Nob3VsZERvQ29weVBoYXNlID0gdG90YWxGcmFnbWVudGF0aW9uIDw9 IE9wdGlvbnM6Om1pbkhlYXBVdGlsaXphdGlvbigpOwogICAgIGlmICghbV9zaG91bGREb0NvcHlQ aGFzZSkK 211123 2013-09-09 17:13:21 -0700 2013-09-09 17:17:35 -0700 Patch bug-121045-20130909171308.patch text/plain 3020 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTA5LTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29waWVkU3BhY2U6OnN0YXJ0ZWRDb3B5aW5nIHNob3VsZCBub3QgY2FsbCBNYXJr ZWRTcGFjZTo6Y2FwYWNpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMTA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1hcmtlZFNwYWNlOjpjYXBhY2l0eSgpIGl0ZXJhdGVzIGV2ZXJ5IGJsb2NrIGlu IE1hcmtlZFNwYWNlLiBJbnN0ZWFkIHdlIHNob3VsZCBqdXN0IAorICAgICAgICBrZWVwIHRyYWNr IG9mIG91ciB0b3RhbCBjYXBhY2l0eSBpbiBNYXJrZWRTcGFjZSBhcyB3ZSBhZGQgYW5kIHJlbW92 ZSBNYXJrZWRCbG9ja3MuCisKKyAgICAgICAgKiBoZWFwL01hcmtlZFNwYWNlLmNwcDoKKyAgICAg ICAgKEpTQzo6TWFya2VkU3BhY2U6OmZyZWVCbG9jayk6CisgICAgICAgICogaGVhcC9NYXJrZWRT cGFjZS5oOgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6ZGlkQWRkQmxvY2spOgorICAgICAg ICAoSlNDOjpNYXJrZWRTcGFjZTo6Y2FwYWNpdHkpOgorCiAyMDEzLTA5LTA5ICBNaWNoYWVsIFNh Ym9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFdyb25nIGZvciBTbG93UGF0aENh bGwgdG8gbG9hZCBjYWxsRnJhbWUgcmVnIGZyb20gdm0udG9wQ2FsbEZyYW1lIGFmdGVyIGNhbGwK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZFNwYWNlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRTcGFjZS5jcHAJKHJldmlz aW9uIDE1NTM5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZFNwYWNlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzksNiArNzksNyBAQCBzdHJ1Y3QgUmVhcFdlYWtTZXQgOiBN YXJrZWRCbG9jazo6Vm9pZEZ1CiAKIE1hcmtlZFNwYWNlOjpNYXJrZWRTcGFjZShIZWFwKiBoZWFw KQogICAgIDogbV9oZWFwKGhlYXApCisgICAgLCBtX3RvdGFsQ2FwYWNpdHkoMCkKIHsKICAgICBm b3IgKHNpemVfdCBjZWxsU2l6ZSA9IHByZWNpc2VTdGVwOyBjZWxsU2l6ZSA8PSBwcmVjaXNlQ3V0 b2ZmOyBjZWxsU2l6ZSArPSBwcmVjaXNlU3RlcCkgewogICAgICAgICBhbGxvY2F0b3JGb3IoY2Vs bFNpemUpLmluaXQoaGVhcCwgdGhpcywgY2VsbFNpemUsIE1hcmtlZEJsb2NrOjpOb25lKTsKQEAg LTE5NSw2ICsxOTYsNyBAQCBib29sIE1hcmtlZFNwYWNlOjppc1BhZ2VkT3V0KGRvdWJsZSBkZWFk CiB2b2lkIE1hcmtlZFNwYWNlOjpmcmVlQmxvY2soTWFya2VkQmxvY2sqIGJsb2NrKQogewogICAg IGJsb2NrLT5hbGxvY2F0b3IoKS0+cmVtb3ZlQmxvY2soYmxvY2spOworICAgIG1fdG90YWxDYXBh Y2l0eSAtPSBibG9jay0+Y2FwYWNpdHkoKTsKICAgICBtX2Jsb2Nrcy5yZW1vdmUoYmxvY2spOwog ICAgIGlmIChibG9jay0+Y2FwYWNpdHkoKSA9PSBNYXJrZWRCbG9jazo6YmxvY2tTaXplKSB7CiAg ICAgICAgIG1faGVhcC0+YmxvY2tBbGxvY2F0b3IoKS5kZWFsbG9jYXRlKE1hcmtlZEJsb2NrOjpk ZXN0cm95KGJsb2NrKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRT cGFjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZFNw YWNlLmgJKHJldmlzaW9uIDE1NTM5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01h cmtlZFNwYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDEwICs1OSw2IEBAIHN0cnVjdCBTaXpl IDogTWFya2VkQmxvY2s6OkNvdW50RnVuY3RvciAKICAgICB2b2lkIG9wZXJhdG9yKCkoTWFya2Vk QmxvY2sqIGJsb2NrKSB7IGNvdW50KGJsb2NrLT5tYXJrQ291bnQoKSAqIGJsb2NrLT5jZWxsU2l6 ZSgpKTsgfQogfTsKIAotc3RydWN0IENhcGFjaXR5IDogTWFya2VkQmxvY2s6OkNvdW50RnVuY3Rv ciB7Ci0gICAgdm9pZCBvcGVyYXRvcigpKE1hcmtlZEJsb2NrKiBibG9jaykgeyBjb3VudChibG9j ay0+Y2FwYWNpdHkoKSk7IH0KLX07Ci0KIGNsYXNzIE1hcmtlZFNwYWNlIHsKICAgICBXVEZfTUFL RV9OT05DT1BZQUJMRShNYXJrZWRTcGFjZSk7CiBwdWJsaWM6CkBAIC0xMzYsNiArMTMyLDcgQEAg cHJpdmF0ZToKICAgICBTdWJzcGFjZSBtX25vcm1hbFNwYWNlOwogCiAgICAgSGVhcCogbV9oZWFw OworICAgIHNpemVfdCBtX3RvdGFsQ2FwYWNpdHk7CiAgICAgTWFya2VkQmxvY2tTZXQgbV9ibG9j a3M7CiB9OwogCkBAIC0yNDUsNiArMjQyLDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIEZ1bmN0b3I+ IGlubGluZSB0eXBlbgogCiBpbmxpbmUgdm9pZCBNYXJrZWRTcGFjZTo6ZGlkQWRkQmxvY2soTWFy a2VkQmxvY2sqIGJsb2NrKQogeworICAgIG1fdG90YWxDYXBhY2l0eSArPSBibG9jay0+Y2FwYWNp dHkoKTsKICAgICBtX2Jsb2Nrcy5hZGQoYmxvY2spOwogfQogCkBAIC0yNjUsNyArMjYzLDcgQEAg aW5saW5lIHNpemVfdCBNYXJrZWRTcGFjZTo6c2l6ZSgpCiAKIGlubGluZSBzaXplX3QgTWFya2Vk U3BhY2U6OmNhcGFjaXR5KCkKIHsKLSAgICByZXR1cm4gZm9yRWFjaEJsb2NrPENhcGFjaXR5Pigp OworICAgIHJldHVybiBtX3RvdGFsQ2FwYWNpdHk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwo=