121041 2013-09-09 13:31:19 -0700 Prevent overflow of width/height of layout overflow rectangle which can cause scroll bar to misfunction 2013-09-09 15:35:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned bdakin commit-queue dino hyatt simon.fraser oldest_to_newest 926874 0 rniwa 2013-09-09 13:31:19 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/d050f9be579d02e40c8924b4153376bc32ffba1a When a child element is positioned very far away the width/height of layout overflow rectangle may overflow. The patch detects such cases in RenderOverflow::addLayoutOverflow and shift the top/left edges of the rectangle to avoid overflow. 926895 1 211084 rniwa 2013-09-09 14:07:58 -0700 Created attachment 211084 Just adds the test I couldn't make the test to fail. We can just add the test for now and merge the code change later if the test started failing. 926955 2 211084 commit-queue 2013-09-09 15:35:52 -0700 Comment on attachment 211084 Just adds the test Clearing flags on attachment: 211084 Committed r155394: <http://trac.webkit.org/changeset/155394> 926956 3 commit-queue 2013-09-09 15:35:54 -0700 All reviewed patches have been landed. Closing bug. 211084 2013-09-09 14:07:58 -0700 2013-09-09 15:35:52 -0700 Just adds the test fix121041 text/plain 2831 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NTM4MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTA5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFByZXZlbnQgb3ZlcmZsb3cgb2Ygd2lkdGgvaGVp Z2h0IG9mIGxheW91dCBvdmVyZmxvdyByZWN0YW5nbGUgd2hpY2ggY2FuIGNhdXNlIHNjcm9sbCBi YXIgdG8gbWlzZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMTA0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1lcmdlIHRoZSB0ZXN0IGZyb20gaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3Vy Y2UuY29tL2Nocm9taXVtL2JsaW5rLysvZDA1MGY5YmU1NzlkMDJlNDBjODkyNGI0MTUzMzc2YmMz MmZmYmExYQorCisgICAgICAgICogc2Nyb2xsYmFycy9zY3JvbGxiYXItbGFyZ2Utb3ZlcmZsb3ct cmVjdGFuZ2xlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc2Nyb2xsYmFycy9zY3Jv bGxiYXItbGFyZ2Utb3ZlcmZsb3ctcmVjdGFuZ2xlLmh0bWw6IEFkZGVkLgorCiAyMDEzLTA5LTA2 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEludGVybmFscyBz aG91bGQgYWx3YXlzIGNhdXNlIGEgbGF5b3V0IGJlZm9yZSBjYWxsaW5nIGludG8gVGV4dEl0ZXJh dG9yCkluZGV4OiBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1sYXJnZS1vdmVyZmxv dy1yZWN0YW5nbGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Njcm9s bGJhcnMvc2Nyb2xsYmFyLWxhcmdlLW92ZXJmbG93LXJlY3RhbmdsZS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1sYXJnZS1vdmVy Zmxvdy1yZWN0YW5nbGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBA QAorVGhpcyBwYWdlIHNob3VsZCBiZSBzY3JvbGxhYmxlCitQQVNTCisKSW5kZXg6IExheW91dFRl c3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWxhcmdlLW92ZXJmbG93LXJlY3RhbmdsZS5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWxhcmdlLW92ZXJm bG93LXJlY3RhbmdsZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc2Nyb2xsYmFy cy9zY3JvbGxiYXItbGFyZ2Utb3ZlcmZsb3ctcmVjdGFuZ2xlLmh0bWwJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSw0MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAg ICA8dGl0bGU+YWJzb2x1dGUgcG9zaXRpb25lZCBlbGVtZW50IHdpdGggbGFyZ2UgbmVnYXRpdmUg dG9wIHZhbHVlIGluc2lkZSB0YWxsIHJlbGF0aXZlIHBvc2l0aW9uZWQgYm94IGRvZXMgbm90IHJl bmRlciBzY3JvbGxiYXJzPC90aXRsZT4KKyAgICAgICAgPHN0eWxlPgorICAgICAgICAgICAgYm9k eSwgcHsKKyAgICAgICAgICAgICAgbWFyZ2luOjA7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBkaXZ7CisgICAgICAgICAgICAgICAgcG9zaXRpb246IHJlbGF0aXZlOworICAgICAgICAgICAg ICAgIGhlaWdodDozMDAwcHg7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBzcGFueworICAg ICAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgICAgICB0b3A6LTMz NTU0MDAwMDBweDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICAgICAgPHNj cmlwdD4KKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAgICAg ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAg CisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0KCkgeworICAgICAgICAgICAgICB2YXIgaGVpZ2h0 ID0gZG9jdW1lbnQuYm9keS5zY3JvbGxIZWlnaHQ7CisgICAgICAgICAgICAgIGlmIChoZWlnaHQg PT0gMzAwMCkKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 IikuaW5uZXJIVE1MID0gIlBBU1MiOworICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVySFRNTCA9ICI8cCBzdHls ZT0nY29sb3I6cmVkJz5GQUlMIGRvY3VtZW50LmJvZHkuc2Nyb2xsSGVpZ2h0ID0gIiArIGhlaWdo dCArIjwvcD4iOworICAgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PiAKKyAgICA8L2hl YWQ+CisgICAgCisgICAgPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorICAgIDxkaXY+CisgICAgICA8 cD4gVGhpcyBwYWdlIHNob3VsZCBiZSBzY3JvbGxhYmxlIDwvcD4KKyAgICAgIDxwIGlkPSJyZXN1 bHQiPiA8L3A+CisgICAgICA8c3BhbiBzdHlsZT0idmlzaWJpbGl0eTpoaWRkZW4iPmZpbGxlciA8 IS0tYWJzIHBvcyB3aXRoIHZlcnkgbGFyZ2UgbmVnYXRpdmUgdG9wIHZhbHVlLS0+PC9zcGFuPgor ICAgIDwvZGl2PgorICAgCisgICAgPC9ib2R5PgorPC9odG1sPgo=