121034 2013-09-09 10:53:59 -0700 MediaStreamDescriptor::removeAudioComponent accidentally changes m_videoComponents 2013-09-09 14:46:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda webkit-unassigned commit-queue eric.carlson glenn hta jer.noble tommyw oldest_to_newest 926791 0 thiago.lacerda 2013-09-09 10:53:59 -0700 removeAudioComponent is calling remove in video components vector by mistake 926793 1 211057 thiago.lacerda 2013-09-09 10:55:30 -0700 Created attachment 211057 Patch 926848 2 ap 2013-09-09 12:39:04 -0700 Re-titled - we use bracketed prefixes for special interest bugs that most people just want to quickly skip over (like platform specific issues). 926906 3 211057 commit-queue 2013-09-09 14:31:50 -0700 Comment on attachment 211057 Patch Clearing flags on attachment: 211057 Committed r155382: <http://trac.webkit.org/changeset/155382> 926907 4 commit-queue 2013-09-09 14:31:52 -0700 All reviewed patches have been landed. Closing bug. 926911 5 211057 darin 2013-09-09 14:41:48 -0700 Comment on attachment 211057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Why? Looks like this was a bad bug. Normally we’d want a regression test. 926916 6 thiago.lacerda 2013-09-09 14:46:47 -0700 (In reply to comment #5) > (From update of attachment 211057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Why? Looks like this was a bad bug. Normally we’d want a regression test. Darin, this was just introduced by accident in this revision https://bugs.webkit.org/show_bug.cgi?id=120872. So I think does not need an Test for that 211057 2013-09-09 10:55:30 -0700 2013-09-09 14:41:48 -0700 Patch bug-121034-20130909145529.patch text/plain 1719 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJkYTU4MjdhOWI1OWEy MmI3MWIzZWFmZDRkOGE0ODFkZGI5ZWMwOS4uMWNmZDU4ZTI0MGIxMDFkZGQ1YzJkNTk2YTA4ODkz ZGYyZmM1MDcwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTA5ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtCdWcgRml4XSBDYWxsaW5nIG1fYXVkaW9Db21wb25lbnRzLnJlbW92ZSBpbiByZW1v dmVBdWRpb0NvbXBvbmVudCAoTWVkaWFTdHJlYW1EZXNjcmlwdG9yKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxMDM0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRGVzY3JpcHRvci5oOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpyZW1vdmVBdWRpb0NvbXBv bmVudCk6CisKIDIwMTMtMDktMDkgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBNb3ZpbmcgQWRkL1JlbW92ZSB0cmFjayBm cm9tIFdlYk1lZGlhU3RyZWFtQ2VudGVyQ2xpZW50IHRvIFdlYk1lZGlhU3RyZWFtCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbURlc2Ny aXB0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RGVzY3JpcHRvci5oCmluZGV4IDk2NTI0YTA2NGVjNTJmOGVmYWYyY2U5MDIxNTViNzQ2NTIzM2U1 NzUuLmYzYjVhN2M5MzBmN2RkM2U4ZDA2N2NlYmJlYjJhMzlmMjBiZGY4YWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRGVzY3JpcHRv ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RGVzY3JpcHRvci5oCkBAIC03Nyw5ICs3Nyw5IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkZEF1ZGlv Q29tcG9uZW50KFBhc3NSZWZQdHI8TWVkaWFTdHJlYW1Db21wb25lbnQ+IGNvbXBvbmVudCkgeyBt X2F1ZGlvQ29tcG9uZW50cy5hcHBlbmQoY29tcG9uZW50KTsgfQogICAgIHZvaWQgcmVtb3ZlQXVk aW9Db21wb25lbnQoTWVkaWFTdHJlYW1Db21wb25lbnQqIGNvbXBvbmVudCkKICAgICB7Ci0gICAg ICAgIHNpemVfdCBwb3MgPSBtX3ZpZGVvQ29tcG9uZW50cy5maW5kKGNvbXBvbmVudCk7CisgICAg ICAgIHNpemVfdCBwb3MgPSBtX2F1ZGlvQ29tcG9uZW50cy5maW5kKGNvbXBvbmVudCk7CiAgICAg ICAgIGlmIChwb3MgIT0gbm90Rm91bmQpCi0gICAgICAgICAgICBtX3ZpZGVvQ29tcG9uZW50cy5y ZW1vdmUocG9zKTsKKyAgICAgICAgICAgIG1fYXVkaW9Db21wb25lbnRzLnJlbW92ZShwb3MpOwog ICAgIH0KIAogICAgIHZvaWQgYWRkUmVtb3RlVHJhY2soTWVkaWFTdHJlYW1Db21wb25lbnQqIGNv bXBvbmVudCkK