121017 2013-09-08 20:11:06 -0700 Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now) 2013-09-08 20:53:12 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin andersca benjamin cmarcelo commit-queue kling sam oldest_to_newest 926548 0 darin 2013-09-08 20:11:06 -0700 Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now) 926549 1 211004 darin 2013-09-08 20:13:11 -0700 Created attachment 211004 Patch 926550 2 darin 2013-09-08 20:13:58 -0700 Really only affects Mac, iOS, and Windows ports like Apple’s that use Core Foundation. But I didn’t know how to specify that in a bug title prefix. 926551 3 commit-queue 2013-09-08 20:14:55 -0700 Attachment 211004 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RetainPtr.h']" exit_code: 1 Source/WTF/wtf/RetainPtr.h:53: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:53: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:54: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:342: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:343: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 926554 4 211004 kling 2013-09-08 20:47:12 -0700 Comment on attachment 211004 Patch Okay. 926555 5 darin 2013-09-08 20:53:12 -0700 Committed r155319: <http://trac.webkit.org/changeset/155319> 211004 2013-09-08 20:13:11 -0700 2013-09-08 20:47:12 -0700 Patch bug-121017-20130908201311.patch text/plain 2404 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBjY2VkNzgyZjZhMThkNGI3YTE1ZjI5 ODY3MjI2YzEzNDkzNDkwNTcuLjEzMDQ2ZTg1N2M1OTkzOTBiNjJiMWFhNWNiMTIzNzI3OWY4ZDM0 OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDktMDggIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIERlcHJlY2F0ZSBBZG9wdENGIGFuZCBBZG9wdE5TIChvbiBh bGwgcGxhdGZvcm1zIGV4Y2VwdCBpT1MgZm9yIG5vdykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTAxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1JldGFpblB0ci5oOiBVc2UgdGhlIHByZXBy b2Nlc3NvciB0byByZW5hbWUgQWRvcHRDRiBhbmQgQWRvcHROUworICAgICAgICB0byBEZXByZWNh dGVkQWRvcHRDRiBhbmQgRGVwcmVjYXRlZEFkb3B0TlMgb24gYWxsIHBsYXRmb3JtcyBleGNlcHQK KyAgICAgICAgZm9yIGlPUy4gQWxzbyByZW1vdmVkIGFuIHVubmVlZGVkIGV4cGxpY2l0IGNvbnZl cnNpb24gaW4gdGhlIHJldGFpblB0cgorICAgICAgICBmdW5jdGlvbi4gQWxzbyByZS1zb3J0ZWQg dGhlIHVzaW5nIGxpbmVzIGF0IHRoZSBlbmQgb2YgdGhlIGZpbGUuCisKIDIwMTMtMDktMDggIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIFdURjo6 bm90Rm91bmQgdG8gVmVjdG9yLmggYW5kIGRlbGV0ZSBOb3RGb3VuZC5oCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9SZXRhaW5QdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCmlu ZGV4IGJmN2NjNDRjOWVhYjg4MTYxYjNhNDY3ZjJmY2JlMWNiMDM1MzE4ZDEuLjEyMDJkZTc4YTYy OWM0ZTJjNDgwNmQyODYyMzUxZmU4M2MzMTEyYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L1JldGFpblB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCkBAIC00OSw2ICs0 OSwxMSBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAvLyBVbmxpa2UgbW9zdCBtb3N0IG9mIG91ciBz bWFydCBwb2ludGVycywgUmV0YWluUHRyIGNhbiB0YWtlIGVpdGhlciB0aGUgcG9pbnRlciB0eXBl IG9yIHRoZSBwb2ludGVkLXRvIHR5cGUsCiAgICAgLy8gc28gYm90aCBSZXRhaW5QdHI8TlNEaWN0 aW9uYXJ5PiBhbmQgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gd2lsbCB3b3JrLgogCisjaWYg IVBMQVRGT1JNKElPUykKKyAgICAjZGVmaW5lIEFkb3B0Q0YgRGVwcmVjYXRlZEFkb3B0Q0YKKyAg ICAjZGVmaW5lIEFkb3B0TlMgRGVwcmVjYXRlZEFkb3B0TlMKKyNlbmRpZgorCiAgICAgZW51bSBB ZG9wdENGVGFnIHsgQWRvcHRDRiB9OwogICAgIGVudW0gQWRvcHROU1RhZyB7IEFkb3B0TlMgfTsK ICAgICAKQEAgLTI5NCw3ICsyOTksNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IHJldGFpblB0cihUKSBXQVJOX1VOVVNFRF9S RVRVUk47CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0cjxUPiByZXRh aW5QdHIoVCBvKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFJldGFpblB0cjxUPihvKTsKKyAgICAg ICAgcmV0dXJuIG87CiAgICAgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUD4gc3RydWN0IEhh c2hUcmFpdHM8UmV0YWluUHRyPFA+ID4gOiBTaW1wbGVDbGFzc0hhc2hUcmFpdHM8UmV0YWluUHRy PFA+ID4geyB9OwpAQCAtMzMyLDE1ICszMzcsMjQgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAg IH0KICAgICAgICAgc3RhdGljIGNvbnN0IGJvb2wgc2FmZVRvQ29tcGFyZVRvRW1wdHlPckRlbGV0 ZWQgPSBmYWxzZTsKICAgICB9OworCisjaWYgIVBMQVRGT1JNKElPUykKKyAgICAjdW5kZWYgQWRv cHRDRgorICAgICN1bmRlZiBBZG9wdE5TCisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV1RGCiAK LXVzaW5nIFdURjo6QWRvcHRDRjsKLXVzaW5nIFdURjo6QWRvcHROUzsKK3VzaW5nIFdURjo6UmV0 YWluUHRyOwogdXNpbmcgV1RGOjphZG9wdENGOwogdXNpbmcgV1RGOjphZG9wdE5TOwotdXNpbmcg V1RGOjpSZXRhaW5QdHI7CiB1c2luZyBXVEY6OnJldGFpblB0cjsKIAorI2lmIFBMQVRGT1JNKElP UykKK3VzaW5nIFdURjo6QWRvcHRDRjsKK3VzaW5nIFdURjo6QWRvcHROUzsKKyNlbmRpZgorCiAj ZW5kaWYgLy8gVVNFKENGKSB8fCBkZWZpbmVkKF9fT0JKQ19fKQogCiAjZW5kaWYgLy8gV1RGX1Jl dGFpblB0cl9oCg==