120971 2013-09-07 15:20:13 -0700 Simplify ComposedShadowTreeWalker parent traversal 2013-09-07 15:30:04 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc kangil.han oldest_to_newest 926275 0 koivisto 2013-09-07 15:20:13 -0700 it is messy 926277 1 210927 koivisto 2013-09-07 15:23:31 -0700 Created attachment 210927 patch 926278 2 koivisto 2013-09-07 15:30:04 -0700 https://trac.webkit.org/r155264 210927 2013-09-07 15:23:31 -0700 2013-09-07 15:26:38 -0700 patch simplify-parent-walker.patch text/plain 5172 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTI2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTA3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlmeSBDb21wb3NlZFNo YWRvd1RyZWVXYWxrZXIgcGFyZW50IHRyYXZlcnNhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwOTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tYmluZSBhIGJ1bmNoIG9mIHBhcmVudCB0cmF2ZXJz YWwgZnVuY3Rpb25zIGludG8gb25lLgorCisgICAgICAgICogZG9tL0NvbXBvc2VkU2hhZG93VHJl ZVdhbGtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6 OnRyYXZlcnNlUGFyZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2VkU2hhZG93VHJlZVdh bGtlcjo6cHJldmlvdXMpOgorICAgICAgICAqIGRvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIu aDoKKyAgICAgICAgCisgICAgICAgICAgICBSZW1vdmUgdW51c2VkIGZyb21GaXJzdENoaWxkLgor CiAyMDEzLTA5LTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgR2V0IHJpZCBvZiBQYXNzT3duQXJyYXlQdHIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Rv bS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCShyZXZpc2lvbiAxNTUyNTQpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTIsMTMgKzUyLDYgQEAgc3RhdGljIGlubGluZSBib29sIG5vZGVDYW5CZURp c3RyaWJ1dGVkKAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotQ29tcG9zZWRTaGFkb3dUcmVlV2Fs a2VyIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6ZnJvbUZpcnN0Q2hpbGQoY29uc3QgTm9kZSog bm9kZSwgUG9saWN5IHBvbGljeSkKLXsKLSAgICBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXIgd2Fs a2VyKG5vZGUsIHBvbGljeSk7Ci0gICAgd2Fsa2VyLmZpcnN0Q2hpbGQoKTsKLSAgICByZXR1cm4g d2Fsa2VyOwotfQotCiB2b2lkIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6Zmlyc3RDaGlsZCgp CiB7CiAgICAgYXNzZXJ0UHJlY29uZGl0aW9uKCk7CkBAIC0xNzgsMTYgKzE3MSw2IEBAIGlubGlu ZSBOb2RlKiBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OmUKICAgICByZXR1cm4gMDsKIH0KIAot aW5saW5lIE5vZGUqIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJhdmVyc2VOb2RlRXNjYXBp bmdGYWxsYmFja0NvbnRlbnRzKGNvbnN0IE5vZGUqIG5vZGUpIGNvbnN0Ci17Ci0gICAgQVNTRVJU KG5vZGUpOwotICAgIGlmICghbm9kZS0+aXNJbnNlcnRpb25Qb2ludCgpKQotICAgICAgICByZXR1 cm4gY29uc3RfY2FzdDxOb2RlKj4obm9kZSk7Ci0gICAgY29uc3QgSW5zZXJ0aW9uUG9pbnQqIGlu c2VydGlvblBvaW50ID0gdG9JbnNlcnRpb25Qb2ludChub2RlKTsKLSAgICByZXR1cm4gaW5zZXJ0 aW9uUG9pbnQtPmhhc0Rpc3RyaWJ1dGlvbigpID8gMCA6Ci0gICAgICAgIGluc2VydGlvblBvaW50 LT5pc0FjdGl2ZSgpID8gdHJhdmVyc2VQYXJlbnQobm9kZSkgOiBjb25zdF9jYXN0PE5vZGUqPihu b2RlKTsKLX0KLQogdm9pZCBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnBhcmVudCgpCiB7CiAg ICAgYXNzZXJ0UHJlY29uZGl0aW9uKCk7CkBAIC0xOTUsOCArMTc4LDYgQEAgdm9pZCBDb21wb3Nl ZFNoYWRvd1RyZWVXYWxrZXI6OnBhcmVudCgpCiAgICAgYXNzZXJ0UG9zdGNvbmRpdGlvbigpOwog fQogCi0vLyBGSVhNRTogVXNlIGFuIGl0ZXJhdGl2ZSBhbGdvcml0aG0gc28gdGhhdCBpdCBjYW4g YmUgaW5saW5lZC4KLS8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MDQxNQogTm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVudChjb25z dCBOb2RlKiBub2RlKSBjb25zdAogewogICAgIGlmIChub2RlLT5pc1BzZXVkb0VsZW1lbnQoKSkK QEAgLTIwOCwyNiArMTg5LDIzIEBAIE5vZGUqIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJh dmVyc2UKICAgICBpZiAobm9kZUNhbkJlRGlzdHJpYnV0ZWQobm9kZSkpIHsKICAgICAgICAgaWYg KEluc2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludCA9IGZpbmRJbnNlcnRpb25Qb2ludE9mKG5v ZGUpKQogICAgICAgICAgICAgcmV0dXJuIHRyYXZlcnNlUGFyZW50KGluc2VydGlvblBvaW50KTsK LSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KLSAgICBy ZXR1cm4gdHJhdmVyc2VQYXJlbnRJbkN1cnJlbnRUcmVlKG5vZGUpOwotfQotCi1pbmxpbmUgTm9k ZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVudEluQ3VycmVudFRyZWUo Y29uc3QgTm9kZSogbm9kZSkgY29uc3QKLXsKLSAgICBpZiAoTm9kZSogcGFyZW50ID0gbm9kZS0+ cGFyZW50Tm9kZSgpKQotICAgICAgICByZXR1cm4gcGFyZW50LT5pc1NoYWRvd1Jvb3QoKSA/IHRy YXZlcnNlUGFyZW50QmFja1RvU2hhZG93Um9vdE9ySG9zdCh0b1NoYWRvd1Jvb3QocGFyZW50KSkg OiB0cmF2ZXJzZU5vZGVFc2NhcGluZ0ZhbGxiYWNrQ29udGVudHMocGFyZW50KTsKLSAgICByZXR1 cm4gMDsKLX0KLQotTm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVu dEJhY2tUb1NoYWRvd1Jvb3RPckhvc3QoY29uc3QgU2hhZG93Um9vdCogc2hhZG93Um9vdCkgY29u c3QKLXsKLSAgICBBU1NFUlQoc2hhZG93Um9vdCk7Ci0KLSAgICBpZiAoY2FuQ3Jvc3NVcHBlckJv dW5kYXJ5KCkpCi0gICAgICAgIHJldHVybiBzaGFkb3dSb290LT5ob3N0RWxlbWVudCgpOwotCi0g ICAgcmV0dXJuIGNvbnN0X2Nhc3Q8U2hhZG93Um9vdCo+KHNoYWRvd1Jvb3QpOworICAgIENvbnRh aW5lck5vZGUqIHBhcmVudCA9IG5vZGUtPnBhcmVudE5vZGUoKTsKKyAgICBpZiAoIXBhcmVudCkK KyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBpZiAocGFyZW50LT5pc1NoYWRvd1Jvb3Qo KSkKKyAgICAgICAgcmV0dXJuIGNhbkNyb3NzVXBwZXJCb3VuZGFyeSgpID8gdG9TaGFkb3dSb290 KHBhcmVudCktPmhvc3RFbGVtZW50KCkgOiBwYXJlbnQ7CisKKyAgICBpZiAocGFyZW50LT5pc0lu c2VydGlvblBvaW50KCkpIHsKKyAgICAgICAgY29uc3QgSW5zZXJ0aW9uUG9pbnQqIGluc2VydGlv blBvaW50ID0gdG9JbnNlcnRpb25Qb2ludChwYXJlbnQpOworICAgICAgICBpZiAoaW5zZXJ0aW9u UG9pbnQtPmhhc0Rpc3RyaWJ1dGlvbigpKQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Cisg ICAgICAgIGlmIChpbnNlcnRpb25Qb2ludC0+aXNBY3RpdmUoKSkKKyAgICAgICAgICAgIHJldHVy biB0cmF2ZXJzZVBhcmVudChwYXJlbnQpOworICAgIH0KKyAgICByZXR1cm4gcGFyZW50OwogfQog CiBOb2RlKiBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNlTmV4dFNpYmxpbmcoY29u c3QgTm9kZSogbm9kZSkKQEAgLTI2Niw3ICsyNDQsNyBAQCB2b2lkIENvbXBvc2VkU2hhZG93VHJl ZVdhbGtlcjo6cHJldmlvdXMoCiAgICAgICAgICAgICBuID0gY2hpbGQ7CiAgICAgICAgIG1fbm9k ZSA9IG47CiAgICAgfSBlbHNlCi0gICAgICAgIHBhcmVudCgpOworICAgICAgICBtX25vZGUgPSB0 cmF2ZXJzZVBhcmVudChtX25vZGUpOwogICAgIGFzc2VydFBvc3Rjb25kaXRpb24oKTsKIH0KIApJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuaAko cmV2aXNpb24gMTU1MjU0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2VkU2hhZG93VHJl ZVdhbGtlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01MiwxMCArNTIsNiBAQCBwdWJsaWM6CiAKICAg ICBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXIoY29uc3QgTm9kZSosIFBvbGljeSA9IENyb3NzVXBw ZXJCb3VuZGFyeSwgU3RhcnRQb2xpY3kgPSBDYW5ub3RTdGFydEZyb21TaGFkb3dCb3VuZGFyeSk7 CiAKLSAgICAvLyBGb3IgYSBjb21tb24gdXNlIGNhc2Ugc3VjaCBhczoKLSAgICAvLyBmb3IgKENv bXBvc2VkU2hhZG93VHJlZVdhbGtlciB3YWxrZXIgPSBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6 OmZyb21GaXJzdENoaWxkKG5vZGUpOyB3YWxrZXIuZ2V0KCk7IHdhbGtlci5uZXh0U2libGluZygp KQotICAgIHN0YXRpYyBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXIgZnJvbUZpcnN0Q2hpbGQoY29u c3QgTm9kZSosIFBvbGljeSA9IENyb3NzVXBwZXJCb3VuZGFyeSk7Ci0KICAgICBOb2RlKiBnZXQo KSBjb25zdCB7IHJldHVybiBjb25zdF9jYXN0PE5vZGUqPihtX25vZGUpOyB9CiAKICAgICB2b2lk IGZpcnN0Q2hpbGQoKTsKQEAgLTExNSwxMCArMTExLDYgQEAgcHJpdmF0ZToKIAogICAgIHN0YXRp YyBOb2RlKiBlc2NhcGVGYWxsYmFja0NvbnRlbnRFbGVtZW50KGNvbnN0IE5vZGUqLCBUcmF2ZXJz YWxEaXJlY3Rpb24pOwogCi0gICAgTm9kZSogdHJhdmVyc2VOb2RlRXNjYXBpbmdGYWxsYmFja0Nv bnRlbnRzKGNvbnN0IE5vZGUqKSBjb25zdDsKLSAgICBOb2RlKiB0cmF2ZXJzZVBhcmVudEluQ3Vy cmVudFRyZWUoY29uc3QgTm9kZSopIGNvbnN0OwotICAgIE5vZGUqIHRyYXZlcnNlUGFyZW50QmFj a1RvU2hhZG93Um9vdE9ySG9zdChjb25zdCBTaGFkb3dSb290KikgY29uc3Q7Ci0KICAgICBjb25z dCBOb2RlKiBtX25vZGU7CiAgICAgUG9saWN5IG1fcG9saWN5OwogfTsK