120969 2013-09-07 15:03:24 -0700 no safeseh on win64 2013-09-25 17:40:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P3 Minor --- 0 alex.christensen webkit-unassigned bfulgham commit-queue oldest_to_newest 926268 0 alex.christensen 2013-09-07 15:03:24 -0700 r155226 added 32-bit assembly for something having to do with safe exception handlers, which should be disabled for win64. 926269 1 210924 alex.christensen 2013-09-07 15:08:01 -0700 Created attachment 210924 Patch 932281 2 212388 alex.christensen 2013-09-23 14:07:16 -0700 Created attachment 212388 Patch 932305 3 212388 bfulgham 2013-09-23 15:02:33 -0700 Comment on attachment 212388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212388&action=review I'm not sure this patch is really the right fix.I already filed https://bugs.webkit.org/show_bug.cgi?id=120906 to fix it properly, but haven't been able to work on it yet. I'm fine with landing this patch with the understanding that Bug 120906 will eventually deal with it. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7516 > + <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild> Are we sure these files are not usable in 64-bit mode? They turn off exception handling for he current stack (handing control of the handler to a hand-written ASM routine.) This routine allows us to crash immediately with a good stack trace,rather than blowing up later. 932310 4 alex.christensen 2013-09-23 15:08:37 -0700 > I'm fine with landing this patch with the understanding that Bug 120906 will eventually deal with it. "eventually". Let's land this to have a working 64-bit build until then. > > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7516 > > + <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild> > > Are we sure these files are not usable in 64-bit mode? They turn off exception handling for he current stack (handing control of the handler to a hand-written ASM routine.) This routine allows us to crash immediately with a good stack trace,rather than blowing up later. I'm not sure these files are not usable for the x64 architecture. I just know there is inline assembly for x86 architecture that is causing compiler problems, and that there is no /safeseh option for MSVC's x64 compiler. 932659 5 alex.christensen 2013-09-24 12:16:30 -0700 First of all, this appears to only be used by the AppleWin port in Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp. Second, the x86 assembly in both of these files will need to be replaced by a dedicated x64 assembly file in Bug 120906, so these files will need to be disabled for the x64 build anyway, unless we want the win32 and win64 ports to share exceptionShouldTerminateProgram. We'd need to do a little refactoring later. In any case, I think this is very close to what we'll want in the long run, and it is a quick solution right now. 933265 6 212388 bfulgham 2013-09-25 17:00:54 -0700 Comment on attachment 212388 Patch r=me 933275 7 212388 commit-queue 2013-09-25 17:40:33 -0700 Comment on attachment 212388 Patch Clearing flags on attachment: 212388 Committed r156436: <http://trac.webkit.org/changeset/156436> 933276 8 commit-queue 2013-09-25 17:40:36 -0700 All reviewed patches have been landed. Closing bug. 210924 2013-09-07 15:08:01 -0700 2013-09-23 14:07:12 -0700 Patch bug-120969-20130907150817.patch text/plain 2889 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTA3ICBBbGV4IENo cmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKworICAgICAgICBXaW42 NCBzaG91bGRuJ3QgaGF2ZSBzYWZlc2VoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIwOTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLnZjeHByb2ovV2ViQ29yZS52Y3hwcm9qOgorICAg ICAgICBEaWFibGVkIGJ1aWxkaW5nIG1ha2VzYWZlc2VoLmFzbSBvbiBXaW42NC4KKyAgICAgICAg KiBwbGF0Zm9ybS93aW4vU3RydWN0dXJlZEV4Y2VwdGlvbkhhbmRsZXJTdXBwcmVzc29yLmNwcDoK KyAgICAgICAgUHJvdGVjdGVkIHg4NiBhc3NlbWJseSB3aXRoIENQVShYODYpLgorCiAyMDEzLTA5 LTA3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg dW5uZWNlc3Nhcnkgc2libGluZyB0ZXh0IHJlbmRlcmVycyBhZnRlciBhdHRhY2gKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2oKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJvagkocmV2aXNp b24gMTU1MjYwKQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4 cHJvagkod29ya2luZyBjb3B5KQpAQCAtMjE0MzgsNiArMjE0MzgsMTAgQEAKICAgICAgIDxBZGRp dGlvbmFsT3B0aW9ucyBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09 J1Byb2R1Y3Rpb258V2luMzInIj4vc2FmZXNlaCAlKEFkZGl0aW9uYWxPcHRpb25zKTwvQWRkaXRp b25hbE9wdGlvbnM+CiAgICAgICA8QWRkaXRpb25hbE9wdGlvbnMgQ29uZGl0aW9uPSInJChDb25m aWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJvfFdpbjMyJyI+L3NhZmVz ZWggJShBZGRpdGlvbmFsT3B0aW9ucyk8L0FkZGl0aW9uYWxPcHRpb25zPgogICAgICAgPEFkZGl0 aW9uYWxPcHRpb25zIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0n UmVsZWFzZXxXaW4zMiciPi9zYWZlc2VoICUoQWRkaXRpb25hbE9wdGlvbnMpPC9BZGRpdGlvbmFs T3B0aW9ucz4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRpb249IickKENvbmZpZ3Vy YXRpb24pfCQoUGxhdGZvcm0pJz09J1JlbGVhc2VfV2luQ2Fpcm98eDY0JyI+dHJ1ZTwvRXhjbHVk ZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0aW9uPSInJChDb25m aWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z3x4NjQnIj50cnVlPC9FeGNsdWRlZEZyb21C dWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRp b24pfCQoUGxhdGZvcm0pJz09J0RlYnVnX1dpbkNhaXJvfHg2NCciPnRydWU8L0V4Y2x1ZGVkRnJv bUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJh dGlvbil8JChQbGF0Zm9ybSknPT0nUmVsZWFzZXx4NjQnIj50cnVlPC9FeGNsdWRlZEZyb21CdWls ZD4KICAgICA8L01BU00+CiAgICAgPE1BU00gSW5jbHVkZT0iLi5ccGx1Z2luc1x3aW5cUGFpbnRI b29rcy5hc20iPgogICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmln dXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWd8V2luMzInIj50cnVlPC9FeGNsdWRlZEZyb21C dWlsZD4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9TdHJ1Y3R1cmVkRXhjZXB0 aW9uSGFuZGxlclN1cHByZXNzb3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9TdHJ1Y3R1cmVkRXhjZXB0aW9uSGFuZGxlclN1cHByZXNzb3IuY3BwCShyZXZp c2lvbiAxNTUyNjApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU3RydWN0dXJlZEV4 Y2VwdGlvbkhhbmRsZXJTdXBwcmVzc29yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzMsNiArNzMs OCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAjcHJhZ21hIHdhcm5pbmcocHVzaCkKICNwcmFnbWEg d2FybmluZyhkaXNhYmxlOiA0NzMzKSAvLyBEaXNhYmxlICJub3QgcmVnaXN0ZXJlZCBhcyBzYWZl IGhhbmRsZXIiIHdhcm5pbmcKIAorI2lmIENQVShYODYpCisKIFN0cnVjdHVyZWRFeGNlcHRpb25I YW5kbGVyU3VwcHJlc3Nvcjo6U3RydWN0dXJlZEV4Y2VwdGlvbkhhbmRsZXJTdXBwcmVzc29yKEV4 Y2VwdGlvblJlZ2lzdHJhdGlvbiYgZXhjZXB0aW9uUmVnaXN0cmF0aW9uKQogewogICAgIC8vIE5v dGU6IFdpbmRvd3MgcmVxdWlyZXMgdGhhdCB0aGUgRVhDRVBUSU9OX1JFR0lTVFJBVElPTiBibG9j ayAobW9kZWxlZCBoZXJlIGFzIG91cgpAQCAtMTI5LDYgKzEzMSw4IEBAIFN0cnVjdHVyZWRFeGNl cHRpb25IYW5kbGVyU3VwcHJlc3Nvcjo6flMKICAgICBfX2FzbSBtb3YgRlM6WzBdLCBlYXgKIH0K IAorI2VuZGlmCisKICNwcmFnbWEgd2FybmluZyhwb3ApCiAKIH0K 212388 2013-09-23 14:07:16 -0700 2013-09-25 17:40:33 -0700 Patch bug-120969-20130923150851.patch text/plain 3514 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjI5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTIzICBBbGV4IENo cmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKworICAgICAgICBXaW42 NCBjb21waWxlIGZpeCBhZnRlciByMTU1MjI2LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwOTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLnZjeHByb2ovV2ViQ29yZS52Y3hwcm9qOgor ICAgICAgICBEaXNhYmxlIGJ1aWxkaW5nIFN0cnVjdHVyZWRFeGNlcHRpb25IYW5kbGVyU3VwcHJl c3Nvci5jcHAgYW5kIG1ha2VzYWZlc2VoLmFzbSBvbiBXaW42NC4KKwogMjAxMy0wOS0yMyAgQWxl eGFuZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9iZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogW0NTUyBSZWdpb25zXSBEaXNwbGF5IENTUyBSZWdpb25zIGZsb3cgbmFtZSBpbiB0aGUg aW5zcGVjdG9yIG92ZXJsYXkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9X ZWJDb3JlLnZjeHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hw cm9qL1dlYkNvcmUudmN4cHJvagkocmV2aXNpb24gMTU2MTE4KQorKysgU291cmNlL1dlYkNvcmUv V2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJvagkod29ya2luZyBjb3B5KQpAQCAtNzUxMiw3 ICs3NTEyLDE0IEBACiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxwbGF0Zm9ybVx3aW5cU2hh cmVkQnVmZmVyV2luLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHBsYXRmb3Jt XHdpblxTaGFyZWRUaW1lcldpbi5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxw bGF0Zm9ybVx3aW5cU291bmRXaW4uY3BwIiAvPgotICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5c cGxhdGZvcm1cd2luXFN0cnVjdHVyZWRFeGNlcHRpb25IYW5kbGVyU3VwcHJlc3Nvci5jcHAiIC8+ CisgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxwbGF0Zm9ybVx3aW5cU3RydWN0dXJlZEV4Y2Vw dGlvbkhhbmRsZXJTdXBwcmVzc29yLmNwcCI+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29u ZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z3x4NjQnIj50cnVl PC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRpb249 IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnX1dpbkNhaXJvfHg2NCciPnRy dWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlv bj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWdTdWZmaXh8eDY0JyI+dHJ1 ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0aW9u PSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlfHg2NCciPnRydWU8L0V4 Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQo Q29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUmVsZWFzZV9XaW5DYWlyb3x4NjQnIj50cnVl PC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRpb249 IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1Byb2R1Y3Rpb258eDY0JyI+dHJ1ZTwv RXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgPC9DbENvbXBpbGU+CiAgICAgPENsQ29tcGlsZSBJbmNs dWRlPSIuLlxwbGF0Zm9ybVx3aW5cU3lzdGVtSW5mby5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJ bmNsdWRlPSIuLlxwbGF0Zm9ybVx3aW5cVGVtcG9yYXJ5TGlua1N0dWJzLmNwcCIgLz4KICAgICA8 Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHBsYXRmb3JtXHdpblxXQ0RhdGFPYmplY3QuY3BwIj4KQEAg LTIxNDAzLDYgKzIxNDEwLDEyIEBACiAgICAgICA8QWRkaXRpb25hbE9wdGlvbnMgQ29uZGl0aW9u PSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdQcm9kdWN0aW9ufFdpbjMyJyI+L3Nh ZmVzZWggJShBZGRpdGlvbmFsT3B0aW9ucyk8L0FkZGl0aW9uYWxPcHRpb25zPgogICAgICAgPEFk ZGl0aW9uYWxPcHRpb25zIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSkn PT0nUmVsZWFzZV9XaW5DYWlyb3xXaW4zMiciPi9zYWZlc2VoICUoQWRkaXRpb25hbE9wdGlvbnMp PC9BZGRpdGlvbmFsT3B0aW9ucz4KICAgICAgIDxBZGRpdGlvbmFsT3B0aW9ucyBDb25kaXRpb249 IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1JlbGVhc2V8V2luMzInIj4vc2FmZXNl aCAlKEFkZGl0aW9uYWxPcHRpb25zKTwvQWRkaXRpb25hbE9wdGlvbnM+CisgICAgICA8RXhjbHVk ZWRGcm9tQnVpbGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdE ZWJ1Z3x4NjQnIj50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21C dWlsZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnX1dp bkNhaXJvfHg2NCciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJv bUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWdT dWZmaXh8eDY0JyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9t QnVpbGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNl fHg2NCciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxk IENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUmVsZWFzZV9XaW5D YWlyb3x4NjQnIj50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21C dWlsZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1Byb2R1Y3Rp b258eDY0JyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CiAgICAgPC9NQVNNPgogICAgIDxNQVNN IEluY2x1ZGU9Ii4uXHBsdWdpbnNcd2luXFBhaW50SG9va3MuYXNtIj4KICAgICAgIDxFeGNsdWRl ZEZyb21CdWlsZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0Rl YnVnfFdpbjMyJyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+Cg==