120959 2013-09-07 11:06:10 -0700 VectorMover should use std::move 2013-09-07 17:25:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue ggaren webkit-ews oldest_to_newest 926227 0 andersca 2013-09-07 11:06:10 -0700 VectorMover should use std::move 926228 1 210913 andersca 2013-09-07 11:08:01 -0700 Created attachment 210913 Patch 926230 2 210913 webkit-ews 2013-09-07 11:16:50 -0700 Comment on attachment 210913 Patch Attachment 210913 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1723005 926232 3 210913 webkit-ews 2013-09-07 11:20:17 -0700 Comment on attachment 210913 Patch Attachment 210913 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1703996 926235 4 ggaren 2013-09-07 11:41:13 -0700 /home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive] I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield? 926236 5 210913 ggaren 2013-09-07 11:41:29 -0700 Comment on attachment 210913 Patch r=me 926238 6 andersca 2013-09-07 11:54:29 -0700 (In reply to comment #4) > /home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive] > > I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield? I think it’s a bug in that particular version of GCC. I am going to change the bitfield type to unsigned instead. 926247 7 210916 andersca 2013-09-07 12:23:39 -0700 Created attachment 210916 Patch 926250 8 andersca 2013-09-07 12:45:05 -0700 Committed r155258: <http://trac.webkit.org/changeset/155258> 210913 2013-09-07 11:08:01 -0700 2013-09-07 12:23:36 -0700 Patch bug-120959-20130907110800.patch text/plain 2850 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkwNDBlYTU0N2VhMjg4YzQ3ODVmOWM5 OGJhYThlNzBlMzZmOGY3ZjkuLjg5ZTkwZmVkN2RmYTEzNGU3ZThjNDZmYWQ4MTgzNTFlOWYwMjM3 ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTMtMDktMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBWZWN0b3JNb3ZlciBzaG91bGQgdXNlIHN0ZDo6 bW92ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIw OTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBsZXRzIHRoZSBjb21waWxlciB1c2UgbW92ZSBjb25zdHJ1Y3RvcnMgd2hlbiBtb3ZpbmcgZGF0 YSwgd2hpY2ggY2FuIGJlIGEgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisgICAgICAgIElmIHRo ZSB2ZWN0b3IgZWxlbWVudCB0eXBlIGlzbid0IG1vdmFibGUgaXQgd2lsbCBiZSBjb3BpZWQgaW5z dGVhZC4KKworICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdURjo6VmVjdG9yVHlw ZU9wZXJhdGlvbnM6Om1vdmUpOgorICAgICAgICAoV1RGOjpWZWN0b3JUeXBlT3BlcmF0aW9uczo6 bW92ZU92ZXJsYXBwaW5nKToKKworMjAxMy0wOS0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgorCiAgICAgICAgIEdldCByaWQgb2YgRmFzdEFsbG9jQmFzZS5oCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA5NTIKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvVmVjdG9yLmggYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3Iu aAppbmRleCA4NjcxMzA0NTI5YmI0MDdmNjQ5MDE5NTc0NzQxZTdkZmZmYmIzYWRjLi41ZTI2NmEy ZDEyMmNhOTkzNDBlMzk4ZDExMTY1NDk4MDg2ZDk1YzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9WZWN0b3IuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaApAQCAtOTAsMjAgKzkw LDE2IEBAIHN0cnVjdCBWZWN0b3JNb3ZlcjsKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+CiBzdHJ1Y3Qg VmVjdG9yTW92ZXI8ZmFsc2UsIFQ+CiB7Ci0gICAgc3RhdGljIHZvaWQgbW92ZShjb25zdCBUKiBz cmMsIGNvbnN0IFQqIHNyY0VuZCwgVCogZHN0KQorICAgIHN0YXRpYyB2b2lkIG1vdmUoVCogc3Jj LCBUKiBzcmNFbmQsIFQqIGRzdCkKICAgICB7CiAgICAgICAgIHdoaWxlIChzcmMgIT0gc3JjRW5k KSB7Ci0gICAgICAgICAgICBuZXcgKE5vdE51bGwsIGRzdCkgVCgqc3JjKTsKLSNpZiBDT01QSUxF UihTVU5DQykgJiYgX19TVU5QUk9fQ0MgPD0gMHg1OTAKLSAgICAgICAgICAgIGNvbnN0X2Nhc3Q8 VCo+KHNyYyktPn5UKCk7IC8vIFdvcmsgYXJvdW5kIG9ic2N1cmUgU3VuQ0MgMTIgY29tcGlsZXIg YnVnLgotI2Vsc2UKKyAgICAgICAgICAgIG5ldyAoTm90TnVsbCwgZHN0KSBUKHN0ZDo6bW92ZSgq c3JjKSk7CiAgICAgICAgICAgICBzcmMtPn5UKCk7Ci0jZW5kaWYKICAgICAgICAgICAgICsrZHN0 OwogICAgICAgICAgICAgKytzcmM7CiAgICAgICAgIH0KICAgICB9Ci0gICAgc3RhdGljIHZvaWQg bW92ZU92ZXJsYXBwaW5nKGNvbnN0IFQqIHNyYywgY29uc3QgVCogc3JjRW5kLCBUKiBkc3QpCisg ICAgc3RhdGljIHZvaWQgbW92ZU92ZXJsYXBwaW5nKFQqIHNyYywgVCogc3JjRW5kLCBUKiBkc3Qp CiAgICAgewogICAgICAgICBpZiAoc3JjID4gZHN0KQogICAgICAgICAgICAgbW92ZShzcmMsIHNy Y0VuZCwgZHN0KTsKQEAgLTExMiw3ICsxMDgsNyBAQCBzdHJ1Y3QgVmVjdG9yTW92ZXI8ZmFsc2Us IFQ+CiAgICAgICAgICAgICB3aGlsZSAoc3JjICE9IHNyY0VuZCkgewogICAgICAgICAgICAgICAg IC0tc3JjRW5kOwogICAgICAgICAgICAgICAgIC0tZHN0RW5kOwotICAgICAgICAgICAgICAgIG5l dyAoTm90TnVsbCwgZHN0RW5kKSBUKCpzcmNFbmQpOworICAgICAgICAgICAgICAgIG5ldyAoTm90 TnVsbCwgZHN0RW5kKSBUKHN0ZDo6bW92ZSgqc3JjRW5kKSk7CiAgICAgICAgICAgICAgICAgc3Jj RW5kLT5+VCgpOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC0yMjIsMTIgKzIxOCwxMiBA QCBzdHJ1Y3QgVmVjdG9yVHlwZU9wZXJhdGlvbnMKICAgICAgICAgVmVjdG9ySW5pdGlhbGl6ZXI8 VmVjdG9yVHJhaXRzPFQ+OjpuZWVkc0luaXRpYWxpemF0aW9uLCBWZWN0b3JUcmFpdHM8VD46OmNh bkluaXRpYWxpemVXaXRoTWVtc2V0LCBUPjo6aW5pdGlhbGl6ZShiZWdpbiwgZW5kKTsKICAgICB9 CiAKLSAgICBzdGF0aWMgdm9pZCBtb3ZlKGNvbnN0IFQqIHNyYywgY29uc3QgVCogc3JjRW5kLCBU KiBkc3QpCisgICAgc3RhdGljIHZvaWQgbW92ZShUKiBzcmMsIFQqIHNyY0VuZCwgVCogZHN0KQog ICAgIHsKICAgICAgICAgVmVjdG9yTW92ZXI8VmVjdG9yVHJhaXRzPFQ+OjpjYW5Nb3ZlV2l0aE1l bWNweSwgVD46Om1vdmUoc3JjLCBzcmNFbmQsIGRzdCk7CiAgICAgfQogCi0gICAgc3RhdGljIHZv aWQgbW92ZU92ZXJsYXBwaW5nKGNvbnN0IFQqIHNyYywgY29uc3QgVCogc3JjRW5kLCBUKiBkc3Qp CisgICAgc3RhdGljIHZvaWQgbW92ZU92ZXJsYXBwaW5nKFQqIHNyYywgVCogc3JjRW5kLCBUKiBk c3QpCiAgICAgewogICAgICAgICBWZWN0b3JNb3ZlcjxWZWN0b3JUcmFpdHM8VD46OmNhbk1vdmVX aXRoTWVtY3B5LCBUPjo6bW92ZU92ZXJsYXBwaW5nKHNyYywgc3JjRW5kLCBkc3QpOwogICAgIH0K 210916 2013-09-07 12:23:39 -0700 2013-09-07 17:25:32 -0700 Patch bug-120959-20130907122338.patch text/plain 4244 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YzAxMjI3YTkyNGNjOTBkMjhjNDk5ODhhMTIwM2E5MjZmYTk1NjBjLi5jZGQ5YjYzMTNjNmMzN2Nh M2M4MjhjZTRiODdkMjRiMDU4NmU0MDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMy0wOS0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCisgICAgICAgIFZlY3Rvck1vdmVyIHNob3VsZCB1c2Ugc3RkOjptb3ZlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA5NTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3JrIGFyb3VuZCBhIGJ1 ZyBpbiBHQ0MgYnkgY2hhbmdpbmcgdGhlIHR5cGUgb2YgdGhlIGNhbGxUeXBlIGJpdGZpZWxkIAor ICAgICAgICBpbiBDYWxsTGlua0luZm8gdG8gYmUgdW5zaWduZWQgaW5zdGVhZCBvZiBDYWxsVHlw ZS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NhbGxMaW5rSW5mby5oOgorCisyMDEzLTA5LTA3ICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgR2V0IHJpZCBv ZiBGYXN0QWxsb2NCYXNlLmgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMDk1MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkwNDBlYTU0N2VhMjg4YzQ3ODVmOWM5OGJhYThlNzBl MzZmOGY3ZjkuLjg5ZTkwZmVkN2RmYTEzNGU3ZThjNDZmYWQ4MTgzNTFlOWYwMjM3ZWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTkgQEAKIDIwMTMtMDktMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAorICAgICAgICBWZWN0b3JNb3ZlciBzaG91bGQgdXNlIHN0ZDo6bW92ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwOTU5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBsZXRzIHRo ZSBjb21waWxlciB1c2UgbW92ZSBjb25zdHJ1Y3RvcnMgd2hlbiBtb3ZpbmcgZGF0YSwgd2hpY2gg Y2FuIGJlIGEgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisgICAgICAgIElmIHRoZSB2ZWN0b3Ig ZWxlbWVudCB0eXBlIGlzbid0IG1vdmFibGUgaXQgd2lsbCBiZSBjb3BpZWQgaW5zdGVhZC4KKwor ICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdURjo6VmVjdG9yVHlwZU9wZXJhdGlv bnM6Om1vdmUpOgorICAgICAgICAoV1RGOjpWZWN0b3JUeXBlT3BlcmF0aW9uczo6bW92ZU92ZXJs YXBwaW5nKToKKworMjAxMy0wOS0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCiAgICAgICAgIEdldCByaWQgb2YgRmFzdEFsbG9jQmFzZS5oCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA5NTIKIApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rSW5mby5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rSW5mby5oCmluZGV4IDM2ZWI4NGJlZTM0Mzdh MzdjYWI2ZjM0MWM4NzZiMGE3MzAwZWJmZDQuLjAyNDQ0OTdkZjRjMDVkMTI3Mzc4MWM2ZjRlZWJk YzYxZmFmZmNkNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9D YWxsTGlua0luZm8uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbExp bmtJbmZvLmgKQEAgLTgyLDcgKzgyLDcgQEAgc3RydWN0IENhbGxMaW5rSW5mbyA6IHB1YmxpYyBC YXNpY1Jhd1NlbnRpbmVsTm9kZTxDYWxsTGlua0luZm8+IHsKICAgICBib29sIGhhc1NlZW5TaG91 bGRSZXBhdGNoIDogMTsKICAgICBib29sIGlzREZHIDogMTsKICAgICBib29sIGhhc1NlZW5DbG9z dXJlIDogMTsKLSAgICBDYWxsVHlwZSBjYWxsVHlwZSA6IDU7CisgICAgdW5zaWduZWQgY2FsbFR5 cGUgOiA1OyAvLyBDYWxsVHlwZQogICAgIHVuc2lnbmVkIGNhbGxlZUdQUiA6IDg7CiAgICAgQ29k ZU9yaWdpbiBjb2RlT3JpZ2luOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3Iu aCBiL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCmluZGV4IDg2NzEzMDQ1MjliYjQwN2Y2NDkwMTk1 NzQ3NDFlN2RmZmZiYjNhZGMuLjVlMjY2YTJkMTIyY2E5OTM0MGUzOThkMTExNjU0OTgwODZkOTVj MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL1ZlY3Rvci5oCkBAIC05MCwyMCArOTAsMTYgQEAgc3RydWN0IFZlY3Rvck1vdmVyOwogdGVt cGxhdGU8dHlwZW5hbWUgVD4KIHN0cnVjdCBWZWN0b3JNb3ZlcjxmYWxzZSwgVD4KIHsKLSAgICBz dGF0aWMgdm9pZCBtb3ZlKGNvbnN0IFQqIHNyYywgY29uc3QgVCogc3JjRW5kLCBUKiBkc3QpCisg ICAgc3RhdGljIHZvaWQgbW92ZShUKiBzcmMsIFQqIHNyY0VuZCwgVCogZHN0KQogICAgIHsKICAg ICAgICAgd2hpbGUgKHNyYyAhPSBzcmNFbmQpIHsKLSAgICAgICAgICAgIG5ldyAoTm90TnVsbCwg ZHN0KSBUKCpzcmMpOwotI2lmIENPTVBJTEVSKFNVTkNDKSAmJiBfX1NVTlBST19DQyA8PSAweDU5 MAotICAgICAgICAgICAgY29uc3RfY2FzdDxUKj4oc3JjKS0+flQoKTsgLy8gV29yayBhcm91bmQg b2JzY3VyZSBTdW5DQyAxMiBjb21waWxlciBidWcuCi0jZWxzZQorICAgICAgICAgICAgbmV3IChO b3ROdWxsLCBkc3QpIFQoc3RkOjptb3ZlKCpzcmMpKTsKICAgICAgICAgICAgIHNyYy0+flQoKTsK LSNlbmRpZgogICAgICAgICAgICAgKytkc3Q7CiAgICAgICAgICAgICArK3NyYzsKICAgICAgICAg fQogICAgIH0KLSAgICBzdGF0aWMgdm9pZCBtb3ZlT3ZlcmxhcHBpbmcoY29uc3QgVCogc3JjLCBj b25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKKyAgICBzdGF0aWMgdm9pZCBtb3ZlT3ZlcmxhcHBpbmco VCogc3JjLCBUKiBzcmNFbmQsIFQqIGRzdCkKICAgICB7CiAgICAgICAgIGlmIChzcmMgPiBkc3Qp CiAgICAgICAgICAgICBtb3ZlKHNyYywgc3JjRW5kLCBkc3QpOwpAQCAtMTEyLDcgKzEwOCw3IEBA IHN0cnVjdCBWZWN0b3JNb3ZlcjxmYWxzZSwgVD4KICAgICAgICAgICAgIHdoaWxlIChzcmMgIT0g c3JjRW5kKSB7CiAgICAgICAgICAgICAgICAgLS1zcmNFbmQ7CiAgICAgICAgICAgICAgICAgLS1k c3RFbmQ7Ci0gICAgICAgICAgICAgICAgbmV3IChOb3ROdWxsLCBkc3RFbmQpIFQoKnNyY0VuZCk7 CisgICAgICAgICAgICAgICAgbmV3IChOb3ROdWxsLCBkc3RFbmQpIFQoc3RkOjptb3ZlKCpzcmNF bmQpKTsKICAgICAgICAgICAgICAgICBzcmNFbmQtPn5UKCk7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KQEAgLTIyMiwxMiArMjE4LDEyIEBAIHN0cnVjdCBWZWN0b3JUeXBlT3BlcmF0aW9ucwog ICAgICAgICBWZWN0b3JJbml0aWFsaXplcjxWZWN0b3JUcmFpdHM8VD46Om5lZWRzSW5pdGlhbGl6 YXRpb24sIFZlY3RvclRyYWl0czxUPjo6Y2FuSW5pdGlhbGl6ZVdpdGhNZW1zZXQsIFQ+Ojppbml0 aWFsaXplKGJlZ2luLCBlbmQpOwogICAgIH0KIAotICAgIHN0YXRpYyB2b2lkIG1vdmUoY29uc3Qg VCogc3JjLCBjb25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKKyAgICBzdGF0aWMgdm9pZCBtb3ZlKFQq IHNyYywgVCogc3JjRW5kLCBUKiBkc3QpCiAgICAgewogICAgICAgICBWZWN0b3JNb3ZlcjxWZWN0 b3JUcmFpdHM8VD46OmNhbk1vdmVXaXRoTWVtY3B5LCBUPjo6bW92ZShzcmMsIHNyY0VuZCwgZHN0 KTsKICAgICB9CiAKLSAgICBzdGF0aWMgdm9pZCBtb3ZlT3ZlcmxhcHBpbmcoY29uc3QgVCogc3Jj LCBjb25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKKyAgICBzdGF0aWMgdm9pZCBtb3ZlT3ZlcmxhcHBp bmcoVCogc3JjLCBUKiBzcmNFbmQsIFQqIGRzdCkKICAgICB7CiAgICAgICAgIFZlY3Rvck1vdmVy PFZlY3RvclRyYWl0czxUPjo6Y2FuTW92ZVdpdGhNZW1jcHksIFQ+Ojptb3ZlT3ZlcmxhcHBpbmco c3JjLCBzcmNFbmQsIGRzdCk7CiAgICAgfQo=