120955 2013-09-07 09:21:12 -0700 removing --dialog-element from build-webkit --help option message 2013-09-07 11:55:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 120467 0 santosh.ma webkit-unassigned commit-queue dbates oldest_to_newest 926208 0 santosh.ma 2013-09-07 09:21:12 -0700 $Tools/Script/build-webkit --help -[no-]data-transfer-items Toggle Data Transfer Items support (default: 0) --[no-]details-element Toggle Details Element support (default: 1) --[no-]device-orientation Toggle Device Orientation support (default: ) --[no-]dialog-element Toggle Dialog Element support (default: 0) ---> Need to Remove --[no-]directory-upload Toggle Directory Upload support (default: 0) --[no-]dom4-events-constructor Expose DOM4 Events constructors (default: 1) Dialog element feature has been removed from webkit. So it should not be display in help message. 926209 1 210910 santosh.ma 2013-09-07 09:32:09 -0700 Created attachment 210910 Patch 926219 2 210910 dbates 2013-09-07 10:20:24 -0700 Comment on attachment 210910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210910&action=review > Tools/ChangeLog:3 > + removing --dialog-element from build-webkit --help option message Nit: Please remove the extra space characters before "from" and before "option". > Tools/ChangeLog:7 > + Please add a description to explain that we're removing --dialog-element because we removed dialog element support in <http://trac.webkit.org/changeset/154835> and <http://trac.webkit.org/changeset/154870>. 926221 3 210912 santosh.ma 2013-09-07 10:41:45 -0700 Created attachment 210912 patch for landing 926239 4 210912 commit-queue 2013-09-07 11:55:25 -0700 Comment on attachment 210912 patch for landing Clearing flags on attachment: 210912 Committed r155256: <http://trac.webkit.org/changeset/155256> 926240 5 commit-queue 2013-09-07 11:55:27 -0700 All reviewed patches have been landed. Closing bug. 210910 2013-09-07 09:32:09 -0700 2013-09-07 10:41:34 -0700 Patch bug-120955-20130907220207.patch text/plain 1753 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MjQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTM5ZDk1YWNhYzE3MzlhODM5ZTZiMTYzOTg4NzA5YzBi MTJkNDlhMC4uNTRmNzhkYTQxNjAzNTA3ZWViNjA5ODBiOTA0MDgyOTMxZDE3ZGZlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA5LTA3ICBTYW50b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4K KworICAgICAgICByZW1vdmluZyAtLWRpYWxvZy1lbGVtZW50ICBmcm9tIGJ1aWxkLXdlYmtpdCAt LWhlbHAgIG9wdGlvbiBtZXNzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjA5NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbToKKyAgICAg ICAgUmVtb3ZlZCAtLWRpYWxvZy1lbGVtZW50IG9wdGlvbiBtZXNzYWdlLgorCiAyMDEzLTA5LTA2 ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMTU1MTk2LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1 cmVMaXN0LnBtCmluZGV4IDE4MmUyZDliZDQ0ZmE2ZmUxODgxNjhjNzBmZjU4MjEwNjIwOWIyNDQu LjBhODc2YWE1M2E2YWRjOTA5MmE2NTNmNzMzZTA4NTNmZDcyYTViZWMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTczLDcgKzczLDYgQEAgbXkgKAogICAgICRk YXRhbGlzdEVsZW1lbnRTdXBwb3J0LAogICAgICRkZXRhaWxzRWxlbWVudFN1cHBvcnQsCiAgICAg JGRldmljZU9yaWVudGF0aW9uU3VwcG9ydCwKLSAgICAkZGlhbG9nRWxlbWVudFN1cHBvcnQsCiAg ICAgJGRpcmVjdG9yeVVwbG9hZFN1cHBvcnQsCiAgICAgJGRvbTRFdmVudHNDb25zdHJ1Y3RvciwK ICAgICAkZG93bmxvYWRBdHRyaWJ1dGVTdXBwb3J0LApAQCAtMjQ5LDkgKzI0OCw2IEBAIG15IEBm ZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9PiAiZGV2aWNlLW9yaWVudGF0aW9uIiwgZGVzYyA9 PiAiVG9nZ2xlIERldmljZSBPcmllbnRhdGlvbiBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAi RU5BQkxFX0RFVklDRV9PUklFTlRBVElPTiIsIGRlZmF1bHQgPT4gaXNCbGFja0JlcnJ5KCksIHZh bHVlID0+IFwkZGV2aWNlT3JpZW50YXRpb25TdXBwb3J0IH0sCiAKLSAgICB7IG9wdGlvbiA9PiAi ZGlhbG9nLWVsZW1lbnQiLCBkZXNjID0+ICJUb2dnbGUgRGlhbG9nIEVsZW1lbnQgc3VwcG9ydCIs Ci0gICAgICBkZWZpbmUgPT4gIkVOQUJMRV9ESUFMT0dfRUxFTUVOVCIsIGRlZmF1bHQgPT4gMCwg dmFsdWUgPT4gXCRkaWFsb2dFbGVtZW50U3VwcG9ydCB9LAotCiAgICAgeyBvcHRpb24gPT4gImRp cmVjdG9yeS11cGxvYWQiLCBkZXNjID0+ICJUb2dnbGUgRGlyZWN0b3J5IFVwbG9hZCBzdXBwb3J0 IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0RJUkVDVE9SWV9VUExPQUQiLCBkZWZhdWx0ID0+ IDAsIHZhbHVlID0+IFwkZGlyZWN0b3J5VXBsb2FkU3VwcG9ydCB9LAogCg== 210912 2013-09-07 10:41:45 -0700 2013-09-07 11:55:25 -0700 patch for landing bug-120955-20130907231143.patch text/plain 1984 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MjQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTM5ZDk1YWNhYzE3MzlhODM5ZTZiMTYzOTg4NzA5YzBi MTJkNDlhMC4uZTM4YjE1Yzc3ZTJiMzcxNmVmZjdkZWYxY2UzYmFkMjM4OWE2MDMwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA5LTA3ICBTYW50b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4K KworICAgICAgICByZW1vdmluZyAtLWRpYWxvZy1lbGVtZW50IGZyb20gYnVpbGQtd2Via2l0IC0t aGVscCBvcHRpb24gbWVzc2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIwOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgor CisgICAgICAgIC0tZGlhbG9nLWVsZW1lbnQgb3B0aW9uIGlzIHVzZWxlc3Mgd2hpbGUgYnVpbGRp bmcgYXMKKyAgICAgICAgRGlhbG9nIEVsZW1lbnQgc3VwcG9ydCBoYXMgYmVlbiByZW1vdmVkIGlu IGZvbGxvd2luZyBjaGFuZ2VzZXQuCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hh bmdlc2V0LzE1NDgzNQorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8x NTQ4NzAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbToKKyAg ICAgICAgUmVtb3ZlZCAtLWRpYWxvZy1lbGVtZW50IG9wdGlvbiBtZXNzYWdlLgorCiAyMDEzLTA5 LTA2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTU1MTk2LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0Zl YXR1cmVMaXN0LnBtCmluZGV4IDE4MmUyZDliZDQ0ZmE2ZmUxODgxNjhjNzBmZjU4MjEwNjIwOWIy NDQuLjBhODc2YWE1M2E2YWRjOTA5MmE2NTNmNzMzZTA4NTNmZDcyYTViZWMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTczLDcgKzczLDYgQEAgbXkgKAogICAg ICRkYXRhbGlzdEVsZW1lbnRTdXBwb3J0LAogICAgICRkZXRhaWxzRWxlbWVudFN1cHBvcnQsCiAg ICAgJGRldmljZU9yaWVudGF0aW9uU3VwcG9ydCwKLSAgICAkZGlhbG9nRWxlbWVudFN1cHBvcnQs CiAgICAgJGRpcmVjdG9yeVVwbG9hZFN1cHBvcnQsCiAgICAgJGRvbTRFdmVudHNDb25zdHJ1Y3Rv ciwKICAgICAkZG93bmxvYWRBdHRyaWJ1dGVTdXBwb3J0LApAQCAtMjQ5LDkgKzI0OCw2IEBAIG15 IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9PiAiZGV2aWNlLW9yaWVudGF0aW9uIiwgZGVz YyA9PiAiVG9nZ2xlIERldmljZSBPcmllbnRhdGlvbiBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9 PiAiRU5BQkxFX0RFVklDRV9PUklFTlRBVElPTiIsIGRlZmF1bHQgPT4gaXNCbGFja0JlcnJ5KCks IHZhbHVlID0+IFwkZGV2aWNlT3JpZW50YXRpb25TdXBwb3J0IH0sCiAKLSAgICB7IG9wdGlvbiA9 PiAiZGlhbG9nLWVsZW1lbnQiLCBkZXNjID0+ICJUb2dnbGUgRGlhbG9nIEVsZW1lbnQgc3VwcG9y dCIsCi0gICAgICBkZWZpbmUgPT4gIkVOQUJMRV9ESUFMT0dfRUxFTUVOVCIsIGRlZmF1bHQgPT4g MCwgdmFsdWUgPT4gXCRkaWFsb2dFbGVtZW50U3VwcG9ydCB9LAotCiAgICAgeyBvcHRpb24gPT4g ImRpcmVjdG9yeS11cGxvYWQiLCBkZXNjID0+ICJUb2dnbGUgRGlyZWN0b3J5IFVwbG9hZCBzdXBw b3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0RJUkVDVE9SWV9VUExPQUQiLCBkZWZhdWx0 ID0+IDAsIHZhbHVlID0+IFwkZGlyZWN0b3J5VXBsb2FkU3VwcG9ydCB9LAogCg==