12093 2007-01-03 03:52:21 -0800 Assertion failure in +[WebDataProtocol _webIsDataProtocolURL:] when running layout tests 2007-01-03 17:23:31 -0800 1 1 1 Unclassified WebKit History 420+ Mac OS X 10.4 RESOLVED FIXED LayoutTestFailure, Regression P1 Critical --- 1 ap webkit-unassigned beidson zimmermann oldest_to_newest 37331 0 ap 2007-01-03 03:52:21 -0800 run-webkit-tests fast/images/svg-as-background.html Testing 1 test cases. fast/images .ASSERTION FAILED: URL (/Users/ap/WebKit/WebCore/loader/mac/WebDataProtocol.mm:223 +[WebDataProtocol _webIsDataProtocolURL:]) Segmentation fault Thread 0 Crashed: 0 com.apple.WebCore 0x01482b84 +[WebDataProtocol _webIsDataProtocolURL:] + 92 1 com.apple.WebCore 0x01483b14 WebCore::DocumentLoader::urlForHistory() const + 132 (DocumentLoaderMac.mm:533) 2 com.apple.WebCore 0x014b94e8 WebCore::FrameLoader::updateHistoryForStandardLoad() + 208 (FrameLoader.cpp:2978) 3 com.apple.WebCore 0x014bcdf0 WebCore::FrameLoader::transitionToCommitted(WTF::PassRefPtr<WebCore::PageCache>) + 848 (FrameLoader.cpp:2024) 4 com.apple.WebCore 0x014bd420 WebCore::FrameLoader::commitProvisionalLoad(WTF::PassRefPtr<WebCore::PageCache>) + 224 (FrameLoader.cpp:1933) 5 com.apple.WebCore 0x0151fc80 WebCore::SVGImage::setData(bool) + 1068 (SVGImage.cpp:139) 6 com.apple.WebCore 0x01156c08 WebCore::CachedImage::data(WTF::Vector<char, (unsigned long)0>&, bool) + 116 (CachedImage.cpp:186) 7 com.apple.WebCore 0x0115a8b4 WebCore::Loader::receivedAllData(WebCore::SubresourceLoader*, NSData*) + 344 (loader.cpp:109) 8 com.apple.WebCore 0x014929c8 WebCore::SubresourceLoader::didFinishLoading() + 248 (SubresourceLoaderMac.mm:196) 9 com.apple.WebCore 0x0148d76c WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) + 60 (ResourceLoaderMac.mm:447) 10 com.apple.WebCore 0x014a1d38 -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 144 (ResourceHandleMac.mm:309) 11 com.apple.Foundation 0x9298f84c -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] + 188 37291 1 eric 2007-01-03 10:10:53 -0800 This smells like a problem with SVGImageEmptyClients, or rather the loader depending on a different answer than SVGImageEmptyClients give. 37288 2 zimmermann 2007-01-03 10:11:57 -0800 I can confirm the problems, must have happened last night. 37289 3 beidson 2007-01-03 10:18:21 -0800 I never ran into this yesterday before landing my patch but was hounded with reports of it this morning - I'm taking a look now to see if I can repro... 37251 4 12203 beidson 2007-01-03 16:51:24 -0800 Created attachment 12203 Proprosed fix 37252 5 12203 andersca 2007-01-03 17:07:56 -0800 Comment on attachment 12203 Proprosed fix r=me with the comments I discussed with Brady 37254 6 beidson 2007-01-03 17:23:31 -0800 Committed in r18561 The issue here - faking subresource loads with internal svgs - makes me want to reiterate how disconcerting it is to be faking subresource loads, though my understanding is that we might start doing this in more places than just svg-as-image. Alexey mentioned on #webkit that the work being done in http://bugs.webkit.org/show_bug.cgi?id=10313 is another example of this. If we start doing this more and more, I think we need a much better defined mechanism of how to represent "this is a fake subresource" when we "kick off" the fake load, so history, subresource progress, and other interesting parts of the infrastructure know how to deal with it. 12203 2007-01-03 16:51:24 -0800 2007-01-03 17:07:56 -0800 Proprosed fix 12093patch.txt text/plain 1687 beidson SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTU5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDEt MDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMDkzIC0gQXNzZXJ0aW9uIGluIGNlcnRhaW4gU1ZHIGxheW91dCB0ZXN0 cworICAgICAgICBJIGNhbid0IHJlYWxseSB0aGluayBvZiBhIGNsZWFuZXIgd2F5IHRvIGZpeCB0 aGlzIHRoZW4gdG8gaGVscCB0aGVzZSBTVkcgY2FzZXMgYXZvaWQKKyAgICAgICAgdGhlIEFTU0VS VCAtIGhvcGVmdWxseSB3ZSBjYW4gY2xlYW4gdXAgdGhlIHN2Zy1hcy1pbWFnZSBzaXR1YXRpb24g YXMgdGhlIGxvYWRlciBzdGFiaWxpemVzIAorICAgICAgICBhbmQgd2UgZmluZCBiZXR0ZXIgd2F5 cyB0byBoYW5kbGUgaXQuLi4KKworICAgICAgICAqIGxvYWRlci9tYWMvRG9jdW1lbnRMb2FkZXJN YWMubW06CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6dXJsRm9ySGlzdG9yeSk6 IGVtcHR5LWNoZWNrIHRoZSB1cmwgYmVmb3JlIHBhc3NpbmcgaXQgdG8gdGhlCisgICAgICAgIEFT U0VSVGluZyBtZXRob2QKKwogMjAwNy0wMS0wMyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSHlhdHQuCkluZGV4OiBsb2FkZXIvbWFjL0RvY3Vt ZW50TG9hZGVyTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxvYWRlci9tYWMvRG9jdW1lbnRMb2FkZXJN YWMubW0JKHJldmlzaW9uIDE4NTU5KQorKysgbG9hZGVyL21hYy9Eb2N1bWVudExvYWRlck1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtNTI5LDggKzUyOSwxMSBAQAogICAgIC8vIFJldHVybiB0aGUg VVJMIHRvIGJlIHVzZWQgZm9yIGhpc3RvcnkgYW5kIEIvRiBsaXN0LgogICAgIC8vIFJldHVybnMg bmlsIGZvciBXZWJEYXRhUHJvdG9jb2wgVVJMcyB0aGF0IGFyZW4ndCBhbHRlcm5hdGVzIAogICAg IC8vIGZvciB1bnJlYWNoYWJsZSBVUkxzLCBiZWNhdXNlIHRoZXNlIGNhbid0IGJlIHN0b3JlZCBp biBoaXN0b3J5LgotCi0gICAgaWYgKFtXZWJEYXRhUHJvdG9jb2wgX3dlYklzRGF0YVByb3RvY29s VVJMOlttX29yaWdpbmFsUmVxdWVzdENvcHkubnNVUkxSZXF1ZXN0KCkgVVJMXV0pCisgICAgCisg ICAgaWYgKG1fb3JpZ2luYWxSZXF1ZXN0Q29weS51cmwoKS5pc0VtcHR5KCkpCisgICAgICAgIHJl dHVybiBtX29yaWdpbmFsUmVxdWVzdENvcHkudXJsKCk7CisgICAgICAgIAorICAgIGlmIChbV2Vi RGF0YVByb3RvY29sIF93ZWJJc0RhdGFQcm90b2NvbFVSTDptX29yaWdpbmFsUmVxdWVzdENvcHku dXJsKCkuZ2V0TlNVUkwoKV0pCiAgICAgICAgIHJldHVybiBbbV9vcmlnaW5hbFJlcXVlc3RDb3B5 Lm5zVVJMUmVxdWVzdCgpIF93ZWJEYXRhUmVxdWVzdFVucmVhY2hhYmxlVVJMXTsKIAogICAgIHJl dHVybiBtX29yaWdpbmFsUmVxdWVzdENvcHkudXJsKCk7Cg==