120894 2013-09-06 13:55:04 -0700 Compute the percentage height for the block when the containing block has viewport percentage specified 2013-12-12 00:46:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 118516 BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned benjamin commit-queue dino d-r esprehn+autocc fmalita glenn gur.trio kondapallykalyan pdr schenney simon.fraser thorton zalan oldest_to_newest 925840 0 rniwa 2013-09-06 13:55:04 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/eb44f5056df38b68f75882c758b4d3b5de57508d 928453 1 zalan 2013-09-12 13:07:56 -0700 It's pretty much the duplication of the previous block (including the 4 lines of comment). We need to change it a bit before landing this. 928849 2 211553 kling 2013-09-13 08:16:24 -0700 Created attachment 211553 Patch 928853 3 211553 kling 2013-09-13 08:20:24 -0700 Comment on attachment 211553 Patch oops what am I doing here.. 928867 4 zalan 2013-09-13 08:50:03 -0700 (In reply to comment #3) > (From update of attachment 211553 [details]) > oops what am I doing here.. I'd rather merge this one :) 959088 5 gur.trio 2013-12-12 00:46:17 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 211553 [details] [details]) > > oops what am I doing here.. > > I'd rather merge this one :) Its already done and code had landed. https://bugs.webkit.org/show_bug.cgi?id=118516 *** This bug has been marked as a duplicate of bug 118516 *** 211553 2013-09-13 08:16:24 -0700 2013-09-13 08:20:23 -0700 Patch bug-121301.diff text/plain 5020 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMWNkMDhiLi4yMTgwZmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTMtMDktMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFtDVFRFXSBSZW5kZXJTVkdJbWFnZSBhbHdheXMgaGFzIGEgU1ZHSW1hZ2VFbGVtZW50Lgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTIxMzAxPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcmVuZGVyZXIgaXMgbmV2ZXIgYW5v bnltb3VzLCBhbmQgYWx3YXlzIGhhcyBhIGNvcnJlc3BvbmRpbmcgU1ZHSW1hZ2VFbGVtZW50LiAK KworICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW1hZ2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyU1ZHSW1hZ2U6OlJlbmRlclNWR0ltYWdlKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclNWR0ltYWdlOjppbWFnZUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyU1ZHSW1hZ2U6OnVwZGF0ZUltYWdlVmlld3BvcnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyU1ZHSW1hZ2U6OmxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdJbWFnZTo6 cGFpbnRGb3JlZ3JvdW5kKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdl Lmg6CisgICAgICAgICogc3ZnL1NWR0ltYWdlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTVkdJbWFnZUVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKToKKworMjAxMy0wOS0xMyAgQW5kcmVh cyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgW0NUVEVdIFJlbmRlclNWR1Jl c291cmNlRmlsdGVyUHJpbWl0aXZlIGFsd2F5cyBoYXMgYSBTVkdGaWx0ZXJQcmltaXRpdmVTdGFu ZGFyZEF0dHJpYnV0ZXMuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjEzMDA+CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW1hZ2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbWFnZS5jcHAKaW5k ZXggNGIwNGIxYi4uZGYxYjNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9SZW5kZXJTVkdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9SZW5kZXJTVkdJbWFnZS5jcHAKQEAgLTQ4LDggKzQ4LDggQEAKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCi1SZW5kZXJTVkdJbWFnZTo6UmVuZGVyU1ZHSW1hZ2UoU1ZHSW1hZ2VFbGVtZW50KiBp bXBsKQotICAgIDogUmVuZGVyU1ZHTW9kZWxPYmplY3QoaW1wbCkKK1JlbmRlclNWR0ltYWdlOjpS ZW5kZXJTVkdJbWFnZShTVkdJbWFnZUVsZW1lbnQmIGVsZW1lbnQpCisgICAgOiBSZW5kZXJTVkdN b2RlbE9iamVjdCgmZWxlbWVudCkKICAgICAsIG1fbmVlZHNCb3VuZGFyaWVzVXBkYXRlKHRydWUp CiAgICAgLCBtX25lZWRzVHJhbnNmb3JtVXBkYXRlKHRydWUpCiAgICAgLCBtX2ltYWdlUmVzb3Vy Y2UoUmVuZGVySW1hZ2VSZXNvdXJjZTo6Y3JlYXRlKCkpCkBAIC02MiwxMyArNjIsMTcgQEAgUmVu ZGVyU1ZHSW1hZ2U6On5SZW5kZXJTVkdJbWFnZSgpCiAgICAgbV9pbWFnZVJlc291cmNlLT5zaHV0 ZG93bigpOwogfQogCitTVkdJbWFnZUVsZW1lbnQmIFJlbmRlclNWR0ltYWdlOjppbWFnZUVsZW1l bnQoKSBjb25zdAoreworICAgIHJldHVybiB0b1NWR0ltYWdlRWxlbWVudCgqUmVuZGVyU1ZHTW9k ZWxPYmplY3Q6OmVsZW1lbnQoKSk7Cit9CisKIGJvb2wgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUlt YWdlVmlld3BvcnQoKQogewotICAgIFNWR0ltYWdlRWxlbWVudCogaW1hZ2UgPSB0b1NWR0ltYWdl RWxlbWVudChlbGVtZW50KCkpOwogICAgIEZsb2F0UmVjdCBvbGRCb3VuZGFyaWVzID0gbV9vYmpl Y3RCb3VuZGluZ0JveDsKIAotICAgIFNWR0xlbmd0aENvbnRleHQgbGVuZ3RoQ29udGV4dChpbWFn ZSk7Ci0gICAgbV9vYmplY3RCb3VuZGluZ0JveCA9IEZsb2F0UmVjdChpbWFnZS0+eCgpLnZhbHVl KGxlbmd0aENvbnRleHQpLCBpbWFnZS0+eSgpLnZhbHVlKGxlbmd0aENvbnRleHQpLCBpbWFnZS0+ d2lkdGgoKS52YWx1ZShsZW5ndGhDb250ZXh0KSwgaW1hZ2UtPmhlaWdodCgpLnZhbHVlKGxlbmd0 aENvbnRleHQpKTsKKyAgICBTVkdMZW5ndGhDb250ZXh0IGxlbmd0aENvbnRleHQoJmltYWdlRWxl bWVudCgpKTsKKyAgICBtX29iamVjdEJvdW5kaW5nQm94ID0gRmxvYXRSZWN0KGltYWdlRWxlbWVu dCgpLngoKS52YWx1ZShsZW5ndGhDb250ZXh0KSwgaW1hZ2VFbGVtZW50KCkueSgpLnZhbHVlKGxl bmd0aENvbnRleHQpLCBpbWFnZUVsZW1lbnQoKS53aWR0aCgpLnZhbHVlKGxlbmd0aENvbnRleHQp LCBpbWFnZUVsZW1lbnQoKS5oZWlnaHQoKS52YWx1ZShsZW5ndGhDb250ZXh0KSk7CiAKICAgICBp ZiAob2xkQm91bmRhcmllcyA9PSBtX29iamVjdEJvdW5kaW5nQm94KQogICAgICAgICByZXR1cm4g ZmFsc2U7CkBAIC04OCw3ICs5Miw3IEBAIHZvaWQgUmVuZGVyU1ZHSW1hZ2U6OmxheW91dCgpCiAK ICAgICBib29sIHRyYW5zZm9ybU9yQm91bmRhcmllc1VwZGF0ZSA9IG1fbmVlZHNUcmFuc2Zvcm1V cGRhdGUgfHwgbV9uZWVkc0JvdW5kYXJpZXNVcGRhdGU7CiAgICAgaWYgKG1fbmVlZHNUcmFuc2Zv cm1VcGRhdGUpIHsKLSAgICAgICAgbV9sb2NhbFRyYW5zZm9ybSA9IHRvU1ZHSW1hZ2VFbGVtZW50 KGVsZW1lbnQoKSktPmFuaW1hdGVkTG9jYWxUcmFuc2Zvcm0oKTsKKyAgICAgICAgbV9sb2NhbFRy YW5zZm9ybSA9IGltYWdlRWxlbWVudCgpLmFuaW1hdGVkTG9jYWxUcmFuc2Zvcm0oKTsKICAgICAg ICAgbV9uZWVkc1RyYW5zZm9ybVVwZGF0ZSA9IGZhbHNlOwogICAgIH0KIApAQCAtMTUxLDggKzE1 NSw3IEBAIHZvaWQgUmVuZGVyU1ZHSW1hZ2U6OnBhaW50Rm9yZWdyb3VuZChQYWludEluZm8mIHBh aW50SW5mbykKICAgICBGbG9hdFJlY3QgZGVzdFJlY3QgPSBtX29iamVjdEJvdW5kaW5nQm94Owog ICAgIEZsb2F0UmVjdCBzcmNSZWN0KDAsIDAsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0 KCkpOwogCi0gICAgU1ZHSW1hZ2VFbGVtZW50KiBpbWFnZUVsZW1lbnQgPSB0b1NWR0ltYWdlRWxl bWVudChlbGVtZW50KCkpOwotICAgIGltYWdlRWxlbWVudC0+cHJlc2VydmVBc3BlY3RSYXRpbygp LnRyYW5zZm9ybVJlY3QoZGVzdFJlY3QsIHNyY1JlY3QpOworICAgIGltYWdlRWxlbWVudCgpLnBy ZXNlcnZlQXNwZWN0UmF0aW8oKS50cmFuc2Zvcm1SZWN0KGRlc3RSZWN0LCBzcmNSZWN0KTsKIAog ICAgIHBhaW50SW5mby5jb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UuZ2V0KCksIENvbG9yU3BhY2VE ZXZpY2VSR0IsIGRlc3RSZWN0LCBzcmNSZWN0KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW1hZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvUmVuZGVyU1ZHSW1hZ2UuaAppbmRleCBiODQ5YTBkLi4zMTUxYmNlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbWFnZS5oCkBAIC0zOCw5ICsz OCwxMSBAQCBjbGFzcyBTVkdJbWFnZUVsZW1lbnQ7CiAKIGNsYXNzIFJlbmRlclNWR0ltYWdlIEZJ TkFMIDogcHVibGljIFJlbmRlclNWR01vZGVsT2JqZWN0IHsKIHB1YmxpYzoKLSAgICBSZW5kZXJT VkdJbWFnZShTVkdJbWFnZUVsZW1lbnQqKTsKKyAgICBleHBsaWNpdCBSZW5kZXJTVkdJbWFnZShT VkdJbWFnZUVsZW1lbnQmKTsKICAgICB2aXJ0dWFsIH5SZW5kZXJTVkdJbWFnZSgpOwogCisgICAg U1ZHSW1hZ2VFbGVtZW50JiBpbWFnZUVsZW1lbnQoKSBjb25zdDsKKwogICAgIGJvb2wgdXBkYXRl SW1hZ2VWaWV3cG9ydCgpOwogICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc0JvdW5kYXJpZXNVcGRh dGUoKSB7IG1fbmVlZHNCb3VuZGFyaWVzVXBkYXRlID0gdHJ1ZTsgfQogICAgIHZpcnR1YWwgYm9v bCBuZWVkc0JvdW5kYXJpZXNVcGRhdGUoKSBPVkVSUklERSB7IHJldHVybiBtX25lZWRzQm91bmRh cmllc1VwZGF0ZTsgfQpAQCAtNTMsNiArNTUsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBwYWludEZv cmVncm91bmQoUGFpbnRJbmZvJik7CiAKIHByaXZhdGU6CisgICAgdm9pZCBlbGVtZW50KCkgY29u c3QgV1RGX0RFTEVURURfRlVOQ1RJT047CisKICAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIHJlbmRl ck5hbWUoKSBjb25zdCB7IHJldHVybiAiUmVuZGVyU1ZHSW1hZ2UiOyB9CiAgICAgdmlydHVhbCBi b29sIGlzU1ZHSW1hZ2UoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdJbWFnZUVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvc3ZnL1NWR0ltYWdlRWxlbWVudC5jcHAKaW5kZXggNTJjNzQ4Zi4uNTVhZGYwOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ltYWdlRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0ltYWdlRWxlbWVudC5jcHAKQEAgLTE4NSw3ICsxODUsNyBAQCBi b29sIFNWR0ltYWdlRWxlbWVudDo6c2VsZkhhc1JlbGF0aXZlTGVuZ3RocygpIGNvbnN0CiAKIFJl bmRlck9iamVjdCogU1ZHSW1hZ2VFbGVtZW50OjpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSog YXJlbmEsIFJlbmRlclN0eWxlKikKIHsKLSAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyU1ZH SW1hZ2UodGhpcyk7CisgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlclNWR0ltYWdlKCp0aGlz KTsKIH0KIAogYm9vbCBTVkdJbWFnZUVsZW1lbnQ6OmhhdmVMb2FkZWRSZXF1aXJlZFJlc291cmNl cygpCg==