120892 2013-09-06 13:21:59 -0700 [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null 2013-09-11 09:14:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto berto mrobinson svillar oldest_to_newest 925815 0 berto 2013-09-06 13:21:59 -0700 This is a follow-up to bug 117733. If the glContext() call in LayerTreeHostGtk::initialize() returns null, m_isValid is set to false, which breaks an assertion in invalidate(). It's not necessary to set m_isValid here, the rest of the code already deals with the case where glContext() is null so that can be safely removed. The m_isValid variable is otherwise relevant in this class since it checks that invalidate() is called once before the object is destroyed. 925819 1 210789 berto 2013-09-06 13:24:37 -0700 Created attachment 210789 Patch 927809 2 berto 2013-09-11 09:14:40 -0700 Committed r155533: <http://trac.webkit.org/changeset/155533> 210789 2013-09-06 13:24:37 -0700 2013-09-11 09:03:14 -0700 Patch 120892.diff text/plain 1633 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZDgyZjQ5Li5hNTJhOWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDktMDYgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbV0syXSBbR1RLXSBMYXllclRyZWVIb3N0R3RrOiBkb24ndCBzZXQgbV9pc1ZhbGlkIHRv IGZhbHNlIGlmIGdsQ29udGV4dCgpIHJldHVybnMgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIEdMIGNvbnRleHQgY2Fubm90IGJlIGNy ZWF0ZWQgdGhlbiBtX2lzVmFsaWQgaXMgc2V0IHRvIGZhbHNlCisgICAgICAgIGR1cmluZyB0aGUg aW5pdGlhbGl6YXRpb24gb2YgTGF5ZXJUcmVlSG9zdEd0ay4KKworICAgICAgICBUaGlzIGlzIG5v dCByZWFsbHkgbmVjZXNzYXJ5IHNpbmNlIHRoZSByZXN0IG9mIHRoZSBjb2RlIGFscmVhZHkKKyAg ICAgICAgZGVhbHMgd2l0aCB0aGF0IHNpdHVhdGlvbiwgc28gaXQgZG9lc24ndCBoYXZlIGFueSBl ZmZlY3Qgb3RoZXIKKyAgICAgICAgdGhhbiBicmVha2luZyB0aGUgYXNzZXJ0aW9uIGluIGludmFs aWRhdGUoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9z dEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3RHdGs6OmluaXRpYWxpemUp OgorCiAyMDEzLTA5LTA1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbQ01BS0VdIEFkZCBjKysweCBpbnRvIENYWF9GTEFHUyBhcyBhIGRlZmF1bHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVl SG9zdEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0xheWVy VHJlZUhvc3RHdGsuY3BwCmluZGV4IGVhMDA2MWQuLjRmYjA1OTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9zdEd0ay5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVIb3N0R3Rr LmNwcApAQCAtMTE2LDEwICsxMTYsOCBAQCB2b2lkIExheWVyVHJlZUhvc3RHdGs6OmluaXRpYWxp emUoKQogICAgIG1fbGF5ZXJUcmVlQ29udGV4dC53aW5kb3dIYW5kbGUgPSBtX3dlYlBhZ2UtPm5h dGl2ZVdpbmRvd0hhbmRsZSgpOwogCiAgICAgR0xDb250ZXh0KiBjb250ZXh0ID0gZ2xDb250ZXh0 KCk7Ci0gICAgaWYgKCFjb250ZXh0KSB7Ci0gICAgICAgIG1faXNWYWxpZCA9IGZhbHNlOworICAg IGlmICghY29udGV4dCkKICAgICAgICAgcmV0dXJuOwotICAgIH0KIAogICAgIC8vIFRoZSBjcmVh dGlvbiBvZiB0aGUgVGV4dHVyZU1hcHBlciBuZWVkcyBhbiBhY3RpdmUgT3BlbkdMIGNvbnRleHQu CiAgICAgY29udGV4dC0+bWFrZUNvbnRleHRDdXJyZW50KCk7Cg==